Re: [OpenJDK 2D-Dev] RFR: 8163238: Upgrade to harfbuzz 1.3.0 in JDK 9

2016-08-09 Thread Vadim Pakhnushev
+1 Vadim On 09.08.2016 3:34, Philip Race wrote: Yes. I saw that (I reviewed the list of fixes that were made after the 1.3.0 release) but JDK9 won't be supporting 10.9 so I figured it was not critical. But also the function that is fixed is not used in our current code. We do use hb_coretext_

Re: [OpenJDK 2D-Dev] RFR: 8163238: Upgrade to harfbuzz 1.3.0 in JDK 9

2016-08-08 Thread Philip Race
Yes. I saw that (I reviewed the list of fixes that were made after the 1.3.0 release) but JDK9 won't be supporting 10.9 so I figured it was not critical. But also the function that is fixed is not used in our current code. We do use hb_coretext_face_create but that is implemented differently. S

Re: [OpenJDK 2D-Dev] RFR: 8163238: Upgrade to harfbuzz 1.3.0 in JDK 9

2016-08-08 Thread Sergey Bylokhov
Looks fine. FYI: after release 1.3 there is a fix for coretext crash on osx < 10.10: https://cgit.freedesktop.org/harfbuzz/commit/?id=489acf6c3180d3726158864fa0e1adeea3c23fae On 05.08.16 23:33, Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8163238 webrev: http://cr.openjdk.ja

[OpenJDK 2D-Dev] RFR: 8163238: Upgrade to harfbuzz 1.3.0 in JDK 9

2016-08-05 Thread Phil Race
Bug : https://bugs.openjdk.java.net/browse/JDK-8163238 webrev: http://cr.openjdk.java.net/~prr/8163238/ Not easily reviewable .. it is basically the diff between harfbuzz 1.0.6 and 1.3 I have included all the files that we use and some of them you will see have zero changes. But I wanted all t