Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-13 Thread Thomas Stüfe
On Mon, Mar 12, 2018 at 5:58 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > > On 2018-03-12 14:26, Thomas Stüfe wrote: > >> Yes, I am aware :( Long term I hope windows 32bit gets the same occasional >> love as zero does. I can produce occasional patches if time allows. >> >> But

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-12 Thread Magnus Ihse Bursie
On 2018-03-12 14:26, Thomas Stüfe wrote: Yes, I am aware :( Long term I hope windows 32bit gets the same occasional love as zero does. I can produce occasional patches if time allows. But in this case the error was in front of the computer, as Magnus pointed, I may just have a broken build

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-12 Thread Magnus Ihse Bursie
On 2018-03-09 23:10, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8193017 Webrev: http://cr.openjdk.java.net/~prr/8193017/index.html Looks good to me. Thanks for fixing this Phil! Freetype has really been a constant pain in building on all platforms except Linux. For once,

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-12 Thread Sergey Bylokhov
Ok, looks fine. On 09/03/2018 15:52, Philip Race wrote: It is correct as is .. -phil. On 3/9/18, 3:49 PM, Sergey Bylokhov wrote: I am not an expert here, but the LICENSE.TXT is a little bit different. It states that "This means  that *you* must choose  *one* of the  two licenses described

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-12 Thread Thomas Stüfe
Yes, I am aware :( Long term I hope windows 32bit gets the same occasional love as zero does. I can produce occasional patches if time allows. But in this case the error was in front of the computer, as Magnus pointed, I may just have a broken build env. Thanks for your fix, btw! removing the

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-10 Thread Philip Race
This is a tricky one. Since Oracle no longer ships 32 bit JDKs for any platform for the new releases, then there aren't resources or effort being put into making sure it still builds. Our build systems might still support it, but for how long? It might effectively have to become a "port" that

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-09 Thread Thomas Stüfe
Hi Phil, This is a nice change! And will make setting up the windows build env much easier. Change itself seems fine at a cursory glance. I also tested the build on Win7 with VS2013 (before, I used to build with a hand-compiled version of the freetypelib), and it worked fine. I attempted to

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-09 Thread Philip Race
It is correct as is .. -phil. On 3/9/18, 3:49 PM, Sergey Bylokhov wrote: I am not an expert here, but the LICENSE.TXT is a little bit different. It states that "This means that *you* must choose *one* of the two licenses described below,.". So I do not know should we select the license

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-09 Thread Sergey Bylokhov
I am not an expert here, but the LICENSE.TXT is a little bit different. It states that "This means that *you* must choose *one* of the two licenses described below,.". So I do not know should we select the license and provide the text only for one or for both. On 09/03/2018 15:28,

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-09 Thread Philip Race
Just to be clear, I mean we don't import it to each of the source files. But it is there in the file legal/freetype.md in this webrev. On 3/9/18, 3:26 PM, Philip Race wrote: No. -phil. On 3/9/18, 3:23 PM, Sergey Bylokhov wrote: Hi, Phil Headers of the new files refer to LICENSE.TXT. Should

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-09 Thread Philip Race
No. -phil. On 3/9/18, 3:23 PM, Sergey Bylokhov wrote: Hi, Phil Headers of the new files refer to LICENSE.TXT. Should we import it as well? On 09/03/2018 14:10, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8193017 Webrev: http://cr.openjdk.java.net/~prr/8193017/index.html

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-09 Thread Sergey Bylokhov
Hi, Phil Headers of the new files refer to LICENSE.TXT. Should we import it as well? On 09/03/2018 14:10, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8193017 Webrev: http://cr.openjdk.java.net/~prr/8193017/index.html This fix is will make building openjdk somewhat easier as

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-09 Thread Erik Joelsson
Build changes look good. /Erik On 2018-03-09 14:10, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8193017 Webrev: http://cr.openjdk.java.net/~prr/8193017/index.html This fix is will make building openjdk somewhat easier as it removes the dependence on an OpenJDK developer on

[OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

2018-03-09 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8193017 Webrev: http://cr.openjdk.java.net/~prr/8193017/index.html This fix is will make building openjdk somewhat easier as it removes the dependence on an OpenJDK developer on Windows or Mac going off and downloading and building freetype source