Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-17 Thread Magnus Ihse Bursie
On 2020-11-17 19:08, Philip Race wrote: So maybe the actual *usage* of C++11 features slows it down. I found this :- https://stackoverflow.com/questions/34179434/is-compiling-with-c11-way-slower-than-with-c98 I really did not even think to measure the build time and I don't think there's

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-17 Thread Philip Race
So maybe the actual *usage* of C++11 features slows it down. I found this :- https://stackoverflow.com/questions/34179434/is-compiling-with-c11-way-slower-than-with-c98 I really did not even think to measure the build time and I don't think there's any JDK build parallelism in building a specifi

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-17 Thread Florian Weimer
* Philip Race: > There is more code in the newer version but not 4 times as much ! > Harfbuzz now requires c++11 features (-std=c++11) > Possibly the C++ compiler you are using (you don't mention platform) is > slower in this mode. It's GCC 8 on Debian buster, which defaults to C++14. And it's

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-17 Thread Philip Race
There is more code in the newer version but not 4 times as much ! Harfbuzz now requires c++11 features (-std=c++11) Possibly the C++ compiler you are using (you don't mention platform) is slower in this mode. -phil. On 11/17/20, 9:01 AM, Florian Weimer wrote: * Phil Race: This upgrades JDK

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-17 Thread Florian Weimer
* Phil Race: > This upgrades JDK to import the current 2.7.2 version of harfbuzz - > an OpenType text shaping library > > https://bugs.openjdk.java.net/browse/JDK-8247872 > > This has passed building and headless and headful automated tests on > all platforms. Is it just me, or does the new Harfb

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v3]

2020-11-08 Thread Sergey Bylokhov
On Thu, 5 Nov 2020 17:52:19 GMT, Phil Race wrote: >> This upgrades JDK to import the current 2.7.2 version of harfbuzz - an >> OpenType text shaping library >> >> https://bugs.openjdk.java.net/browse/JDK-8247872 >> >> This has passed building and headless and headful automated tests on all >>

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v3]

2020-11-05 Thread Magnus Ihse Bursie
On Thu, 5 Nov 2020 17:52:53 GMT, Phil Race wrote: >> @mrserb Good catch! Yes indeed, it looks like `range-loop-analysis` needs to >> be disabled for clang for Xcode 12 to not complain. > > I added that to the disabled warnings .. now I suppose the actions will > re-run but I don't see any sign

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v3]

2020-11-05 Thread Phil Race
On Thu, 5 Nov 2020 13:36:18 GMT, Magnus Ihse Bursie wrote: >> Looks like the build on macOS via GitHub will be broken by this fix? > > @mrserb Good catch! Yes indeed, it looks like `range-loop-analysis` needs to > be disabled for clang for Xcode 12 to not complain. I added that to the disabled

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v3]

2020-11-05 Thread Phil Race
> This upgrades JDK to import the current 2.7.2 version of harfbuzz - an > OpenType text shaping library > > https://bugs.openjdk.java.net/browse/JDK-8247872 > > This has passed building and headless and headful automated tests on all > platforms. Phil Race has updated the pull request increme

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v2]

2020-11-05 Thread Magnus Ihse Bursie
On Thu, 5 Nov 2020 11:24:28 GMT, Sergey Bylokhov wrote: >>> I'm just a bit curious about the added, empty, >>> `src/java.desktop/share/native/libharfbuzz/abc.txt`... >>> >>> If it really is in upstream source, I'm not saying you should remove it. It >>> just looks very odd. It's not a merge ar

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v2]

2020-11-05 Thread Sergey Bylokhov
On Mon, 2 Nov 2020 16:23:19 GMT, Phil Race wrote: >> I'm just a bit curious about the added, empty, >> `src/java.desktop/share/native/libharfbuzz/abc.txt`... >> >> If it really is in upstream source, I'm not saying you should remove it. It >> just looks very odd. It's not a merge artifact? >>

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v2]

2020-11-02 Thread Phil Race
On Mon, 2 Nov 2020 12:33:17 GMT, Magnus Ihse Bursie wrote: > I'm just a bit curious about the added, empty, > `src/java.desktop/share/native/libharfbuzz/abc.txt`... > > If it really is in upstream source, I'm not saying you should remove it. It > just looks very odd. It's not a merge artifact?

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v2]

2020-11-02 Thread Phil Race
> This upgrades JDK to import the current 2.7.2 version of harfbuzz - an > OpenType text shaping library > > https://bugs.openjdk.java.net/browse/JDK-8247872 > > This has passed building and headless and headful automated tests on all > platforms. Phil Race has updated the pull request increme

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-02 Thread Magnus Ihse Bursie
On Mon, 2 Nov 2020 04:19:57 GMT, Phil Race wrote: > This upgrades JDK to import the current 2.7.2 version of harfbuzz - an > OpenType text shaping library > > https://bugs.openjdk.java.net/browse/JDK-8247872 > > This has passed building and headless and headful automated tests on all > platfo

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-01 Thread Phil Race
On Mon, 2 Nov 2020 04:19:57 GMT, Phil Race wrote: > This upgrades JDK to import the current 2.7.2 version of harfbuzz - an > OpenType text shaping library > > https://bugs.openjdk.java.net/browse/JDK-8247872 > > This has passed building and headless and headful automated tests on all > platfo

[OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-01 Thread Phil Race
This upgrades JDK to import the current 2.7.2 version of harfbuzz - an OpenType text shaping library https://bugs.openjdk.java.net/browse/JDK-8247872 This has passed building and headless and headful automated tests on all platforms. - Commit messages: - 8247872: Upgrade HarfBuzz