On Wed, 7 Apr 2021 05:24:30 GMT, Denis Konoplev wrote:
> Check if blit sizes are less than MTL_GPU_FAMILY_MAC_TXT_SIZE.
>
> It's safe since we copy tile from the image with memcpy.
>
> // copy src pixels inside src bounds to buff
> for (int row = 0; row < sh; row++) {
>
On Wed, 7 Apr 2021 05:24:30 GMT, Denis Konoplev wrote:
> Check if blit sizes are less than MTL_GPU_FAMILY_MAC_TXT_SIZE.
>
> It's safe since we copy tile from the image with memcpy.
>
> // copy src pixels inside src bounds to buff
> for (int row = 0; row < sh; row++) {
>
On Sat, 10 Apr 2021 20:31:31 GMT, Sergey Bylokhov wrote:
>>> I wonder why we have two similar but different constants:
>>> #define MaxTextureSize 16384
>>> #define MTL_GPU_FAMILY_MAC_TXT_SIZE 16384
>>
>> I can remove MaxTextureSize and replace its usages.
>> Should I file a new bug or put
On Wed, 7 Apr 2021 05:24:30 GMT, Denis Konoplev wrote:
> Check if blit sizes are less than MTL_GPU_FAMILY_MAC_TXT_SIZE.
>
> It's safe since we copy tile from the image with memcpy.
>
> // copy src pixels inside src bounds to buff
> for (int row = 0; row < sh; row++) {
>
On Thu, 8 Apr 2021 16:45:23 GMT, Denis Konoplev wrote:
> I can remove MaxTextureSize and replace its usages.
> Should I file a new bug or put changes in this PR?
Yes please file a bug.
-
PR: https://git.openjdk.java.net/jdk/pull/3369
On Wed, 7 Apr 2021 19:54:03 GMT, Sergey Bylokhov wrote:
> I wonder why we have two similar but different constants:
> #define MaxTextureSize 16384
> #define MTL_GPU_FAMILY_MAC_TXT_SIZE 16384
I can remove MaxTextureSize and replace its usages.
Should I file a new bug or put changes in this PR?
On Wed, 7 Apr 2021 19:56:43 GMT, Sergey Bylokhov wrote:
>> Check if blit sizes are less than MTL_GPU_FAMILY_MAC_TXT_SIZE.
>>
>> It's safe since we copy tile from the image with memcpy.
>> // copy src pixels inside src bounds to buff
>> for (int row = 0; row < sh; row++) {
>>
On Wed, 7 Apr 2021 05:24:30 GMT, Denis Konoplev wrote:
> Check if blit sizes are less than MTL_GPU_FAMILY_MAC_TXT_SIZE.
>
> It's safe since we copy tile from the image with memcpy.
> // copy src pixels inside src bounds to buff
> for (int row = 0; row < sh; row++) {
> memcpy(buff.contents
Check if blit sizes are less than MTL_GPU_FAMILY_MAC_TXT_SIZE.
It's safe since we copy tile from the image with memcpy.
// copy src pixels inside src bounds to buff
for (int row = 0; row < sh; row++) {
memcpy(buff.contents + (row * sw * srcInfo->pixelStride), raster, sw *
