jdk.java.net/~mbaesken/webrevs/8248802.2/
Best regards, Matthias
From: Langer, Christoph
Sent: Dienstag, 14. Juli 2020 17:44
To: Baesken, Matthias ; Philip Race
Cc: Peter Hull ; Jayathirth D v
; 2d-dev@openjdk.java.net
Subject: RE: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to
FontUt
On 7/14/20, 8:43 AM, Langer, Christoph wrote:
This should probably also be pushed to the client repo.
That is not just "probably", it is a definite yes.
-phil.
@openjdk.java.net
Subject: RE: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to
FontUtilities.java
>BTW I suppose you believe you have found all the cases in various packages
>and platform folders and converted them ?
>Or were there some cases you intentionally left alone ?
Hi Phil, I ke
: Donnerstag, 9. Juli 2020 19:17
To: Baesken, Matthias
<mailto:matthias.baes...@sap.com>
Cc: Peter Hull <mailto:peterhul...@gmail.com>;
Jayathirth D v <mailto:jayathirth@oracle.com>;
Langer, Christoph <mailto:christoph.lan...@sap.com>;
2d-dev@openjdk.java.net<mailto
hristoph ;
2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to
FontUtilities.java
That is a good question. I am not sure any more how we ended up with
the mixed usage but isLogging() seems appropriate to guard the call to log.
So maybe make them consistent for a
dk.java.net
*Subject:* Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods
to FontUtilities.java
There is no harm in repeating isLogging() inside logWarning() but
I don't think it is sufficient.
What we mean is that in some cases the code looks now like this :-
http://cr.openjdk.j
g standard Font Configuration");
Best regards, Matthias
From: Philip Race
Sent: Donnerstag, 9. Juli 2020 19:17
To: Baesken, Matthias
Cc: Peter Hull ; Jayathirth D v
; Langer, Christoph ;
2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to
FontUtilitie
s
-Original Message-
From: Philip Race
Sent: Donnerstag, 9. Juli 2020 17:04
To: Peter Hull
Cc: Baesken, Matthias; Jayathirth D
v; Langer, Christoph;
2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to
FontUtilities.java
I agree.
There alwa
penJDK 2D-Dev] RFR : 8248802: Add log helper methods to
FontUtilities.java
I agree.
There always should be a call such as FontUtilities.isLogging() test
protecting doing unnecessary work.
-phil.
On 7/9/20, 3:24 AM, Peter Hull wrote:
> Probably not my place to comment, but, does it matter
From: Jayathirth D v
Sent: Donnerstag, 9. Juli 2020 07:21
To: Baesken, Matthias
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to
FontUtilities.java
Looks good to me.
Thanks,
Jay
On 06-Jul-2020, at 12:43 PM, Baesken, Matthias wrote:
Hel
ias
> Cc: 2d-dev@openjdk.java.net
> Subject: Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to
> FontUtilities.java
>
>
>
> Looks good to me.
>
>
>
> Thanks,
>
> Jay
>
>
>
> On 06-Jul-2020, at 12:43 PM, Baesken, Matthias
> wr
Thank‘s for the review !
May I get a second review ?
Best regards, Matthias
From: Jayathirth D v
Sent: Donnerstag, 9. Juli 2020 07:21
To: Baesken, Matthias
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to
FontUtilities.java
Looks good to
Looks good to me.
Thanks,
Jay
> On 06-Jul-2020, at 12:43 PM, Baesken, Matthias
> wrote:
>
> Hello, please review this small change to font related logging .
>
> We have a lot of font logging calls in java.desktop that look similar to this
> coding :
>
> if (FontUtilities.isLogging(
Hello, please review this small change to font related logging .
We have a lot of font logging calls in java.desktop that look similar to this
coding :
if (FontUtilities.isLogging()) {
FontUtilities.getLogger().info("Here comes my important info");
}
This coding coul
14 matches
Mail list logo
