Re: [OpenJDK 2D-Dev] RFR [14]: JDK-8228711: Path rendered incorrectly when it goes outside the clipping region

2019-08-07 Thread Laurent Bourgès
Kevin & Philip, Thank you for your reviews, I pushed the fix: http://hg.openjdk.java.net/jdk/client/rev/13178f7e75d5 Laurent Le mer. 7 août 2019 à 01:30, Kevin Rushforth a écrit : > Looks good. > > +1 > > -- Kevin > > On 8/6/2019 12:28 AM, Laurent Bourgès wrote: > > Ping: > Could someone do a

Re: [OpenJDK 2D-Dev] RFR [14]: JDK-8228711: Path rendered incorrectly when it goes outside the clipping region

2019-08-06 Thread Kevin Rushforth
Looks good. +1 -- Kevin On 8/6/2019 12:28 AM, Laurent Bourgès wrote: Ping: Could someone do a second review ? Laurent Le ven. 2 août 2019 à 17:01, Laurent Bourgès mailto:bourges.laur...@gmail.com>> a écrit : Thanks Philip, I am waiting for another approval, Cheers,

Re: [OpenJDK 2D-Dev] RFR [14]: JDK-8228711: Path rendered incorrectly when it goes outside the clipping region

2019-08-06 Thread Laurent Bourgès
Ping: Could someone do a second review ? Laurent Le ven. 2 août 2019 à 17:01, Laurent Bourgès a écrit : > Thanks Philip, > > I am waiting for another approval, > Cheers, > Laurent > > Le ven. 2 août 2019 à 00:13, Philip Race a > écrit : > >> +1 from me. Looks the same as the FX fix modulo some

Re: [OpenJDK 2D-Dev] RFR [14]: JDK-8228711: Path rendered incorrectly when it goes outside the clipping region

2019-08-02 Thread Laurent Bourgès
Thanks Philip, I am waiting for another approval, Cheers, Laurent Le ven. 2 août 2019 à 00:13, Philip Race a écrit : > +1 from me. Looks the same as the FX fix modulo some moving things around. > > -phil. > > On 7/29/19, 12:56 AM, Laurent Bourgès wrote: > > Hi, > > > > Please review this bug

Re: [OpenJDK 2D-Dev] RFR [14]: JDK-8228711: Path rendered incorrectly when it goes outside the clipping region

2019-08-01 Thread Philip Race
+1 from me. Looks the same as the FX fix modulo some moving things around. -phil. On 7/29/19, 12:56 AM, Laurent Bourgès wrote: Hi, Please review this bug fix for the Marlin renderer (introduced in JDK11.0.2): JBS: https://bugs.openjdk.java.net/browse/JDK-8228711 webrev:

[OpenJDK 2D-Dev] RFR [14]: JDK-8228711: Path rendered incorrectly when it goes outside the clipping region

2019-07-29 Thread Laurent Bourgès
Hi, Please review this bug fix for the Marlin renderer (introduced in JDK11.0.2): JBS: https://bugs.openjdk.java.net/browse/JDK-8228711 webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8228711.0/ This patch is very close to MarlinFX patch integrated last week in OpenJFX 14, see