Re: [OpenJDK 2D-Dev] request for review: 7188093

2012-09-20 Thread Vadim Pakhnushev
That's good, I will try to improve my test to be automated then. Thanks, Vadim On 21.09.2012 0:40, Clemens Eisserer wrote: Hi, Automated test will require taking screenshot and comparing results, I'm not sure if this mechanism works good. It should be possible to render to a VolatileImage, w

Re: [OpenJDK 2D-Dev] request for review: 7188093

2012-09-20 Thread Clemens Eisserer
Hi, > Automated test will require taking screenshot and comparing results, I'm not > sure if this mechanism works good. It should be possible to render to a VolatileImage, which allows direct readback without taking a screenshot. - Clemens

Re: [OpenJDK 2D-Dev] request for review: 7188093

2012-09-20 Thread Vadim Pakhnushev
I copied original test .java and .html files, renamed and adjusted them for this case. Is it enough for jtreg? Automated test will require taking screenshot and comparing results, I'm not sure if this mechanism works good. If it is, I could develop automated test, Andrew mentioned that there is

Re: [OpenJDK 2D-Dev] request for review: 7188093

2012-09-20 Thread Phil Race
Ideally it should go under this bug id but its not the end of the world if we push it under another one. If you can provide it soon in jtreg form we can do it as part of this fix. Ideally it should be automated. -phil. On 9/20/2012 7:51 AM, Vadim Pakhnushev wrote: Phil, I'm not sure about or

Re: [OpenJDK 2D-Dev] request for review: 7188093

2012-09-20 Thread Vadim Pakhnushev
Phil, I'm not sure about original test case, it uses cow.gif file. Moreover, it's not useful for this particular bug at all. I can open my version of the test which clearly shows the bug. I suppose I should post a webrev for this same CR with added test? Thanks, Vadim On 18.09.2012 22:32, Phi

Re: [OpenJDK 2D-Dev] request for review: 7188093

2012-09-18 Thread Clemens Eisserer
> Approved (2nd reviewer). Please commit the patch if its ok. > This looks good. OpenGL and D3D punt under the same circumstances... Thanks for the clarification :) Thanks, Clemens 2012/9/18 Phil Race : > Approved (2nd reviewer). > > Vadim: can you also see if we can 'open' the regression test

Re: [OpenJDK 2D-Dev] request for review: 7188093

2012-09-18 Thread Phil Race
Approved (2nd reviewer). Vadim: can you also see if we can 'open' the regression test that identified this bug. -phi. On 9/18/2012 10:37 AM, Jim Graham wrote: This looks good. OpenGL and D3D punt under the same circumstances... ...jim On 9/18/2012 1:16 AM, Clemens Eisserer wrote:

Re: [OpenJDK 2D-Dev] request for review: 7188093

2012-09-18 Thread Jim Graham
This looks good. OpenGL and D3D punt under the same circumstances... ...jim On 9/18/2012 1:16 AM, Clemens Eisserer wrote: Hello, Please review my fix for bug 7188093, located at: http://cr.openjdk.java.net/~ceisserer/7188093/webrev.01/ Billinear interpolation is the highest q

[OpenJDK 2D-Dev] request for review: 7188093

2012-09-18 Thread Clemens Eisserer
Hello, Please review my fix for bug 7188093, located at: http://cr.openjdk.java.net/~ceisserer/7188093/webrev.01/ Billinear interpolation is the highest quality interpolation supported by xrender, so the xrender-pipeline has to fall back software loops in case bicubic interpolation is requested.