java.net"2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
Hi Shashi,
I think if the overhead can be fixed with a small change, we should do it as I
think we need to keep the code optimized with whatever code is prese
*Cc:* 2d-dev@openjdk.java.net
*Subject:* RE: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print
tests after JDK-8153732
Hi Prasanta, The parameters for the function does not tells the order
and is not implied by the way function definition is and more over
this function is called
Subject: RE: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
Hi Prasanta, The parameters for the function does not tells the order and is
not implied by the way function definition is and more over this function is
called in an interval of minimum refresh time(4
, February 15, 2019 12:28 PM
To: Shashidhara Veerabhadraiah ; Philip
Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
Hi Shashi,
In this case, we know doCompare() is called from one location only [and also is
not a public
,
Shashi
*From:*Prasanta Sadhukhan
*Sent:* Friday, February 15, 2019 12:11 PM
*To:* Phil Race ; Shashidhara Veerabhadraiah
*Cc:* 2d-dev@openjdk.java.net
*Subject:* Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print
tests after JDK-8153732
Hi Shashi,
I have one comment:
doCompare
you agree with me.
Thanks and regards,
Shashi
From: Prasanta Sadhukhan
Sent: Friday, February 15, 2019 12:11 PM
To: Phil Race ; Shashidhara Veerabhadraiah
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
Hi Shashi
abhadraiah
<mailto:shashidhara.veerabhadra...@oracle.com>
*Cc:* Prasanta Sadhukhan
<mailto:prasanta.sadhuk...@oracle.com>; 2d-dev@openjdk.java.net
<mailto:2d-dev@openjdk.java.net>
*Subject:* Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the
pr
ra/8212202/webrev.06/
Thanks and regards,
Shashi
*From:*Philip Race
*Sent:* Saturday, February 9, 2019 2:25 AM
*To:* Shashidhara Veerabhadraiah
*Cc:* Prasanta Sadhukhan ;
2d-dev@openjdk.java.net
*Subject:* Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print
tests after JDK-8153
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
413 if (str1 == null && str2 == null) {
414 return false;
415 } else if ((str1 == null && str2 != null) || (str2 == null &&
lt;mailto:prasanta.sadhuk...@oracle.com>; 2d-dev@openjdk.java.net
<mailto:2d-dev@openjdk.java.net>
*Subject:* RE: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print
tests after JDK-8153732
Hi Phil, Please find the updated Webrev.
http://cr.openjdk.java.net/~sveerabhadra/
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
Sorry .. this got lost ..
I don't understand this line :
253 jobjectArray emptyArray = env->NewObjectArray(1, clazz, NULL);
This is returning an array of length 1 and element 0 is NULL.
I think
Race
*Cc:* Prasanta Sadhukhan ;
2d-dev@openjdk.java.net
*Subject:* RE: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print
tests after JDK-8153732
Hi Phil, Please find the updated Webrev.
http://cr.openjdk.java.net/~sveerabhadra/8212202/webrev.03/
Thanks and regards,
Shashi
*From:*Philip
28, 2018 11:19 PM
To: Shashidhara Veerabhadraiah HYPERLINK
"mailto:shashidhara.veerabhadra...@oracle.com;;
Prasanta Sadhukhan HYPERLINK
"mailto:prasanta.sadhuk...@oracle.com;;
HYPERLINK "mailto:2d-dev@openjdk.java.net"2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE
shidhara Veerabhadraiah HYPERLINK
"mailto:shashidhara.veerabhadra...@oracle.com;;
Prasanta Sadhukhan HYPERLINK
"mailto:prasanta.sadhuk...@oracle.com;;
HYPERLINK "mailto:2d-dev@openjdk.java.net"2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-821220
nta Sadhukhan
; 2d-dev@openjdk.java.net
*Subject:* Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print
tests after JDK-8153732
But what I am saying is we should not return a NULL string reference
from native. You are still allowing that and then having to handle
it in Java code.
And FWIW
ukhan HYPERLINK
"mailto:prasanta.sadhuk...@oracle.com;;
HYPERLINK "mailto:2d-dev@openjdk.java.net"2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
I am not understanding you. I thought the problem to be we got an arra
idhara Veerabhadraiah
<mailto:shashidhara.veerabhadra...@oracle.com>;
2d-dev@openjdk.java.net <mailto:2d-dev@openjdk.java.net>
*Subject:* Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print
tests after JDK-8153732
[Removed swing-dev as this as nothing to do wit
To: Shashidhara Veerabhadraiah ; Philip
Race ; Prasanta Sadhukhan
; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
Hi, Shashi.
> The big problem was that I was not able to reproduce this problem neither at
> my end nor at the system
Hi, Shashi.
The big problem was that I was not able to reproduce this problem neither at my
end nor at the systems used for PIT testing. Only Sergey had produced this NPE
till now.
If you cannot reproduce this exception on the system w/o
printers, then it is interesting what will return this
this NPE
till now.
Thanks and regards,
Shashi
From: Phil Race
Sent: Wednesday, November 28, 2018 11:19 PM
To: Shashidhara Veerabhadraiah ;
Prasanta Sadhukhan ; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
I am
swing-...@openjdk.java.net
<mailto:swing-...@openjdk.java.net>; 2d-dev@openjdk.java.net
<mailto:2d-dev@openjdk.java.net>
*Subject:* Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the
print tests after JDK-8153732
On 26-Nov-18 6:51 PM, shash
Sadhukhan ; Shashidhara
Veerabhadraiah ; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
[Removed swing-dev as this as nothing to do with swing].
You mention in the bug eval that you don't need a new test because this
is already
:*Prasanta Sadhukhan
*Sent:* Monday, November 26, 2018 8:01 PM
*To:* Shashidhara Veerabhadraiah
; swing-...@openjdk.java.net;
2d-dev@openjdk.java.net
*Subject:* Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print
tests after JDK-8153732
On 26-Nov-18 6:51 PM, shashidhara.veerabhadra...@oracle.com
8:01 PM
*To:* Shashidhara Veerabhadraiah
; swing-...@openjdk.java.net;
2d-dev@openjdk.java.net
*Subject:* Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print
tests after JDK-8153732
On 26-Nov-18 6:51 PM, shashidhara.veerabhadra...@oracle.com
<mailto:shashidhara.veerabhadra...@oracle.
, this fix tries
to eliminate the possible NPE cases.
Thanks and regards,
Shashi
From: Prasanta Sadhukhan
Sent: Monday, November 26, 2018 8:01 PM
To: Shashidhara Veerabhadraiah ;
swing-...@openjdk.java.net; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print
On 26-Nov-18 6:51 PM, shashidhara.veerabhadra...@oracle.com wrote:
Hi Prasanta, I think we should not create a behavior across the
functions. doCompare() does only the comparison and it may be used for
other purposes and is complete with respect to the comparison
functionality.
run()
Hi Prasanta, I think we should not create a behavior across the
functions. doCompare() does only the comparison and it may be used for
other purposes and is complete with respect to the comparison functionality.
run() function has a different behavior as it needs to populate the
27 matches
Mail list logo
