Changes are fine.
Thanks,
Jay
> On 11-Jun-2019, at 6:09 PM, Philip Race wrote:
>
> Hi,
>
> I am still looking for a code review on this - needed today !
>
> -phil.
>
> On 6/5/19, 11:43 AM, Phil Race wrote:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8217731
>> webrev:
Looks fine.
On 11/06/2019 05:39, Philip Race wrote:
Hi,
I am still looking for a code review on this - needed today !
-phil.
On 6/5/19, 11:43 AM, Phil Race wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8217731
webrev: http://cr.openjdk.java.net/~prr/8217731/
This is intended to
Hi Phil,
Unfortunately I'm not a reviewer on 12 so I won't be able to OK for
you, but the patch looks good to me. We had found a similar issue with
Freetype and also came to the same conclusion that we should have the
rendering mode to version 35 I think.
I agree "better" is subjective, but I
Hi,
I am still looking for a code review on this - needed today !
-phil.
On 6/5/19, 11:43 AM, Phil Race wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8217731
webrev: http://cr.openjdk.java.net/~prr/8217731/
This is intended to "help" but cannot completely cure, with
some of the
On 6/6/19 9:12 AM, Phil Race wrote:
On 6/6/19 9:11 AM, semyon.sadet...@oracle.com wrote:
On 6/5/19 6:43 PM, Philip Race wrote:
On 6/5/19, 4:18 PM, Semyon Sadetsky wrote:
On 6/5/19 2:11 PM, Phil Race wrote:
It *can* make a difference and in fact we have a regression test
that now
On 6/6/19 9:11 AM, semyon.sadet...@oracle.com wrote:
On 6/5/19 6:43 PM, Philip Race wrote:
On 6/5/19, 4:18 PM, Semyon Sadetsky wrote:
On 6/5/19 2:11 PM, Phil Race wrote:
It *can* make a difference and in fact we have a regression test
that now passes with this fix which tests different
On 6/5/19 6:43 PM, Philip Race wrote:
On 6/5/19, 4:18 PM, Semyon Sadetsky wrote:
On 6/5/19 2:11 PM, Phil Race wrote:
It *can* make a difference and in fact we have a regression test
that now passes with this fix which tests different rendering modes.
Which test is it? Why you didn't mark
On 6/5/19, 4:18 PM, Semyon Sadetsky wrote:
On 6/5/19 2:11 PM, Phil Race wrote:
It *can* make a difference and in fact we have a regression test
that now passes with this fix which tests different rendering modes.
Which test is it? Why you didn't mark it with the bug id?
See
On 6/5/19 2:11 PM, Phil Race wrote:
It *can* make a difference and in fact we have a regression test
that now passes with this fix which tests different rendering modes.
Which test is it? Why you didn't mark it with the bug id?
However that is not a direct test for this potential difference.
It *can* make a difference and in fact we have a regression test
that now passes with this fix which tests different rendering modes.
However that is not a direct test for this potential difference.
You cannot say that this change *must* make a difference, it
just does. Sometimes.
-phil.
On
Can you clarify does the change affects font metrics?
I see that it is a sub-pixel difference for each single glyph but if a
long line of text can accumulate a notable difference the reg test can
be provided.
--Semyon
On 6/5/19 11:43 AM, Phil Race wrote:
bug:
11 matches
Mail list logo
