Re: [OpenJDK 2D-Dev] OGLGraphicsConfig

2009-10-19 Thread Mario Torre
Il 07/10/2009 19:07, Chris Campbell ha scritto: It's package-private because it's only accessed within the sun.java2d.opengl package, and in general we strive to reduce the visibility of classes/interfaces. The concrete GLX/WGL implementations also live in that package, so there was no reason to

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-10-19 Thread Mario Torre
Il 25/09/2009 22:29, Jim Graham ha scritto: Hi Jim, I think we could add a quick "if (loops == null) {...}" in those 2 classes and maybe add a comment "// assert(some pipe will always be a LoopBasedPipe)" to indicate that we aren't checking the types of the pipes because we think it is always t

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-10-19 Thread Jim Graham
Hi Mario, That's just what I was trying to describe, thanks! Looks good to go... ...jim Mario Torre wrote: Il 25/09/2009 22:29, Jim Graham ha scritto: Hi Jim, I think we could add a quick "if (loops == null) {...}" in those 2 classes and maybe add a comment "// assert(some