[OpenJDK 2D-Dev] request for review: 7188093

2012-09-18 Thread Clemens Eisserer
Hello, Please review my fix for bug 7188093, located at: http://cr.openjdk.java.net/~ceisserer/7188093/webrev.01/ Billinear interpolation is the highest quality interpolation supported by xrender, so the xrender-pipeline has to fall back software loops in case bicubic interpolation is requested.

Re: [OpenJDK 2D-Dev] request for review: 7188093

2012-09-18 Thread Jim Graham
This looks good. OpenGL and D3D punt under the same circumstances... ...jim On 9/18/2012 1:16 AM, Clemens Eisserer wrote: Hello, Please review my fix for bug 7188093, located at: http://cr.openjdk.java.net/~ceisserer/7188093/webrev.01/ Billinear interpolation is the highest q

Re: [OpenJDK 2D-Dev] request for review: 7188093

2012-09-18 Thread Phil Race
Approved (2nd reviewer). Vadim: can you also see if we can 'open' the regression test that identified this bug. -phi. On 9/18/2012 10:37 AM, Jim Graham wrote: This looks good. OpenGL and D3D punt under the same circumstances... ...jim On 9/18/2012 1:16 AM, Clemens Eisserer wrote:

Re: [OpenJDK 2D-Dev] request for review: 7188093

2012-09-18 Thread Clemens Eisserer
> Approved (2nd reviewer). Please commit the patch if its ok. > This looks good. OpenGL and D3D punt under the same circumstances... Thanks for the clarification :) Thanks, Clemens 2012/9/18 Phil Race : > Approved (2nd reviewer). > > Vadim: can you also see if we can 'open' the regression test