Re: [OpenJDK 2D-Dev] Review request for 8034218: AIX: Provide a better fontconfig.properties file

Hello 2d-dev, Volker, Could I have the updated patch reviewed ? any more comments ? On Tue, May 20, 2014 at 2:17 PM, Jonathan Lu wrote: > Hi Volker, > > I've updated the patch by dropping the those fonts configurations from > $JRE_LIB_FONTS directory. > The change is based on the SAP version,

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041644 [OGL] clip is ignored during surface->sw blit

Hi, Andrew. CR filed https://bugs.openjdk.java.net/browse/JDK-8044788 testcase updated: http://cr.openjdk.java.net/~serb/8041644/webrev.01 On 03.06.2014 18:02, Andrew Brygin wrote: Hello Sergey, the fix for ogl looks fine to me. Could you please update the test, and submit a separate bug aga

[OpenJDK 2D-Dev] Review request for: JDK-8014458: New VC++ compiler warnings in awt_PrintJob.cpp

Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8014458 Webrev corresponding: http://cr.openjdk.java.net/~serb/antonm/8014458/webrev.00 Thanks. Regards, Anton Melnikov

Re: [OpenJDK 2D-Dev] Review request for 8034218: AIX: Provide a better fontconfig.properties file

Hi Jonathan, sorry for the long delay. I think the change look good now. Can you please slightly update the comment in the 31-33 to something like: # This file references the standard Latin Type1 fonts from the AIX package # X11.fnt.iso_T1 and the Unicode TrueType fonts from X11.fnt.ucs.ttf. The

Re: [OpenJDK 2D-Dev] Review request for: JDK-8014458: New VC++ compiler warnings in awt_PrintJob.cpp

I'm not sure how you didn't notice this but fixes for all these issues already exist :- http://hg.openjdk.java.net/jdk9/client/jdk/rev/823387e2bf42 -phil. On 6/5/14 5:09 AM, Anton Melnikov wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/brow

Re: [OpenJDK 2D-Dev] Review request for: JDK-8014458: New VC++ compiler warnings in awt_PrintJob.cpp

Hmm .. the "-8" on the end of your repo name makes me think you are working against the wrong JDK version. All fixes start with 9 and get backported to 8-updates if they are important enough. -phil. On 6/5/14 2:27 PM, Phil Race wrote: I'm not sure how you didn't notice this but fixes for all

[OpenJDK 2D-Dev] RFR: 8044551, 8044396: Fix raw and unchecked lint warnings in platform-specific sun.awt and sun.java2d

Hi, Please review a follow-up to clean up rawtype and unchecked warnings in platform-specific code. Bug: https://bugs.openjdk.java.net/browse/JDK-8044396 https://bugs.openjdk.java.net/browse/JDK-8044551 Webrev: http://cr.openjdk.java.net/~henryjen/jdk9/8044551/0/webrev/ Cheers, Henry

Re: [OpenJDK 2D-Dev] RFR: 8044551, 8044396: Fix raw and unchecked lint warnings in platform-specific sun.awt and sun.java2d

Hi Henry, From a quick look, the changes seem fine. Thanks, -Joe On 06/05/2014 04:51 PM, Henry Jen wrote: Hi, Please review a follow-up to clean up rawtype and unchecked warnings in platform-specific code. Bug: https://bugs.openjdk.java.net/browse/JDK-8044396 https://bugs.openjdk.java.net