It gets further complicated, though, when you consider that we probably need the dimensions of the base image for any
metrics reporting anyway.
Consider a 25x25 image with variants. If the user supplies a 125pct variant then they will need an image that is 31.25
pixels in size. Do they use a
Hi All,
Please review a fix for jdk9 where it is seen that LinearGradientPaint
is not getting printed on osx.
The below webrev is only for LinearGradientPaint
and RadialGradientPaint will be handled separately.
Bug: https://bugs.openjdk.java.net/browse/JDK-8162796
webrev: http://cr.openjdk.jav
+1
Regards
Prasanta
On 9/21/2016 11:27 AM, Jayathirth D V wrote:
Hi Prasanta,
Thanks for your review.
When we are writing embedded image we have internal WriteProgressAdapter in
which we have dummy listener functions which are doing nothing.
So there is no need to check for abortRequested() at
I see this is mostly what I approved for JDK9 but I noticed you made a
change
after I approved it and I did not see or approve the updated version.
I am concerned about this comment you posted for the JDK 9 webrev :
>Regarding "2856 RELEASE_ARRAYS(env, data, (const JOCTET
*)(dest->next
This looks wrong to me. Shouldn't the logic look like the one you have
earlier in
the file ? ie this :
1271 JobSheets jobSheets =
(JobSheets)attributes.get(JobSheets.class);
1272 if (jobSheets != null) {
1273 noJobSheet = jobSheets == JobSheets.NONE;
1274 }
Hi Phil,
My new code takes care of the problem when attribute is not set by the
user who directly calls PrinterJob.print(). If no print dialog is shown,
then print(attr) seems to be called with Null attribute
and since noJobSheet was false, it used to print the banner page.
I now checked only
What happens if the application does not display a dialog but
instead the application code explicitly does this:
aset.add(JobSheets.STANDARD);
print(aset)
?
It appears to me you will over-ride that.
-phil.
On 9/22/16, 9:54 AM, Prasanta Sadhukhan wrote:
Hi Phil,
My new code takes care of the
That's why I call the new code before setAttributes() so that user's
selection is not overridden. I put a comment regarding that in the fix.
Regards
Prasanta
On 9/22/2016 10:38 PM, Philip Race wrote:
What happens if the application does not display a dialog but
instead the application code expl
On 9/21/2016 9:47 PM, Philip Race wrote:
Hi,
When the application is specifying the set of images from which
to build the MRI you ask the app to specify a "schema" (probably not the
right name given that it is per-file), and a floating point scale.
I don't see why we need to ask the app to name
Your comment refers only (and explicitly) to the print dialog :-
1484 * printing Banner page through print dialog via setAttributes().
So if we get into that code afterwards why do we need this new code ?
I do see that call to setAttributes() but I am assuming it does not
get in there
On 9/22/2016 3:48 AM, Jim Graham wrote:
I think this is a good point. The only gotcha would appear to be
handling the ImageObserver notifications and the prepareImage() calls.
The ImageObserver should get the variant's dimensions as one of the
first notifications, though if they trigger an im
On 9/22/2016 10:59 PM, Philip Race wrote:
Your comment refers only (and explicitly) to the print dialog :-
1484 * printing Banner page through print dialog via setAttributes().
So if we get into that code afterwards why do we need this new code ?
The new code is needed because if we
OK I see now.
The comment should be updated to remove mention of the dialog
and explain that instead.
But in that case do you still need the "else" in setAttributes?
-phil.
On 9/22/16, 10:32 AM, Prasanta Sadhukhan wrote:
On 9/22/2016 10:59 PM, Philip Race wrote:
Your comment refers only (
On 9/22/2016 11:09 PM, Philip Race wrote:
OK I see now.
The comment should be updated to remove mention of the dialog
and explain that instead.
But in that case do you still need the "else" in setAttributes?
Yes, right. we do not need the else in setAttributes. will update that
and comment a
On 9/22/2016 11:30 AM, Jim Graham wrote:
It gets further complicated, though, when you consider that we
probably need the dimensions of the base image for any metrics
reporting anyway.
Consider a 25x25 image with variants. If the user supplies a 125pct
variant then they will need an image th
Why do we need a new issue ?
I don't see how this fix can proceed without a lot of changes along
the lines I suggested and that should (must even) be part of it.
-phil.
On 9/22/16, 10:41 AM, Alexandr Scherbatiy wrote:
On 9/22/2016 11:30 AM, Jim Graham wrote:
It gets further complicated, though,
> The method getImageUsingNamingSchemes(String fileName,
MediaResolutionNamingScheme...
> namingSchemes) works for any scheme not only for the default one.
I'm sure it does. My point is that we don't need it.
No one will care or use it. They just want to list their image files.
The naming sche
Also as I pointed out before a string specified per-variant is not a
naming *scheme*.
It is just a "per-file" add-on to the basename
I could use
Image image = toolkit.getImageUsingNamingSchemes(url,
new Toolkit.MediaResolutionNamingScheme("abc", 1.5f),
new Toolkit.MediaRes
If I am developing a skinned UI and I provide a set of 20 images for various parts of the controls and then hand off to
my graphic designer to create the DPI variants for all of the images, it is much easier for me to tell them to name all
of the images with suffixes for the DPI variants and then
Does that need a whole new API class to support a list of strings ?
And it still not a "schema". It is simply one of a list of suffixes.
-phil.
On 9/22/16, 1:51 PM, Jim Graham wrote:
If I am developing a skinned UI and I provide a set of 20 images for
various parts of the controls and then hand
PING .. any takers on this two week old RFR ?
-phil.
On 9/8/16, 1:12 PM, Philip Race wrote:
[Fix i18n-dev address]
-phil.
On 9/8/16, 1:10 PM, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8162531
Webrev: http://cr.openjdk.java.net/~prr/8162531/
Solaris 10 is not supported
Naming aside - I think I came up with schema a few discussions ago and
better name suggestions are always welcome...
If we can get away with a list of suffixes then a new class is less
important, though we have the issue that an array or list of strings is
mutable. If any part of this process
22 matches
Mail list logo
