Re: [OpenJDK 2D-Dev] RFR: 8170552: [macosx] Wrong rendering of diacritics on macOS

I am not sure, but Is the apache license in the test can be accepted in the openjdk? I had an impression that all code should by under GPL v2 or GPL v2 + the Classpath exception. > > > +1 > > Vadim > > On 11/02/2017 16:15, dmitry markov wrote: >> Hi Dmitry, >> >> The fix looks good to me

Re: [OpenJDK 2D-Dev] RFR: 8170552: [macosx] Wrong rendering of diacritics on macOS

You are right ! I missed that. OpenJDK rules rquire it be contributed under GPL v2 (not classpath) The test needs to be updated or deleted ASAP (today would be good). -phil. On 2/15/17, 4:47 AM, Sergey Bylokhov wrote: I am not sure, but Is the apache license in the test can be accepted in the

Re: [OpenJDK 2D-Dev] RFR: 8170552: [macosx] Wrong rendering of diacritics on macOS

I have opened JDK-8175025 for that. Will send review soon. Thanks, Dmitry On 15/02/2017 18:36, Philip Race wrote: You are right ! I missed that. OpenJDK rules rquire it be contributed under GPL v2 (not classpath) The test needs to be updated

[OpenJDK 2D-Dev] [9] Review request for 8175025: The copyright section in the test/java/awt/font/TextLayout/DiacriticsDrawingTest.java should be updated

Hello, Could you review a simple fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8175025 webrev: http://cr.openjdk.java.net/~dmarkov/8175025/webrev.00/ Changed the license in the test to GPL v2. Thanks, Dmitry

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8147002:[macosx] Arabic character cannot be rendered on MacOS X

Hi, I don't know what versions of MacOS X either of you (Dmitry+Prasanta) used but I am going to guess they are different (can you both report these, for the record). In https://bugs.openjdk.java.net/browse/JDK-8147002, Prasanta enumerates the cascade list for the Italic case and I don't see .N

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8147002:[macosx] Arabic character cannot be rendered on MacOS X

Hi Phil, I was using osx10.11 but the list I enumerated in JBS is actually the composite font I get in CCompositeGlyphMapper#convertToGlyph() which contains those 29 slots [CCompositeGlyphMapper#convertToGlyph(unicode=value 1575) gets the glyph code(909) from slot[4] which is CourierNewPSMT,