Re: [OpenJDK 2D-Dev] [9] Review Request: 8177461 Wrong references are used in the javadoc in the java.desktop module

2017-03-29 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 23/03/17 18:24, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. In java.desktop module in a various places we use incorrect links. Most of them are in the documentation in non-public classes/methods(But there are two places in publi

[OpenJDK 2D-Dev] RFR: JDK-8177135: OpenJDK 9 freetype needs msvcr100.dll

2017-03-29 Thread Erik Joelsson
Hello, The build of freetype used internally at Oracle when building OpenJDK builds (for the reference implementation) is very old. It was also built using Visual Studio 2010, which makes it require msvcr100.dll, while the rest of OpenJDK is built with Visual Studio 2013 and subsequently requ

Re: [OpenJDK 2D-Dev] RFR: JDK-8177135: OpenJDK 9 freetype needs msvcr100.dll

2017-03-29 Thread Magnus Ihse Bursie
On 2017-03-29 15:00, Erik Joelsson wrote: Hello, The build of freetype used internally at Oracle when building OpenJDK builds (for the reference implementation) is very old. It was also built using Visual Studio 2010, which makes it require msvcr100.dll, while the rest of OpenJDK is built wit

Re: [OpenJDK 2D-Dev] RFR: JDK-8177135: OpenJDK 9 freetype needs msvcr100.dll

2017-03-29 Thread Philip Race
+1 -phil. On 3/29/17, 6:16 AM, Magnus Ihse Bursie wrote: On 2017-03-29 15:00, Erik Joelsson wrote: Hello, The build of freetype used internally at Oracle when building OpenJDK builds (for the reference implementation) is very old. It was also built using Visual Studio 2010, which makes it r

Re: [OpenJDK 2D-Dev] [9] Review request for 8167102: [macosx] PrintRequestAttributeSet breaks page size set using PageFormat

2017-03-29 Thread Philip Race
If the test is manual anyway, why does it not display a dialog so it is easier to run. On mac you can always then save as PDF so the "virtual printer" isn't needed. Note: this assumes you are using the native dialog not the Swing one. Does this in some way change the test so that it passed anywa

Re: [OpenJDK 2D-Dev] [9] Review request for 8167102: [macosx] PrintRequestAttributeSet breaks page size set using PageFormat

2017-03-29 Thread Anton Litvinov
Hello Prasanta, Thank you for approval of the second version of the fix. As it was agreed, I have filed a new bug with a corresponding test case for the separate issue which we discussed. The filed bug is (https://bugs.openjdk.java.net/browse/JDK-8177781). Thank you, Anton On 3/28/2017 5:23

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2017-03-29 Thread Sergey Bylokhov
Hi, Jim, Phil. I have started to use MRI and a new Robot in some of the tests and wonder why the MultiResolutionImage does not use generics for getResolutionVariants()? So for example if we have an API like: http://download.java.net/java/jdk9/docs/api/java/awt/Robot.html#createMultiResolutionScre

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2017-03-29 Thread Philip Race
This would be a reasonable thing to try to fix before 9 GA I think. Can't affect many tests since the code is new .. -phil. On 3/29/17, 1:22 PM, Sergey Bylokhov wrote: Hi, Jim, Phil. I have started to use MRI and a new Robot in some of the tests and wonder why the MultiResolutionImage does no