Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-17 Thread Florian Weimer
* Phil Race: > This upgrades JDK to import the current 2.7.2 version of harfbuzz - > an OpenType text shaping library > > https://bugs.openjdk.java.net/browse/JDK-8247872 > > This has passed building and headless and headful automated tests on > all platforms. Is it just me, or does the new Harfb

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-17 Thread Philip Race
There is more code in the newer version but not 4 times as much ! Harfbuzz now requires c++11 features (-std=c++11) Possibly the C++ compiler you are using (you don't mention platform) is slower in this mode. -phil. On 11/17/20, 9:01 AM, Florian Weimer wrote: * Phil Race: This upgrades JDK

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-17 Thread Florian Weimer
* Philip Race: > There is more code in the newer version but not 4 times as much ! > Harfbuzz now requires c++11 features (-std=c++11) > Possibly the C++ compiler you are using (you don't mention platform) is > slower in this mode. It's GCC 8 on Debian buster, which defaults to C++14. And it's

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-17 Thread Philip Race
So maybe the actual *usage* of C++11 features slows it down. I found this :- https://stackoverflow.com/questions/34179434/is-compiling-with-c11-way-slower-than-with-c98 I really did not even think to measure the build time and I don't think there's any JDK build parallelism in building a specifi

Re: [OpenJDK 2D-Dev] RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-17 Thread Victor Dyakov
On Tue, 10 Nov 2020 16:38:25 GMT, Kevin Rushforth wrote: >> Change looks ok from a build point of view, but I can't comment on the >> validity and implications of using this key. > > I ran a 3D lighting test that is designed to be a GPU stress test. It's a > worst case, to be sure, but it take

Re: [OpenJDK 2D-Dev] RFR: 8256321: Some "inactive" color profiles use the wrong profile class

2020-11-17 Thread Victor Dyakov
On Fri, 13 Nov 2020 22:50:02 GMT, Sergey Bylokhov wrote: > The implementation of ICC_Profile tries to defer loading the data of the > color profile, and it uses some predefined values for some profile properties > for the standard profiles like sRGB, PYCC, etc. If the application requests > pr

Re: [OpenJDK 2D-Dev] RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-17 Thread Phil Race
On Tue, 10 Nov 2020 16:38:25 GMT, Kevin Rushforth wrote: >> Change looks ok from a build point of view, but I can't comment on the >> validity and implications of using this key. > > I ran a 3D lighting test that is designed to be a GPU stress test. It's a > worst case, to be sure, but it take

Re: [OpenJDK 2D-Dev] RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-17 Thread Sergey Bylokhov
On Tue, 10 Nov 2020 16:38:25 GMT, Kevin Rushforth wrote: >> Change looks ok from a build point of view, but I can't comment on the >> validity and implications of using this key. > > I ran a 3D lighting test that is designed to be a GPU stress test. It's a > worst case, to be sure, but it take

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2

2020-11-17 Thread Magnus Ihse Bursie
On 2020-11-17 19:08, Philip Race wrote: So maybe the actual *usage* of C++11 features slows it down. I found this :- https://stackoverflow.com/questions/34179434/is-compiling-with-c11-way-slower-than-with-c98 I really did not even think to measure the build time and I don't think there's