[OpenJDK 2D-Dev] RFR: JDK-8079652: Could not enable D3D pipeline

2015-05-08 Thread Vadim Pakhnushev 

Hi,
Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8079652
Focus window's client area should be bigger otherwise CreateDevice fails.

diff --git 
a/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp 
b/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp
--- 
a/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp
+++ 
b/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp

@@ -829,7 +829,7 @@
 }

 HWND hWnd = CreateWindow(LD3DFocusWindow, LD3DFocusWindow, 0,
-mi.rcMonitor.left, mi.rcMonitor.top, 1, 1,
+mi.rcMonitor.left, mi.rcMonitor.top, 100, 100,
 NULL, NULL, GetModuleHandle(NULL), NULL);
 if (hWnd == 0) {
 J2dRlsTraceLn(J2D_TRACE_ERROR,

Re: [OpenJDK 2D-Dev] RFR: JDK-8079652: Could not enable D3D pipeline

2015-05-08 Thread Vadim Pakhnushev 
It's invisible and used only for getting application focus notifications 
internally by Direct3D.


On 08.05.2015 16:14, Sergey Bylokhov wrote:

Hi, Vadim.
Why we do not use the full screen size for this window?

On 08.05.15 14:07, Vadim Pakhnushev wrote:

Hi,
Please review the fix for 
https://bugs.openjdk.java.net/browse/JDK-8079652
Focus window's client area should be bigger otherwise CreateDevice 
fails.


diff --git 
a/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp 
b/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp 

--- 
a/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp
+++ 
b/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp

@@ -829,7 +829,7 @@
 }

 HWND hWnd = CreateWindow(LD3DFocusWindow, LD3DFocusWindow, 0,
-mi.rcMonitor.left, mi.rcMonitor.top, 1, 1,
+mi.rcMonitor.left, mi.rcMonitor.top, 100, 100,
 NULL, NULL, GetModuleHandle(NULL), NULL);
 if (hWnd == 0) {
 J2dRlsTraceLn(J2D_TRACE_ERROR,

Re: [OpenJDK 2D-Dev] RFR: JDK-8079652: Could not enable D3D pipeline

2015-05-08 Thread Sergey Bylokhov 

Hi, Vadim.
Thanks for clarification, please add this information as a comment to 
the code, before the push.


On 08.05.15 16:19, Vadim Pakhnushev wrote:
It's invisible and used only for getting application focus 
notifications internally by Direct3D.


On 08.05.2015 16:14, Sergey Bylokhov wrote:

Hi, Vadim.
Why we do not use the full screen size for this window?

On 08.05.15 14:07, Vadim Pakhnushev wrote:

Hi,
Please review the fix for 
https://bugs.openjdk.java.net/browse/JDK-8079652
Focus window's client area should be bigger otherwise CreateDevice 
fails.


diff --git 
a/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp 
b/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp 

--- 
a/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp
+++ 
b/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp

@@ -829,7 +829,7 @@
 }

 HWND hWnd = CreateWindow(LD3DFocusWindow, LD3DFocusWindow, 0,
-mi.rcMonitor.left, mi.rcMonitor.top, 1, 1,
+mi.rcMonitor.left, mi.rcMonitor.top, 100, 100,
 NULL, NULL, GetModuleHandle(NULL), NULL);
 if (hWnd == 0) {
 J2dRlsTraceLn(J2D_TRACE_ERROR,









--
Best regards, Sergey.

Re: [OpenJDK 2D-Dev] [9] Review Request: 6587235 Incorrect javadoc: no parameter in 2d source code

2015-05-08 Thread Phil Race 

273  * codeRuntimePermission(accessClassInPackage.+pkg)/code
 274  * permission.
 275  *
 276  * @param  pkgname   the package name.


perhaps line 273 should match ?

7  * @param srcArg The first source tile for the compositing operation.
  88  * @param dstIn The second source tile for the compositing operation.
  89  * @param dstOut The tile where the result of the operation is stored.
  90  */
  91 public void compose(Raster srcArg, Raster dstIn, WritableRaster 
dstOut) {

it might be better to rename the actual arguments to match the doc.


47 /**
  48  * Construct a new dialog type selection enumeration value with the
  49  * given integer value.
  50  *
  51  * @param  frame  Integer value.
  52  */
  53 public DialogOwner(Frame frame) {

Huh ? The entire doc seems to be nonsense .. changing the name of the param
just makes it worse. The text seems to have been copied from
javax.attribute.standard.DialogTypeSelection.java


-phil.

On 05/08/2015 12:25 PM, Sergey Bylokhov wrote:

Hello.
Please review the fix for a typos in jdk9. This CR was filed by me 
long time ago and I doubt that someone will take a look at it.

I fixed all clients files in sun.** subpackages.

Bug: https://bugs.openjdk.java.net/browse/JDK-6587235
Webrev can be found at: 
http://cr.openjdk.java.net/~serb/6587235/webrev.00

Re: [OpenJDK 2D-Dev] RFR: JDK-8079652: Could not enable D3D pipeline

2015-05-08 Thread Phil Race 
I guess this is OK since 100x100 ought to be always big enough but not 
too big ..
I suppose it may imply a different default window style is being added 
by CreateWindow

than we got before.

-phil.



On 5/8/2015 6:28 AM, Sergey Bylokhov wrote:

Hi, Vadim.
Thanks for clarification, please add this information as a comment to 
the code, before the push.


On 08.05.15 16:19, Vadim Pakhnushev wrote:
It's invisible and used only for getting application focus 
notifications internally by Direct3D.


On 08.05.2015 16:14, Sergey Bylokhov wrote:

Hi, Vadim.
Why we do not use the full screen size for this window?

On 08.05.15 14:07, Vadim Pakhnushev wrote:

Hi,
Please review the fix for 
https://bugs.openjdk.java.net/browse/JDK-8079652
Focus window's client area should be bigger otherwise CreateDevice 
fails.


diff --git 
a/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp 
b/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp 

--- 
a/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp
+++ 
b/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp

@@ -829,7 +829,7 @@
 }

 HWND hWnd = CreateWindow(LD3DFocusWindow, LD3DFocusWindow, 0,
-mi.rcMonitor.left, mi.rcMonitor.top, 1, 1,
+mi.rcMonitor.left, mi.rcMonitor.top, 100, 100,
 NULL, NULL, GetModuleHandle(NULL), NULL);
 if (hWnd == 0) {
 J2dRlsTraceLn(J2D_TRACE_ERROR,

[OpenJDK 2D-Dev] [9] Review Request: 6587235 Incorrect javadoc: no parameter in 2d source code

2015-05-08 Thread Sergey Bylokhov 

Hello.
Please review the fix for a typos in jdk9. This CR was filed by me long 
time ago and I doubt that someone will take a look at it.

I fixed all clients files in sun.** subpackages.

Bug: https://bugs.openjdk.java.net/browse/JDK-6587235
Webrev can be found at: http://cr.openjdk.java.net/~serb/6587235/webrev.00

--
Best regards, Sergey.

Re: [OpenJDK 2D-Dev] RFR: JDK-8079652: Could not enable D3D pipeline

2015-05-08 Thread Sergey Bylokhov 

Hi, Vadim.
Why we do not use the full screen size for this window?

On 08.05.15 14:07, Vadim Pakhnushev wrote:

Hi,
Please review the fix for 
https://bugs.openjdk.java.net/browse/JDK-8079652

Focus window's client area should be bigger otherwise CreateDevice fails.

diff --git 
a/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp 
b/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp 

--- 
a/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp
+++ 
b/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp

@@ -829,7 +829,7 @@
 }

 HWND hWnd = CreateWindow(LD3DFocusWindow, LD3DFocusWindow, 0,
-mi.rcMonitor.left, mi.rcMonitor.top, 1, 1,
+mi.rcMonitor.left, mi.rcMonitor.top, 100, 100,
 NULL, NULL, GetModuleHandle(NULL), NULL);
 if (hWnd == 0) {
 J2dRlsTraceLn(J2D_TRACE_ERROR,




--
Best regards, Sergey.

Re: [OpenJDK 2D-Dev] [9] Review Request: 6587235 Incorrect javadoc: no parameter in 2d source code

2015-05-08 Thread Sergey Bylokhov 

Hi, Phil.
Thanks for a review! The new version:
http://cr.openjdk.java.net/~serb/6587235/webrev.01

On 08.05.15 22:52, Phil Race wrote:

273 * codeRuntimePermission(accessClassInPackage.+pkg)/code
 274  * permission.
 275  *
 276  * @param  pkgname   the package name.


perhaps line 273 should match ?

7  * @param srcArg The first source tile for the compositing 
operation.
  88  * @param dstIn The second source tile for the compositing 
operation.
  89  * @param dstOut The tile where the result of the operation 
is stored.

  90  */
  91 public void compose(Raster srcArg, Raster dstIn, 
WritableRaster dstOut) {


it might be better to rename the actual arguments to match the doc.


47 /**
  48  * Construct a new dialog type selection enumeration value 
with the

  49  * given integer value.
  50  *
  51  * @param  frame  Integer value.
  52  */
  53 public DialogOwner(Frame frame) {

Huh ? The entire doc seems to be nonsense .. changing the name of the 
param

just makes it worse. The text seems to have been copied from
javax.attribute.standard.DialogTypeSelection.java


-phil.

On 05/08/2015 12:25 PM, Sergey Bylokhov wrote:

Hello.
Please review the fix for a typos in jdk9. This CR was filed by me 
long time ago and I doubt that someone will take a look at it.

I fixed all clients files in sun.** subpackages.

Bug: https://bugs.openjdk.java.net/browse/JDK-6587235
Webrev can be found at: 
http://cr.openjdk.java.net/~serb/6587235/webrev.00







--
Best regards, Sergey.

Re: [OpenJDK 2D-Dev] [9] Review Request: 6587235 Incorrect javadoc: no parameter in 2d source code

2015-05-08 Thread Phil Race 
I did not slog through all the webrev again but the changed parts look 
good, so +1.


-phil.

On 5/8/15 3:34 PM, Sergey Bylokhov wrote:

Hi, Phil.
Thanks for a review! The new version:
http://cr.openjdk.java.net/~serb/6587235/webrev.01

On 08.05.15 22:52, Phil Race wrote:

273 * codeRuntimePermission(accessClassInPackage.+pkg)/code
 274  * permission.
 275  *
 276  * @param  pkgname   the package name.


perhaps line 273 should match ?

7  * @param srcArg The first source tile for the compositing 
operation.
  88  * @param dstIn The second source tile for the compositing 
operation.
  89  * @param dstOut The tile where the result of the operation 
is stored.

  90  */
  91 public void compose(Raster srcArg, Raster dstIn, 
WritableRaster dstOut) {


it might be better to rename the actual arguments to match the doc.


47 /**
  48  * Construct a new dialog type selection enumeration value 
with the

  49  * given integer value.
  50  *
  51  * @param  frame  Integer value.
  52  */
  53 public DialogOwner(Frame frame) {

Huh ? The entire doc seems to be nonsense .. changing the name of the 
param

just makes it worse. The text seems to have been copied from
javax.attribute.standard.DialogTypeSelection.java


-phil.

On 05/08/2015 12:25 PM, Sergey Bylokhov wrote:

Hello.
Please review the fix for a typos in jdk9. This CR was filed by me 
long time ago and I doubt that someone will take a look at it.

I fixed all clients files in sun.** subpackages.

Bug: https://bugs.openjdk.java.net/browse/JDK-6587235
Webrev can be found at: 
http://cr.openjdk.java.net/~serb/6587235/webrev.00