Re: [OpenJDK 2D-Dev] RFR [XS] 8230769: BufImg_SetupICM add ReleasePrimitiveArrayCritical call in early return

Looks good Matthias. While looking at the code I saw that we escape two critical arrays via BufImg_GetRasInfo(). I guess its okay if all caller code to GetRasInfo() in the JDK are properly closed with the associated release function; still it made me a bit apprehensive. Cheers, Thomas On

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8217707: JNICALL declaration breaks Splash screen functions

Looks fine. Cheers, Thomas On Thu, Mar 28, 2019 at 5:11 PM Alexey Ivanov wrote: > Any volunteers for review? > > On 24/03/2019 19:18, Alexey Ivanov wrote: > > Hi, > > > > Please review the fix for jdk 13. > > > > bug: https://bugs.openjdk.java.net/browse/JDK-8217707 > > webrev:

Re: [OpenJDK 2D-Dev] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality

good now. Thank you. Strange that this error was not detected before, what with the masses of people running swing apps on AIX. Cheers, thomas > Thank you and best regards, > Volker > > > > On Mon, Mar 18, 2019 at 8:59 PM Thomas Stüfe > wrote: > > > > Sorry, not awt/2

Re: [OpenJDK 2D-Dev] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality

Sorry, not awt/2d group, but to me it looks fine too. Only nit: the error printout at 495 I would put right after the associated dlsym at 456. You want to make sure dlerror() is not stale at the point where you call it, since it would return NULL. Cheers, Thomas On Mon, Mar 18, 2019 at 3:17 PM

Re: [OpenJDK 2D-Dev] RFR(S): 8214343: Handle the absence of Xrandr more generically

Looks good Volker. I agree, NO_XRANDR is reasonable and better than HAVE_XRANDR. I have to say, the amount of work this took is insane for the size of the problem involved. Cheers, Thomas On Tue, Nov 27, 2018 at 2:54 PM Volker Simonis wrote: > > Hi, > > can I please have a review for the

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

Side note, I wondered whether IBM does anything original in their openj9 (the jdk parts they forked off OpenJDK) since they are targetting AIX too and must be having the same build error. But I cannot find anything they did: --- thomas@t450:/shared/projects/openjdk/j9/openj9-openjdk-jdk$ git log

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

FWIW I am very much in favor of (1) and if aesthetics are a problem in awt_GraphicsEnv.c, a "HAVE_XRANDR" define would make things a bit prettier... just my 2c. On Mon, Nov 19, 2018 at 6:58 PM Volker Simonis wrote: > > Hi Phil, > > I'd like to kindly ask you to suggest how we can proceed with

Re: [OpenJDK 2D-Dev] RFR: JDK-8204211: windows : handle potential C++ exception in GDIRenderer -was : RE: java2d coding using SAFE_SIZE_ARRAY_ALLOC / safe_Malloc

nge : > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8204211/ > > > > >> -Original Message- >> From: Thomas Stüfe [mailto:thomas.stu...@gmail.com] >> Sent: Mittwoch, 30. Mai 2018 17:37 >> To: Baesken, Matthias >> Cc: 2d-dev <2d-dev

Re: [OpenJDK 2D-Dev] [XS] RFR : JDK-8204085: avoid printing uninitialized pointer in java.desktop/windows/native/libawt/java2d/windows/GDIWindowSurfaceData.cpp

Hi Matthias, looks reasonable. Best Regards, Thomas On Wed, May 30, 2018 at 3:32 PM, Baesken, Matthias wrote: > Hi could I please get reviews for this very small change : > > > > In > java.desktop/windows/native/libawt/java2d/windows/GDIWindowSurfaceData.cpp , > function

Re: [OpenJDK 2D-Dev] RFR [XS] - 8203355 : MITSHM define guarding missing

Hi Matthias, Looks good. Best Regards, Thomas On Tue, May 22, 2018 at 8:33 AM, Baesken, Matthias wrote: > Hi Phil, thanks for looking into it. > > > > Can I get a second review ? > > > > Best regards, Matthias > > > > From: Phil Race [mailto:philip.r...@oracle.com] >

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

> upstream? > > Best Regards > > Adam > >> Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning >> in jchuff.cPhilip Race to: Adam Farley8 17/05/2018 03:32 >> Cc: 2d-dev, Andrew Leonard, build-dev, Magnus Ihse Bursie, "Thomas Stüfe"

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

gt;> >> Returning to this. >> >> While I understand your reluctance to patch upstream code, let me point >> out that we have not updated libjpeg a single time since the JDK was open >> sourced. We're using 6b from 27-Mar-1998. I had a look at the Wikipedia page

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

gs-as-errors on zlinux. Thanks, Thomas > > On 03/27/2018 05:44 AM, Thomas Stüfe wrote: > > Hi all, > > just a friendly reminder. I would like to push this tiny fix because > tripping over this on our linux s390x builds is annoying (yes, we can > maintain patch que

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

Hi all, Last week I openend JDK-8200052 and posted it to 2d-dev for RFR. Me included we have two reviewers and the tier1 tests ran through. Are there really any serious objections against pushing this tiny fix? It would make life for us (working on zLinux) easier. I will wait for 24 more hours

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

, I want to push it (tier1 tests ran thru, and me and Christoph langer are both Reviewers). Thanks! Thomas On Wed, Mar 21, 2018 at 6:20 PM, Thomas Stüfe <thomas.stu...@gmail.com> wrote: > Hi all, > > may I please have another review for this really trivial change. It fixes > a g

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

Thank you Christoph! On Tue, Mar 27, 2018 at 2:30 PM, Langer, Christoph <christoph.lan...@sap.com > wrote: > Hi Thomas, > > > > to me this fix looks good. > > > > Best regards > > Christoph > > > > *From:* 2d-dev [mailto:2d-dev-boun...@open

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

Hi Phil! thanks for pointing out the history, I was not aware of that. I looked at that huffman coding and tried to determine whether the underflow may happen in real life scenarios. I could at least not exclude that possibility. I looked thru the mailing list threads - did someone analyse and

[OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

Hi all, may I please have another review for this really trivial change. It fixes a gcc warning on s390 and ppc. Also, it is probably a good idea to fix this. bug: https://bugs.openjdk.java.net/browse/JDK-8200052 webrev:

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

es Development > IBM Hursley > IBM United Kingdom Ltd > Phone internal: 245913, external: 01962 815913 > internet email: andrew_m_leon...@uk.ibm.com > > > > > From:"Thomas Stüfe" <thomas.stu...@gmail.com> > To:Adam Farley8 &l

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

Hi, @Andrew Leonard: Sorry, I cannot find your name in http://openjdk.java.net/census#jdk. Are you a jdk contributor/reviewer, and if yes, what is your user name? @openjdk 2d folks: I also need to know: does the 2d project have any special rules about who can push or can I just push (I am jdk

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

Hi Adam, this patch looks good. I can sponsor this for you if noone else steps up, but we need a second reviewer, preferably one from the 2d project. Best Regards, Thomas On Wed, Mar 21, 2018 at 12:41 PM, Adam Farley8 wrote: > Hi All, > > If committers really don't

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

On Mon, Mar 12, 2018 at 5:58 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > > On 2018-03-12 14:26, Thomas Stüfe wrote: > >> Yes, I am aware :( Long term I hope windows 32bit gets the same occasional >> love as zero does. I can produce occasi

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

t perhaps .. but if someone > will do that I expect patches would not be refused. > > -phil. > > > On 3/9/18, 11:55 PM, Thomas Stüfe wrote: > >> I attempted to test the 32bit build but that seems to have bitrotted, I >> ran into errors not having anything to do with your change. >> >

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

Hi Phil, This is a nice change! And will make setting up the windows build env much easier. Change itself seems fine at a cursory glance. I also tested the build on Win7 with VS2013 (before, I used to build with a hand-compiled version of the freetypelib), and it worked fine. I attempted to