Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

2018-02-20 Thread Jayathirth D V
-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender. Hi, >>> 1) When we call Graphics2D.setColor() it uses ArgbPre PixelConverter >>> based on SurfaceData(here it is XRenderPixMap ArgbPre surface) and >>> converts the color to pr

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

2018-01-17 Thread Phil Race
+1 from me as well. I had approved the first version of the fix but this one looks fine too. -phil. On 01/16/2018 11:05 AM, Clemens Eisserer wrote: Hi Jay, 1) When we call Graphics2D.setColor() it uses ArgbPre PixelConverter based on SurfaceData(here it is XRenderPixMap ArgbPre surface)

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

2018-01-16 Thread Clemens Eisserer
Hi Jay, > 1) When we call Graphics2D.setColor() it uses ArgbPre PixelConverter based on > SurfaceData(here it is XRenderPixMap ArgbPre surface) and converts the color > to pre-multiplied values. Thanks a lot for identifying the issue and working on it. The fix itself looks fine and low-risk.

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

2018-01-15 Thread Prahalad Kumar Narayanan
; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender. Hello Jay > After that I listed call hierarchy to XRColor.setColorValues(int, boolean) > and found that after my fix at all the places we are p

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

2018-01-15 Thread Jayathirth D V
ny drawing operation. You could refer to one of the existing test cases and correct the test file. Thank you Have a good day Prahalad N. - Original Message - From: Phil Race Sent: Tuesday, December 12, 2017 12:15 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [10] RFR

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

2018-01-15 Thread Prahalad Kumar Narayanan
-Original Message- From: Jayathirth D V Sent: Thursday, December 14, 2017 6:49 PM To: Prahalad Kumar Narayanan; Philip Race; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender. Hello Prahalad, T

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

2017-12-14 Thread Jayathirth D V
test cases and correct the test file. Thank you Have a good day Prahalad N. - Original Message - From: Phil Race Sent: Tuesday, December 12, 2017 12:15 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on vo

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

2017-12-14 Thread Prahalad Kumar Narayanan
ou Have a good day Prahalad N. - Original Message - From: Phil Race Sent: Tuesday, December 12, 2017 12:15 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender. The explanati

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

2017-12-11 Thread Phil Race
The explanation sounds reasonable, although I'd like to give Clemens a chance to review this. -phil. On 12/07/2017 07:16 AM, Jayathirth D V wrote: Hello All, Please review the following fix in JDK10 : Bug : https://bugs.openjdk.java.net/browse/JDK-8176795 Webrev :

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

2017-12-11 Thread Jayathirth D V
Hello All, Gentle reminder for review. Thanks, Jay From: Jayathirth D V Sent: Thursday, December 07, 2017 8:47 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender. Hello All, Please

[OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

2017-12-07 Thread Jayathirth D V
Hello All, Please review the following fix in JDK10 : Bug : https://bugs.openjdk.java.net/browse/JDK-8176795 Webrev : http://cr.openjdk.java.net/~jdv/8176795/webrev.00/ Issue : When we draw translucent color over an opaque color in Unix from JDK 8 we get different color after