A general problem with hand-written HTML is that container elements are
treated as in-line affects. In particular, we sprinkle tags like
they are a command to insert a paragraph break, but that is a misnomer,
they are the start of a paragraph block and we never end any of them.
Most parsers g
Hi,
I am not happy with approving this until I have had a chance to review
1) The actual warnings from tidy
2) The effect on the generated javadoc.
I think adds extra space that does not, so don't jump to
conclusions
about what the original author was trying to achieve.
-phil.
On 11/21/201
Hi Joe.
In most cases the author used this stray "" as a line break.
A line break is necessary indeed but if it is followed by a block
element, it is considered erroneous by tidy.
So adding does, in fact, better correspond to the author original
idea.
On Wednesday, November 20, 2013 04:46:59
Sergey, you are right, in some cases (i.e.
at the end of package-summary.html)
the closing tag "/p" works exactly like "br".
I can submit another change; note however, that "/p" is not
mandatory for "p"; "br" works exactly like "/p" here;
and line break was the intention of the author.
Should I mak
Hi Joe,
there seems to be several reasons:
-- in some cases this just adds an extra line between items in
successive construction. Remove the , and these s will
stay as close to each other as regular lines in the document.
Which means too close, or did mean for original author of the doc.
See
Hi, Sergey.
Looks like in some cases, it is possible to replace "" to the ""
and close previous "" tag.
And I had a question to a 2D team. Is duplication in the header of [1]
intended?
[1]
http://download.java.net/jdk8/docs/api/javax/print/attribute/standard/Sides.html
Like:
SINGLE_DOCUMEN
Hello,
I'm not an HTML expert, but it seems preferable to me to just remove an
unnecessary "" tag rather than replacing it with "".
Is there a reason to prefer ""?
Otherwise the changes look fine.
Thanks,
-Joe
On 11/20/2013 1:47 AM, Sergey Lugovoy wrote:
Hi all,
please review the fix.
bug
Hi all,
please review the fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8028272
webrev : http://cr.openjdk.java.net/~yan/8028272/webrev.00/
This patch cleanup tidy warnings for generated html documentation for
javax.print package, and do not affect the appearance of the documentation.
The pa
