Re: [OpenJDK 2D-Dev] RFR: 8189809: Large performance regression in Swing text layout.

2017-12-11 Thread Sergey Bylokhov
Looks fine. On 11/12/2017 14:39, Phil Race wrote: Yes, it should  be negative since we want to use this as the y origin of the rectangle relative to the baseline. I am using it correctly in the height calculation. 40 float height = ascent + descent + leading; 541 return new

Re: [OpenJDK 2D-Dev] RFR: 8189809: Large performance regression in Swing text layout.

2017-12-11 Thread Phil Race
Yes, it should be negative since we want to use this as the y origin of the rectangle relative to the baseline. I am using it correctly in the height calculation. 40 float height = ascent + descent + leading; 541 return new Rectangle2D.Float(0f, ascent, width, height);

Re: [OpenJDK 2D-Dev] RFR: 8189809: Large performance regression in Swing text layout.

2017-12-11 Thread Sergey Bylokhov
Hi, Phil. The new code will calculate the logical bounds this way: 541 new Rectangle2D.Float(0f, ascent, width, height); But previously it was: 2613 new Rectangle2D.Float(0, -tl.getAscent(), tl.getAdvance(), 2614 tl.getAscent() + tl.getDescent() + 2615

Re: [OpenJDK 2D-Dev] RFR: 8189809: Large performance regression in Swing text layout.

2017-12-11 Thread Prahalad Kumar Narayanan
as well. Thank you Have a good day Prahalad -Original Message- From: Phil Race Sent: Friday, December 08, 2017 2:24 AM To: 2d-dev; swing-...@openjdk.java.net Subject: [OpenJDK 2D-Dev] RFR: 8189809: Large performance regression in Swing text layout. Bug: https://bugs.openjdk.java.net/browse

[OpenJDK 2D-Dev] RFR: 8189809: Large performance regression in Swing text layout.

2017-12-07 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8189809 webrev: http://cr.openjdk.java.net/~prr/8189809/ This partially addresses a slow-down in Swing. Swing now usually calls Font.getStringBounds() instead of FontMetrics().stringWidth for text measurement. The latter has a fast-path for