Re: [OpenJDK 2D-Dev] Initial implementation for batched AA-mask upload for xrender

2018-03-08 Thread Laurent Bourgès
Hi Clemens, I finally got my hands on a 10-year old NVidia GPU (8800GTS) and can > confirm Laurent's findings. > The proprietary nvidia driver is awesome for the MaskBlit workload, > for x11perf -shmput10 it is 32x faster > than my kaveri APU solution (despite it has to copy data via PCIe). >

Re: [OpenJDK 2D-Dev] Initial implementation for batched AA-mask upload for xrender

2018-03-08 Thread Clemens Eisserer
Hi Sergey, > Thank you for contribution! If there is a chance to implement it soon(at an > early test stage) then it is possible to push this to jdk11 and enable it by > default to expose all possible issues. If no issues will be found, then we > can release it as-is, otherwise we can disable it

Re: [OpenJDK 2D-Dev] Initial implementation for batched AA-mask upload for xrender

2018-03-08 Thread Clemens Eisserer
Hi everybody, I finally got my hands on a 10-year old NVidia GPU (8800GTS) and can confirm Laurent's findings. The proprietary nvidia driver is awesome for the MaskBlit workload, for x11perf -shmput10 it is 32x faster than my kaveri APU solution (despite it has to copy data via PCIe). > Finally,

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198406 Test TestAATMorxFont is unstable

2018-03-08 Thread Sergey Bylokhov
On 08/03/2018 08:30, Semyon Sadetsky wrote: Please remove redundant platform detection code since this is done in the jtreg header now. This check was added for the case when the test will be run in standalone w/o jtreg --Semyon On 03/07/2018 07:32 PM, Sergey Bylokhov wrote: Hello.

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198406 Test TestAATMorxFont is unstable

2018-03-08 Thread Phil Race
+1 I think the updated test is fine as it is. -phil. On 03/07/2018 07:32 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8198406 Webrev can be found at: http://cr.openjdk.java.net/~serb/8198406/webrev.00 Initially, this test

Re: [OpenJDK 2D-Dev] Initial implementation for batched AA-mask upload for xrender

2018-03-08 Thread Sergey Bylokhov
On 08/03/2018 03:21, Clemens Eisserer wrote: Hi Sergey, Thank you for contribution! If there is a chance to implement it soon(at an early test stage) then it is possible to push this to jdk11 and enable it by default to expose all possible issues. If no issues will be found, then we can

Re: [OpenJDK 2D-Dev] Initial implementation for batched AA-mask upload for xrender

2018-03-08 Thread Sergey Bylokhov
On 08/03/2018 05:03, Laurent Bourgès wrote: Does anybody know good statistical profiles these days? I have netbeans a try (worked well in the past) but it seems broken, VisualVM reports all time is spent in SunGraphics2D.fill/draw without providing any further details

Re: [OpenJDK 2D-Dev] bug 8146238 - Java Queue Flusher on MacOS

2018-03-08 Thread Bill York
Hi again, This JDK seems to fix the issue we see with our product. I have a few more questions. 1. Can we can share the download site with our customers? 2. Is there a best practice for that kind of sharing? 3. Is there a plan to get this bug fix into the JRE distributed by Oracle? Please let

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198406 Test TestAATMorxFont is unstable

2018-03-08 Thread Semyon Sadetsky
On 03/08/2018 02:24 PM, Sergey Bylokhov wrote: On 08/03/2018 14:11, Semyon Sadetsky wrote: That's doesn't make any sense. The w/o jtreg it is run manually and it is always known on what is the platform. There may be a need to run the test on another platform but this redundant check makes it

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198406 Test TestAATMorxFont is unstable

2018-03-08 Thread Semyon Sadetsky
On 03/08/2018 12:47 PM, Sergey Bylokhov wrote: On 08/03/2018 12:38, Semyon Sadetsky wrote: This check was added for the case when the test will be run in standalone w/o jtreg That's doesn't make any sense. The w/o jtreg it is run manually and it is always known on what is the platform. There

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

2018-03-08 Thread Sergey Bylokhov
On 08/03/2018 14:02, Laurent Bourgès wrote: I suppose the queue is drained too quickly on my fast gpu and is too small to feed the gpu... maybe I am wron Profiling will help here. on macOS you can user Instruments which can profile cpu and gpu. Definitely it is more related to awt... and

Re: [OpenJDK 2D-Dev] bug 8146238 - Java Queue Flusher on MacOS

2018-03-08 Thread Sergey Bylokhov
Hi, Bill. Thank you for confirmation. On 08/03/2018 14:08, Bill York wrote: 3. Is there a plan to get this bug fix into the JRE distributed by Oracle? I will reevaluate the fix for inclusion in jdk11. -- Best regards, Sergey.

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

2018-03-08 Thread Sergey Bylokhov
On 06/03/2018 00:38, Laurent Bourgès wrote: Yes d3d/ogl are defered rendering so using RenderQueue buffering has costs (1 extra mask copy + command arguments). I wonder how to improve such buffer queue to have less synchronization overhead induced by flushNow(), and why increasing the buffer

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198406 Test TestAATMorxFont is unstable

2018-03-08 Thread Semyon Sadetsky
On 03/08/2018 12:03 PM, Sergey Bylokhov wrote: On 08/03/2018 08:30, Semyon Sadetsky wrote: Please remove redundant platform detection code since this is done in the jtreg header now. This check was added for the case when the test will be run in standalone w/o jtreg That's doesn't make any

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198406 Test TestAATMorxFont is unstable

2018-03-08 Thread Sergey Bylokhov
On 08/03/2018 12:38, Semyon Sadetsky wrote: This check was added for the case when the test will be run in standalone w/o jtreg That's doesn't make any sense. The w/o jtreg it is run manually and it is always known on what is the platform. There may be a need to run the test on another

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198406 Test TestAATMorxFont is unstable

2018-03-08 Thread Sergey Bylokhov
On 08/03/2018 14:11, Semyon Sadetsky wrote: That's doesn't make any sense. The w/o jtreg it is run manually and it is always known on what is the platform. There may be a need to run the test on another platform but this redundant check makes it not possible. It was intentional decision, if

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

2018-03-08 Thread Laurent Bourgès
Sergey, Le 8 mars 2018 21:21, "Sergey Bylokhov" a écrit : On 06/03/2018 00:38, Laurent Bourgès wrote: > Yes d3d/ogl are defered rendering so using RenderQueue buffering has costs > (1 extra mask copy + command arguments). I wonder how to improve such > buffer queue

Re: [OpenJDK 2D-Dev] [11] Review Request: 4912693 Behavior of null arguments not specified in Java Sound

2018-03-08 Thread Sergey Bylokhov
Thank you for review. An updated version: http://cr.openjdk.java.net/~serb/4912693/webrev.01/ I also have updated the text in the "javax/print" package On 18/01/2018 16:18, Dan Rollo wrote: Hi Sergey, Looks good to me. One minor grammar thought: “an example of a”. Maybe: {@code

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198406 Test TestAATMorxFont is unstable

2018-03-08 Thread Semyon Sadetsky
Hi Sergey, Please remove redundant platform detection code since this is done in the jtreg header now. --Semyon On 03/07/2018 07:32 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8198406 Webrev can be found at: