Hi Phil,
> Test case works properly before and after the code change.
? You mean it does not fail before the fix ?
It definitely fails for me before the fix.
- I mean as intended Phil. It fails before the fix and after the fix it passes.
> Since we are touching getNumThumbnailsSupported()
Hi Laurent,
It took me I at least 5 tries to get all the way through this.
I don't have any substantial comments, just a few clean up questions.
What is this in Curve.java + DCurve.java ?
+if (false) {
+dax = 0.0d;
+day = 0.0d;
+dbx = 0.0d;
+
On 3/23/18, 11:56 AM, Sergey Bylokhov wrote:
Hi, Prahalad.
A few small comments about the test:
- Is it possible to test all installed ImageWriterSpi? It seems that
the test itself is not a JPEG plugin specific?
None of the other plugins support thumbnails so they will all return 0
On 3/23/18, 2:21 AM, Jayathirth D V wrote:
Hi Prahalad,
Change looks fine.
Test case works properly before and after the code change.
? You mean it does not fail before the fix ?
It definitely fails for me before the fix.
Since we are touching getNumThumbnailsSupported() function and it is