[OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

Hi, Could you please review the following fix for jdk11? bug: https://bugs.openjdk.java.net/browse/JDK-8202476 webrev: http://cr.openjdk.java.net/~aivanov/8202476/jdk11/webrev.0/ This is a follow-up fix for JDK-8201226 which enabled building JDK for 32 bit Windows, its code review:

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

Hi Alexey, looks good to me (not a Reviewer however). Thanks, Matthias > -Original Message- > From: Alexey Ivanov [mailto:alexey.iva...@oracle.com] > Sent: Mittwoch, 2. Mai 2018 11:52 > To: 2d-dev <2d-dev@openjdk.java.net> > Cc: build-dev ; Baesken, Matthias

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

Looks good to me, but you should have a reviewer from the client team as well. /Magnus > 2 maj 2018 kl. 11:52 skrev Alexey Ivanov : > > Hi, > > Could you please review the following fix for jdk11? > > bug: https://bugs.openjdk.java.net/browse/JDK-8202476 > webrev:

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

So ... the original change that removed the mapfiles broke the 32 bit build because of inconsistency between declarations + definitions of some functions. It did not affect 64 bit build because JNICALL is a no-op there. The next change (8201226) added JNICALL to make it consistent, but was not

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors (Resend)

I added a screenshot to https://bugs.openjdk.java.net/browse/JDK-8187100 if anyone wants to see what the impact of this fix is On Wed, Apr 25, 2018 at 8:39 AM, Steven R. Loomis wrote: > (Retrying as actual text) > > Support Unicode Variation Selectors. > > Code by my colleague

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

Hi Phil, Thank you for your review. On 02/05/2018 17:28, Phil Race wrote: So ... the original change that removed the mapfiles broke the 32 bit build because of inconsistency between declarations + definitions of some functions. It did not affect 64 bit build because JNICALL is a no-op

Re: [OpenJDK 2D-Dev] RFR: 8196572: Tests ColConvCCMTest.java and MTColConvTest.java fail

+1 On 02/05/2018 14:19, Phil Race wrote: Need to update the tolerances allowed in color conversion after LCMS 2.9 upgrade The CIEXYZ overall result is actually much better but the test will fail on a single difference of a color component for a single pixel. More details in the bug report.

[OpenJDK 2D-Dev] RFR: 8196572: Tests ColConvCCMTest.java and MTColConvTest.java fail

Need to update the tolerances allowed in color conversion after LCMS 2.9 upgrade The CIEXYZ overall result is actually much better but the test will fail on a single difference of a color component for a single pixel. More details in the bug report. Bug: