[OpenJDK 2D-Dev] [13] Review Request: 8225372 accessibility errors in tables in java.desktop files

2019-06-11 Thread Sergey Bylokhov
Hello. Please review the fix for JDK 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8225372 Fix: http://cr.openjdk.java.net/~serb/8225372/webrev.00 Doc: http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/module-summary.html In the fix, some(most) of the issues which were

Re: [OpenJDK 2D-Dev] RFR: 8217731: Font rendering and glyph spacing changed from jdk-8 to jdk-11

2019-06-11 Thread Philip Race
Hi, I am still looking for a code review on this - needed today ! -phil. On 6/5/19, 11:43 AM, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8217731 webrev: http://cr.openjdk.java.net/~prr/8217731/ This is intended to "help" but cannot completely cure, with some of the

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

2019-06-11 Thread Ajit Ghaisas
Hi Alexey, Thanks for suggesting how to run basic perf test. I did run it with and without Metal. The test run with Metal takes ~2X time to run as compared with OpenGL. What is your observation? Although, the java side code changes are good, I see an issue with native Metal

Re: [OpenJDK 2D-Dev] RFR: 8217731: Font rendering and glyph spacing changed from jdk-8 to jdk-11

2019-06-11 Thread Mario Torre
Hi Phil, Unfortunately I'm not a reviewer on 12 so I won't be able to OK for you, but the patch looks good to me. We had found a similar issue with Freetype and also came to the same conclusion that we should have the rendering mode to version 35 I think. I agree "better" is subjective, but I

Re: [OpenJDK 2D-Dev] RFR: 8217731: Font rendering and glyph spacing changed from jdk-8 to jdk-11

2019-06-11 Thread Sergey Bylokhov
Looks fine. On 11/06/2019 05:39, Philip Race wrote: Hi, I am still looking for a code review on this - needed today ! -phil. On 6/5/19, 11:43 AM, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8217731 webrev: http://cr.openjdk.java.net/~prr/8217731/ This is intended to

Re: [OpenJDK 2D-Dev] RFR: 8217731: Font rendering and glyph spacing changed from jdk-8 to jdk-11

2019-06-11 Thread Jayathirth Rao
Changes are fine. Thanks, Jay > On 11-Jun-2019, at 6:09 PM, Philip Race wrote: > > Hi, > > I am still looking for a code review on this - needed today ! > > -phil. > > On 6/5/19, 11:43 AM, Phil Race wrote: >> bug: https://bugs.openjdk.java.net/browse/JDK-8217731 >> webrev: