Re: [OpenJDK 2D-Dev] request for review: 7188093

Phil, I'm not sure about original test case, it uses cow.gif file. Moreover, it's not useful for this particular bug at all. I can open my version of the test which clearly shows the bug. I suppose I should post a webrev for this same CR with added test? Thanks, Vadim On 18.09.2012 22:32,

Re: [OpenJDK 2D-Dev] request for review: 7188093

. Ideally it should be automated. -phil. On 9/20/2012 7:51 AM, Vadim Pakhnushev wrote: Phil, I'm not sure about original test case, it uses cow.gif file. Moreover, it's not useful for this particular bug at all. I can open my version of the test which clearly shows the bug. I suppose I should post

Re: [OpenJDK 2D-Dev] request for review: 7188093

That's good, I will try to improve my test to be automated then. Thanks, Vadim On 21.09.2012 0:40, Clemens Eisserer wrote: Hi, Automated test will require taking screenshot and comparing results, I'm not sure if this mechanism works good. It should be possible to render to a VolatileImage,

[OpenJDK 2D-Dev] [8] request for review JDK-8000176

Hello, Please review automated test which checks that accelerated pipelines correctly use interpolation rendering hints. Discussion of the bug for which the test was created: http://mail.openjdk.java.net/pipermail/2d-dev/2012-September/002767.html webrev:

Re: [OpenJDK 2D-Dev] [8] request for review JDK-8000176

, Vadim On 28.09.2012 16:20, Vadim Pakhnushev wrote: Hello, Please review automated test which checks that accelerated pipelines correctly use interpolation rendering hints. Discussion of the bug for which the test was created: http://mail.openjdk.java.net/pipermail/2d-dev/2012-September/002767.html

Re: [OpenJDK 2D-Dev] [8] request for review JDK-8000176

, so you'll run the default twice, but that's OK. -phil. On 10/3/12 7:00 AM, Andrew Brygin wrote: Hello Vadim, the test looks fine to me. Thanks, Andrew On 03.10.2012 17:41, Vadim Pakhnushev wrote: Hello, I've made changes according to Andrew Brygin's feedback: Created unified drawTestImage

[OpenJDK 2D-Dev] [8] request for review: 4892259 GIF ImageReader does not call passComplete in IIOReadUpdateListener

Hi, Please review a fix for bug 4892259: http://bugs.sun.com/view_bug.do?bug_id=4892259 http://cr.openjdk.java.net/~bae/4892259/webrev.00/ Actually GIFImageReader should not call neither passComplete, nor passStarted for non-interlaced images in the first place. So the fix is to check whether

[OpenJDK 2D-Dev] [8] request for review: 5082749: GIF stream metadata specification of aspect ratio is incorrect.

Hi, Please review fix for the bug 5082749: http://bugs.sun.com/view_bug.do?bug_id=5082749 http://cr.openjdk.java.net/~bae/5082749/webrev.00/ There is a typo in the documentation, there are correct values everywhere else in the code. Thanks, Vadim

Re: [OpenJDK 2D-Dev] [8] request for review: 4892259 GIF ImageReader does not call passComplete in IIOReadUpdateListener

Phil, Andrew, Would you please take a look at this updated fix posted half a year ago? Thanks, Vadim On 20.11.2012 22:14, Vadim Pakhnushev wrote: Phil, That's right, interlaced images works as expected without the fix. Non-interlaced images could be considered single pass

[OpenJDK 2D-Dev] [8] request for review: 8016254 several sun/java2d/OpenGL tests failed with SIGFPE

Hi, Please review the fix for 8016254: http://bugs.sun.com/view_bug.do?bug_id=8016254 https://jbs.oracle.com/bugs/browse/JDK-8016254 http://cr.openjdk.java.net/~vadim/8016254/webrev.00/ The problem is that Intel 865G chipset (and some other ancient video cards) doesn't support

Re: [OpenJDK 2D-Dev] RFR: 8008022: Upgrade Direct X SDK used to build JDK

need to be sure that JPRT builds fine it will still be configured with that SDK, so your independent testing is also needed for that. -phil. On 9/6/2013 1:21 PM, Vadim Pakhnushev wrote: Hi all, Please review the fix for this bug: http://bugs.sun.com/view_bug.do?bug_id=8008022 http

Re: [OpenJDK 2D-Dev] [8] request for review: 8024511: Crash during color profile destruction

Looks good. On 10.09.2013 14:16, Andrew Brygin wrote: Hello, could you please review a fix for CR 8024511? Bug: http://bugs.sun.com/view_bug.do?bug_id=8024511 Webrev: http://cr.openjdk.java.net/~bae/8024511/webrev.00/ Starting fix for 7043064, we are using disposer to destroy a native part

Re: [OpenJDK 2D-Dev] Handling of premultication in the D3D OGL pipelines

BTW, before you stumble upon XOR XRender bug yourself - I'm currently working on it and will send a fix for review shortly. Thanks, Vadim On 01.10.2013 9:52, Clemens Eisserer wrote: Hi, I am currently testing compatibility of the xrender pipeline with different composition operations, and I

Re: [OpenJDK 2D-Dev] RFR: 8024343: Change different color with the The XOR alternation color combobox, the color of the image can not shown immediately.

Clemens, This bug is filed against JCK test, and there were a lot of internal urls in descriptions, hence it's confidential. So I have created open automatic regression test for that. Thanks, Vadim On 01.10.2013 20:43, Clemens Eisserer wrote: Hi Vadim, The fix itself looks fine to me -

[OpenJDK 2D-Dev] RFR: 8023590: REGRESSION: large count of graphics artifacts with Java 8 on Windows 8 on Intel HD card.

Hi, Please review a fix for this issue: https://bugs.openjdk.java.net/browse/JDK-8023590 http://cr.openjdk.java.net/~vadim/8023590/webrev.00/ In JDK 8 b91 we enabled D3D pipeline on Intel HD Graphics chipsets https://bugs.openjdk.java.net/browse/JDK-8000936 After that we received a number of

Re: [OpenJDK 2D-Dev] [8] request for review: 8026702: Fix for 8025429 breaks jdk build on windows

Looks good. On 16.10.2013 17:00, Andrew Brygin wrote: Hello, could you please review a fix for CR 8026702? Bug: http://bugs.sun.com/view_bug.do?bug_id=8026702 Webrev: http://cr.openjdk.java.net/~bae/8026702/webrev.00/ Suggested fix is to declare local variables in the beginning of the

[OpenJDK 2D-Dev] RFR: 8029628: Large amount of graphic artifacts

Hello, Please review a fix for the https://bugs.openjdk.java.net/browse/JDK-8029628 http://cr.openjdk.java.net/~vadim/8029628/webrev.00/ Intel HD Graphics 2000/3000 seems to be not usable (yet again!) So the proposed fix is to blacklist all Intel cards except for HD 4000+, which seems to be

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8029628: Many graphic artifacts

Changeset: c8c4aef922ff Author:vadim Date: 2013-12-13 11:49 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c8c4aef922ff 8029628: Many graphic artifacts Reviewed-by: prr, bae ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h

Re: [OpenJDK 2D-Dev] RFR: JDK-8039444: Swing applications not being displayed properly

Looks good to me. On 07.11.2014 21:52, Phil Race wrote: http://cr.openjdk.java.net/~prr/8039444/ Historically we enabled D3D only on Nvidia ATI hardware. Intel chipsets are a large part of the market but we continually encountered rendering artifacts that apparently were driver or hardware

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review Request: 8074028 Remove API references to java.awt.peer

On 04/03/15 15:37, Sergey Bylokhov wrote: http://cr.openjdk.java.net/~serb/8074028/webrev.05/src/java.desktop/share/classes/java/awt/MenuComponent.java.sdiff.html What's the point of ComponentPeer peer = this.peer; ? Why not just use peer as in other places in this file? Thanks, Vadim

[OpenJDK 2D-Dev] RFR: JDK-8079652: Could not enable D3D pipeline

Hi, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8079652 Focus window's client area should be bigger otherwise CreateDevice fails. diff --git a/src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp

Re: [OpenJDK 2D-Dev] RFR: (JDK-7011935) Using AWT in fullscreen exclusive mode results in a black screen

Hi Prasanta, I don't think that this is the right fix, it basically changes the D3D fullscreen mode from exclusive to simulated (as per GraphicsDevice.setFullScreenWindow terminology). I think further investigation is needed as to why this happens. BTW, while trying this, I've found that

Re: [OpenJDK 2D-Dev] RFR: JDK-8079652: Could not enable D3D pipeline

It's invisible and used only for getting application focus notifications internally by Direct3D. On 08.05.2015 16:14, Sergey Bylokhov wrote: Hi, Vadim. Why we do not use the full screen size for this window? On 08.05.15 14:07, Vadim Pakhnushev wrote: Hi, Please review the fix for https

Re: [OpenJDK 2D-Dev] RFR: JDK-8079652: Could not enable D3D pipeline

for clarification, please add this information as a comment to the code, before the push. On 08.05.15 16:19, Vadim Pakhnushev wrote: It's invisible and used only for getting application focus notifications internally by Direct3D. On 08.05.2015 16:14, Sergey Bylokhov wrote: Hi, Vadim. Why we do not use

Re: [OpenJDK 2D-Dev] RFR: JDK-8079652: Could not enable D3D pipeline

Could somebody take a look? On 13.05.2015 13:48, Vadim Pakhnushev wrote: Actually I've found a better solution - specify WS_POPUP window style. In this case the client area size will be exactly as specified instead of adjusting for some default window style. So please review the second

Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

lease find updated Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.06/ Please review so that we can push the change. Thanks, Jay -Original Message----- From: Vadim Pakhnushev Sent: Monday, October 19, 2015 4:03 PM To: Jayathirth D V; Sergey Bylokhov; 2d-dev@openjdk.java.n

Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

, Jayathirth D V wrote: Hi Vadim, Thanks for the review. I have made suggested changes. Updated Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.05/ Please review. Thanks, Jay -Original Message- From: Vadim Pakhnushev Sent: Friday, October 16, 2015 8:15 PM To: Jayathirth D V

Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

k.java.net/~rchamyal/jay/7182758/webrev.05/ Please review. Thanks, Jay -Original Message- From: Vadim Pakhnushev Sent: Friday, October 16, 2015 8:15 PM To: Jayathirth D V; Sergey Bylokhov; 2d-dev@openjdk.java.net; Philip Race Subject: Re: [OpenJDK 2D-Dev] Review request for JDK-7182758:

Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

updated Webrev: http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.07/ Please review. Thanks, Jay -Original Message- From: Vadim Pakhnushev Sent: Monday, October 19, 2015 4:50 PM To: Jayathirth D V; Sergey Bylokhov; 2d-dev@openjdk.java.net; Philip Race Subject: Re: [OpenJDK 2D-Dev]

Re: [OpenJDK 2D-Dev] RFR: 8143177: Integrate harfbuzz opentype layout engine per JEP 258

Looks good to me. Vadim On 22.11.2015 2:07, Philip Race wrote: http://cr.openjdk.java.net/~prr/8143177.2 is uploaded. See comments below. On 11/21/15, 2:41 AM, Vadim Pakhnushev wrote: Phil, In the HBShaper.c in the init_JNI_IDs function I think CHECK_NULL is missing for the gvdIndicesFID

Re: [OpenJDK 2D-Dev] RFR: 8143177: Integrate harfbuzz opentype layout engine per JEP 258

Phil, In the HBShaper.c in the init_JNI_IDs function I think CHECK_NULL is missing for the gvdIndicesFID. I guess it's just a copy from SunLayoutEngine.cpp but still. Calling init_JNI_IDs each time seems unneeded (not very harmful though), could it be somehow merged with the

Re: [OpenJDK 2D-Dev] RFR: 8055463: Needs public API allowing full access to font collections in Font.createFont()

Phil, Now the javadoc for both java.awt.Font.createFonts methods is incorrect: * The explicit purpose of this overloading of the * {@code createFont(int, InputStream)} method It's not an overload anymore. Other than that, looks good. Vadim On 21.03.2016 20:52, Phil Race wrote: After some CCC

[OpenJDK 2D-Dev] RFR: 8047931: Remove unused medialib code

Hi all, Please review this cleanup fix: https://bugs.openjdk.java.net/browse/JDK-8047931 While investigating unused files in the sparc build, it was found that there are a lot of unused code in the medialib. So without further ado, here's the whopping 35000 lines removal webrev:

Re: [OpenJDK 2D-Dev] RFR: 8039444: Swing applications not being displayed properly

+1 Vadim On 28.04.2016 23:52, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8039444 Webrev: http://cr.openjdk.java.net/~prr/8039444/ This makes 9 consistent in black-listing all intel chipsets as we did in 8u40 :

Re: [OpenJDK 2D-Dev] RFR: 8047931: Remove unused medialib code

Ping? On 25.04.2016 20:13, Vadim Pakhnushev wrote: Hi all, Please review this cleanup fix: https://bugs.openjdk.java.net/browse/JDK-8047931 While investigating unused files in the sparc build, it was found that there are a lot of unused code in the medialib. So without further ado, here's

Re: [OpenJDK 2D-Dev] RFR: 8047931: Remove unused medialib code

only mlib images with types MLIB_BYTE, and MLIB_SHORT (see allocateArray() and allocateReasterArray()) so routines for other types likely can be eliminated. Thanks, Andrew On May 4, 2016, at 1:08 PM, Vadim Pakhnushev <vadim.pakhnus...@oracle.com> wrote: Ping? On 25.04.2016 20:13,

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

Phil, I guess you wanted to remove the lines in the Awt2dLibraries.gmk? Do you think it's worth it to rewrite these assignments as separate assignment and a condition? Especially long ones with a lot of parentheses? Like this one, instead of if ((j = ((mlib_s32) ((mlib_addr) psrc_row & 4) >>

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

On 29.07.2016 17:30, Philip Race wrote: On 7/29/16, 7:00 AM, Vadim Pakhnushev wrote: On 29.07.2016 16:28, Philip Race wrote: On 7/29/16, 3:23 AM, Vadim Pakhnushev wrote: Phil, I guess you wanted to remove the lines in the Awt2dLibraries.gmk? Ah, yes. Not just disable them Do you

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

On 29.07.2016 16:28, Philip Race wrote: On 7/29/16, 3:23 AM, Vadim Pakhnushev wrote: Phil, I guess you wanted to remove the lines in the Awt2dLibraries.gmk? Ah, yes. Not just disable them Do you think it's worth it to rewrite these assignments as separate assignment and a condition

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

Why not just registry.getServiceProviders(ImageReaderSpi.class, ? Vadim On 01.08.2016 19:13, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience : Bug : https://bugs.openjdk.java.net/browse/JDK-8160736 Webrev :

[OpenJDK 2D-Dev] RFR: 8162545: Mac build failure

Hi all, Please review the build failure fix for: https://bugs.openjdk.java.net/browse/JDK-8162545 diff -r c0cf6ec85273 src/java.desktop/share/native/libjavajpeg/imageioJPEG.c --- a/src/java.desktop/share/native/libjavajpeg/imageioJPEG.c Tue Jul 26 15:55:22 2016 +0300 +++

Re: [OpenJDK 2D-Dev] RFR: 8162545: Mac build failure

I checked that this fix passes JPRT with Phil's fix as well. Vadim On 26.07.2016 18:10, Prasanta Sadhukhan wrote: Looks good. But strangely, I do not see this function in this file when Phil sent for review for his disable warning fix ;-) Regards Prasanta On 7/26/2016 8:20 PM, Vadim

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

Looks good! Vadim On 30.07.2016 6:49, Philip Race wrote: See http://cr.openjdk.java.net/~prr/8074843.1/ Also passes JPRT -phil. On 7/29/16, 7:35 AM, Vadim Pakhnushev wrote: On 29.07.2016 17:30, Philip Race wrote: On 7/29/16, 7:00 AM, Vadim Pakhnushev wrote: On 29.07.2016 16:28, Philip

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

Phil Race wrote: Looking for another "+1" ... -phil. On 07/29/2016 10:13 PM, Vadim Pakhnushev wrote: Looks good! Vadim On 30.07.2016 6:49, Philip Race wrote: See http://cr.openjdk.java.net/~prr/8074843.1/ Also passes JPRT -phil. On 7/29/16, 7:35 AM, Vadim Pakhnushev wrote: On 29.07.2016

Re: [OpenJDK 2D-Dev] RFR(S): 8161923: Fix two memory issues.

Hi Goetz, Maybe instead of increasing the stack size we could move the increment from the assignment to the previous if statement where we check for the overwrite possibility? There are similar code patterns in this file. Also there is almost identical file LigatureSubstProc.cpp which also

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

if (j = (w & 1)), isn't it? Regards Prasanta On 8/1/2016 10:43 PM, Phil Race wrote: Looking for another "+1" ... -phil. On 07/29/2016 10:13 PM, Vadim Pakhnushev wrote: Looks good! Vadim On 30.07.2016 6:49, Philip Race wrote: See http://cr.openjdk.java.net/~prr/8074843.1/ Also pas

Re: [OpenJDK 2D-Dev] RFR: 8170552: [macosx] Wrong rendering of diacritics on macOS

+1 Vadim On 11/02/2017 16:15, dmitry markov wrote: Hi Dmitry, The fix looks good to me too, but I am not a reviewer. So you need one more +1 from someone else with reviewer status. I will sponsor integration of the fix once it is finally approved. Thanks, Dmitry On 11/02/2017 02:48, Phil

Re: [OpenJDK 2D-Dev] RFR: 8170913: Java "1.8.0_112" on Windows 10 displays different characters for EUDCs from ones created in eudcedit.exe.

Looks good. Vadim On 10.02.2017 21:02, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8170913 http://cr.openjdk.java.net/~prr/8170913/ The EUDC font is now placed first in the list of fall backs, since anyone who has a EUDC font presumably wants the code points from there more

Re: [OpenJDK 2D-Dev] RFR: 8173028: Incorrect processing of supplementary-plane characters in text fields

+1 Vadim On 13/02/2017 20:52, Sergey Bylokhov wrote: Looks fine, but I’am not an expert in this area. https://bugs.openjdk.java.net/browse/JDK-8173028 http://cr.openjdk.java.net/~prr/8173028/ An off by-one bug in assigning remaining glyphs in the cluster to char indices so that the zero

Re: [OpenJDK 2D-Dev] [9] Review request for 8175025: The copyright section in the test/java/awt/font/TextLayout/DiacriticsDrawingTest.java should be updated

+1 Vadim On 16.02.2017 15:13, Sergey Bylokhov wrote: Looks fine. Hello, Could you review a simple fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8175025 webrev: http://cr.openjdk.java.net/~dmarkov/8175025/webrev.00/ Changed the license in the test to

Re: [OpenJDK 2D-Dev] RFR: 8172999: Crash on Windows getting FontMetrics since JDK 9 b96

Looks good. On 19.01.2017 2:08, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8172999 Webrev: http://cr.openjdk.java.net/~prr/8172999/ fix for a crash on windows. -phil.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6357887: selected printertray is ignored under linux

In the PSPrinterJob.java customTray.getChoiceName() is not checked for null but in the UnixPrintJob it is checked. Could this be a problem? The getMediaTray method in the test could be simplified to for (Media m : media) { if (m instanceof MediaTray) { if (m.toString().trim()...) {

Re: [OpenJDK 2D-Dev] RFR(XS): 8161923: Fix free in awt_PrintControl.

Looks good. Vadim On 25.08.2016 16:42, Lindenmaier, Goetz wrote: Hi, Could I please get a review for this tiny fix? http://cr.openjdk.java.net/~goetz/wr16/8161923-jdkMem/webrev.03/ Best regards, Goetz.

Re: [OpenJDK 2D-Dev] Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

Prem, I believe it's possible to use AccelSurface.getBounds() method and skip casting to SurfaceData completely. The calculations are basically the same. According to the comments in the TranslucentWindowPainter.createInstance you will get BIWindowPainter even for OpenGL pipeline unless you

Re: [OpenJDK 2D-Dev] Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

I am working on OpenGL rendering issue(8164811). Regards, Prem *From:*Vadim Pakhnushev *Sent:* Wednesday, August 31, 2016 5:00 PM *To:* Prem Balakrishnan; Sergey Bylokhov; 2d-dev@openjdk.java.net *Subject:* Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTransl

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

On 09.09.2016 15:58, Semyon Sadetsky wrote: On 09.09.2016 14:45, Vadim Pakhnushev wrote: My cards are HD Graphics 3000 (0x8086/0x0126) with 9.17.10.4101 and ATI Radeon HD 5700 (0x1002/0x68b8) with driver 8.17.10.1333 ATI is unrelated to this fix. Could you upgrade to the latest driver from

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

/drivers. To check if it's reproducible for you, hover the mouse above checkboxes in SwingSet2. For me they appears corrupted after the hover. Thanks, Vadim On 09.09.2016 14:16, Semyon Sadetsky wrote: On 09.09.2016 13:43, Vadim Pakhnushev wrote: On 09.09.2016 13:12, Semyon Sadetsky wrote

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

My cards are HD Graphics 3000 (0x8086/0x0126) with 9.17.10.4101 and ATI Radeon HD 5700 (0x1002/0x68b8) with driver 8.17.10.1333 ATI is unrelated to this fix. Could you upgrade to the latest driver from https://downloadcenter.intel.com/search?keyword=hd+graphics+3000 and try to reproduce

Re: [OpenJDK 2D-Dev] [9] Review Request 8155753: Removing a monitor in the OS dispaly configuration causes assertion fails under Windows

Looks good to me (have you submitted JPRT job just in case?) Vadim On 12/09/16 22:31, Semyon Sadetsky wrote: I missed this file in the list of changes. http://cr.openjdk.java.net/~ssadetsky/8155753/webrev.02/ --Semyon On 9/12/2016 9:33 PM, Vadim Pakhnushev wrote: Have you forgotten

Re: [OpenJDK 2D-Dev] [9] Review Request 8155753: Removing a monitor in the OS dispaly configuration causes assertion fails under Windows

/12/2016 6:56 PM, Semyon Sadetsky wrote: Okay. I will remove AccelDeviceEventNotifier and all related code. --Semyon On 9/12/2016 6:43 PM, Vadim Pakhnushev wrote: Hi Semyon, Generally seems reasonable, it seems that you should use screen instead of gdiScreen in the JNU_CallStaticMethodByName,

Re: [OpenJDK 2D-Dev] [9] Review Request 8155753: Removing a monitor in the OS dispaly configuration causes assertion fails under Windows

On 12/09/16 23:06, Semyon Sadetsky wrote: On 9/12/2016 10:36 PM, Vadim Pakhnushev wrote: Looks good to me (have you submitted JPRT job just in case?) Is JPRT really necessary? The native part is only changed for Windows on which the build is deterministic. As you wish --Semyon Vadim

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

On 09.09.2016 13:12, Semyon Sadetsky wrote: On 09.09.2016 12:56, Vadim Pakhnushev wrote: Semyon, I can reproduce JDK-803944 on my machine with your fix. More importantly, the RenderRectTest is passed for me on Windows 7 on ATI and Intel cards _without the fix_. My fix is not aimed to fix

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

Semyon, I can reproduce JDK-803944 on my machine with your fix. More importantly, the RenderRectTest is passed for me on Windows 7 on ATI and Intel cards _without the fix_. Do you have a standalone test from the original report? Vadim On 09.09.2016 10:31, Semyon Sadetsky wrote: I cannot

Re: [OpenJDK 2D-Dev] [9] Review Request 8155753: Removing a monitor in the OS dispaly configuration causes assertion fails under Windows

Hi Semyon, Generally seems reasonable, it seems that you should use screen instead of gdiScreen in the JNU_CallStaticMethodByName, otherwise the code won't compile. Not sure how the rest of the code handles monitor removal, seems to me that there are no usages of this notifications anywhere,

Re: [OpenJDK 2D-Dev] RFR: 8162531solaris.fontconfig.properties needs updating

+1 Vadim On 24.09.2016 8:00, Philip Race wrote: 1) version change is only if the format is incompatible - so no change there. 2) paths being absent is not a new issue. It has always been the case that a file is not present on a system at runtime. This was historically very common. The

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6357887: selected printertray is ignored under linux

You see, you now have 102 MediaTray mt = null; 114 return( mt); This can be just return null; No need for new webrev for that, +1. Vadim On 25.08.2016 19:14, Prasanta Sadhukhan wrote: On 8/25/2016 7:29 PM, Vadim Pakhnushev wrote: In the PSPrinterJob.java

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

+1 Vadim On 21.08.2016 21:31, Philip Race wrote: Thanks Sergey .. I am still waiting for a 2nd +1 from someone else. -phil. On 8/12/16, 12:28 PM, Sergey Bylokhov wrote: Looks fine. On 12.08.16 20:15, Philip Race wrote: Updated test : http://cr.openjdk.java.net/~prr/8139176.1/ -phil. On

Re: [OpenJDK 2D-Dev] RFR: 8168364: [macosx] Delete unused class NSPrintinfo

Looks good. Vadim On 24.10.2016 21:37, Philip Race wrote: Can I get a 2nd reviewer on this one ? -phil. On 10/20/16, 3:52 AM, Sergey Bylokhov wrote: Looks fine. On 20.10.16 2:35, Philip Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8168364 webrev :

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

My go-to place for BMP spec is https://msdn.microsoft.com/en-us/library/dd183391(v=vs.85).aspx which is where we point from JavaFX docs. Vadim On 24.10.2016 18:57, Philip Race wrote: I've poked around the Microsoft website and didn't turn up a location I am sure we could rely on. A

Re: [OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

I guess you could reorder the calls for CFRelease(font); and CFRelease(desc); so the desc gets released first in two locations under family == NULL and name == NULL. Just for the sake of consistency. Other than that, +1. Vadim On 16.10.2016 19:09, Philip Race wrote: Anyone ? I'd like to get

Re: [OpenJDK 2D-Dev] [9] Review Request: 8152683 Deadlock when resuming from sleep with different monitor setup

Looks good. Vadim On 05.03.2017 21:20, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-8152683 Webrev can be found at: http://cr.openjdk.java.net/~serb/8152683/webrev.00/ In the fix we update the mainDisplayId when the list of