Re: [PATCH V2] arm/kvm: add support for MTE

2024-09-19 Thread Cornelia Huck
On Thu, Sep 19 2024, Ganapatrao Kulkarni wrote: > I have modified as below diff to keep TCG if loop as it is and adding if > for KVM case to clear/mask the MTE bits if MTE in KVM mode is not > enabled by user command(if no mte=on). > > Is below diff makes sense? > > diff --git a/target/arm/cpu

Re: [PATCH V2] arm/kvm: add support for MTE

2024-09-17 Thread Cornelia Huck
guest even if the board hadn't > enabled MTE by wiring up the tag RAM. This meant that if the guest > then tried to use MTE QEMU would segfault accessing the > non-existent tag RAM. > > Signed-off-by: Cornelia Huck > Signed-off-by: Ganapatrao Kulkarni > --- > Changes sin

Re: [PATCH v1 00/14] s390x: virtio-mem support

2024-09-11 Thread Cornelia Huck
On Wed, Sep 11 2024, "Michael S. Tsirkin" wrote: >> > >> > I'd rather have it in a shared and bigger repo than in your personal >> > gitlab one. Maybe there's a space somewhere in QEMU or the Virtio team's >> > repos that would be a good fit if the kernel's docu isn't the right place? >> >> At

Re: [RFC PATCH V2 1/5] include: Add macro definitions needed for interrupt controller kvm emulation

2024-09-10 Thread Cornelia Huck
On Tue, Sep 10 2024, Xianglai Li wrote: > Add macro definitions needed for interrupt controller kvm emulation. > > Signed-off-by: Xianglai Li > --- > Cc: Paolo Bonzini > Cc: Song Gao > Cc: Jiaxun Yang > Cc: Huacai Chen > Cc: "Michael S. Tsirki

Re: [PATCH] hw/i386: define _AS_LATEST() macros for machine types

2024-09-06 Thread Cornelia Huck
> Signed-off-by: Daniel P. Berrangé > --- > hw/i386/pc_piix.c| 11 +-- > hw/i386/pc_q35.c | 11 ++- > include/hw/i386/pc.h | 4 +++- > 3 files changed, 14 insertions(+), 12 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH for-9.2] hw: add compat machines for 9.2

2024-08-16 Thread Cornelia Huck
On Fri, Aug 16 2024, Daniel P. Berrangé wrote: > On Fri, Aug 16, 2024 at 12:37:23PM +0200, Cornelia Huck wrote: >> Add 9.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. >> >> Signed-off-by: Cornelia Huck >> --- >> hw/arm/virt.c |

[PATCH for-9.2] hw: add compat machines for 9.2

2024-08-16 Thread Cornelia Huck
Add 9.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 15 --- hw/i386/pc_q35.c | 13

Re: [PATCH] arm/kvm: add support for MTE

2024-08-02 Thread Cornelia Huck
t;> enabled MTE by wiring up the tag RAM. This meant that if the guest >>> then tried to use MTE QEMU would segfault accessing the >>> non-existent tag RAM. >>> >>> Signed-off-by: Cornelia Huck >>> Signed-off-by: Ganapatrao Kulkarni >>>

Re: [PATCH v3 2/5] target/arm/kvm: Fix PMU feature bit early

2024-07-19 Thread Cornelia Huck
On Fri, Jul 19 2024, Akihiko Odaki wrote: > On 2024/07/18 21:07, Peter Maydell wrote: >> On Tue, 16 Jul 2024 at 13:50, Akihiko Odaki wrote: >>> >>> kvm_arm_get_host_cpu_features() used to add the PMU feature >>> unconditionally, and kvm_arch_init_vcpu() removed it when it is actually >>> not ava

Re: [PATCH v2] scripts/checkpatch: more checks on files imported from Linux

2024-07-19 Thread Cornelia Huck
> 1 file changed, 24 insertions(+) Reviewed-by: Cornelia Huck

Re: [PATCH] scripts/checkpatch: emit a warning if an imported file is touched

2024-07-17 Thread Cornelia Huck
On Wed, Jul 17 2024, Stefano Garzarella wrote: > If a file imported from Linux is touched, emit a warning and suggest > using scripts/update-linux-headers.sh > > Signed-off-by: Stefano Garzarella > --- > scripts/checkpatch.pl | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(

Re: [RFC 0/4] Added Interrupt controller emulation for loongarch kvm

2024-07-17 Thread Cornelia Huck
the branch is: interrupt > > the qemu: > https://github.com/lixianglai/qemu > the branch is: interrupt > > Please note that the code above is regularly updated based on community > reviews. > > Cc: Paolo Bonzini > Cc: Song Gao > Cc: Huacai Chen > Cc: Jiaxun Yang

Re: [PATCH] arm/kvm: add support for MTE

2024-07-10 Thread Cornelia Huck
we didn't configure tag memory, but the rest of the behaviour stays the same? > > Signed-off-by: Cornelia Huck > Signed-off-by: Ganapatrao Kulkarni (...) > +void kvm_arm_enable_mte(Object *cpuobj, Error **errp) > +{ > +static bool tried_to_enable; > +

Re: [PATCH 0/4] update-linux-headers: prepare for updating to 6.9+ and for SNP patches

2024-06-04 Thread Cornelia Huck
ude/standard-headers/linux/kvm_para.h > rename include/standard-headers/{linux => misc}/pvpanic.h (100%) > create mode 100644 linux-headers/asm-x86/kvm_para.h > create mode 100644 linux-headers/linux/kvm_para.h With the hash added to the headers update, Reviewed-by: Cornelia Huck for the series.

Re: [PATCH 3/4] linux-headers: Update to current kvm/next

2024-06-03 Thread Cornelia Huck
On Mon, Jun 03 2024, Paolo Bonzini wrote: > On Mon, Jun 3, 2024 at 5:58 PM Cornelia Huck wrote: >> Hm, I'm not sure updating to kvm/next is a good idea ("current kvm/next" >> does not mean anything without a commit hash anyway.) I think we should >> only

Re: [PATCH 3/4] linux-headers: Update to current kvm/next

2024-06-03 Thread Cornelia Huck
On Mon, Jun 03 2024, Paolo Bonzini wrote: > From: Pankaj Gupta > > Also brings in an linux-headers/linux/vhost.h fix from v6.9-rc4. > > Co-developed-by: Michael Roth > Signed-off-by: Michael Roth > Signed-off-by: Pankaj Gupta > Message-ID: <20240530111643.1091816-3-pankaj.gu...@amd.com> > Sig

Re: [PATCH 0/2] ppc: spapr: Nested kvm guest migration fixes

2024-06-03 Thread Cornelia Huck
On Mon, Jun 03 2024, Shivaprasad G Bhat wrote: > The series fixes the issues exposed by the kvm-unit-tests[1] > sprs-migration test. > > The sprs DEXCR and HASKKEYR are not registered with one-reg IDs > without which the Qemu is not setting them to their 'previous' > value during guest migreation

Re: [PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-27 Thread Cornelia Huck
On Mon, May 27 2024, Thomas Huth wrote: > On 27/05/2024 17.04, Cornelia Huck wrote: >> On Mon, May 27 2024, Thomas Huth wrote: >> >>> We are reusing the same temporary directory for installing the headers >>> of all targets, so there could be stale files here w

Re: [PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-27 Thread Cornelia Huck
On Mon, May 27 2024, Thomas Huth wrote: > We are reusing the same temporary directory for installing the headers > of all targets, so there could be stale files here when switching from > one target to another. Make sure to delete the folder before installing > a new set of target headers into it

Re: [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h

2024-05-27 Thread Cornelia Huck
"$output/standard-headers/asm-x86" > +"$output/include/standard-headers/asm-x86" > fi > if [ $arch = riscv ]; then > cp "$hdrdir/include/asm/ptrace.h" "$output/linux-headers/asm-riscv/" Reviewed-by: Cornelia Huck

Re: [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-04-16 Thread Cornelia Huck
On Wed, Apr 10 2024, Thomas Huth wrote: > On 09/04/2024 09.47, Shaoqin Huang wrote: >> Hi Thmoas, >> >> On 4/9/24 13:33, Thomas Huth wrote: +    assert_has_feature(qts, "host", "kvm-pmu-filter"); >>> >>> So you assert here that the feature is available ... >>>   assert_has_

Re: [PATCH] linux-headers: change the annotation of VFIO_IOMMU_SPAPR_REGISTER_MEMORY in vfio.h

2024-04-12 Thread Cornelia Huck
On Thu, Apr 11 2024, JianChunfu wrote: > The ioctl(VFIO_IOMMU_MAP_DMA/VFIO_IOMMU_UNMAP_DMA) won't be called > in SPAPR machine, which is replaced by VFIO_IOMMU_SPAPR_TCE_CREATE/ > VFIO_IOMMU_SPAPR_TCE_REMOVE, so change the description. > > Signed-off-by: JianChunfu > --- > linux-headers/linux/v

Re: [PATCH] Revert "hw/virtio: Add support for VDPA network simulation devices"

2024-04-08 Thread Cornelia Huck
et.rst| 121 - > 9 files changed, 3 insertions(+), 399 deletions(-) > delete mode 100644 docs/system/devices/vdpa-net.rst Acked-by: Cornelia Huck We should get rid of this before we release a version with non-upstream header code.

Re: [PATCH for-9.1 v5 1/3] hw: Add compat machines for 9.1

2024-03-25 Thread Cornelia Huck
On Mon, Mar 25 2024, Paolo Bonzini wrote: > Add 9.1 machine types for arm/i440fx/m68k/q35/s390x/spapr. > > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: Harsh Prateek Bora > Cc: Gavin Shan > Signed-off-by: Paolo Bonzini > --- > include/hw/boards.h| 3

Re: [PATCH 09/10] hw/pci: Set write-mask bits for PCIE Link-Control-2 register

2024-03-25 Thread Cornelia Huck
On Mon, Mar 25 2024, Cédric Le Goater wrote: > On 3/21/24 11:04, Saif Abrar wrote: >> PHB updates the register PCIE Link-Control-2. >> Set the write-mask bits for TLS, ENTER_COMP, TX_MARGIN, >> HASD, MOD_COMP, COMP_SOS and COMP_P_DE. > > > You should resend this patch independently of the PowerNV

Re: [PATCH vhost v4 1/6] virtio_balloon: remove the dependence where names[] is null

2024-03-25 Thread Cornelia Huck
On Mon, Mar 25 2024, Xuan Zhuo wrote: > On Fri, 22 Mar 2024 22:02:27 +0100, David Hildenbrand > wrote: >> On 22.03.24 20:16, Daniel Verkamp wrote: >> > On Thu, Mar 21, 2024 at 3:16 AM Xuan Zhuo >> > wrote: >> >> >> >> Currently, the init_vqs function within the virtio_balloon driver relies >>

Re: [PATCH vhost v4 1/6] virtio_balloon: remove the dependence where names[] is null

2024-03-25 Thread Cornelia Huck
On Mon, Mar 25 2024, Xuan Zhuo wrote: > On Fri, 22 Mar 2024 22:02:27 +0100, David Hildenbrand > wrote: >> On 22.03.24 20:16, Daniel Verkamp wrote: >> > On Thu, Mar 21, 2024 at 3:16 AM Xuan Zhuo >> > wrote: >> >> >> >> Currently, the init_vqs function within the virtio_balloon driver relies >>

Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH v3] virtio-can: Device specification.

2024-02-26 Thread Cornelia Huck
On Wed, Feb 21 2024, Marc Kleine-Budde wrote: > On 21.02.2024 14:16:54, Matias Ezequiel Vara Larsen wrote: >> On Wed, Feb 21, 2024 at 01:49:31PM +0100, Marc Kleine-Budde wrote: >> > On 21.02.2024 11:37:58, Matias Ezequiel Vara Larsen wrote: >> > > > > +The length of the \field{sdu} is determined

Re: [virtio-dev] [RFC PATCH v3] virtio-can: Device specification.

2024-02-16 Thread Cornelia Huck
On Fri, Jun 09 2023, Mikhail Golubev-Ciuchea wrote: > From: Harald Mommer > > virtio-can is a virtual CAN device. It provides a way to give access to > a CAN controller from a driver guest. The device is aimed to be used by > driver guests running a HLOS as well as by driver guests running a >

Re: [virtio-dev] [RFC PATCH v3 0/3] Virtio SPI Linux driver compliant to draft spec V10

2024-02-14 Thread Cornelia Huck
On Tue, Feb 13 2024, Harald Mommer wrote: > This is the 3rd RFC version of a virtio SPI Linux driver which is > intended to be compliant with the proposed virtio SPI draft > specification V10. FWIW: this version of the SPI spec has been voted in for virtio 1.4 (and is consequently available on t

[virtio-dev] Re: [virtio-comment] [PATCH] sound: add sampling rates 12000Hz and 24000Hz

2024-02-14 Thread Cornelia Huck
On Wed, Feb 14 2024, Anton Yakovlev wrote: > Thanks Pape! > > > On 05.02.2024 23:41, Pape, Andreas (ADITG/ESS3) wrote: >> 24kHz is used for 'super wideband' voice transmission 12kHz is added 'for >> completeness' >> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/184 >> >> Signed-off-by:

Re: [virtio-dev] [RFC PATCH v3] virtio-can: Device specification.

2024-02-13 Thread Cornelia Huck
On Fri, Jun 09 2023, Mikhail Golubev-Ciuchea wrote: > diff --git a/introduction.tex b/introduction.tex > index b7155bf..d560c63 100644 > --- a/introduction.tex > +++ b/introduction.tex > @@ -101,6 +101,8 @@ \section{Normative References}\label{sec:Normative > References} > \phantomsection

[virtio-dev] Re: [PATCH V2] virtio-transport: Clarify requirements

2024-02-13 Thread Cornelia Huck
On Tue, Jan 30 2024, Viresh Kumar wrote: > The virtio documentation currently doesn't define any generic > requirements that are applicable to all transports. They can be useful > while adding support for a new transport. > > This commit tries to define the same. > > Signed-off-by: Viresh Kumar

[virtio-dev] Re: [virtio-comment] [PATCH] sound: add sampling rates 12000Hz and 24000Hz

2024-02-07 Thread Cornelia Huck
On Mon, Feb 05 2024, "Pape, Andreas (ADITG/ESS3)" wrote: > 24kHz is used for 'super wideband' voice transmission 12kHz is added 'for > completeness' > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/184 > > Signed-off-by: Andreas Pape > --- > device-types/sound/description.tex | 4 +++-

[virtio-dev] Re: [virtio-comment] [RFC PATCH v3] virtio-can: Device specification.

2024-02-02 Thread Cornelia Huck
On Mon, Jan 15 2024, Cornelia Huck wrote: > On Mon, Jan 08 2024, Mikhail Golubev-Ciuchea > wrote: > >> Hi all! >> >> I kindly request a vote. >> >> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/186 > > Oh, that has been a while... I belie

Re: [virtio-dev] [PATCH] Define the DEVICE ID of Virtio Cpu balloon device as 47.

2024-01-30 Thread Cornelia Huck
On Mon, Jan 29 2024, Shujun Xue wrote: > Is there ETA for the migration? Well, I wish I knew... > > Bests, > Shujun > > > Cornelia Huck 于2024年1月29日 周一上午6:55写道: > >> On Tue, Jan 23 2024, Shujun Xue wrote: >> >> > The Virtio CPU balloon device is a

[virtio-dev] Re: [virtio] [PATCH] virtio-net: clarify error handling for coalescing

2024-01-29 Thread Cornelia Huck
On Mon, Jan 29 2024, "Michael S. Tsirkin" wrote: > On Mon, Jan 29, 2024 at 04:06:01PM +0100, Cornelia Huck wrote: >> On Wed, Jan 24 2024, "Michael S. Tsirkin" wrote: >> >> > This is not a huge deal since it's a SHOULD anyway, >> > so ma

[virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2024-01-29 Thread Cornelia Huck
On Mon, Jan 29 2024, Viresh Kumar wrote: > On 18-12-23, 15:02, Cornelia Huck wrote: >> Other things that probably should be mandatory: >> >> - A way for the driver to change the device status. Reading it would >> probably be a strong SHOULD. >> - A way to imp

[virtio-dev] Re: [virtio] [PATCH] virtio-net: clarify error handling for coalescing

2024-01-29 Thread Cornelia Huck
On Wed, Jan 24 2024, "Michael S. Tsirkin" wrote: > This is not a huge deal since it's a SHOULD anyway, > so make the new requirement SHOULD too. > > Signed-off-by: Michael S. Tsirkin > --- > device-types/net/description.tex | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff -

Re: [virtio-dev] [PATCH] Define the DEVICE ID of Virtio Cpu balloon device as 47.

2024-01-29 Thread Cornelia Huck
On Tue, Jan 23 2024, Shujun Xue wrote: > The Virtio CPU balloon device is a primitive device for managing guest > CPU capacity: the device asks for certain CPU cores to be online, > offline or throttled, and the driver performs the requested operation. > This allows the guest to adapt to changes

[virtio-dev] Re: [virtio-comment] [RFC PATCH v3] virtio-can: Device specification.

2024-01-15 Thread Cornelia Huck
On Mon, Jan 08 2024, Mikhail Golubev-Ciuchea wrote: > Hi all! > > I kindly request a vote. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/186 Oh, that has been a while... I believe that this still fits on top, although it has conflicts with virtio-spi, but nothing that a bit of fidd

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/1] RFC: virtio-bt: add virtio BT device specification

2024-01-15 Thread Cornelia Huck
On Thu, Dec 07 2023, Igor Skalkin wrote: > diff --git a/device-types/bt/description.tex b/device-types/bt/description.tex > new file mode 100644 > index 000..98311f4 > --- /dev/null > +++ b/device-types/bt/description.tex > @@ -0,0 +1,158 @@ > +\section{BT Device}\label{sec:Device Types / BT

Re: [PATCH] hw/arm/virt: Consolidate valid CPU types

2024-01-12 Thread Cornelia Huck
Signed-off-by: Gavin Shan > --- > hw/arm/virt.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH v4 4/4] hw/misc/pvpanic: add support for normal shutdowns

2024-01-12 Thread Cornelia Huck
: Thomas Weißschuh > --- > docs/specs/pvpanic.rst| 2 ++ > hw/misc/pvpanic.c | 5 + > include/hw/misc/pvpanic.h | 3 ++- > 3 files changed, 9 insertions(+), 1 deletion(-) Not deeply involved with this, but looks reasonable to me. Acked-by: Cornelia Huck

Re: [PATCH v4 3/4] tests/qtest/pvpanic: use centralized definition of supported events

2024-01-12 Thread Cornelia Huck
| 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH v4 2/4] hw/misc/pvpanic: centralize definition of supported events

2024-01-12 Thread Cornelia Huck
sa.c | 2 +- > hw/misc/pvpanic-pci.c | 2 +- > hw/misc/pvpanic.c | 2 +- > include/hw/misc/pvpanic.h | 1 + > 4 files changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH v4 1/4] linux-headers: drop pvpanic.h

2024-01-12 Thread Cornelia Huck
| 3 +++ > include/standard-headers/linux/pvpanic.h | 9 - > scripts/update-linux-headers.sh | 3 +-- > 6 files changed, 4 insertions(+), 14 deletions(-) Reviewed-by: Cornelia Huck

Re: [virtio-dev] [PATCH v8] virtio-net: correct conditions for devices to validate packet checksum

2024-01-11 Thread Cornelia Huck
On Thu, Jan 11 2024, Heng Qi wrote: > 在 2024/1/4 下午12:47, Heng Qi 写道: >> >> >> 在 2024/1/3 下午2:35, Heng Qi 写道: >>> There is a historical error in virtio spec: >>>    "If VIRTIO_NET_F_GUEST_CSUM is not negotiated, the device *MUST* >>> set flags >>>     to zero and SHOULD supply a fully checksumme

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-22 Thread Cornelia Huck
On Tue, Dec 12 2023, Haixu Cui wrote: > The Virtio SPI (Serial Peripheral Interface) device is a virtual > SPI controller that allows the driver to operate and use the SPI > controller under the control of the host. > > This patch adds the specification for virtio-spi. > > Signed-off-by: Haixu Cu

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-21 Thread Cornelia Huck
On Thu, Dec 21 2023, Haixu Cui wrote: > Hi Cornelia, > > On 12/21/2023 4:44 PM, Cornelia Huck wrote: >> On Thu, Dec 21 2023, Haixu Cui wrote: >>>> Please move inclusion of this new file into content.tex here, instead of >>>> including a not-

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-21 Thread Cornelia Huck
On Thu, Dec 21 2023, Haixu Cui wrote: > Hi Cornelia, > Much appreciated for your comments and please refer to my response. > > On 12/18/2023 7:04 PM, Cornelia Huck wrote: >> On Tue, Dec 12 2023, Haixu Cui wrote: >> >> [BTW: A changelog would be useful, eithe

[virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2023-12-20 Thread Cornelia Huck
On Mon, Dec 18 2023, Bill Mills wrote: > On 12/18/23 9:19 AM, Alex Bennée wrote: >> Cornelia Huck writes: >> >>> On Wed, Dec 06 2023, Viresh Kumar wrote: >>> >>>> On 05-12-23, 14:18, Cornelia Huck wrote: >>>>> On Tue, Dec 05 2

Re: [virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2023-12-20 Thread Cornelia Huck
On Mon, Dec 18 2023, Alex Bennée wrote: > Cornelia Huck writes: > >> On Tue, Dec 05 2023, Alex Bennée wrote: >> >>> Cornelia Huck writes: >>> >>>> On Tue, Dec 05 2023, Viresh Kumar wrote: >>>>> + >>>>> +The device

[virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2023-12-18 Thread Cornelia Huck
On Wed, Dec 06 2023, Viresh Kumar wrote: > On 05-12-23, 14:18, Cornelia Huck wrote: >> On Tue, Dec 05 2023, Viresh Kumar wrote: >> > +\section{Virtio Transport Requirements}\label{sec:Virtio Transport >> > Options / Virtio Transport Requirements} >> >

[virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2023-12-18 Thread Cornelia Huck
On Tue, Dec 05 2023, Alex Bennée wrote: > Cornelia Huck writes: > >> On Tue, Dec 05 2023, Viresh Kumar wrote: >>> + >>> +The device MUST present each event, in a transport defined way, from the >>> +moment it takes place until the driver acknowledges the

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-18 Thread Cornelia Huck
On Tue, Dec 12 2023, Haixu Cui wrote: [BTW: A changelog would be useful, either in the patch or in the cover letter.] > The Virtio SPI (Serial Peripheral Interface) device is a virtual > SPI controller that allows the driver to operate and use the SPI > controller under the control of the host.

[virtio-dev] Re: [virtio-comment] Changes coming to this mail list system

2023-12-14 Thread Cornelia Huck
On Tue, Dec 05 2023, Scott McGrath wrote: [dropped non-virtio lists, added the other virtio lists] > The Transition Schedule > > Starting 14 December, there may be as much as several days of system > downtime. During the downtime you will not receive email messages sent to > this list or have ac

[virtio-dev] virtio 1.3: update

2023-12-11 Thread Cornelia Huck
You may have been wondering what the current state of virtio 1.3 is; the tl;dr is: we have to deal with some unfortunate delays, but it is really nearing release now. The current state - virtio-1.3-csd01 (committee specification draft) has been out for public review, and that 30 d

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-12-06 Thread Cornelia Huck
On Mon, Dec 04 2023, Haixu Cui wrote: > Hi Huck, > > On 12/1/2023 7:01 PM, Cornelia Huck wrote: >> On Fri, Dec 01 2023, Haixu Cui wrote: >> >>>>> +Note: chipselect is an electrical signal controlled by the SPI >>>>> controller, used to selec

[virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2023-12-05 Thread Cornelia Huck
On Tue, Dec 05 2023, Viresh Kumar wrote: > The virtio documentation currently doesn't define any generic > requirements that are applicable to all transports. They can be useful > while adding support for a new transport. > > This commit tries to define the same. Thank you for tackling this, alb

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-12-01 Thread Cornelia Huck
On Fri, Dec 01 2023, Haixu Cui wrote: >>> +Note: chipselect is an electrical signal controlled by the SPI controller, >>> used to select the >>> +SPI slaves connected to the controller. >> >> I wonder whether another term is now more commonly used... the Wikipedia >> article uses main/sub, is t

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-11-30 Thread Cornelia Huck
On Thu, Nov 30 2023, Haixu Cui wrote: > The Virtio SPI (Serial Peripheral Interface) device is a virtual > SPI controller that allows the driver to operate and use the SPI > controller under the control of the device. > > This patch adds the specification for virtio-spi. > > Signed-off-by: Haixu

Re: [PATCH v2 3/3] hw/misc/pvpanic: add support for normal shutdowns

2023-11-29 Thread Cornelia Huck
On Wed, Nov 29 2023, Thomas Weißschuh wrote: > On 2023-11-29 09:23:46+0100, Cornelia Huck wrote: >> On Tue, Nov 28 2023, Thomas Weißschuh wrote: >> > diff --git a/include/standard-headers/linux/pvpanic.h >> > b/include/standard-headers/linux/pvpanic.h >> &

[virtio-dev] Re: [virtio-comment] [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-29 Thread Cornelia Huck
On Wed, Nov 29 2023, Viresh Kumar wrote: > On 29-11-23, 18:31, Haixu Cui wrote: >> Hi Viresh, >> >> Thank you for your helpful comments. In next patch, I will clearly point >> this out: > > Great, finally we are on the same page. Thanks Haixu. > >> "For full-duplex read and write transfe

[virtio-dev] Re: [virtio-comment] [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-29 Thread Cornelia Huck
On Wed, Nov 29 2023, Haixu Cui wrote: > Hi Viresh, > > On 11/29/2023 3:30 PM, Viresh Kumar wrote: >> On 28-11-23, 20:58, Haixu Cui wrote: >>> On 11/27/2023 6:17 PM, Viresh Kumar wrote: On 24-11-23, 15:20, Haixu Cui wrote: > +For half-duplex read transfer, \field{rx_buf} is filled by Virt

Re: [PATCH v2 3/3] hw/misc/pvpanic: add support for normal shutdowns

2023-11-29 Thread Cornelia Huck
On Tue, Nov 28 2023, Thomas Weißschuh wrote: > Shutdown requests are normally hardware dependent. > By extending pvpanic to also handle shutdown requests, guests can > submit such requests with an easily implementable and cross-platform > mechanism. > > Signed-off-by: Thomas Weißschuh > --- > d

Re: [PATCH for-8.2] target/arm: Disable SME if SVE is disabled

2023-11-28 Thread Cornelia Huck
On Mon, Nov 27 2023, Peter Maydell wrote: > There is no architectural requirement that SME implies SVE, but > our implementation currently assumes it. (FEAT_SME_FA64 does > imply SVE.) So if you try to run a CPU with eg "-cpu max,sve=off" > you quickly run into an assert when the guest tries to w

[virtio-dev] Re: [virtio-comment] Re: [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-27 Thread Cornelia Huck
On Mon, Nov 27 2023, Cornelia Huck wrote: > On Mon, Nov 27 2023, Haixu Cui wrote: > >> On 11/24/2023 11:46 PM, Cornelia Huck wrote: >>> On Fri, Nov 24 2023, Haixu Cui wrote: >>>> +The \field{chip_select_max_number} is the maximum number of chipselect >

[virtio-dev] Re: [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-27 Thread Cornelia Huck
On Mon, Nov 27 2023, Haixu Cui wrote: > On 11/24/2023 11:46 PM, Cornelia Huck wrote: >> On Fri, Nov 24 2023, Haixu Cui wrote: >>> +The \field{chip_select_max_number} is the maximum number of chipselect the >>> host SPI controller supports. >> >> &q

[virtio-dev] Re: [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-24 Thread Cornelia Huck
On Fri, Nov 24 2023, Haixu Cui wrote: > virtio-spi is a virtual SPI (Serial Peripheral Interface) controller and it > allows > a guest to operate and use the host SPI controller. > > This patch adds the specification for virtio-spi. As Mark has already reviewed it from the SPI POV (thanks!), I'

[PATCH for-9.0] hw: Add compat machines for 9.0

2023-11-20 Thread Cornelia Huck
Add 9.0 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 17 ++--- hw/i386/pc_q35.c | 13

Re: [virtio] Invitation to comment on Virtual I/O Device (VIRTIO) Version 1.3 - ends December 8th

2023-11-13 Thread Cornelia Huck
It seems that the original mail did not make it to some of the mailing lists it was intended to go to, possibly due to the html part of the original mail. Therefore, I'm trying again, this time with plain text only. Apologies in advance for any duplicates. On Wed, Nov 08 2023, Paul Knight wrote:

Re: [virtio] Invitation to comment on Virtual I/O Device (VIRTIO) Version 1.3 - ends December 8th

2023-11-13 Thread Cornelia Huck
It seems that the original mail did not make it to some of the mailing lists it was intended to go to, possibly due to the html part of the original mail. Therefore, I'm trying again, this time with plain text only. Apologies in advance for any duplicates. On Wed, Nov 08 2023, Paul Knight wrote:

Re: [PATCH v1 1/9] linux-headers: Add KVM headers for loongarch

2023-11-08 Thread Cornelia Huck
On Wed, Nov 08 2023, xianglai li wrote: > From: zhaotianrui > > Update linux KVM headers about LoongArch KVM form linux > kernel. Mainly contains some KVM structures and macro > defines such as LoongArch KVM registers number, LoongArch > fpu structure, exit reason of LoongArch IOCSR, etc. > > Si

Re: [PATCH v2 3/3] arm/kvm: convert to read_sys_reg64

2023-10-17 Thread Cornelia Huck
On Tue, Oct 17 2023, Peter Maydell wrote: > On Tue, 10 Oct 2023 at 15:25, Cornelia Huck wrote: >> >> We can use read_sys_reg64 to get the SVE_VLS register instead of >> calling GET_ONE_REG directly. >> >> Suggested-by: Gavin Shan >> Signed-off-by: Corne

[PATCH v2 2/3] arm/kvm: convert to kvm_get_one_reg

2023-10-10 Thread Cornelia Huck
We can neaten the code by switching the callers that work on a CPUstate to the kvm_get_one_reg function. Reviewed-by: Gavin Shan Signed-off-by: Cornelia Huck --- target/arm/kvm.c | 15 +++- target/arm/kvm64.c | 57 -- 2 files changed, 18

[PATCH v2 1/3] arm/kvm: convert to kvm_set_one_reg

2023-10-10 Thread Cornelia Huck
We can neaten the code by switching to the kvm_set_one_reg function. Reviewed-by: Gavin Shan Signed-off-by: Cornelia Huck --- target/arm/kvm.c | 13 +++-- target/arm/kvm64.c | 66 +- 2 files changed, 21 insertions(+), 58 deletions(-) diff

[PATCH v2 3/3] arm/kvm: convert to read_sys_reg64

2023-10-10 Thread Cornelia Huck
We can use read_sys_reg64 to get the SVE_VLS register instead of calling GET_ONE_REG directly. Suggested-by: Gavin Shan Signed-off-by: Cornelia Huck --- target/arm/kvm64.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index

[PATCH v2 0/3] arm/kvm: use kvm_{get,set}_one_reg

2023-10-10 Thread Cornelia Huck
oth in 'Odd fixes' anyway), I left them alone. Survives some testing on a Mt. Snow. Cornelia Huck (3): arm/kvm: convert to kvm_set_one_reg arm/kvm: convert to kvm_get_one_reg arm/kvm: convert to read_sys_reg64 target/arm/kvm.c | 28 +++--- target/arm/

Re: [PATCH for-8.2 2/2] arm/kvm: convert to kvm_get_one_reg

2023-10-10 Thread Cornelia Huck
[spooky season is coming up, so time for some thread necromancy!] On Thu, Jul 27 2023, Cornelia Huck wrote: > On Tue, Jul 25 2023, Gavin Shan wrote: > >> On 7/24/23 18:48, Cornelia Huck wrote: >>> On Mon, Jul 24 2023, Gavin Shan wrote: >>>> >>>> On

Re: MAINTAINERS still leaves more files uncovered than I'd like

2023-09-29 Thread Cornelia Huck
On Fri, Sep 29 2023, Thomas Huth wrote: > On 29/09/2023 14.05, Cornelia Huck wrote: >> On Fri, Sep 29 2023, Markus Armbruster wrote: >> >>> Where are the remaining unmaintained files now? Top-scoring >>> directories, files in sub-directories not counted: &

[PATCH] MAINTAINERS: add standard-headers to Hosts/LINUX

2023-09-29 Thread Cornelia Huck
The files in there are updated via update-linux-headers.sh. Signed-off-by: Cornelia Huck --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 355b1960ce46..95df1f3d8884 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -556,6 +556,7 @@ M: Cornelia Huck

Re: MAINTAINERS still leaves more files uncovered than I'd like

2023-09-29 Thread Cornelia Huck
On Fri, Sep 29 2023, Markus Armbruster wrote: > Where are the remaining unmaintained files now? Top-scoring > directories, files in sub-directories not counted: > > $ sed 's,/[^/]*$,/,;s,^[^/]*$,./,' unmaintained-files | sort | uniq -c | > sort -nr > > # directory (...) > 40 in

Re: [virtio-dev] [PATCH] html: add missing enumitem package

2023-09-28 Thread Cornelia Huck
On Wed, Sep 27 2023, "Michael S. Tsirkin" wrote: > makediffhtml.sh currently fails with: > > ! Missing number, treated as zero. > >\c@* > l.25850 \begin{enumerate}[label=\alph* > .] > ? > ! Emergency stop. > >\c@* > l

Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled

2023-09-27 Thread Cornelia Huck
On Wed, Sep 27 2023, Halil Pasic wrote: > On Wed, 27 Sep 2023 12:08:43 +0200 > Cornelia Huck wrote: > >> > On the other hand virtio_airq_handler() calls vring_interrupt() with >> > interrupts enabled. (While vring_interrupt() is called in a (read) >> > cri

Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled

2023-09-27 Thread Cornelia Huck
On Tue, Sep 26 2023, Halil Pasic wrote: > [..] >> --- a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c >> +++ b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c >> @@ -61,8 +61,9 @@ static void virtio_crypto_akcipher_finalize_req( >> vc_akcipher_req->src_buf = NULL; >> vc_akciph

[virtio-dev] [PATCH virtio-1.3] update acknowledgements for 1.3

2023-08-15 Thread Cornelia Huck
Move some names to the section for previous versions, add names of new contributors, etc. Signed-off-by: Cornelia Huck --- acknowledgements.tex | 124 ++- 1 file changed, 75 insertions(+), 49 deletions(-) diff --git a/acknowledgements.tex b

Re: [PATCH for-8.2] hw/s390x/s390-virtio-ccw: Remove superfluous code to set the NIC model

2023-08-04 Thread Cornelia Huck
odel() - and this in turn calls qemu_find_nic_model() > which contains the same check for nd->model being NULL again. So we > can remove this from the calling site now. > > Signed-off-by: Thomas Huth > --- > hw/s390x/s390-virtio-ccw.c | 4 > 1 file changed, 4 deletions(-) Reviewed-by: Cornelia Huck

[virtio-dev] [virtio 1.3] Change freeze has started

2023-08-02 Thread Cornelia Huck
As outlined in https://lists.oasis-open.org/archives/virtio/202304/msg00036.html ff., as part of the release process for the 1.3 version of the virtio spec, we have now entered change freeze. This means that the only changes to the main virtio branch will now be those needed for the 1.3 release (ad

Re: [PATCH for-8.2 2/2] arm/kvm: convert to kvm_get_one_reg

2023-07-27 Thread Cornelia Huck
On Tue, Jul 25 2023, Gavin Shan wrote: > On 7/24/23 18:48, Cornelia Huck wrote: >> On Mon, Jul 24 2023, Gavin Shan wrote: >>> >>> On 7/18/23 21:14, Cornelia Huck wrote: >>>> We can neaten the code by switching the callers that work on a >&g

Re: [PATCH for-8.2 2/2] arm/kvm: convert to kvm_get_one_reg

2023-07-24 Thread Cornelia Huck
On Mon, Jul 24 2023, Gavin Shan wrote: > Hi Connie, > > On 7/18/23 21:14, Cornelia Huck wrote: >> We can neaten the code by switching the callers that work on a >> CPUstate to the kvm_get_one_reg function. >> >> Signed-off-by: Cornelia Huck &g

Re: [PATCH for-8.2 1/2] arm/kvm: convert to kvm_set_one_reg

2023-07-24 Thread Cornelia Huck
On Mon, Jul 24 2023, Gavin Shan wrote: > Hi Connie, > > On 7/18/23 21:14, Cornelia Huck wrote: >> We can neaten the code by switching to the kvm_set_one_reg function. >> >> Signed-off-by: Cornelia Huck >> --- >> target/arm/kvm.c | 13

Re: [virtio-dev] [virtio 1.3] Feature freeze has started

2023-07-21 Thread Cornelia Huck
On Mon, Jul 03 2023, Cornelia Huck wrote: > As outlined in > https://lists.oasis-open.org/archives/virtio/202304/msg00036.html ff., > as part of the release process for the 1.3 version of the virtio spec, > we have now entered feature freeze. This means: > > *** > By July

[virtio-dev] Re: 1.3 and branching

2023-07-21 Thread Cornelia Huck
On Fri, Jul 21 2023, "Michael S. Tsirkin" wrote: > On Fri, Jul 21, 2023 at 02:24:57PM +0200, Cornelia Huck wrote: >> On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: >> >> > On Wed, Jul 12, 2023 at 02:24:32PM +0200, Cornelia Huck wrote: >> &

[virtio-dev] 1.3 and branching (was: [virtio-dev] Re: [PATCH v12] virtio-net: support device stats)

2023-07-21 Thread Cornelia Huck
On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: > On Wed, Jul 12, 2023 at 02:24:32PM +0200, Cornelia Huck wrote: >> On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: >> > Yes we were supposed to freeze for 1.3. This change can be merged on a >> >

[PATCH] hw: Add compat machines for 8.2

2023-07-18 Thread Cornelia Huck
Add 8.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 16 +--- hw/i386/pc_q35.c | 14

[PATCH for-8.2 1/2] arm/kvm: convert to kvm_set_one_reg

2023-07-18 Thread Cornelia Huck
We can neaten the code by switching to the kvm_set_one_reg function. Signed-off-by: Cornelia Huck --- target/arm/kvm.c | 13 +++-- target/arm/kvm64.c | 66 +- 2 files changed, 21 insertions(+), 58 deletions(-) diff --git a/target/arm/kvm.c b

[PATCH for-8.2 2/2] arm/kvm: convert to kvm_get_one_reg

2023-07-18 Thread Cornelia Huck
We can neaten the code by switching the callers that work on a CPUstate to the kvm_get_one_reg function. Signed-off-by: Cornelia Huck --- target/arm/kvm.c | 15 +++- target/arm/kvm64.c | 57 -- 2 files changed, 18 insertions(+), 54 deletions

[PATCH for-8.2 0/2] arm/kvm: use kvm_{get,set}_one_reg

2023-07-18 Thread Cornelia Huck
conversions in the target/arm code. target/mips and target/ppc also have some potential for conversions, but as I cannot test either (and they are both in 'Odd fixes' anyway), I left them alone. Survives some testing on a Mt. Snow. Cornelia Huck (2): arm/kvm: convert to kvm_set_one_reg

Re: [PATCH 3/3] hw/arm/virt: Support host CPU type only when KVM or HVF is configured

2023-07-13 Thread Cornelia Huck
On Thu, Jul 13 2023, Gavin Shan wrote: > The CPU type 'host-arm-cpu' class won't be registered until KVM or > HVF is configured in target/arm/cpu64.c. Support the corresponding > CPU type only when KVM or HVF is configured. > > Signed-off-by: Gavin Shan > --- > hw/arm/virt.c | 2 ++ > 1 file ch

  1   2   3   4   5   6   7   8   9   10   >