[Lldb-commits] [lldb] r335079 - Correct the pathname that PlatformDarwinKernel::ExamineKextForMatchingUUID

Author: jmolenda Date: Tue Jun 19 14:39:10 2018 New Revision: 335079 URL: http://llvm.org/viewvc/llvm-project?rev=335079=rev Log: Correct the pathname that PlatformDarwinKernel::ExamineKextForMatchingUUID passes to the recursive search function so we only recursively search the kext bundle

[Lldb-commits] [lldb] r334995 - Some NFC changes to how we scan of kexts & kernels in memory in the

Author: jmolenda Date: Mon Jun 18 16:30:03 2018 New Revision: 334995 URL: http://llvm.org/viewvc/llvm-project?rev=334995=rev Log: Some NFC changes to how we scan of kexts & kernels in memory in the DynamicLoaderDarwinKernel plugin. Created a new function ReadMachHeader and instead of reading

[Lldb-commits] [lldb] r334873 - Sort the files in the PBXBuildFile and PBXFileReference sections

Author: jmolenda Date: Fri Jun 15 16:32:37 2018 New Revision: 334873 URL: http://llvm.org/viewvc/llvm-project?rev=334873=rev Log: Sort the files in the PBXBuildFile and PBXFileReference sections of debugserver's xcode project file to reduce automerger issues with the github swift repository of

[Lldb-commits] [lldb] r334872 - Sort the files in the PBXBuildFile and PBXFileReference

Author: jmolenda Date: Fri Jun 15 16:29:32 2018 New Revision: 334872 URL: http://llvm.org/viewvc/llvm-project?rev=334872=rev Log: Sort the files in the PBXBuildFile and PBXFileReference sections of lldb's xcode project file to reduce automerger issues with the github swift repository of lldb

[Lldb-commits] [lldb] r334783 - Change TestExec.py from creating an i386+x86_64 fat binary

Author: jmolenda Date: Thu Jun 14 17:55:53 2018 New Revision: 334783 URL: http://llvm.org/viewvc/llvm-project?rev=334783=rev Log: Change TestExec.py from creating an i386+x86_64 fat binary on darwin systems and re-execing itself, to creating two separate test programs; lldb runs the first program

[Lldb-commits] [lldb] r334680 - fix cmake include path.

Author: jmolenda Date: Wed Jun 13 18:29:18 2018 New Revision: 334680 URL: http://llvm.org/viewvc/llvm-project?rev=334680=rev Log: fix cmake include path. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/objcxx/CMakeLists.txt Modified:

[Lldb-commits] [lldb] r334667 - Move the header file to be in the same new place as the .mm file.

Author: jmolenda Date: Wed Jun 13 15:37:01 2018 New Revision: 334667 URL: http://llvm.org/viewvc/llvm-project?rev=334667=rev Log: Move the header file to be in the same new place as the .mm file. Added:

[Lldb-commits] [lldb] r334666 - Fix group entry.

Author: jmolenda Date: Wed Jun 13 15:33:27 2018 New Revision: 334666 URL: http://llvm.org/viewvc/llvm-project?rev=334666=rev Log: Fix group entry. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r334662 - Fix macos xcode build.

Author: jmolenda Date: Wed Jun 13 15:05:38 2018 New Revision: 334662 URL: http://llvm.org/viewvc/llvm-project?rev=334662=rev Log: Fix macos xcode build. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj lldb/trunk/source/Host/macosx/objcxx/Host.mm Modified:

[Lldb-commits] [lldb] r334442 - Document how lldb uses the DBGSourcePathRemapping

Author: jmolenda Date: Mon Jun 11 14:36:40 2018 New Revision: 334442 URL: http://llvm.org/viewvc/llvm-project?rev=334442=rev Log: Document how lldb uses the DBGSourcePathRemapping source path remapping src/dest path pairs with respect to the DBGVersion number in the plist. Modified:

[Lldb-commits] [lldb] r334441 - Add DebugNamesDWARFIndex.cpp.

Author: jmolenda Date: Mon Jun 11 14:35:36 2018 New Revision: 334441 URL: http://llvm.org/viewvc/llvm-project?rev=334441=rev Log: Add DebugNamesDWARFIndex.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r333690 - Set m_struct_valid to initial value in ctor.

Author: jmolenda Date: Thu May 31 13:01:15 2018 New Revision: 333690 URL: http://llvm.org/viewvc/llvm-project?rev=333690=rev Log: Set m_struct_valid to initial value in ctor. Patch from Tom Tromey . Differential Revision: https://reviews.llvm.org/D47481 Modified:

[Lldb-commits] [lldb] r331497 - The on-ios-device command line lldb has an optimization where

Author: jmolenda Date: Thu May 3 17:59:37 2018 New Revision: 331497 URL: http://llvm.org/viewvc/llvm-project?rev=331497=rev Log: The on-ios-device command line lldb has an optimization where when it and the inferior process both have the same shared cache (a conglomeration of all libraries at

Re: [Lldb-commits] [lldb] r331415 - [NSDictionary] Simplify the formatter. NFCI.

> On May 2, 2018, at 4:58 PM, Davide Italiano <dccitali...@gmail.com> wrote: > > On Wed, May 2, 2018 at 4:56 PM, Davide Italiano <dccitali...@gmail.com> wrote: >> On Wed, May 2, 2018 at 4:51 PM, Jason Molenda via lldb-commits >> <lldb-commits@lists.llvm.or

Re: [Lldb-commits] [lldb] r331415 - [NSDictionary] Simplify the formatter. NFCI.

Is this really simpler? We could write it if (name == g_zero) return 0; else return UINT32_MAX; or we could do it that way, or it could be done the way it was originally written. tbh it seems like a style choice, and whoever wrote it originally may have preferred it being expressed that

[Lldb-commits] [lldb] r331315 - Fix the .experimental. settings feature so that we don't return an error

Author: jmolenda Date: Tue May 1 15:49:01 2018 New Revision: 331315 URL: http://llvm.org/viewvc/llvm-project?rev=331315=rev Log: Fix the .experimental. settings feature so that we don't return an error if an experimental setting has been removed/is missing. Add tests for the .experimental.

[Lldb-commits] [lldb] r331239 - Log to the process channel, not target twice.

Author: jmolenda Date: Mon Apr 30 17:42:17 2018 New Revision: 331239 URL: http://llvm.org/viewvc/llvm-project?rev=331239=rev Log: Log to the process channel, not target twice. Modified: lldb/trunk/source/Utility/ArchSpec.cpp Modified: lldb/trunk/source/Utility/ArchSpec.cpp URL:

Re: [Lldb-commits] [lldb] r331236 - Add logging when ArchSpec::SetArchitecture is given a cputype and

> On Apr 30, 2018, at 5:23 PM, Davide Italiano <dccitali...@gmail.com> wrote: > > On Mon, Apr 30, 2018 at 5:05 PM, Jason Molenda via lldb-commits > <lldb-commits@lists.llvm.org> wrote: >> >> fAnyCategoriesSet(LIBLLDB_LOG_TARGET | LIBLLDB_LOG_TARGET | >

[Lldb-commits] [lldb] r331236 - Add logging when ArchSpec::SetArchitecture is given a cputype and

Author: jmolenda Date: Mon Apr 30 17:05:54 2018 New Revision: 331236 URL: http://llvm.org/viewvc/llvm-project?rev=331236=rev Log: Add logging when ArchSpec::SetArchitecture is given a cputype and cpusubtype that don't map to any known core definition. Modified:

Re: [Lldb-commits] [PATCH] D45348: Don't return error for settings set .experimental. settings that are absent

> On Apr 6, 2018, at 2:07 AM, Pavel Labath via Phabricator > wrote: > > labath added inline comments. > > > > Comment at: packages/Python/lldbsuite/test/settings/TestSettings.py:544-545 > +# the actual name and via .experimental. > +

[Lldb-commits] [lldb] r328591 - Add the same new entitlement from r326399 to

Author: jmolenda Date: Mon Mar 26 16:13:17 2018 New Revision: 328591 URL: http://llvm.org/viewvc/llvm-project?rev=328591=rev Log: Add the same new entitlement from r326399 to the macos entitlement list. Modified: lldb/trunk/tools/debugserver/source/debugserver-macosx-entitlements.plist

[Lldb-commits] [lldb] r328383 - Remove CommandObjectStats.cpp & CleanUpTest.cpp from

Author: jmolenda Date: Fri Mar 23 16:32:16 2018 New Revision: 328383 URL: http://llvm.org/viewvc/llvm-project?rev=328383=rev Log: Remove CommandObjectStats.cpp & CleanUpTest.cpp from installing in the man page directory. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r328382 - Put CommandObjectStats.cpp in lldb-core target, remove CommandObjectStats.h from targets.

Author: jmolenda Date: Fri Mar 23 15:50:23 2018 New Revision: 328382 URL: http://llvm.org/viewvc/llvm-project?rev=328382=rev Log: Put CommandObjectStats.cpp in lldb-core target, remove CommandObjectStats.h from targets. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r328374 - Change the darwin-debug target to build the standard

Author: jmolenda Date: Fri Mar 23 14:37:19 2018 New Revision: 328374 URL: http://llvm.org/viewvc/llvm-project?rev=328374=rev Log: Change the darwin-debug target to build the standard archs. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r327922 - Rename remotectl_com.apple.internal.xpc.remote.debugserver.plist

Author: jmolenda Date: Mon Mar 19 16:07:31 2018 New Revision: 327922 URL: http://llvm.org/viewvc/llvm-project?rev=327922=rev Log: Rename remotectl_com.apple.internal.xpc.remote.debugserver.plist to com.apple.internal.xpc.remote.debugserver.plist, not sure where that remotectl_ prefix came from.

[Lldb-commits] [lldb] r327918 - I didn't see that SocketAddress.cpp was already being pulled

Author: jmolenda Date: Mon Mar 19 15:55:19 2018 New Revision: 327918 URL: http://llvm.org/viewvc/llvm-project?rev=327918=rev Log: I didn't see that SocketAddress.cpp was already being pulled in to debugserver; my re-addition resulted in duplicated symbols. Remove my added SocketAddress.cpp, and

[Lldb-commits] [lldb] r327915 - Add the ios-mini target to the top-level xcodeproj, which builds

Author: jmolenda Date: Mon Mar 19 15:04:45 2018 New Revision: 327915 URL: http://llvm.org/viewvc/llvm-project?rev=327915=rev Log: Add the ios-mini target to the top-level xcodeproj, which builds the debugserver-mini target in debugserver. Add a new plist which needs to be installed for

[Lldb-commits] [lldb] r327913 - Add DWARFUnit.cpp to the correct target.

Author: jmolenda Date: Mon Mar 19 14:55:48 2018 New Revision: 327913 URL: http://llvm.org/viewvc/llvm-project?rev=327913=rev Log: Add DWARFUnit.cpp to the correct target. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

> On Mar 13, 2018, at 11:51 AM, Davide Italiano via lldb-commits > wrote: > > We had the report of a crash where lldb was setting a conditional > breakpoint on an invalid condition (CGRect == pointer, which is, > ill-formed). > The symbol-based resolution of lldb

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

> On Mar 12, 2018, at 7:52 PM, Davide Italiano via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > On Mon, Mar 12, 2018 at 7:27 PM, Jason Molenda via lldb-commits > <lldb-commits@lists.llvm.org> wrote: >> FWIW, we'll definitely get pushback about

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

FWIW, we'll definitely get pushback about > Now you can't do in lldb anymore > (lldb) call _Zsomethingsomething(1,2,3) There are clever users of lldb, often working at assembly language level without any symbolic information, who are able to correctly call a C++ mangled function by hand.

[Lldb-commits] [lldb] r327097 - I added CFLAGS etc to one part of the project file I should not have.

Author: jmolenda Date: Thu Mar 8 17:43:18 2018 New Revision: 327097 URL: http://llvm.org/viewvc/llvm-project?rev=327097=rev Log: I added CFLAGS etc to one part of the project file I should not have. Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r327095 - More cleanups of debugserver project file and the libpmenergy/libpmsample

Author: jmolenda Date: Thu Mar 8 17:37:37 2018 New Revision: 327095 URL: http://llvm.org/viewvc/llvm-project?rev=327095=rev Log: More cleanups of debugserver project file and the libpmenergy/libpmsample stuff. Activate it when an internal SDK is selected. Update the name of the LDFLAGS to

[Lldb-commits] [lldb] r327088 - Remove unneeded per-arch sdk specifications from debugserver xcode project file.

Author: jmolenda Date: Thu Mar 8 16:32:56 2018 New Revision: 327088 URL: http://llvm.org/viewvc/llvm-project?rev=327088=rev Log: Remove unneeded per-arch sdk specifications from debugserver xcode project file. Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r327087 - Remove the explicit dependency on libpmenergy and libpmsample.

Author: jmolenda Date: Thu Mar 8 16:28:51 2018 New Revision: 327087 URL: http://llvm.org/viewvc/llvm-project?rev=327087=rev Log: Remove the explicit dependency on libpmenergy and libpmsample. Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r327085 - Fixed two more sdk inconsistencies with the pmenergy stuff.

Author: jmolenda Date: Thu Mar 8 16:23:29 2018 New Revision: 327085 URL: http://llvm.org/viewvc/llvm-project?rev=327085=rev Log: Fixed two more sdk inconsistencies with the pmenergy stuff. Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r327084 - Three little cleanups in the debugserver xcode project file.

Author: jmolenda Date: Thu Mar 8 16:17:22 2018 New Revision: 327084 URL: http://llvm.org/viewvc/llvm-project?rev=327084=rev Log: Three little cleanups in the debugserver xcode project file. 1. Link against libpmenergy and pmsample unconditionally. It is available on macOS 10.10 ("Yosemite")

[Lldb-commits] [lldb] r326849 - the thread id is easier to read in base16.

Author: jmolenda Date: Tue Mar 6 15:33:02 2018 New Revision: 326849 URL: http://llvm.org/viewvc/llvm-project?rev=326849=rev Log: the thread id is easier to read in base16. Modified: lldb/trunk/tools/darwin-threads/examine-threads.c Modified:

[Lldb-commits] [lldb] r326756 - Upstreaming avx512 register support in debugserver. These changes

Author: jmolenda Date: Mon Mar 5 16:27:41 2018 New Revision: 326756 URL: http://llvm.org/viewvc/llvm-project?rev=326756=rev Log: Upstreaming avx512 register support in debugserver. These changes were originally written by Chris Bieneman, they've undergone a number of changes since then. Also

[Lldb-commits] [lldb] r326399 - Add another entitlement that we need for debugserver.

Author: jmolenda Date: Wed Feb 28 17:04:07 2018 New Revision: 326399 URL: http://llvm.org/viewvc/llvm-project?rev=326399=rev Log: Add another entitlement that we need for debugserver. Modified: lldb/trunk/tools/debugserver/source/debugserver-entitlements.plist Modified:

[Lldb-commits] [lldb] r326302 - Add EmulateInstructionPPC64.cpp to xcode project file.

Author: jmolenda Date: Tue Feb 27 20:11:37 2018 New Revision: 326302 URL: http://llvm.org/viewvc/llvm-project?rev=326302=rev Log: Add EmulateInstructionPPC64.cpp to xcode project file. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

Re: [Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

Ah, no. Pavel suggested that the unwind plan unittests should be turned into FileCheck tests, and then Davide suggested that he'd heard unwind testing is difficult (he was conflating the unwind sources -> UnwindPlan IR conversions and the runtime use of UnwindPlans to walk the stack & find

Re: [Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

> On Feb 12, 2018, at 12:59 PM, Zachary Turner wrote: > > > > On Mon, Feb 12, 2018 at 12:52 PM Jason Molenda wrote: >> >> >> > On Feb 12, 2018, at 12:48 PM, Zachary Turner via Phabricator >> > wrote: >> > >> > zturner

Re: [Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

> On Feb 12, 2018, at 12:48 PM, Zachary Turner via Phabricator > wrote: > > zturner added a comment. > > In https://reviews.llvm.org/D43048#1005513, @jasonmolenda wrote: > >> No, the unwind unittests that exist today should stay written as unit tests. >> These

[Lldb-commits] [lldb] r324795 - Looks like this fails when built i386 on linux bots, possible target

Author: jmolenda Date: Fri Feb 9 17:57:33 2018 New Revision: 324795 URL: http://llvm.org/viewvc/llvm-project?rev=324795=rev Log: Looks like this fails when built i386 on linux bots, possible target arch incompat with spec in file so it's rejected and the test fails. will look into this later,

[Lldb-commits] [lldb] r324792 - Add test case for x86_64 architecture recognition in the

Author: jmolenda Date: Fri Feb 9 17:13:34 2018 New Revision: 324792 URL: http://llvm.org/viewvc/llvm-project?rev=324792=rev Log: Add test case for x86_64 architecture recognition in the target.xml packet if it is included. Added:

[Lldb-commits] [lldb] r324437 - lldb running on an ios device is using the _dyld_get_all_image_infos()

Author: jmolenda Date: Tue Feb 6 17:28:29 2018 New Revision: 324437 URL: http://llvm.org/viewvc/llvm-project?rev=324437=rev Log: lldb running on an ios device is using the _dyld_get_all_image_infos() SPI call to to find its own shared cache's UUID. On newer sytems we need to use the a new SPI

Re: [Lldb-commits] [lldb] r322339 - When parsing the target.xml register file, if no architecture has

Davide Italiano <dccitali...@gmail.com> >>>>> wrote: >>>>> >>>>> On Thu, Jan 11, 2018 at 5:26 PM, Davide Italiano <dccitali...@gmail.com> >>>>> wrote: >>>>>> On Thu, Jan 11, 2018 at 5:16 PM, Jason Mol

[Lldb-commits] [lldb] r324287 - Fix the cputype comparison in GDBRemoteCommunicationServerCommon::Handle_qHostInfo

Author: jmolenda Date: Mon Feb 5 15:10:51 2018 New Revision: 324287 URL: http://llvm.org/viewvc/llvm-project?rev=324287=rev Log: Fix the cputype comparison in GDBRemoteCommunicationServerCommon::Handle_qHostInfo to use Mach-O cpu types instead of the ArchSpec enum value, and handle the case of

Re: [Lldb-commits] [PATCH] D42210: Re-enable logging on the child side of a fork() in lldb-server platform mode

Yeah I saw the TCPSocket::Accept differences on top of tree after sending the email - unfortunately I have to do my work on this old branch, and I can't build our top of tree sources for the iphone target right now. It's not a great situation! The min/max ports are needed for running the

Re: [Lldb-commits] [PATCH] D42210: Re-enable logging on the child side of a fork() in lldb-server platform mode

Hi Pavel, I closed this phabracator, I've been working on this on-and-off and I think a different approach would be better. I am working up a patch where I change tools/lldb-server/lldb-platform.cpp from using a fork() model to using std::thread's. The main thread listens for incoming

[Lldb-commits] [lldb] r324158 - Turn off the deprecated ALWAYS_SEARCH_USER_PATHS feature

Author: jmolenda Date: Fri Feb 2 16:37:46 2018 New Revision: 324158 URL: http://llvm.org/viewvc/llvm-project?rev=324158=rev Log: Turn off the deprecated ALWAYS_SEARCH_USER_PATHS feature in debugserver. This is already set this way in the lldb project files but not in debugserver. Updating for

[Lldb-commits] [lldb] r324156 - Fix a copy of a fixed length, possibly non-nul terminated, string

Author: jmolenda Date: Fri Feb 2 14:48:45 2018 New Revision: 324156 URL: http://llvm.org/viewvc/llvm-project?rev=324156=rev Log: Fix a copy of a fixed length, possibly non-nul terminated, string into a std::string so we don't run off the end of the array when there is no nul byte in

Re: [Lldb-commits] [lldb] r322339 - When parsing the target.xml register file, if no architecture has

> On Jan 28, 2018, at 9:59 PM, Davide Italiano <dccitali...@gmail.com> wrote: > > On Thu, Jan 11, 2018 at 5:26 PM, Davide Italiano <dccitali...@gmail.com> > wrote: >> On Thu, Jan 11, 2018 at 5:16 PM, Jason Molenda via lldb-commits >> <lldb-commits@list

[Lldb-commits] [lldb] r322418 - We have two sources for path remapping information that we get out

Author: jmolenda Date: Fri Jan 12 14:42:45 2018 New Revision: 322418 URL: http://llvm.org/viewvc/llvm-project?rev=322418=rev Log: We have two sources for path remapping information that we get out of a dSYM per-uuid plist that may be present (dsymutil does not create this plist, it is only added

[Lldb-commits] [lldb] r322339 - When parsing the target.xml register file, if no architecture has

Author: jmolenda Date: Thu Jan 11 17:16:13 2018 New Revision: 322339 URL: http://llvm.org/viewvc/llvm-project?rev=322339=rev Log: When parsing the target.xml register file, if no architecture has been specified yet (either by the user, or by one of the lldb extensions like qHostInfo or

[Lldb-commits] [lldb] r322237 - Remove Environment.h, test-dwarf.cpp, test-dwarf.exe

Author: jmolenda Date: Wed Jan 10 15:11:29 2018 New Revision: 322237 URL: http://llvm.org/viewvc/llvm-project?rev=322237=rev Log: Remove Environment.h, test-dwarf.cpp, test-dwarf.exe from being listed as a part of the desktop or desktop/desktop_no_xpc Targets - they should not be a part of any

[Lldb-commits] [lldb] r322128 - This change updates the deployment target for lldb and debugserver

Author: jmolenda Date: Tue Jan 9 14:17:10 2018 New Revision: 322128 URL: http://llvm.org/viewvc/llvm-project?rev=322128=rev Log: This change updates the deployment target for lldb and debugserver (built with Xcode) from 10.9 to 10.11. It also enables the use of libcompression in debugserver by

Re: [Lldb-commits] [PATCH] D41584: Check existence of each required component during construction of LLVMCDisassembler.

> On Jan 9, 2018, at 6:24 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > In https://reviews.llvm.org/D41584#970945, @tatyana-krasnukha wrote: > >> Thank you, Pavel. >> Would you mind if I move LLVMCDisassembler declaration in .cpp also?

Re: [Lldb-commits] [PATCH] D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

> On Jan 9, 2018, at 6:51 AM, Michał Górny via Phabricator via lldb-commits > wrote: > > mgorny added a comment. > > In https://reviews.llvm.org/D41725#970926, @labath wrote: > >> In https://reviews.llvm.org/D41725#969388, @mgorny wrote: >> >>> I was talking

[Lldb-commits] [lldb] r321338 - Change SBProcess::ReadCStringFromMemory() back to returning

Author: jmolenda Date: Thu Dec 21 19:27:02 2017 New Revision: 321338 URL: http://llvm.org/viewvc/llvm-project?rev=321338=rev Log: Change SBProcess::ReadCStringFromMemory() back to returning an empty Python string object when it reads a 0-length string out of memory (and a successful SBError

[Lldb-commits] [lldb] r321328 - Change the default Aarch64 ISA to be v8.2 to correctly decode newer

Author: jmolenda Date: Thu Dec 21 16:16:04 2017 New Revision: 321328 URL: http://llvm.org/viewvc/llvm-project?rev=321328=rev Log: Change the default Aarch64 ISA to be v8.2 to correctly decode newer instructions (e.g. on the new iphones). Modified:

Re: [Lldb-commits] [lldb] r320240 - Update PlatformDarwin::GetDeveloperDir to handle the two

.llvm.org> wrote: > > Jason, any chance we can write a test case for this? > > -- > Davide > >> On Mon, Dec 11, 2017 at 12:52 AM, Davide Italiano <dccitali...@gmail.com> >> wrote: >> Testcase? >> >> On Fri, Dec 8, 2017 at 7:06 PM, Jas

[Lldb-commits] [lldb] r321051 - Tweak to the debugserver entitlements setup in the xcode project

Author: jmolenda Date: Mon Dec 18 17:41:47 2017 New Revision: 321051 URL: http://llvm.org/viewvc/llvm-project?rev=321051=rev Log: Tweak to the debugserver entitlements setup in the xcode project file. For macos builds specifically, use the macosx entitlements files; for all other builds, use the

Re: [Lldb-commits] [lldb] r320242 - Change uses of strncpy in debugserver to strlcpy

tability? > > On Sun, Dec 10, 2017 at 3:52 PM, Davide Italiano via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > On Fri, Dec 8, 2017 at 7:37 PM, Jason Molenda via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > Author: jmolenda > > Date: Fri Dec

[Lldb-commits] [lldb] r320242 - Change uses of strncpy in debugserver to strlcpy

Author: jmolenda Date: Fri Dec 8 19:37:09 2017 New Revision: 320242 URL: http://llvm.org/viewvc/llvm-project?rev=320242=rev Log: Change uses of strncpy in debugserver to strlcpy for better safety. Modified: lldb/trunk/tools/debugserver/source/DNB.cpp

[Lldb-commits] [lldb] r320241 - Change the ordering that we search for kexts and kernels on the local

Author: jmolenda Date: Fri Dec 8 19:28:15 2017 New Revision: 320241 URL: http://llvm.org/viewvc/llvm-project?rev=320241=rev Log: Change the ordering that we search for kexts and kernels on the local computer. When doing kernel debugging, lldb scrapes around a few well-known locations to find

Re: [Lldb-commits] [lldb] r319653 - Makefile.rules: compile all tests with -fno-limit-debug-info

It looks like the macos testsuite on the bot is broken with this - http://lab.llvm.org:8080/green/view/LLDB/job/lldb/3086/ On my desktop with a recent clang, it works fine. But it seems like every test? most tests? are failing with error: parsing line table prologue at 0x (parsing

[Lldb-commits] [lldb] r319500 - We had a situation where a kext was inlined into the kernel,

Author: jmolenda Date: Thu Nov 30 15:31:18 2017 New Revision: 319500 URL: http://llvm.org/viewvc/llvm-project?rev=319500=rev Log: We had a situation where a kext was inlined into the kernel, but still listed in the kernel's kext table with the kernel binary UUID. This resulted in the kernel text

Re: [Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

> On Nov 29, 2017, at 2:51 PM, Zachary Turner via lldb-commits > wrote: > > > > On Wed, Nov 29, 2017 at 1:59 PM Jim Ingham wrote: > I'm mostly basing this concern on the bad effect this had on gdb all of whose > testing was expect based

Re: [Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

> On Nov 29, 2017, at 2:13 PM, Greg Clayton <clayb...@gmail.com> wrote: > > >> On Nov 29, 2017, at 2:10 PM, Jason Molenda via lldb-commits >> <lldb-commits@lists.llvm.org> wrote: >> >> The last time this discussion came up (Sep 2016), I poi

Re: [Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

The last time this discussion came up (Sep 2016), I pointed out that a great approach here would be to use the lldb-mi driver. The MI (Machine Interface) is a JSON-like debugger UI which closely models how people use the lldb command line driver. It was written at Cygnus (long before JSON,

[Lldb-commits] [lldb] r318500 - Update xcode project file to build new ppc64le files.

Author: jmolenda Date: Thu Nov 16 17:55:50 2017 New Revision: 318500 URL: http://llvm.org/viewvc/llvm-project?rev=318500=rev Log: Update xcode project file to build new ppc64le files. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

Re: [Lldb-commits] Need to change swig typemap for reading C strings

Yeah, I'm going to check in one based on my little example program. The only tricky bit is > > const char *invalid_memory_string = (char*)0x100; // lower 4k is always > > PAGEZERO & unreadable on darwin I'll need some address that is unmapped for other platforms. Maybe address -1 or

Re: [Lldb-commits] Need to change swig typemap for reading C strings

The general point you're making is reasonable, and something like Thread::GetStopDescription is not clear which the correct behavior should be. But I think we can all agree that Process::ReadCStringFromMemory() returning a None object when there is an empty c-string is incorrect. People are

[Lldb-commits] Need to change swig typemap for reading C strings

Hi Zachary, reviving a problem I initially found a year ago -- in r253487 where a swig typemap was changed for string reading methods. The problem we're seeing with this change is that SBProcess::ReadCStringFromMemory() now returns a None object when you try to read a zero-length string, and

[Lldb-commits] [lldb] r318357 - Fix alignment of arm64 fpu register context structure

Author: jmolenda Date: Wed Nov 15 16:50:29 2017 New Revision: 318357 URL: http://llvm.org/viewvc/llvm-project?rev=318357=rev Log: Fix alignment of arm64 fpu register context structure so it has the same padding as the kernel's definition which is written in terms of uint128_t. Original patch by

Re: [Lldb-commits] [lldb] r318262 - Roll back r318260 because it is causing the windows bot to

> On Nov 15, 2017, at 1:38 AM, Pavel Labath <lab...@google.com> wrote: > > On 15 November 2017 at 03:41, Jason Molenda via lldb-commits > <lldb-commits@lists.llvm.org> wrote: >> Author: jmolenda >> Date: Tue Nov 14 19:41:47 2017 >> New Revision: 3182

Re: [Lldb-commits] [lldb] r318262 - Roll back r318260 because it is causing the windows bot to

Hi Zachary, do you have a suggestion on how to specify this alignment in a way that works with MSVC? > On Nov 14, 2017, at 7:41 PM, Jason Molenda via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > Author: jmolenda > Date: Tue Nov 14 19:41:47 2017 > New Revisio

[Lldb-commits] [lldb] r318262 - Roll back r318260 because it is causing the windows bot to

Author: jmolenda Date: Tue Nov 14 19:41:47 2017 New Revision: 318262 URL: http://llvm.org/viewvc/llvm-project?rev=318262=rev Log: Roll back r318260 because it is causing the windows bot to break. The alignas(__uint128_t) is not recognized with MSVC it looks like. Zachary, is there a similar

[Lldb-commits] [lldb] r318260 - Two small fixes to handle arm64 fpu register contexts in

Author: jmolenda Date: Tue Nov 14 19:18:24 2017 New Revision: 318260 URL: http://llvm.org/viewvc/llvm-project?rev=318260=rev Log: Two small fixes to handle arm64 fpu register contexts in a Mach-O file load command correctly, patch by Ryan Mansfield. Modified:

[Lldb-commits] [lldb] r318218 - Update xcode project file to track ArchSpec.cpp

Author: jmolenda Date: Tue Nov 14 15:15:35 2017 New Revision: 318218 URL: http://llvm.org/viewvc/llvm-project?rev=318218=rev Log: Update xcode project file to track ArchSpec.cpp move and LibCxxBitset.cpp addition. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r317183 - Revert r317182 for https://reviews.llvm.org/D39128

Author: jmolenda Date: Wed Nov 1 20:17:07 2017 New Revision: 317183 URL: http://llvm.org/viewvc/llvm-project?rev=317183=rev Log: Revert r317182 for https://reviews.llvm.org/D39128 we're still failing on android. I'll ask Larry to ask Pavel for any tips he might be able to give. Modified:

[Lldb-commits] [lldb] r317182 - Commit Lawrence D'Anna's patch to change

Author: jmolenda Date: Wed Nov 1 19:43:27 2017 New Revision: 317182 URL: http://llvm.org/viewvc/llvm-project?rev=317182=rev Log: Commit Lawrence D'Anna's patch to change SetOututFileHandle to work with IOBase. I did make one change after checking with Larry -- I renamed SBDebugger::Flush to

[Lldb-commits] [lldb] r317181 - Ahhhh roll back that commit, I didn't see that Lawrence had filed

Author: jmolenda Date: Wed Nov 1 19:33:59 2017 New Revision: 317181 URL: http://llvm.org/viewvc/llvm-project?rev=317181=rev Log: A roll back that commit, I didn't see that Lawrence had filed a separate phabracator with the revised change. This was his first atttempt which broke on the bots

[Lldb-commits] [lldb] r317180 - Commit Lawrence D'Anna's patch to change

Author: jmolenda Date: Wed Nov 1 19:02:56 2017 New Revision: 317180 URL: http://llvm.org/viewvc/llvm-project?rev=317180=rev Log: Commit Lawrence D'Anna's patch to change SetOututFileHandle to work with IOBase. I did make one change after checking with Larry -- I renamed SBDebugger::Flush to

[Lldb-commits] [lldb] r317129 - add LibCxxTuple.cpp, LibCxxQueue.cpp to xcode project file.

Author: jmolenda Date: Wed Nov 1 14:55:35 2017 New Revision: 317129 URL: http://llvm.org/viewvc/llvm-project?rev=317129=rev Log: add LibCxxTuple.cpp, LibCxxQueue.cpp to xcode project file. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r317067 - Remove Sean Callanan from the CODE_OWNERS, he won't have time

Author: jmolenda Date: Tue Oct 31 18:38:42 2017 New Revision: 317067 URL: http://llvm.org/viewvc/llvm-project?rev=317067=rev Log: Remove Sean Callanan from the CODE_OWNERS, he won't have time to participate in lldb going forward. Jim Ingham is adopting the areas he was responsible for.

Re: [Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

haven't had a chance to look at the patch yet, but just to comment on one part from Zach: > On Oct 27, 2017, at 2:06 PM, Zachary Turner via Phabricator via lldb-commits > wrote: > > > > Comment at: source/Target/Platform.cpp:986-991 > +if

[Lldb-commits] [lldb] r316727 - Add Arm Architecture plugin to the xcode project file.

Author: jmolenda Date: Thu Oct 26 19:21:55 2017 New Revision: 316727 URL: http://llvm.org/viewvc/llvm-project?rev=316727=rev Log: Add Arm Architecture plugin to the xcode project file. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

Re: [Lldb-commits] [lldb] r316673 - Allow SysV-i386 ABI on everything other than Apple targets

> On Oct 26, 2017, at 3:21 PM, Jason Molenda wrote: > > > >> On Oct 26, 2017, at 3:12 PM, Davide Italiano wrote: >> >> On Thu, Oct 26, 2017 at 3:04 PM, Jason Molenda wrote: >>> >>> On Oct 26, 2017, at 10:24 AM, Davide

Re: [Lldb-commits] [lldb] r316673 - Allow SysV-i386 ABI on everything other than Apple targets

> On Oct 26, 2017, at 3:12 PM, Davide Italiano wrote: > > On Thu, Oct 26, 2017 at 3:04 PM, Jason Molenda wrote: >> >> >>> On Oct 26, 2017, at 10:24 AM, Davide Italiano via lldb-commits >>> wrote: >>> >>> On Thu, Oct

Re: [Lldb-commits] [lldb] r316673 - Allow SysV-i386 ABI on everything other than Apple targets

> On Oct 26, 2017, at 10:24 AM, Davide Italiano via lldb-commits > wrote: > > On Thu, Oct 26, 2017 at 10:04 AM, Stephane Sezer via lldb-commits > wrote: >> Author: sas >> Date: Thu Oct 26 10:04:20 2017 >> New Revision: 316673 >> >>

Re: [Lldb-commits] [lldb] r315967 - Reverting r315966 - it caused a build failure on an ubuntu x android bot.

Can anyone more familiar with the android SDK help out? Larry's patch in https://reviews.llvm.org/D38829 aadds this code to File.cpp: +File::File(void *cookie, + int (*readfn)(void *, char *, int), + int (*writefn)(void *, const char *, int), + int (*closefn)(void

[Lldb-commits] [lldb] r315135 - Remove the input file specification from the

Author: jmolenda Date: Fri Oct 6 17:13:10 2017 New Revision: 315135 URL: http://llvm.org/viewvc/llvm-project?rev=315135=rev Log: Remove the input file specification from the "Prepare Swig Bindings" shell script phase; it wasn't the actual input file and could lead to incorrect dependency

[Lldb-commits] [lldb] r315123 - Specify the input & output results of the "Prepare Swig Bindings"

Author: jmolenda Date: Fri Oct 6 15:43:42 2017 New Revision: 315123 URL: http://llvm.org/viewvc/llvm-project?rev=315123=rev Log: Specify the input & output results of the "Prepare Swig Bindings" shell script phase to aid build systems. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r314731 - Move install_name_tool to a separate make target.

Author: jmolenda Date: Mon Oct 2 15:11:22 2017 New Revision: 314731 URL: http://llvm.org/viewvc/llvm-project?rev=314731=rev Log: Move install_name_tool to a separate make target. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/Makefile Modified:

[Lldb-commits] [lldb] r314366 - Change build-llvm.py and build-lldb-llvm-clang's patching mechanisms to

Author: jmolenda Date: Wed Sep 27 16:44:54 2017 New Revision: 314366 URL: http://llvm.org/viewvc/llvm-project?rev=314366=rev Log: Change build-llvm.py and build-lldb-llvm-clang's patching mechanisms to assume git-style diffs. Committing for Francis Ricci. Differential Revision:

[Lldb-commits] [lldb] r314355 - Add support for running the lldb testsuite against an apple watch

Author: jmolenda Date: Wed Sep 27 15:12:54 2017 New Revision: 314355 URL: http://llvm.org/viewvc/llvm-project?rev=314355=rev Log: Add support for running the lldb testsuite against an apple watch running watchos. These tests cannot run on normal customer devices, but I hope to some day have a

[Lldb-commits] [lldb] r314343 - Update the Objective-C runtime interface code to handle objc objects

Author: jmolenda Date: Wed Sep 27 13:56:32 2017 New Revision: 314343 URL: http://llvm.org/viewvc/llvm-project?rev=314343=rev Log: Update the Objective-C runtime interface code to handle objc objects whose isa is an index instead of a pointer. Currently, this type of isa encoding is only used on

<    4   5   6   7   8   9   10   11   12   >