Re: [ovirt-users] Re: Any way to terminate stuck export task

2021-07-05 Thread Nir Soffer
On Mon, Jul 5, 2021 at 3:36 PM Gianluca Cecchi wrote: > > On Mon, Jul 5, 2021 at 2:13 PM Nir Soffer wrote: >> >> >> > >> > vdsm 14342 3270 0 11:17 ?00:00:03 /usr/bin/qemu-img convert >> > -p -t none -T none -f raw >> >

[ovirt-users] Re: Any way to terminate stuck export task

2021-07-05 Thread Nir Soffer
On Mon, Jul 5, 2021 at 4:06 PM Strahil Nikolov wrote: > > >Disks on the export domain are never used by a running VM so there is > no reason to > preallocate them. The system should always use sparse disks when > copying to export > domain. > > >When importing disks from export domain, the system

Re: [ovirt-users] Re: Any way to terminate stuck export task

2021-07-05 Thread Nir Soffer
On Mon, Jul 5, 2021 at 4:06 PM Strahil Nikolov wrote: > > >Disks on the export domain are never used by a running VM so there is > no reason to > preallocate them. The system should always use sparse disks when > copying to export > domain. > > >When importing disks from export domain, the system

[ovirt-users] Re: Any way to terminate stuck export task

2021-07-05 Thread Nir Soffer
On Mon, Jul 5, 2021 at 12:50 PM Gianluca Cecchi wrote: > > On Sun, Jul 4, 2021 at 1:01 PM Nir Soffer wrote: >> >> On Sun, Jul 4, 2021 at 11:30 AM Strahil Nikolov >> wrote: >> > >> > Isn't it better to strace it before killing qemu-img . >>

Re: [ovirt-users] Re: Any way to terminate stuck export task

2021-07-05 Thread Nir Soffer
On Mon, Jul 5, 2021 at 12:50 PM Gianluca Cecchi wrote: > > On Sun, Jul 4, 2021 at 1:01 PM Nir Soffer wrote: >> >> On Sun, Jul 4, 2021 at 11:30 AM Strahil Nikolov >> wrote: >> > >> > Isn't it better to strace it before killing qemu-img . >>

[ovirt-users] Re: Any way to terminate stuck export task

2021-07-04 Thread Nir Soffer
On Sun, Jul 4, 2021 at 11:30 AM Strahil Nikolov wrote: > > Isn't it better to strace it before killing qemu-img . It may be too late, but it may help to understand why this qemu-img run got stuck. > Best Regards, > Strahil Nikolov > > On Sun, Jul 4, 2021 at 0:15, Nir So

Re: [ovirt-users] Re: Any way to terminate stuck export task

2021-07-04 Thread Nir Soffer
On Sun, Jul 4, 2021 at 11:30 AM Strahil Nikolov wrote: > > Isn't it better to strace it before killing qemu-img . It may be too late, but it may help to understand why this qemu-img run got stuck. > Best Regards, > Strahil Nikolov > > On Sun, Jul 4, 2021 at 0:15, Nir So

[ovirt-users] Re: Any way to terminate stuck export task

2021-07-03 Thread Nir Soffer
On Sat, Jul 3, 2021 at 3:46 PM Gianluca Cecchi wrote: > > Hello, > in oVirt 4.3.10 an export job to export domain takes too long, probably due > to the NFS server slow. > How can I stop in a clean way the task? > I see the exported file remains always at 4,5Gb of size. > Command vmstat on host wi

Re: [ovirt-users] Any way to terminate stuck export task

2021-07-03 Thread Nir Soffer
On Sat, Jul 3, 2021 at 3:46 PM Gianluca Cecchi wrote: > > Hello, > in oVirt 4.3.10 an export job to export domain takes too long, probably due > to the NFS server slow. > How can I stop in a clean way the task? > I see the exported file remains always at 4,5Gb of size. > Command vmstat on host wi

Re: [PATCH v2] docs: document file-posix locking protocol

2021-07-03 Thread Nir Soffer
On Sat, Jul 3, 2021 at 4:51 PM Vladimir Sementsov-Ogievskiy wrote: > > Let's document how we use file locks in file-posix driver, to allow > external programs to "communicate" in this way with Qemu. This makes the locking implementation public, so qemu can never change it without breaking externa

Re: [PATCH v2] docs: document file-posix locking protocol

2021-07-03 Thread Nir Soffer
On Sat, Jul 3, 2021 at 4:51 PM Vladimir Sementsov-Ogievskiy wrote: > > Let's document how we use file locks in file-posix driver, to allow > external programs to "communicate" in this way with Qemu. This makes the locking implementation public, so qemu can never change it without breaking externa

Re: [Libguestfs] Commit "v2v: Remove -o rhv-upload -oa preallocated"

2021-07-03 Thread Nir Soffer
On Sat, Jul 3, 2021 at 4:53 PM Richard W.M. Jones wrote: > > On Sat, Jul 03, 2021 at 04:34:09PM +0300, Nir Soffer wrote: > > For some reason I did not see this change in the mailing list: > > https://github.com/libguestfs/virt-v2v/commit/18084f90d9dd9092831cb3487039328981796291

[Libguestfs] Commit "v2v: Remove -o rhv-upload -oa preallocated"

2021-07-03 Thread Nir Soffer
For some reason I did not see this change in the mailing list: https://github.com/libguestfs/virt-v2v/commit/18084f90d9dd9092831cb3487039328981796291 The commit message claims: > Using -oa preallocated with -o rhv-upload always gave an error. We > should be able to implement this properly in mod

[ovirt-users] Re: Strange Issue with imageio

2021-07-01 Thread Nir Soffer
On Thu, Jul 1, 2021 at 11:15 AM Gianluca Cecchi wrote: > > On Thu, May 27, 2021 at 7:43 AM Eyal Shenitzky wrote: >> >> This bug is targeted to be fixed in 4.4.7 so 4.4.6 doesn't contain the fix. >> > > But is there a workaround for this? > On a single host environment with external engine and loc

[ovirt-users] Re: upgrading to 4.4.6 with Rocky Linux 8

2021-07-01 Thread Nir Soffer
On Wed, Jun 30, 2021 at 5:45 PM Jason Keltz wrote: > > Hi.. > > I'm looking to migrate soon from CentOS 7.9 with oVirt 4.3.10 to Rocky > Linux 8.4 with oVirt 4.4.6. I'm working on my kickstart of my > standalone engine in a VM at the moment. > > So far, with minimal experience with Rocky Linux, a

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-29 Thread Nir Soffer
On Tue, Jun 29, 2021 at 5:40 PM Kevin Wolf wrote: > > Am 29.06.2021 um 09:23 hat Vladimir Sementsov-Ogievskiy geschrieben: > > 28.06.2021 20:42, Eric Blake wrote: > > > On Wed, Jun 23, 2021 at 06:04:19PM +0200, Kevin Wolf wrote: > > > > > This is fine, but it means that this flag will present in a

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-29 Thread Nir Soffer
On Tue, Jun 29, 2021 at 5:40 PM Kevin Wolf wrote: > > Am 29.06.2021 um 09:23 hat Vladimir Sementsov-Ogievskiy geschrieben: > > 28.06.2021 20:42, Eric Blake wrote: > > > On Wed, Jun 23, 2021 at 06:04:19PM +0200, Kevin Wolf wrote: > > > > > This is fine, but it means that this flag will present in a

[ovirt-devel] Re: cloning LVM partitions

2021-06-29 Thread Nir Soffer
On Tue, Jun 29, 2021 at 9:09 AM Laurent Duparchy wrote: ... > This is valuable information. I didn't read it anywhere so far. > We'll have to evaluate what impact this way of snapshoting has on > performances. Sure, keeping many snapshots is not recommended. You should not treat snapshots as lon

[ovirt-devel] Re: cloning LVM partitions

2021-06-28 Thread Nir Soffer
le if your storage supports thin provisioning. But note that backup in storage level can create inconsistent backup, so starting a VM after restore may require running fsck. Using snapshots or incremental backup should generally avoid this issue if the VMs have qemu-guest-agent. Nir > Laure

[JIRA] (OVIRT-3102) Broken commit-msg hook in gerrit

2021-06-25 Thread Nir Soffer (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nir Soffer updated OVIRT-3102: -- Attachment: commit-msg On Fri, Jun 25, 2021 at 10:38 PM Nir Soffer wrote: > > In ovirt-i

[ovirt-devel] Re: Broken commit-msg hook in gerrit

2021-06-25 Thread Nir Soffer
On Fri, Jun 25, 2021 at 10:38 PM Nir Soffer wrote: > > In ovirt-imageio developer docs, we ask to install the commit-msg hook > from gerrit: > > wget -P .git/hooks https://gerrit.ovirt.org/tools/hooks/commit-msg > > This downloads now a broken script that does not add

[JIRA] (OVIRT-3102) Broken commit-msg hook in gerrit

2021-06-25 Thread Nir Soffer (oVirt JIRA)
Nir Soffer created OVIRT-3102: - Summary: Broken commit-msg hook in gerrit Key: OVIRT-3102 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-3102 Project: oVirt - virtualization made easy Issue

[ovirt-devel] Broken commit-msg hook in gerrit

2021-06-25 Thread Nir Soffer
In ovirt-imageio developer docs, we ask to install the commit-msg hook from gerrit: wget -P .git/hooks https://gerrit.ovirt.org/tools/hooks/commit-msg This downloads now a broken script that does not add a ChangeId header. In the past I think it returned something like the attached file, wit

Re: how to change sector size using qemu-img

2021-06-25 Thread Nir Soffer
On Fri, Jun 25, 2021 at 7:40 PM Jiatong Shen wrote: > > Hello community, > > I have a disk with both logical and physical sector size being 4096. I have a > qcow2 image which is built from a virtual machine has legacy 512 bytes sector > size. > > when I do something like > > qemu-img convert -f

[ovirt-users] Re: oVirt and ARM

2021-06-25 Thread Nir Soffer
On Fri, Jun 25, 2021 at 4:28 PM Sandro Bonazzola wrote: > > > Il giorno ven 25 giu 2021 alle ore 14:20 Marko Vrgotic < > m.vrgo...@activevideo.com> ha scritto: > >> Hi Sandro, >> >> >> >> Thank you for the update. I am not equipped to help on development side, >> but I can most certainly do test

[JIRA] (OVIRT-3101) Add "ci system-test" command

2021-06-24 Thread Nir Soffer (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41033#comment-41033 ] Nir Soffer commented on OVIRT-3101: --- On Thu, Jun 24, 2021 at 1:49 PM Marcin Sobczyk w

[ovirt-devel] Re: Add "ci system-test" command

2021-06-24 Thread Nir Soffer
On Thu, Jun 24, 2021 at 1:49 PM Marcin Sobczyk wrote: > > > > On 6/23/21 5:44 PM, Nir Soffer wrote: > > Similar to "ci build", "ci test", "ci merge" add a new command that > > triggers OST run. > > > > Running OST is tied now in

[JIRA] (OVIRT-3101) Add "ci system-test" command

2021-06-24 Thread Nir Soffer (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41032#comment-41032 ] Nir Soffer commented on OVIRT-3101: --- On Thu, Jun 24, 2021 at 2:11 PM Yedidyah Bar D

[ovirt-devel] Re: Add "ci system-test" command

2021-06-24 Thread Nir Soffer
On Thu, Jun 24, 2021 at 2:11 PM Yedidyah Bar David wrote: > > On Thu, Jun 24, 2021 at 1:51 PM Marcin Sobczyk wrote: > > > > > > > > On 6/23/21 5:44 PM, Nir Soffer wrote: > > > Similar to "ci build", "ci test", "ci merge" add

[ovirt-users] Re: [ANN] oVirt 4.4.7 Fourth Release Candidate is now available for testing

2021-06-24 Thread Nir Soffer
On Thu, Jun 24, 2021 at 4:19 AM Sketch wrote: > > On Wed, 23 Jun 2021, Nir Soffer wrote: > > > On Wed, Jun 23, 2021 at 12:22 PM Sketch wrote: > >> > >> Installation fails on a CentOS Linux 8.4 host using yum update. > >> > >> Problem 1: c

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-23 Thread Nir Soffer
On Wed, Jun 23, 2021 at 7:04 PM Kevin Wolf wrote: > > Am 23.06.2021 um 15:58 hat Nir Soffer geschrieben: > > On Wed, Jun 23, 2021 at 11:58 AM Kevin Wolf wrote: > > > > > > Am 22.06.2021 um 18:56 hat Nir Soffer geschrieben: > > > > On Tue,

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-23 Thread Nir Soffer
On Wed, Jun 23, 2021 at 7:04 PM Kevin Wolf wrote: > > Am 23.06.2021 um 15:58 hat Nir Soffer geschrieben: > > On Wed, Jun 23, 2021 at 11:58 AM Kevin Wolf wrote: > > > > > > Am 22.06.2021 um 18:56 hat Nir Soffer geschrieben: > > > > On Tue,

[JIRA] (OVIRT-3101) Add "ci system-test" command

2021-06-23 Thread Nir Soffer (oVirt JIRA)
Nir Soffer created OVIRT-3101: - Summary: Add "ci system-test" command Key: OVIRT-3101 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-3101 Project: oVirt - virtualization made easy

[ovirt-devel] Add "ci system-test" command

2021-06-23 Thread Nir Soffer
Similar to "ci build", "ci test", "ci merge" add a new command that triggers OST run. Running OST is tied now in vdsm (and engine?) to Code-Review: +2. This causes trouble and does not allow non-maintainers to use the convenient OST infrastructure. Expected flow: 1. User add a comment with "ci s

[JIRA] (OVIRT-3100) Add OST flag to all oVirt projects

2021-06-23 Thread Nir Soffer (oVirt JIRA)
Nir Soffer created OVIRT-3100: - Summary: Add OST flag to all oVirt projects Key: OVIRT-3100 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-3100 Project: oVirt - virtualization made easy

[ovirt-devel] Add OST flag to all oVirt projects

2021-06-23 Thread Nir Soffer
Similar to Continuous-Integration flag, OST needs its own flag. OST will set this flag when OST build started from gerrit was started. We want to make this field mandatory for merging patches, like Continuous-Integration. Like Continuous-Integration maintainers should be able to override the val

[ovirt-users] Re: [ANN] oVirt 4.4.7 Fourth Release Candidate is now available for testing

2021-06-23 Thread Nir Soffer
On Wed, Jun 23, 2021 at 12:22 PM Sketch wrote: > > Installation fails on a CentOS Linux 8.4 host using yum update. > > I had previously installed ceph and python3-os-brick from the > centos-oepnstrack-train and ceph-nautilus repos, but I removed the > packages and the repos and ran dnf distro-sync

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-23 Thread Nir Soffer
On Wed, Jun 23, 2021 at 11:58 AM Kevin Wolf wrote: > > Am 22.06.2021 um 18:56 hat Nir Soffer geschrieben: > > On Tue, Jun 22, 2021 at 6:38 PM Kevin Wolf wrote: > > > > > > Am 11.06.2021 um 21:03 hat Eric Blake geschrieben: > > > > To save the user fro

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-23 Thread Nir Soffer
On Wed, Jun 23, 2021 at 11:58 AM Kevin Wolf wrote: > > Am 22.06.2021 um 18:56 hat Nir Soffer geschrieben: > > On Tue, Jun 22, 2021 at 6:38 PM Kevin Wolf wrote: > > > > > > Am 11.06.2021 um 21:03 hat Eric Blake geschrieben: > > > > To save the user fro

Re: [Libguestfs] [libnbd PATCH] ci: Enable python code style

2021-06-23 Thread Nir Soffer
On Wed, Jun 23, 2021 at 3:56 PM Martin Kletzander wrote: > > On Tue, Jun 22, 2021 at 10:36:54PM +0300, Nir Soffer wrote: > >On Tue, Jun 22, 2021 at 9:20 PM Martin Kletzander > >wrote: > >> > >> Signed-off-by: Martin Kletzander > >> --- > >>

Re: [Libguestfs] [libnbd PATCH] ci: Enable python code style

2021-06-22 Thread Nir Soffer
On Tue, Jun 22, 2021 at 9:20 PM Martin Kletzander wrote: > > Signed-off-by: Martin Kletzander > --- > ci/build.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ci/build.sh b/ci/build.sh > index 7d62a84a5d4b..4ea3fec7d512 100755 > --- a/ci/build.sh > +++ b/ci/build.sh > @@ -8,6 +8,7 @@

Re: [Libguestfs] [libnbd PATCH] nbdsh: Simplify the script

2021-06-22 Thread Nir Soffer
On Tue, Jun 22, 2021 at 9:20 PM Martin Kletzander wrote: > > There is no need for any hacks if we just do what execution of the module > would > have done. > > Signed-off-by: Martin Kletzander > --- > sh/nbdsh.in | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --gi

[JIRA] (OVIRT-3099) Re: oVirt CI mirror for centos stream advancedvirt-common repo

2021-06-22 Thread Nir Soffer (oVirt JIRA)
Nir Soffer created OVIRT-3099: - Summary: Re: oVirt CI mirror for centos stream advancedvirt-common repo Key: OVIRT-3099 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-3099 Project: oVirt

[ovirt-devel] Re: oVirt CI mirror for centos stream advancedvirt-common repo

2021-06-22 Thread Nir Soffer
On Fri, Jun 11, 2021 at 12:41 PM Sandro Bonazzola wrote: > > > Il giorno ven 4 giu 2021 alle ore 19:44 Nir Soffer > ha scritto: > >> I updated vdsm libvirt requirement to 7.0.0-14. The package exists in >> centos >> stream and rhel so the change is correct, but

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-22 Thread Nir Soffer
On Fri, Jun 11, 2021 at 10:03 PM Eric Blake wrote: > > To save the user from having to check 'qemu-img info --backing-chain' > or other followup command to determine which "depth":n goes beyond the > chain, add a boolean field "backing" that is set only for unallocated > portions of the disk. > >

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-22 Thread Nir Soffer
On Fri, Jun 11, 2021 at 10:03 PM Eric Blake wrote: > > To save the user from having to check 'qemu-img info --backing-chain' > or other followup command to determine which "depth":n goes beyond the > chain, add a boolean field "backing" that is set only for unallocated > portions of the disk. > >

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-22 Thread Nir Soffer
On Tue, Jun 22, 2021 at 6:38 PM Kevin Wolf wrote: > > Am 11.06.2021 um 21:03 hat Eric Blake geschrieben: > > To save the user from having to check 'qemu-img info --backing-chain' > > or other followup command to determine which "depth":n goes beyond the > > chain, add a boolean field "backing" tha

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-22 Thread Nir Soffer
On Tue, Jun 22, 2021 at 6:38 PM Kevin Wolf wrote: > > Am 11.06.2021 um 21:03 hat Eric Blake geschrieben: > > To save the user from having to check 'qemu-img info --backing-chain' > > or other followup command to determine which "depth":n goes beyond the > > chain, add a boolean field "backing" tha

[ovirt-devel] Re: cloning LVM partitions

2021-06-21 Thread Nir Soffer
On Mon, Jun 21, 2021 at 10:29 PM wrote: > > Hi, > What are the internal commands used to clone LVM partitions ? Are you sure this is the right mailing list? > (you can simply indicate me the source code where this is done) If you mean how we copy disks lvm based disks (e.g. on FC/iSCSI storage

[ovirt-devel] Re: AV 8.4 for CentOS Linux

2021-06-21 Thread Nir Soffer
On Mon, Jun 21, 2021 at 8:39 PM Marcin Sobczyk wrote: > > > > On 6/20/21 12:23 PM, Dana Elfassy wrote: > > Hi, > > I'm getting packages conflicts when trying to upgrade my Centos8.4 and > > Centos-Stream hosts. > > (Centos Stream was installed from iso, then I > > installed ovirt-release-master.rp

[ovirt-devel] Re: OST verifed -1 broken, fails for infra issue in OST

2021-06-21 Thread Nir Soffer
On Mon, Jun 21, 2021 at 7:30 PM Michal Skrivanek wrote: > > > > > On 14. 6. 2021, at 13:14, Nir Soffer wrote: > > > > I got this wrong review from OST, which looks like an infra issue in OST: > > > > Patch: > > https://gerrit.ovirt.org/c/vdsm/+/11523

[JIRA] (OVIRT-3098) Gerrit hook adds unrelated patches to bugs

2021-06-21 Thread Nir Soffer (oVirt JIRA)
Nir Soffer created OVIRT-3098: - Summary: Gerrit hook adds unrelated patches to bugs Key: OVIRT-3098 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-3098 Project: oVirt - virtualization made easy

[ovirt-devel] Re: libvirtError: internal error: unknown feature amd-sev-es

2021-06-21 Thread Nir Soffer
I'm using RHEL AV 8.5.0 nightly repos without any issue. $ rpm -q libvirt-daemon vdsm libvirt-daemon-7.3.0-1.module+el8.5.0+11004+f4810536.x86_64 vdsm-4.40.70.3-202106131544.git9b5c96716.el8.x86_64 Nir ___ Devel mailing list -- devel@ovirt.org To unsubs

[ovirt-devel] Re: Purging inactive maintainers from vdsm-master-maintainers

2021-06-21 Thread Nir Soffer
On Mon, Jun 21, 2021 at 12:09 PM Milan Zamazal wrote: > > Nir Soffer writes: > > > On Mon, Jun 21, 2021 at 11:35 AM Milan Zamazal wrote: > >> > >> Edward Haas writes: > > > >> > >> > On Sun, Jun 20, 2021 at 11:29 PM Nir Soffer wro

[ovirt-devel] Re: Purging inactive maintainers from vdsm-master-maintainers

2021-06-21 Thread Nir Soffer
Thu, Nov 28, 2019 at 3:37 AM Milan Zamazal wrote: > >> Dan Kenigsberg writes: >> >> > On Wed, Nov 27, 2019 at 4:33 PM Francesco Romani >> wrote: >> >> >> >> On 11/27/19 3:25 PM, Nir Soffer wrote: >> > >> >> > I want to re

[ovirt-devel] Moving #vdsm to #ovirt?

2021-06-21 Thread Nir Soffer
We had mostly dead #vdsm channel in freenode[1]. Recently there was a hostile takeover of freenode, and old freenode folks created libera[2] network. Most (all?) projects moved to this network. We can move #vdsm to libera, but I think we have a better option, use #ovirt channel in oftc[3], which

[ovirt-devel] Re: Purging inactive maintainers from vdsm-master-maintainers

2021-06-21 Thread Nir Soffer
On Mon, Jun 21, 2021 at 11:35 AM Milan Zamazal wrote: > > Edward Haas writes: > > > On Sun, Jun 20, 2021 at 11:29 PM Nir Soffer wrote: > > > >> On Mon, Dec 2, 2019 at 4:27 PM Adam Litke wrote: > >> > >>> I also agree with the proposal. It&#

[ovirt-devel] Gerrit hook adds unrelated patches to bugs

2021-06-21 Thread Nir Soffer
Gerrit hook is wrongly looking for https://bugzilla.redhat.com/ URLs in the commit message, and adding the patch to the bug. Example patch: https://gerrit.ovirt.org/c/vdsm/+/115339 I had to clean up the bug after the broken hook (see screenshot). The hook should really look only in the single UR

[ovirt-devel] OST verifed -1 broken, fails for infra issue in OST

2021-06-21 Thread Nir Soffer
I got this wrong review from OST, which looks like an infra issue in OST: Patch: https://gerrit.ovirt.org/c/vdsm/+/115232 Error: https://gerrit.ovirt.org/c/vdsm/+/115232#message-46ad5e75_ed543485 Failing code: Package(*line.split()) for res in results.values() > for line in _filter_results(res[

Re: [Libguestfs] [PATCH libnbd 2/2] copy: Set default request-size to 2**18 (262144 bytes)

2021-06-20 Thread Nir Soffer
On Sun, Jun 20, 2021 at 11:58 PM Richard W.M. Jones wrote: > > On Sun, Jun 20, 2021 at 10:21:52PM +0300, Nir Soffer wrote: > > On Sun, Jun 20, 2021 at 7:46 PM Richard W.M. Jones > > wrote: > > > > > > As Nir has often pointed out, our current default req

Re: [Libguestfs] [PATCH libnbd 2/2] copy: Set default request-size to 2**18 (262144 bytes)

2021-06-20 Thread Nir Soffer
On Sun, Jun 20, 2021 at 7:46 PM Richard W.M. Jones wrote: > > As Nir has often pointed out, our current default request buffer size > (32MB) is too large, resulting in nbdcopy being as much as 2½ times > slower than it could be. > > The optimum buffer size most likely depends on the hardware, and

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-15 Thread Nir Soffer
On Tue, Jun 15, 2021 at 11:54 AM Vladimir Sementsov-Ogievskiy wrote: > > 11.06.2021 22:03, Eric Blake wrote: > > To save the user from having to check 'qemu-img info --backing-chain' > > or other followup command to determine which "depth":n goes beyond the > > chain, add a boolean field "backing"

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-15 Thread Nir Soffer
On Tue, Jun 15, 2021 at 11:54 AM Vladimir Sementsov-Ogievskiy wrote: > > 11.06.2021 22:03, Eric Blake wrote: > > To save the user from having to check 'qemu-img info --backing-chain' > > or other followup command to determine which "depth":n goes beyond the > > chain, add a boolean field "backing"

Re: Reporting absent extents in qcow2 image

2021-06-15 Thread Nir Soffer
On Tue, Jun 15, 2021 at 2:23 PM Vladimir Sementsov-Ogievskiy wrote: > > 15.06.2021 01:29, Nir Soffer wrote: > > oVirt started to use now qemu:allocation-depth meta context. > > In the past, we use base:allocation and reported NBD_STATE_HOLE > > as a hole, and this broke in

Re: [Libguestfs] virt-builder fails in fedora 34 container:

2021-06-15 Thread Nir Soffer
On Sun, Jun 13, 2021 at 1:38 PM Richard W.M. Jones wrote: > > On Sat, Jun 12, 2021 at 11:11:22PM +0300, Nir Soffer wrote: > > I'm running this inside a fedora 34 container in ovirt-imageio CI: > > > > 'virt-builder', '-v', '

Re: [Libguestfs] virt-builder fails in fedora 34 container:

2021-06-15 Thread Nir Soffer
On Tue, Jun 15, 2021 at 1:28 PM Nir Soffer wrote: > > On Tue, Jun 15, 2021 at 7:35 AM Martin Kletzander wrote: > > > > On Tue, Jun 15, 2021 at 02:12:00AM +0300, Nir Soffer wrote: > > >On Tue, Jun 15, 2021 at 1:26 AM Martin Kletzander > > >wrote: > > &

Re: [Libguestfs] virt-builder fails in fedora 34 container:

2021-06-15 Thread Nir Soffer
On Tue, Jun 15, 2021 at 7:35 AM Martin Kletzander wrote: > > On Tue, Jun 15, 2021 at 02:12:00AM +0300, Nir Soffer wrote: > >On Tue, Jun 15, 2021 at 1:26 AM Martin Kletzander > >wrote: > > [...] > > >> I looked at GitHub and saw this: > >> > &g

Re: [Libguestfs] virt-builder fails in fedora 34 container:

2021-06-14 Thread Nir Soffer
On Tue, Jun 15, 2021 at 1:26 AM Martin Kletzander wrote: > > On Tue, Jun 15, 2021 at 12:15:35AM +0300, Nir Soffer wrote: > >On Mon, Jun 14, 2021 at 11:50 PM Nir Soffer wrote: > >> > >> On Mon, Jun 14, 2021 at 7:47 PM Martin Kletzander > >> wrote: >

Reporting absent extents in qcow2 image

2021-06-14 Thread Nir Soffer
oVirt started to use now qemu:allocation-depth meta context. In the past, we use base:allocation and reported NBD_STATE_HOLE as a hole, and this broke in qemu 6.0.0. Now we have NBD_STATE_HOLE from base:allocation, and flags == 0 from qemu:allocation-depth. We map flags == 0 to EXTENT_BACKING (1

Re: [Libguestfs] virt-builder fails in fedora 34 container:

2021-06-14 Thread Nir Soffer
On Mon, Jun 14, 2021 at 11:50 PM Nir Soffer wrote: > > On Mon, Jun 14, 2021 at 7:47 PM Martin Kletzander wrote: > > > > On Mon, Jun 14, 2021 at 01:01:37PM +0100, Richard W.M. Jones wrote: > > >On Mon, Jun 14, 2021 at 02:20:40PM +0300, Nir Soffer wrote: > > &g

Re: [Libguestfs] virt-builder fails in fedora 34 container:

2021-06-14 Thread Nir Soffer
On Mon, Jun 14, 2021 at 7:47 PM Martin Kletzander wrote: > > On Mon, Jun 14, 2021 at 01:01:37PM +0100, Richard W.M. Jones wrote: > >On Mon, Jun 14, 2021 at 02:20:40PM +0300, Nir Soffer wrote: > >> On Mon, Jun 14, 2021 at 11:57 AM Martin Kletzander > >> wrote: >

Re: [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

2021-06-14 Thread Nir Soffer
On Mon, Jun 14, 2021 at 4:56 PM Eric Blake wrote: > > On Sat, Jun 12, 2021 at 02:39:44AM +0300, Nir Soffer wrote: > > Since this change is not simple, and the chance that we also get the dirty > > bitmap included in the result seems to be very low, I decided to check the > &

Re: [Libguestfs] [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

2021-06-14 Thread Nir Soffer
On Mon, Jun 14, 2021 at 4:56 PM Eric Blake wrote: > > On Sat, Jun 12, 2021 at 02:39:44AM +0300, Nir Soffer wrote: > > Since this change is not simple, and the chance that we also get the dirty > > bitmap included in the result seems to be very low, I decided to check the > &

Re: [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

2021-06-14 Thread Nir Soffer
On Mon, Jun 14, 2021 at 4:56 PM Eric Blake wrote: > > On Sat, Jun 12, 2021 at 02:39:44AM +0300, Nir Soffer wrote: > > Since this change is not simple, and the chance that we also get the dirty > > bitmap included in the result seems to be very low, I decided to check the > &

Re: [Libguestfs] virt-builder fails in fedora 34 container:

2021-06-14 Thread Nir Soffer
On Mon, Jun 14, 2021 at 11:57 AM Martin Kletzander wrote: > > On Sun, Jun 13, 2021 at 11:15:31PM +0300, Nir Soffer wrote: > >On Sun, Jun 13, 2021 at 1:38 PM Richard W.M. Jones wrote: > >> > >> On Sat, Jun 12, 2021 at 11:11:22PM +0300, Nir Soffer wrote: > >>

Re: [Libguestfs] virt-builder fails in fedora 34 container:

2021-06-13 Thread Nir Soffer
On Sun, Jun 13, 2021 at 1:38 PM Richard W.M. Jones wrote: > > On Sat, Jun 12, 2021 at 11:11:22PM +0300, Nir Soffer wrote: > > I'm running this inside a fedora 34 container in ovirt-imageio CI: > > > > 'virt-builder', '-v', '

[Libguestfs] virt-builder fails in fedora 34 container:

2021-06-12 Thread Nir Soffer
I'm running this inside a fedora 34 container in ovirt-imageio CI: 'virt-builder', '-v', '-x', 'cirros-0.3.5', '--write', '/etc/cirros-init/config:DATASOURCE_LIST="nocloud"', '--root-password', 'password:', '-o', '/var/tmp/imageio-images/cirros-0.3.5' The command fails in: supermin: ext2: co

Re: [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

2021-06-11 Thread Nir Soffer
On Wed, Jun 9, 2021 at 9:01 PM Eric Blake wrote: > > When trying to reconstruct a qcow2 chain using information provided > over NBD, ovirt had been relying on an unsafe assumption that any > portion of the qcow2 file advertised as sparse would defer to the > backing image; this worked with what qe

Re: [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

2021-06-11 Thread Nir Soffer
On Wed, Jun 9, 2021 at 9:01 PM Eric Blake wrote: > > When trying to reconstruct a qcow2 chain using information provided > over NBD, ovirt had been relying on an unsafe assumption that any > portion of the qcow2 file advertised as sparse would defer to the > backing image; this worked with what qe

Re: [Libguestfs] [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

2021-06-11 Thread Nir Soffer
On Wed, Jun 9, 2021 at 9:01 PM Eric Blake wrote: > > When trying to reconstruct a qcow2 chain using information provided > over NBD, ovirt had been relying on an unsafe assumption that any > portion of the qcow2 file advertised as sparse would defer to the > backing image; this worked with what qe

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Nir Soffer
On Fri, Jun 11, 2021 at 9:34 PM Eric Blake wrote: > > On Fri, Jun 11, 2021 at 08:35:01PM +0300, Nir Soffer wrote: > > On Fri, Jun 11, 2021 at 4:28 PM Eric Blake wrote: > > > > > > On Fri, Jun 11, 2021 at 10:09:09AM +0200, Kevin Wolf wrote: > > > > >

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Nir Soffer
On Fri, Jun 11, 2021 at 9:34 PM Eric Blake wrote: > > On Fri, Jun 11, 2021 at 08:35:01PM +0300, Nir Soffer wrote: > > On Fri, Jun 11, 2021 at 4:28 PM Eric Blake wrote: > > > > > > On Fri, Jun 11, 2021 at 10:09:09AM +0200, Kevin Wolf wrote: > > > > >

Re: [PATCH v2] qemu-img: Make unallocated part of backing chain obvious in map

2021-06-11 Thread Nir Soffer
On Fri, Jun 11, 2021 at 5:59 PM Eric Blake wrote: > > On Fri, Jun 11, 2021 at 05:35:12PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > > An obvious solution is to make 'qemu-img map --output=json' > > > distinguish between clusters that have a local allocation from those > > > that are found nowh

Re: [PATCH v2] qemu-img: Make unallocated part of backing chain obvious in map

2021-06-11 Thread Nir Soffer
On Fri, Jun 11, 2021 at 5:59 PM Eric Blake wrote: > > On Fri, Jun 11, 2021 at 05:35:12PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > > An obvious solution is to make 'qemu-img map --output=json' > > > distinguish between clusters that have a local allocation from those > > > that are found nowh

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Nir Soffer
On Fri, Jun 11, 2021 at 4:28 PM Eric Blake wrote: > > On Fri, Jun 11, 2021 at 10:09:09AM +0200, Kevin Wolf wrote: > > > Yes, that might work as well. But we didn't previously document > > > depth to be optional. Removing something from output risks breaking > > > more downstream tools that expec

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Nir Soffer
On Fri, Jun 11, 2021 at 4:28 PM Eric Blake wrote: > > On Fri, Jun 11, 2021 at 10:09:09AM +0200, Kevin Wolf wrote: > > > Yes, that might work as well. But we didn't previously document > > > depth to be optional. Removing something from output risks breaking > > > more downstream tools that expec

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Nir Soffer
> ‫ב-11 ביוני 2021, בשעה 11:14, ‏‏Vladimir Sementsov-Ogievskiy > ‏ כתב/ה:‬ > > 11.06.2021 11:09, Kevin Wolf wrote: >> Am 10.06.2021 um 22:46 hat Eric Blake geschrieben: >>>> On Thu, Jun 10, 2021 at 11:09:05PM +0300, Nir Soffer wrote: >>>>>> But

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Nir Soffer
> ‫ב-11 ביוני 2021, בשעה 11:14, ‏‏Vladimir Sementsov-Ogievskiy > ‏ כתב/ה:‬ > > 11.06.2021 11:09, Kevin Wolf wrote: >> Am 10.06.2021 um 22:46 hat Eric Blake geschrieben: >>>> On Thu, Jun 10, 2021 at 11:09:05PM +0300, Nir Soffer wrote: >>>>>> But

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-10 Thread Nir Soffer
On Thu, Jun 10, 2021 at 9:35 PM Eric Blake wrote: > > On Tue, Jun 08, 2021 at 07:38:10PM +0300, Nir Soffer wrote: > > The example I provided was not detailed enough, what we actually do is: > > > > qemu-nbd .. 'json:{"driver": "qcow2", "ba

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-10 Thread Nir Soffer
On Thu, Jun 10, 2021 at 9:35 PM Eric Blake wrote: > > On Tue, Jun 08, 2021 at 07:38:10PM +0300, Nir Soffer wrote: > > The example I provided was not detailed enough, what we actually do is: > > > > qemu-nbd .. 'json:{"driver": "qcow2", "ba

Re: [Libguestfs] [libnbd PATCH] info: Avoid ambiguous 'allocated' terminology in mapping

2021-06-10 Thread Nir Soffer
in qemu:allocation-depth, either a cluster is known to come > from the backing chain (either locally, or from a given backing > depth), or it is completely absent from the chain (not allocated in > any of the layers). Instead of calling it "unallocated", we can call > it "

Re: [libnbd PATCH] info: Avoid ambiguous 'allocated' terminology in mapping

2021-06-10 Thread Nir Soffer
in qemu:allocation-depth, either a cluster is known to come > from the backing chain (either locally, or from a given backing > depth), or it is completely absent from the chain (not allocated in > any of the layers). Instead of calling it "unallocated", we can call > it "

Re: [RFC libnbd PATCH] info: Add support for new qemu:joint-allocation

2021-06-10 Thread Nir Soffer
On Thu, Jun 10, 2021 at 4:06 PM Eric Blake wrote: > > On Thu, Jun 10, 2021 at 01:20:13AM +0300, Nir Soffer wrote: > > > + else if (strcmp (metacontext, "qemu:joint-allocation") == 0) { > > > +/* Combo of base:allocation and stripped-down qemu:allocation-dep

Re: [RFC libnbd PATCH] info: Add support for new qemu:joint-allocation

2021-06-10 Thread Nir Soffer
On Thu, Jun 10, 2021 at 4:06 PM Eric Blake wrote: > > On Thu, Jun 10, 2021 at 01:20:13AM +0300, Nir Soffer wrote: > > > + else if (strcmp (metacontext, "qemu:joint-allocation") == 0) { > > > +/* Combo of base:allocation and stripped-down qemu:allocation-dep

Re: [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

2021-06-10 Thread Nir Soffer
On Thu, Jun 10, 2021 at 2:52 AM Nir Soffer wrote: > > On Wed, Jun 9, 2021 at 9:01 PM Eric Blake wrote: I posted a work in progress patch implementing support for qemu:joint-allocaition in oVirt: https://gerrit.ovirt.org/c/ovirt-imageio/+/115197 The most important part is the nbd client:

Re: [Libguestfs] [RFC libnbd PATCH] info: Add support for new qemu:joint-allocation

2021-06-10 Thread Nir Soffer
On Thu, Jun 10, 2021 at 4:06 PM Eric Blake wrote: > > On Thu, Jun 10, 2021 at 01:20:13AM +0300, Nir Soffer wrote: > > > + else if (strcmp (metacontext, "qemu:joint-allocation") == 0) { > > > +/* Combo of base:allocation and stripped-down qemu:allocation-dep

Re: [Libguestfs] [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

2021-06-10 Thread Nir Soffer
On Thu, Jun 10, 2021 at 2:52 AM Nir Soffer wrote: > > On Wed, Jun 9, 2021 at 9:01 PM Eric Blake wrote: I posted a work in progress patch implementing support for qemu:joint-allocaition in oVirt: https://gerrit.ovirt.org/c/ovirt-imageio/+/115197 The most important part is the nbd client:

Re: [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

2021-06-10 Thread Nir Soffer
On Thu, Jun 10, 2021 at 2:52 AM Nir Soffer wrote: > > On Wed, Jun 9, 2021 at 9:01 PM Eric Blake wrote: I posted a work in progress patch implementing support for qemu:joint-allocaition in oVirt: https://gerrit.ovirt.org/c/ovirt-imageio/+/115197 The most important part is the nbd client:

Re: [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

2021-06-09 Thread Nir Soffer
not a practical issue for oVirt, but it would be better to report: $ ./nbdinfo --map="qemu:joint-allocation" nbd://localhost 0 10737418243 hole,zero,unallocated This is the output for the empty qcow2 image. And this also affects --allocation-depth, for raw empty image

Re: [Libguestfs] [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

2021-06-09 Thread Nir Soffer
not a practical issue for oVirt, but it would be better to report: $ ./nbdinfo --map="qemu:joint-allocation" nbd://localhost 0 10737418243 hole,zero,unallocated This is the output for the empty qcow2 image. And this also affects --allocation-depth, for raw empty image

<    3   4   5   6   7   8   9   10   11   12   >