[Lldb-commits] [lldb] 85f025e - [lldb/test] Test lldb-server named pipe functionality on windows

Author: Pavel Labath Date: 2021-02-16T15:47:39+01:00 New Revision: 85f025e5b33d148808177427eebca4cc14f93079 URL: https://github.com/llvm/llvm-project/commit/85f025e5b33d148808177427eebca4cc14f93079 DIFF: https://github.com/llvm/llvm-project/commit/85f025e5b33d148808177427eebca4cc14f93079.diff

[Lldb-commits] [lldb] 3cad308 - Revert "[lldb/test] Automatically find debug servers to test"

Author: Pavel Labath Date: 2021-02-11T20:26:05+01:00 New Revision: 3cad308ce5d9eb2cc52f43ccef68f3d2b12f2a32 URL: https://github.com/llvm/llvm-project/commit/3cad308ce5d9eb2cc52f43ccef68f3d2b12f2a32 DIFF: https://github.com/llvm/llvm-project/commit/3cad308ce5d9eb2cc52f43ccef68f3d2b12f2a32.diff

[Lldb-commits] [lldb] 7df4eaa - [lldb/test] Automatically find debug servers to test

Author: Pavel Labath Date: 2021-02-11T14:43:53+01:00 New Revision: 7df4eaaa937332c0617aa665080533966e2c98a0 URL: https://github.com/llvm/llvm-project/commit/7df4eaaa937332c0617aa665080533966e2c98a0 DIFF: https://github.com/llvm/llvm-project/commit/7df4eaaa937332c0617aa665080533966e2c98a0.diff

[Lldb-commits] [lldb] d77b04e - [lldb/test] Move and improve TestPlatformProcessConnect.py

Author: Pavel Labath Date: 2021-02-10T21:01:26+01:00 New Revision: d77b04e4edc00da3be2e0d2c8a0c80ae3ce0d829 URL: https://github.com/llvm/llvm-project/commit/d77b04e4edc00da3be2e0d2c8a0c80ae3ce0d829 DIFF: https://github.com/llvm/llvm-project/commit/d77b04e4edc00da3be2e0d2c8a0c80ae3ce0d829.diff

[Lldb-commits] [lldb] b90c490 - [lldb/cmake] Reduce duplication in generation lldb-dotest

Author: Pavel Labath Date: 2021-02-05T08:44:10+01:00 New Revision: b90c4907ae81e13ff3ce8a56b698e92b36a62d61 URL: https://github.com/llvm/llvm-project/commit/b90c4907ae81e13ff3ce8a56b698e92b36a62d61 DIFF: https://github.com/llvm/llvm-project/commit/b90c4907ae81e13ff3ce8a56b698e92b36a62d61.diff

[Lldb-commits] [lldb] 98d9f2d - [lldb/test] Reduce API test tools configuration boilerplate

Author: Pavel Labath Date: 2021-02-05T08:44:08+01:00 New Revision: 98d9f2dcaca0c9fe64616fcca882e45473cf6dd1 URL: https://github.com/llvm/llvm-project/commit/98d9f2dcaca0c9fe64616fcca882e45473cf6dd1 DIFF: https://github.com/llvm/llvm-project/commit/98d9f2dcaca0c9fe64616fcca882e45473cf6dd1.diff

[Lldb-commits] [lldb] aa56b30 - [lldb] Make TestLocalVariables.py compatible with the new pass manager

Author: Pavel Labath Date: 2021-02-04T11:27:08+01:00 New Revision: aa56b30014d96700b2fc945be11866789f341d38 URL: https://github.com/llvm/llvm-project/commit/aa56b30014d96700b2fc945be11866789f341d38 DIFF: https://github.com/llvm/llvm-project/commit/aa56b30014d96700b2fc945be11866789f341d38.diff

Re: [Lldb-commits] Performing ManualDWARFIndex::Index() async during ManualDWARFIndex::Preload()

On 29/01/2021 16:25, Lasse Folger via lldb-commits wrote: > Hi lldb devs, > > We experienced some issues when debugging large binaries. > The startup time of lldb for large binaries is long (tens of seconds). > One of the reasons is that the /ManualDWARFIndex::Index()/ function is > executed

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On 25/01/2021 05:30, David Blaikie wrote: On Fri, Jan 22, 2021 at 5:37 AM Pavel Labath > wrote: On 19/01/2021 23:23, David Blaikie wrote: > On Tue, Jan 19, 2021 at 1:12 AM Pavel Labath mailto:pa...@labath.sk>> wrote: > Yeah - I have mixed feelings about

[Lldb-commits] [lldb] 2afaf07 - Implement vAttachOrWait

Author: Augusto Noronha Date: 2021-01-24T21:30:09+01:00 New Revision: 2afaf072f5c1467767081571f2a3747b3ba91354 URL: https://github.com/llvm/llvm-project/commit/2afaf072f5c1467767081571f2a3747b3ba91354 DIFF:

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On 22/01/2021 18:42, Jim Ingham wrote: If you are just loading an object file and the looking at the line table or something like that, would a UnitTest be more suitable? Jim It depends on who you're talking to. :) I, for one, think we should be writing more unit tests, however, this is

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On 19/01/2021 23:23, David Blaikie wrote: On Tue, Jan 19, 2021 at 1:12 AM Pavel Labath wrote: Yeah - I have mixed feelings about debugger testing here - it is nice to have end-to-end tests which makes for handy debugger testing (though I guess in theory, debuginfo-tests is the place for

Re: [Lldb-commits] [lldb] 079e664 - [lldb] Re-enable TestPlatformProcessConnect on macos

On 20/01/2021 04:35, Eric Christopher wrote: +Jordan Rupprecht Interesting, we were using this internally to point to an lldb-server to test. I've disabled some tests at the moment, but I'm not sure it isn't entirely useful functionality :) -eric Yes, I

[Lldb-commits] [lldb] 599fdfc - Revert "[lldb] Re-enable TestPlatformProcessConnect on macos"

Author: Pavel Labath Date: 2021-01-20T20:49:03+01:00 New Revision: 599fdfc5db8f44582ee9bd05544769268ec9b4a3 URL: https://github.com/llvm/llvm-project/commit/599fdfc5db8f44582ee9bd05544769268ec9b4a3 DIFF: https://github.com/llvm/llvm-project/commit/599fdfc5db8f44582ee9bd05544769268ec9b4a3.diff

[Lldb-commits] [lldb] 079e664 - [lldb] Re-enable TestPlatformProcessConnect on macos

Author: Pavel Labath Date: 2021-01-19T11:01:07+01:00 New Revision: 079e664661770a78e30c0d27a12d50047f1b1ea8 URL: https://github.com/llvm/llvm-project/commit/079e664661770a78e30c0d27a12d50047f1b1ea8 DIFF: https://github.com/llvm/llvm-project/commit/079e664661770a78e30c0d27a12d50047f1b1ea8.diff

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

(sorry for inactivity -- I mostly tuned out of this discussion as I couldn't keep up with its pace) On 08/01/2021 01:55, Jim Ingham via lldb-commits wrote: > 3) However, we try to push as many tests as possible all the way > through the compiler, since the lldb test suite is also one of the >

[Lldb-commits] [lldb] a89242d - [lldb] Skip TestPlatformProcessConnect on windows and darwin

Author: Pavel Labath Date: 2021-01-17T20:18:55+01:00 New Revision: a89242d874df72cddeafbebc75ac377371e72796 URL: https://github.com/llvm/llvm-project/commit/a89242d874df72cddeafbebc75ac377371e72796 DIFF: https://github.com/llvm/llvm-project/commit/a89242d874df72cddeafbebc75ac377371e72796.diff

[Lldb-commits] [lldb] a997a1d - [lldb/test] Ensure launched processes are ready to be attached

Author: Pavel Labath Date: 2021-01-14T12:07:04+01:00 New Revision: a997a1d7fbe229433fb458bb0035b32424ecf3bd URL: https://github.com/llvm/llvm-project/commit/a997a1d7fbe229433fb458bb0035b32424ecf3bd DIFF: https://github.com/llvm/llvm-project/commit/a997a1d7fbe229433fb458bb0035b32424ecf3bd.diff

[Lldb-commits] [lldb] 4b284b9 - [lldb] Fix TestPlatformProcessConnect.py

Author: Pavel Labath Date: 2021-01-14T09:49:19+01:00 New Revision: 4b284b9ca8098e284b8d965a633b71bd283043d6 URL: https://github.com/llvm/llvm-project/commit/4b284b9ca8098e284b8d965a633b71bd283043d6 DIFF: https://github.com/llvm/llvm-project/commit/4b284b9ca8098e284b8d965a633b71bd283043d6.diff

[Lldb-commits] [lldb] 2bbf724 - Implement vAttachWait in lldb-server

Author: Augusto Noronha Date: 2021-01-14T09:25:15+01:00 New Revision: 2bbf724feea9824f9b9e4d20d34828023dbec2af URL: https://github.com/llvm/llvm-project/commit/2bbf724feea9824f9b9e4d20d34828023dbec2af DIFF:

[Lldb-commits] [lldb] 7ad54d1 - [lldb][wasm] Parse DWO section names

Author: Philip Pfaffe Date: 2021-01-14T08:45:02+01:00 New Revision: 7ad54d193871ce69968565ea46372e81c9f1ce62 URL: https://github.com/llvm/llvm-project/commit/7ad54d193871ce69968565ea46372e81c9f1ce62 DIFF: https://github.com/llvm/llvm-project/commit/7ad54d193871ce69968565ea46372e81c9f1ce62.diff

[Lldb-commits] [lldb] d36e879 - [lldb] Disable PipeTest.OpenAsReader on windows

Author: Pavel Labath Date: 2021-01-11T13:37:49+01:00 New Revision: d36e879c21c9620c9b6a1a8f45afe46379142d2f URL: https://github.com/llvm/llvm-project/commit/d36e879c21c9620c9b6a1a8f45afe46379142d2f DIFF: https://github.com/llvm/llvm-project/commit/d36e879c21c9620c9b6a1a8f45afe46379142d2f.diff

[Lldb-commits] [lldb] 13dea03 - [lldb] Fix some bugs in the Pipe class and add tests

Author: Pavel Labath Date: 2021-01-10T21:59:16+01:00 New Revision: 13dea030b3d794d05a08dd0080c35844c9ca1b30 URL: https://github.com/llvm/llvm-project/commit/13dea030b3d794d05a08dd0080c35844c9ca1b30 DIFF: https://github.com/llvm/llvm-project/commit/13dea030b3d794d05a08dd0080c35844c9ca1b30.diff

[Lldb-commits] [lldb] 4e0e79d - [lldb] Simplify some lldb-server tests

Author: Pavel Labath Date: 2021-01-06T15:39:51+01:00 New Revision: 4e0e79dd349a208384449fd8dcdc9bf1644ee0f3 URL: https://github.com/llvm/llvm-project/commit/4e0e79dd349a208384449fd8dcdc9bf1644ee0f3 DIFF: https://github.com/llvm/llvm-project/commit/4e0e79dd349a208384449fd8dcdc9bf1644ee0f3.diff

[Lldb-commits] [lldb] 54a1c86 - [lldb] Deduplicate more lldb-server tests

Author: Pavel Labath Date: 2021-01-02T18:32:25+01:00 New Revision: 54a1c861ca7a9e15d23904e1e702ac7e868882b0 URL: https://github.com/llvm/llvm-project/commit/54a1c861ca7a9e15d23904e1e702ac7e868882b0 DIFF: https://github.com/llvm/llvm-project/commit/54a1c861ca7a9e15d23904e1e702ac7e868882b0.diff

[Lldb-commits] [lldb] d9ba814 - [lldb/test] Deduplicate the rest of TestLldbGdbServer.py

Author: Pavel Labath Date: 2021-01-02T18:32:25+01:00 New Revision: d9ba8142c9a44a025c9816a8dc4a015ad8baec6a URL: https://github.com/llvm/llvm-project/commit/d9ba8142c9a44a025c9816a8dc4a015ad8baec6a DIFF: https://github.com/llvm/llvm-project/commit/d9ba8142c9a44a025c9816a8dc4a015ad8baec6a.diff

[Lldb-commits] [lldb] a0b68a2 - [lldb] Deduplicate some tests in TestLldbGdbServer

Author: Pavel Labath Date: 2020-12-29T09:37:01+01:00 New Revision: a0b68a2925fbe31f4b0af27677d55feaff6b1362 URL: https://github.com/llvm/llvm-project/commit/a0b68a2925fbe31f4b0af27677d55feaff6b1362 DIFF: https://github.com/llvm/llvm-project/commit/a0b68a2925fbe31f4b0af27677d55feaff6b1362.diff

[Lldb-commits] [lldb] 76a718e - [lldb] Deduplicate some lldb-server tests

Author: Pavel Labath Date: 2020-12-28T20:16:08+01:00 New Revision: 76a718ee939ed84d95b005f36cfbd103a702522f URL: https://github.com/llvm/llvm-project/commit/76a718ee939ed84d95b005f36cfbd103a702522f DIFF: https://github.com/llvm/llvm-project/commit/76a718ee939ed84d95b005f36cfbd103a702522f.diff

[Lldb-commits] [lldb] bd39a5c - [lldb/test] Automatically skip remote lldb-server tests when applicable

Author: Pavel Labath Date: 2020-12-27T13:58:10+01:00 New Revision: bd39a5cb30a34547eb56a81eb7ca8aca23544099 URL: https://github.com/llvm/llvm-project/commit/bd39a5cb30a34547eb56a81eb7ca8aca23544099 DIFF: https://github.com/llvm/llvm-project/commit/bd39a5cb30a34547eb56a81eb7ca8aca23544099.diff

[Lldb-commits] [lldb] aca4488 - [lldb] Surpress "ingoring result" warning in reproducer_handler

Author: Pavel Labath Date: 2020-12-27T13:58:05+01:00 New Revision: aca4488847b4ddceeda8d4ddb2cd9cb3defbab0c URL: https://github.com/llvm/llvm-project/commit/aca4488847b4ddceeda8d4ddb2cd9cb3defbab0c DIFF: https://github.com/llvm/llvm-project/commit/aca4488847b4ddceeda8d4ddb2cd9cb3defbab0c.diff

[Lldb-commits] [lldb] 0a8a245 - [lldb/test] Add GdbRemoteTestCaseFactory to avoid duplication in lldb-server tests

Author: Pavel Labath Date: 2020-12-22T10:07:47+01:00 New Revision: 0a8a2453fb843cf2e0f43e389b58d516525f0b8c URL: https://github.com/llvm/llvm-project/commit/0a8a2453fb843cf2e0f43e389b58d516525f0b8c DIFF: https://github.com/llvm/llvm-project/commit/0a8a2453fb843cf2e0f43e389b58d516525f0b8c.diff

[Lldb-commits] [lldb] 3f3ab03 - [lldb] Remove anonymous namespace from NativeRegisterContextLinux_x86_64

Author: Pavel Labath Date: 2020-12-21T20:39:05+01:00 New Revision: 3f3ab03ab7bbaf13329b0ff07c5d3de40970bfcd URL: https://github.com/llvm/llvm-project/commit/3f3ab03ab7bbaf13329b0ff07c5d3de40970bfcd DIFF: https://github.com/llvm/llvm-project/commit/3f3ab03ab7bbaf13329b0ff07c5d3de40970bfcd.diff

[Lldb-commits] [lldb] 37974b4 - [lldb/test] Enable reverse-connect on windows too

Author: Pavel Labath Date: 2020-12-20T10:37:48+01:00 New Revision: 37974b493a48cf97ac3d486512d6cd70c176924a URL: https://github.com/llvm/llvm-project/commit/37974b493a48cf97ac3d486512d6cd70c176924a DIFF: https://github.com/llvm/llvm-project/commit/37974b493a48cf97ac3d486512d6cd70c176924a.diff

[Lldb-commits] [lldb] c15c296 - [lldb/test] Reduce boilerplate in lldb-server tests

Author: Pavel Labath Date: 2020-12-18T13:01:42+01:00 New Revision: c15c29652118292c389d5f9fde1b11b55c248cd9 URL: https://github.com/llvm/llvm-project/commit/c15c29652118292c389d5f9fde1b11b55c248cd9 DIFF: https://github.com/llvm/llvm-project/commit/c15c29652118292c389d5f9fde1b11b55c248cd9.diff

[Lldb-commits] [lldb] 122a4eb - Revert "[lldb] Make CommandInterpreter's execution context the same as debugger's one."

Author: Pavel Labath Date: 2020-12-17T17:47:53+01:00 New Revision: 122a4ebde3f4394a84e9f93b9c7085f088be6dd7 URL: https://github.com/llvm/llvm-project/commit/122a4ebde3f4394a84e9f93b9c7085f088be6dd7 DIFF: https://github.com/llvm/llvm-project/commit/122a4ebde3f4394a84e9f93b9c7085f088be6dd7.diff

[Lldb-commits] [lldb] e7a3c4c - [lldb-vscode] Speculative fix for raciness in TestVSCode_attach

Author: Pavel Labath Date: 2020-12-17T14:19:52+01:00 New Revision: e7a3c4c11e84ba99c3682ae6cf20c398f16cf3f5 URL: https://github.com/llvm/llvm-project/commit/e7a3c4c11e84ba99c3682ae6cf20c398f16cf3f5 DIFF: https://github.com/llvm/llvm-project/commit/e7a3c4c11e84ba99c3682ae6cf20c398f16cf3f5.diff

[Lldb-commits] [lldb] b505142 - [lldb/test] Change base class of lldb-server tests

Author: Pavel Labath Date: 2020-12-10T16:21:28+01:00 New Revision: b505142fa5d301238796318d2d092d6fb3bd2d31 URL: https://github.com/llvm/llvm-project/commit/b505142fa5d301238796318d2d092d6fb3bd2d31 DIFF: https://github.com/llvm/llvm-project/commit/b505142fa5d301238796318d2d092d6fb3bd2d31.diff

[Lldb-commits] [lldb] db84208 - [lldb/test] Replace ad-hoc server test choice with test categories

Author: Pavel Labath Date: 2020-12-10T16:21:28+01:00 New Revision: db8420825073371ddc077b020634e71e315e38a1 URL: https://github.com/llvm/llvm-project/commit/db8420825073371ddc077b020634e71e315e38a1 DIFF: https://github.com/llvm/llvm-project/commit/db8420825073371ddc077b020634e71e315e38a1.diff

[Lldb-commits] [lldb] a2f4f7d - [lldb/test] Refactor socket_packet_pump

Author: Pavel Labath Date: 2020-12-07T09:24:13+01:00 New Revision: a2f4f7daf76c767efd668390bc7f8b99bdb1218c URL: https://github.com/llvm/llvm-project/commit/a2f4f7daf76c767efd668390bc7f8b99bdb1218c DIFF: https://github.com/llvm/llvm-project/commit/a2f4f7daf76c767efd668390bc7f8b99bdb1218c.diff

[Lldb-commits] [lldb] 174b09e - [lldb/test] Simplify TestLldbGdbServer.py

Author: Pavel Labath Date: 2020-12-07T09:24:13+01:00 New Revision: 174b09e9153894903c13bd4f40c6dab07b2558ba URL: https://github.com/llvm/llvm-project/commit/174b09e9153894903c13bd4f40c6dab07b2558ba DIFF: https://github.com/llvm/llvm-project/commit/174b09e9153894903c13bd4f40c6dab07b2558ba.diff

[Lldb-commits] [lldb] ce279e0 - [lldb/test] Simplify TestGdbRemoteExitCode.py

Author: Pavel Labath Date: 2020-12-07T09:24:12+01:00 New Revision: ce279e0c80eb3af913bc2cd08c2bcf4632252675 URL: https://github.com/llvm/llvm-project/commit/ce279e0c80eb3af913bc2cd08c2bcf4632252675 DIFF: https://github.com/llvm/llvm-project/commit/ce279e0c80eb3af913bc2cd08c2bcf4632252675.diff

[Lldb-commits] [lldb] b6e04ac - [lldb/test] Avoid the socket "pump" thread

Author: Pavel Labath Date: 2020-11-30T09:07:45+01:00 New Revision: b6e04ac5aa881c1fbb66da884b04e48dfb102474 URL: https://github.com/llvm/llvm-project/commit/b6e04ac5aa881c1fbb66da884b04e48dfb102474 DIFF: https://github.com/llvm/llvm-project/commit/b6e04ac5aa881c1fbb66da884b04e48dfb102474.diff

Re: [Lldb-commits] [lldb] 6c0cd56 - [lldb] Make `process connect` behave the same in sync and async mode.

On 14/11/2020 02:39, Jonas Devlieghere via lldb-commits wrote: +# RUN: echo -e 'platform select remote-gdb-server\nprocess connect connect://localhost:4321' | %lldb 2>&1 | FileCheck %s + +# CHECK: Platform: remote-gdb-server +# CHECK: Connected: no +# CHECK: error: Failed to connect port This

[Lldb-commits] [lldb] 4edb7e3 - [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results

Author: Pavel Labath Date: 2020-11-10T16:10:08+01:00 New Revision: 4edb7e34f824ca4adaa55d3668e050166bae2ad4 URL: https://github.com/llvm/llvm-project/commit/4edb7e34f824ca4adaa55d3668e050166bae2ad4 DIFF: https://github.com/llvm/llvm-project/commit/4edb7e34f824ca4adaa55d3668e050166bae2ad4.diff

[Lldb-commits] [lldb] 586c375 - [lldb] Remove [US]IntValueIsValidForSize from CommandObjectMemory

Author: Pavel Labath Date: 2020-11-04T16:28:10+01:00 New Revision: 586c375fa3f0bb6f685a69ea43d7f235b76b6a9f URL: https://github.com/llvm/llvm-project/commit/586c375fa3f0bb6f685a69ea43d7f235b76b6a9f DIFF: https://github.com/llvm/llvm-project/commit/586c375fa3f0bb6f685a69ea43d7f235b76b6a9f.diff

[Lldb-commits] [lldb] e2d24d9 - [lldb/Utility] Delete Scalar::[US]IntValueIsValidForSize

Author: Pavel Labath Date: 2020-11-04T16:28:10+01:00 New Revision: e2d24d91c2a11ea488844d20ef5fabd05936a668 URL: https://github.com/llvm/llvm-project/commit/e2d24d91c2a11ea488844d20ef5fabd05936a668 DIFF: https://github.com/llvm/llvm-project/commit/e2d24d91c2a11ea488844d20ef5fabd05936a668.diff

[Lldb-commits] [lldb] ac6799d - [lldb] Improve RegisterValue::GetScalarValue

Author: Pavel Labath Date: 2020-11-04T14:53:06+01:00 New Revision: ac6799d25a59e262191e0babcd7024537fda467e URL: https://github.com/llvm/llvm-project/commit/ac6799d25a59e262191e0babcd7024537fda467e DIFF: https://github.com/llvm/llvm-project/commit/ac6799d25a59e262191e0babcd7024537fda467e.diff

[Lldb-commits] [lldb] 5d64574 - [lldb] Delete Value::Vector class

Author: Pavel Labath Date: 2020-11-04T10:21:56+01:00 New Revision: 5d64574301836c4c17127794121d49a62d24f803 URL: https://github.com/llvm/llvm-project/commit/5d64574301836c4c17127794121d49a62d24f803 DIFF: https://github.com/llvm/llvm-project/commit/5d64574301836c4c17127794121d49a62d24f803.diff

Re: [Lldb-commits] [lldb] 051da2b - [lldb] [test/Shell] Pass -pthread to host toolchain on FreeBSD too

On 03/11/2020 22:02, Michał Górny via lldb-commits wrote: Author: Michał Górny Date: 2020-11-03T22:01:59+01:00 New Revision: 051da2bede4ba7231d009b5708d1191dde1e5dde URL: https://github.com/llvm/llvm-project/commit/051da2bede4ba7231d009b5708d1191dde1e5dde DIFF:

[Lldb-commits] [lldb] d2700b7 - [lldb/Utility] Add unit tests for RegisterValue::GetScalarValue

Author: Pavel Labath Date: 2020-11-03T16:12:32+01:00 New Revision: d2700b7873e305a09a931e98b12ebab7b42deec3 URL: https://github.com/llvm/llvm-project/commit/d2700b7873e305a09a931e98b12ebab7b42deec3 DIFF: https://github.com/llvm/llvm-project/commit/d2700b7873e305a09a931e98b12ebab7b42deec3.diff

[Lldb-commits] [lldb] 1695c84 - [lldb] Generalize an deflake gdb-remote *client* tests

Author: Pavel Labath Date: 2020-11-02T16:34:25+01:00 New Revision: 1695c8420a1c43ff6f4ff442ce5fa0cdd2f6e78f URL: https://github.com/llvm/llvm-project/commit/1695c8420a1c43ff6f4ff442ce5fa0cdd2f6e78f DIFF: https://github.com/llvm/llvm-project/commit/1695c8420a1c43ff6f4ff442ce5fa0cdd2f6e78f.diff

[Lldb-commits] [lldb] e3645fd - [lldb/test] Fix a fragile assumption in TestTypeGetModule

Author: Pavel Labath Date: 2020-11-02T15:42:14+01:00 New Revision: e3645fdff4639d2ac93e1869a7cd0be8ef24b6f2 URL: https://github.com/llvm/llvm-project/commit/e3645fdff4639d2ac93e1869a7cd0be8ef24b6f2 DIFF: https://github.com/llvm/llvm-project/commit/e3645fdff4639d2ac93e1869a7cd0be8ef24b6f2.diff

[Lldb-commits] [lldb] 1d1d916 - Fix an embarrasing use-after-free from a895a446bcde

Author: Pavel Labath Date: 2020-10-30T16:54:24+01:00 New Revision: 1d1d916f960e1ab059d4223abf91bea91780a7e9 URL: https://github.com/llvm/llvm-project/commit/1d1d916f960e1ab059d4223abf91bea91780a7e9 DIFF: https://github.com/llvm/llvm-project/commit/1d1d916f960e1ab059d4223abf91bea91780a7e9.diff

[Lldb-commits] [lldb] 8485ee7 - [lldb/DWARF] Fix dwo flavour of TestTypeGetModule

Author: Pavel Labath Date: 2020-10-30T15:20:27+01:00 New Revision: 8485ee781fcfcc2e8335093ece985d8366d3906b URL: https://github.com/llvm/llvm-project/commit/8485ee781fcfcc2e8335093ece985d8366d3906b DIFF: https://github.com/llvm/llvm-project/commit/8485ee781fcfcc2e8335093ece985d8366d3906b.diff

[Lldb-commits] [lldb] 62286c5 - [lldb/test] Remove a double debugserver launch in TestGdbRemoteGPacket

Author: Pavel Labath Date: 2020-10-30T14:27:50+01:00 New Revision: 62286c569d84c81236522c386a67e60f8f333f63 URL: https://github.com/llvm/llvm-project/commit/62286c569d84c81236522c386a67e60f8f333f63 DIFF: https://github.com/llvm/llvm-project/commit/62286c569d84c81236522c386a67e60f8f333f63.diff

[Lldb-commits] [lldb] a895a44 - [lldb/test] Simplify/generalize YAMLModuleTester

Author: Pavel Labath Date: 2020-10-30T14:27:50+01:00 New Revision: a895a446bcde4d78572ced8ff0b559f476aa4274 URL: https://github.com/llvm/llvm-project/commit/a895a446bcde4d78572ced8ff0b559f476aa4274 DIFF: https://github.com/llvm/llvm-project/commit/a895a446bcde4d78572ced8ff0b559f476aa4274.diff

[Lldb-commits] [lldb] 8cc49be - [lldb] Use reverse connection method for lldb-server tests

Author: Pavel Labath Date: 2020-10-29T13:49:51+01:00 New Revision: 8cc49bec2e067808e4b4d091a351fd66616d7b18 URL: https://github.com/llvm/llvm-project/commit/8cc49bec2e067808e4b4d091a351fd66616d7b18 DIFF: https://github.com/llvm/llvm-project/commit/8cc49bec2e067808e4b4d091a351fd66616d7b18.diff

[Lldb-commits] [lldb] 97ca9ca - [lldb] Fix bitfield "frame var" for pointers (pr47743)

Author: Pavel Labath Date: 2020-10-26T12:01:20+01:00 New Revision: 97ca9ca180f0810adcc1637d1a6dd32a04f63cfe URL: https://github.com/llvm/llvm-project/commit/97ca9ca180f0810adcc1637d1a6dd32a04f63cfe DIFF: https://github.com/llvm/llvm-project/commit/97ca9ca180f0810adcc1637d1a6dd32a04f63cfe.diff

[Lldb-commits] [lldb] e4cc6e9 - [lldb] Modernize PseudoTerminal::Fork

Author: Pavel Labath Date: 2020-10-26T12:01:20+01:00 New Revision: e4cc6e9bcdff5fe979ab72025cb803d723cd9c31 URL: https://github.com/llvm/llvm-project/commit/e4cc6e9bcdff5fe979ab72025cb803d723cd9c31 DIFF: https://github.com/llvm/llvm-project/commit/e4cc6e9bcdff5fe979ab72025cb803d723cd9c31.diff

[Lldb-commits] [lldb] d900b75 - [lldb] Fix windows build for fa5fa63fd140f

Author: Pavel Labath Date: 2020-10-21T17:51:11+02:00 New Revision: d900b755ed003967d1c9675b62293414831db1b6 URL: https://github.com/llvm/llvm-project/commit/d900b755ed003967d1c9675b62293414831db1b6 DIFF: https://github.com/llvm/llvm-project/commit/d900b755ed003967d1c9675b62293414831db1b6.diff

[Lldb-commits] [lldb] fa5fa63 - [lldb] Port lldb gdb-server to libOption

Author: Pavel Labath Date: 2020-10-21T16:16:18+02:00 New Revision: fa5fa63fd140f2d4bad0357839378606a583b32c URL: https://github.com/llvm/llvm-project/commit/fa5fa63fd140f2d4bad0357839378606a583b32c DIFF: https://github.com/llvm/llvm-project/commit/fa5fa63fd140f2d4bad0357839378606a583b32c.diff

[Lldb-commits] [lldb] dfb2266 - [lldb] Make DW_AT_declaration-with-children.s test more realistic

Author: Pavel Labath Date: 2020-10-19T10:34:13+02:00 New Revision: dfb22663287602a90ba249a96c9916227430a99e URL: https://github.com/llvm/llvm-project/commit/dfb22663287602a90ba249a96c9916227430a99e DIFF: https://github.com/llvm/llvm-project/commit/dfb22663287602a90ba249a96c9916227430a99e.diff

[Lldb-commits] [lldb] daae4a8 - [lldb] Modernize PseudoTerminal::OpenSecondary

Author: Pavel Labath Date: 2020-10-16T15:22:55+02:00 New Revision: daae4a84828b131395c531cd5604dc013d9073b6 URL: https://github.com/llvm/llvm-project/commit/daae4a84828b131395c531cd5604dc013d9073b6 DIFF: https://github.com/llvm/llvm-project/commit/daae4a84828b131395c531cd5604dc013d9073b6.diff

[Lldb-commits] [lldb] a1ab2b7 - [lldb] More memory allocation test fixes

Author: Pavel Labath Date: 2020-10-14T20:43:47+02:00 New Revision: a1ab2b773b6d78ec71edfebd2474c403cbe77977 URL: https://github.com/llvm/llvm-project/commit/a1ab2b773b6d78ec71edfebd2474c403cbe77977 DIFF: https://github.com/llvm/llvm-project/commit/a1ab2b773b6d78ec71edfebd2474c403cbe77977.diff

[Lldb-commits] [lldb] 36f22cd - [lldb] Fix TestGdbRemoteMemoryAllocation on windows

Author: Pavel Labath Date: 2020-10-14T16:46:10+02:00 New Revision: 36f22cd28d5e57c197ea374048a06dbdc5a08214 URL: https://github.com/llvm/llvm-project/commit/36f22cd28d5e57c197ea374048a06dbdc5a08214 DIFF: https://github.com/llvm/llvm-project/commit/36f22cd28d5e57c197ea374048a06dbdc5a08214.diff

[Lldb-commits] [lldb] ea3a547 - [lldb] Remove bogus ProcessMonitor forward-decls

Author: Pavel Labath Date: 2020-10-14T16:43:45+02:00 New Revision: ea3a547f0be20d86b041778ae8e2779f2031f714 URL: https://github.com/llvm/llvm-project/commit/ea3a547f0be20d86b041778ae8e2779f2031f714 DIFF: https://github.com/llvm/llvm-project/commit/ea3a547f0be20d86b041778ae8e2779f2031f714.diff

[Lldb-commits] [lldb] 2c4226f - [lldb-server][linux] Add ability to allocate memory

Author: Pavel Labath Date: 2020-10-14T15:02:09+02:00 New Revision: 2c4226f8ac2c925d7e1d59d1de1660cd1dd63f31 URL: https://github.com/llvm/llvm-project/commit/2c4226f8ac2c925d7e1d59d1de1660cd1dd63f31 DIFF: https://github.com/llvm/llvm-project/commit/2c4226f8ac2c925d7e1d59d1de1660cd1dd63f31.diff

[Lldb-commits] [lldb] 6bb123b - [lldb] Modernize PseudoTerminal::OpenFirstAvailablePrimary

Author: Pavel Labath Date: 2020-10-14T14:55:03+02:00 New Revision: 6bb123b819c61c61197ec2ba54ceb6d16e9121cf URL: https://github.com/llvm/llvm-project/commit/6bb123b819c61c61197ec2ba54ceb6d16e9121cf DIFF: https://github.com/llvm/llvm-project/commit/6bb123b819c61c61197ec2ba54ceb6d16e9121cf.diff

[Lldb-commits] [lldb] e2f1fe3 - [lldb/Utility] Introduce UnimplementedError

Author: Pavel Labath Date: 2020-10-12T13:46:17+02:00 New Revision: e2f1fe361a9c7616a1d6459b036d15f47da4a073 URL: https://github.com/llvm/llvm-project/commit/e2f1fe361a9c7616a1d6459b036d15f47da4a073 DIFF: https://github.com/llvm/llvm-project/commit/e2f1fe361a9c7616a1d6459b036d15f47da4a073.diff

[Lldb-commits] [lldb] 0610a25 - [lldb] Delete copy operations on PluginInterface class

Author: Pavel Labath Date: 2020-10-09T10:37:09+02:00 New Revision: 0610a25a85a0a204c994331e1ab275f86010f9ad URL: https://github.com/llvm/llvm-project/commit/0610a25a85a0a204c994331e1ab275f86010f9ad DIFF: https://github.com/llvm/llvm-project/commit/0610a25a85a0a204c994331e1ab275f86010f9ad.diff

[Lldb-commits] [lldb] 19d6413 - [lldb] Fix "frame var" for large bitfields

Author: Pavel Labath Date: 2020-10-08T18:42:50+02:00 New Revision: 19d64138e6a708d1d0571da3ac51e1b4777c2b47 URL: https://github.com/llvm/llvm-project/commit/19d64138e6a708d1d0571da3ac51e1b4777c2b47 DIFF: https://github.com/llvm/llvm-project/commit/19d64138e6a708d1d0571da3ac51e1b4777c2b47.diff

[Lldb-commits] [lldb] d4a7c70 - [lldb] Add a cmake warning about the python/swig incompatibility

Author: Pavel Labath Date: 2020-10-08T18:42:50+02:00 New Revision: d4a7c70751cf5c0b0ce344555e3966ddc80290d2 URL: https://github.com/llvm/llvm-project/commit/d4a7c70751cf5c0b0ce344555e3966ddc80290d2 DIFF: https://github.com/llvm/llvm-project/commit/d4a7c70751cf5c0b0ce344555e3966ddc80290d2.diff

Re: [Lldb-commits] [lldb] 81b11c9 - Fix a macOS build break caused by 3dfb94986170.

On 08/10/2020 00:01, Jim Ingham via lldb-commits wrote: Author: Jim Ingham Date: 2020-10-07T15:01:27-07:00 New Revision: 81b11c91070f3a969b64b2c2e6011b02450fa75f URL: https://github.com/llvm/llvm-project/commit/81b11c91070f3a969b64b2c2e6011b02450fa75f DIFF:

[Lldb-commits] [lldb] 3dfb949 - [lldb] Check for and use ptsname_r if available

Author: Pavel Labath Date: 2020-10-07T15:29:29+02:00 New Revision: 3dfb94986170c57d9b3f5f2cba039a2eab5e6f13 URL: https://github.com/llvm/llvm-project/commit/3dfb94986170c57d9b3f5f2cba039a2eab5e6f13 DIFF: https://github.com/llvm/llvm-project/commit/3dfb94986170c57d9b3f5f2cba039a2eab5e6f13.diff

[Lldb-commits] [lldb] 029290f - [lldb/docs] Clarify python/swig version incompatibility

Author: Pavel Labath Date: 2020-10-07T15:29:29+02:00 New Revision: 029290f1a6231507b82981d56c0a0d2b02d508e0 URL: https://github.com/llvm/llvm-project/commit/029290f1a6231507b82981d56c0a0d2b02d508e0 DIFF: https://github.com/llvm/llvm-project/commit/029290f1a6231507b82981d56c0a0d2b02d508e0.diff

Re: [Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

On 01/10/2020 20:57, Walter wrote: >> - I am surprised that it was not necessary to create a special process > plugin for this purpose. I have a feeling one will be necessary sooner > or later because of the need to customize the step/continue/etc. flows. > Currently, this will probably produce

Re: [Lldb-commits] [lldb] 92e1ebe - [trace] Fix destructor declaration

On 30/09/2020 20:25, Walter Erquinigo wrote: > But what about the case Vedant mentioned? > >>Otherwise, when a std::shared_ptr is destroyed, the destructor for >> the derived TraceIntelPT instance won't run. > > Or is C++ smart enough to pick the destructor from TraceIntelPT class in this

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

On 30/09/2020 23:21, Jim Ingham wrote: > The test doesn’t seem to be flakey in the “run it a bunch of times and > it will eventually fail” type flakey.  I ran the test 200 times on my > machine and didn’t get a failure. Actually, it seems like exactly the typical kind of flaky test to me -- it

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

On 30/09/2020 20:45, Jim Ingham wrote: > I also used to get e-mails when a test failed and I was on the changes list. > But I haven’t gotten any failure e-mails. Does that only happen for some of > the bots (or has that stopped working) or should I look to my filters? > > Jim > You didn't

Re: [Lldb-commits] [lldb] 92e1ebe - [trace] Fix destructor declaration

On 29/09/2020 22:09, Walter Erquinigo via lldb-commits wrote: > The destructor must be defined in the implementation class so that it > can be called That doesn't sound right. Each class automatically gets a destructor if it does not declare one itself. "~Foo() override = default" is completely

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

It looks like the new test (TestStopHookScripted.py) is flaky: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/18360/steps/test/logs/stdio http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/9484/steps/test/logs/stdio

[Lldb-commits] [lldb] af3789a - [lldb] Improve qemu interop for aarch64

Author: Pavel Labath Date: 2020-09-15T13:32:08+02:00 New Revision: af3789a188116e400dd021bae54d91dc543aca7d URL: https://github.com/llvm/llvm-project/commit/af3789a188116e400dd021bae54d91dc543aca7d DIFF: https://github.com/llvm/llvm-project/commit/af3789a188116e400dd021bae54d91dc543aca7d.diff

[Lldb-commits] [lldb] 0a2213c - [lldb/cmake] Fix testing support library dependencies

Author: Pavel Labath Date: 2020-09-15T13:32:08+02:00 New Revision: 0a2213c6eb24c9deec738e30509815e5bddd860c URL: https://github.com/llvm/llvm-project/commit/0a2213c6eb24c9deec738e30509815e5bddd860c DIFF: https://github.com/llvm/llvm-project/commit/0a2213c6eb24c9deec738e30509815e5bddd860c.diff

Re: [Lldb-commits] [lldb] 0e86f39 - [lldb/test] Fix TestPlatform*.py Windows failures (NFC)

On 02/09/2020 21:42, Med Ismail Bennani via lldb-commits wrote: > +#if defined(_WIN32) || defined(_WIN64) BTW, _WIN32 is also defined for 64 bit windows systems -- the macro really means "_not_ win16" rather than what the name would imply. pl ___

[Lldb-commits] [lldb] 9b50546 - [lldb/Utility] Polish the Scalar class

Author: Pavel Labath Date: 2020-08-28T11:51:25+02:00 New Revision: 9b50546b0b4087ec2ee8479d68e70b89c7956aaa URL: https://github.com/llvm/llvm-project/commit/9b50546b0b4087ec2ee8479d68e70b89c7956aaa DIFF: https://github.com/llvm/llvm-project/commit/9b50546b0b4087ec2ee8479d68e70b89c7956aaa.diff

[Lldb-commits] [lldb] 1f9595e - [lldb] Reduce intentation in SymbolFileDWARF::ParseVariableDIE

Author: Pavel Labath Date: 2020-08-28T11:44:03+02:00 New Revision: 1f9595ede48d694b8506d22fd71f7ce13e00dafa URL: https://github.com/llvm/llvm-project/commit/1f9595ede48d694b8506d22fd71f7ce13e00dafa DIFF: https://github.com/llvm/llvm-project/commit/1f9595ede48d694b8506d22fd71f7ce13e00dafa.diff

[Lldb-commits] [lldb] dd63506 - [lldb/cmake] Fix linking of lldbSymbolHelpers for 9cb222e7

Author: Pavel Labath Date: 2020-08-27T16:40:17+02:00 New Revision: dd635062d867835cfe893698161277cc251b4456 URL: https://github.com/llvm/llvm-project/commit/dd635062d867835cfe893698161277cc251b4456 DIFF: https://github.com/llvm/llvm-project/commit/dd635062d867835cfe893698161277cc251b4456.diff

[Lldb-commits] [lldb] 5b2b754 - [lldb/cmake] Fix linking of lldbUtilityHelpers for 9cb222e74

Author: Pavel Labath Date: 2020-08-27T16:06:59+02:00 New Revision: 5b2b754565602a8b49b68967e1810f592f175d6b URL: https://github.com/llvm/llvm-project/commit/5b2b754565602a8b49b68967e1810f592f175d6b DIFF: https://github.com/llvm/llvm-project/commit/5b2b754565602a8b49b68967e1810f592f175d6b.diff

[Lldb-commits] [lldb] 0de1463 - [lldb] Fix Type::GetByteSize for pointer types

Author: Pavel Labath Date: 2020-08-27T15:37:49+02:00 New Revision: 0de1463373918ae424cdcfeaa5b318f45c528696 URL: https://github.com/llvm/llvm-project/commit/0de1463373918ae424cdcfeaa5b318f45c528696 DIFF: https://github.com/llvm/llvm-project/commit/0de1463373918ae424cdcfeaa5b318f45c528696.diff

[Lldb-commits] [lldb] 9cb222e - [cmake] Make gtest include directories a part of the library interface

Author: Pavel Labath Date: 2020-08-27T15:35:57+02:00 New Revision: 9cb222e749e8392517a138cf6645a7c220d671c8 URL: https://github.com/llvm/llvm-project/commit/9cb222e749e8392517a138cf6645a7c220d671c8 DIFF: https://github.com/llvm/llvm-project/commit/9cb222e749e8392517a138cf6645a7c220d671c8.diff

[Lldb-commits] [lldb] 9f5927e - [lldb/DWARF] Fix handling of variables with both location and const_value attributes

Author: Pavel Labath Date: 2020-08-27T15:05:47+02:00 New Revision: 9f5927e42bf4a7448dc9dd3a1550d1126c595dad URL: https://github.com/llvm/llvm-project/commit/9f5927e42bf4a7448dc9dd3a1550d1126c595dad DIFF: https://github.com/llvm/llvm-project/commit/9f5927e42bf4a7448dc9dd3a1550d1126c595dad.diff

[Lldb-commits] [lldb] 219ccdf - [lldb/Utility] Use APSInt in the Scalar class

Author: Pavel Labath Date: 2020-08-27T15:05:47+02:00 New Revision: 219ccdfddecb963971ad14b5c14220b896d2c2e7 URL: https://github.com/llvm/llvm-project/commit/219ccdfddecb963971ad14b5c14220b896d2c2e7 DIFF: https://github.com/llvm/llvm-project/commit/219ccdfddecb963971ad14b5c14220b896d2c2e7.diff

[Lldb-commits] [lldb] 8298230 - [lldb/DWARF] More DW_AT_const_value fixes

Author: Pavel Labath Date: 2020-08-26T13:17:26+02:00 New Revision: 82982304d7095891b10faacdbf9b4eb73e92a92f URL: https://github.com/llvm/llvm-project/commit/82982304d7095891b10faacdbf9b4eb73e92a92f DIFF: https://github.com/llvm/llvm-project/commit/82982304d7095891b10faacdbf9b4eb73e92a92f.diff

[Lldb-commits] [lldb] 0e301fd - [lldb/Utility] Remove some Scalar type accessors

Author: Pavel Labath Date: 2020-08-24T11:45:30+02:00 New Revision: 0e301fd02386e01ca93a28e8c0484447fbb440a1 URL: https://github.com/llvm/llvm-project/commit/0e301fd02386e01ca93a28e8c0484447fbb440a1 DIFF: https://github.com/llvm/llvm-project/commit/0e301fd02386e01ca93a28e8c0484447fbb440a1.diff

[Lldb-commits] [lldb] 8a8a2dd - [lldb/Utility] Simplify Scalar handling of float types

Author: Pavel Labath Date: 2020-08-20T16:26:02+02:00 New Revision: 8a8a2dd3165e63b29e725526745427c6434f0654 URL: https://github.com/llvm/llvm-project/commit/8a8a2dd3165e63b29e725526745427c6434f0654 DIFF: https://github.com/llvm/llvm-project/commit/8a8a2dd3165e63b29e725526745427c6434f0654.diff

[Lldb-commits] [lldb] 9109311 - [lldb] Forcefully complete a type when adding typedefs

Author: Pavel Labath Date: 2020-08-20T15:19:10+02:00 New Revision: 9109311356cc9e74818dd7450020d9b85d2f8125 URL: https://github.com/llvm/llvm-project/commit/9109311356cc9e74818dd7450020d9b85d2f8125 DIFF: https://github.com/llvm/llvm-project/commit/9109311356cc9e74818dd7450020d9b85d2f8125.diff

[Lldb-commits] [lldb] 9cc2f13 - [lldb] Clean up DW_AT_declaration-with-children.s test

Author: Pavel Labath Date: 2020-08-19T14:58:50+02:00 New Revision: 9cc2f13deeb30de3a2ce1854c36f6c0a8de86d6c URL: https://github.com/llvm/llvm-project/commit/9cc2f13deeb30de3a2ce1854c36f6c0a8de86d6c DIFF: https://github.com/llvm/llvm-project/commit/9cc2f13deeb30de3a2ce1854c36f6c0a8de86d6c.diff

[Lldb-commits] [lldb] d736339 - [lldb] Add typedefs to the DeclContext they are created in

Author: Pavel Labath Date: 2020-08-19T14:57:43+02:00 New Revision: d7363397c669f611e379988ea12fb428847fce61 URL: https://github.com/llvm/llvm-project/commit/d7363397c669f611e379988ea12fb428847fce61 DIFF: https://github.com/llvm/llvm-project/commit/d7363397c669f611e379988ea12fb428847fce61.diff

[Lldb-commits] [lldb] 67cdb89 - [lldb/Utility] Simplify and generalize Scalar class

Author: Pavel Labath Date: 2020-08-17T11:09:56+02:00 New Revision: 67cdb899c6b3ec231f35ca17a00023758ef127ba URL: https://github.com/llvm/llvm-project/commit/67cdb899c6b3ec231f35ca17a00023758ef127ba DIFF: https://github.com/llvm/llvm-project/commit/67cdb899c6b3ec231f35ca17a00023758ef127ba.diff

[Lldb-commits] [lldb] 2d89a3b - [lldb] Forcefully complete a type when adding nested classes

Author: Pavel Labath Date: 2020-08-17T11:09:13+02:00 New Revision: 2d89a3ba121b96a4af9aecaf52205eab200394c3 URL: https://github.com/llvm/llvm-project/commit/2d89a3ba121b96a4af9aecaf52205eab200394c3 DIFF: https://github.com/llvm/llvm-project/commit/2d89a3ba121b96a4af9aecaf52205eab200394c3.diff

<    4   5   6   7   8   9   10   11   12   13   >