[virtio-dev] Re: [PATCH v21] virtio-net: support inner header hash

2023-07-12 Thread Cornelia Huck
On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: > On Wed, Jul 12, 2023 at 02:22:26PM +0200, Cornelia Huck wrote: >> On Mon, Jul 03 2023, Heng Qi wrote: >> >> (...) >> >> > +\paragraph{Inner Header Hash} >> > +\label{sec:Device

Re: [virtio-dev] Re: [PATCH v12] virtio-net: support device stats

2023-07-12 Thread Cornelia Huck
On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: > On Wed, Jul 12, 2023 at 07:44:01PM +0800, Xuan Zhuo wrote: >> On Wed, 12 Jul 2023 07:34:38 -0400, "Michael S. Tsirkin" >> wrote: >> > On Tue, Mar 15, 2022 at 11:24:02AM +0800, Xuan Zhuo wrote: >> > > This patch allows the driver to obtain some

[virtio-dev] Re: [PATCH v21] virtio-net: support inner header hash

2023-07-12 Thread Cornelia Huck
On Mon, Jul 03 2023, Heng Qi wrote: (...) > +\paragraph{Inner Header Hash} > +\label{sec:Device Types / Network Device / Device Operation / Processing of > Incoming Packets / Inner Header Hash} > + > +If VIRTIO_NET_F_HASH_TUNNEL has been negotiated, the driver can send the > command >

RE: [RFC PATCH v4 02/24] Update linux-header per VFIO device cdev v14

2023-07-12 Thread Cornelia Huck
On Wed, Jul 12 2023, "Duan, Zhenzhong" wrote: >>-Original Message- >>From: Cornelia Huck >>Sent: Wednesday, July 12, 2023 3:49 PM >>Subject: Re: [RFC PATCH v4 02/24] Update linux-header per VFIO device cdev >>v14 >> >>On Wed, J

Re: [RFC PATCH v4 02/24] Update linux-header per VFIO device cdev v14

2023-07-12 Thread Cornelia Huck
On Wed, Jul 12 2023, Zhenzhong Duan wrote: > Signed-off-by: Zhenzhong Duan > --- > linux-headers/linux/iommufd.h | 347 ++ > linux-headers/linux/kvm.h | 13 +- > linux-headers/linux/vfio.h| 142 +- > 3 files changed, 498 insertions(+), 4

[virtio-dev] Re: [PATCH v14] admin: Add group member legacy register access commands

2023-07-11 Thread Cornelia Huck
On Mon, Jul 10 2023, "Michael S. Tsirkin" wrote: > On Mon, Jul 10, 2023 at 07:17:52PM +0300, Parav Pandit wrote: >> +The \field{flags} value of 0x1 indicates that the notification address is of >> +the owner device, value of 0x2 indicates that the notification address is of >> +the member

Re: [virtio-dev] [PATCH v13] admin: Add group member legacy register access commands

2023-07-10 Thread Cornelia Huck
On Fri, Jul 07 2023, Parav Pandit wrote: (...) > +When the device supports VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_INFO command, the > group s/supports/supports the/ > +owner device hardwires VF BAR0 to zero in the SR-IOV Extended capability. (...) > +\devicenormative{\paragraph}{Legacy

Re: [virtio-dev][PATCH 1/2] virtio-spi: define the DEVICE ID for virtio SPI master

2023-07-10 Thread Cornelia Huck
On Fri, Jul 07 2023, Haixu Cui wrote: > Hi Michael S. Tsirkin, Cornelia Huck, > I have created an issue > https://github.com/oasis-tcs/virtio-spec/issues/174 to request Device ID > 45 for SPI master. Please help to deal with it, thank you very much. Technically, we're in fe

Re: [PATCH 1/1] linux-headers: update to v6.5-rc1

2023-07-10 Thread Cornelia Huck
/mman.h| 14 ++ > linux-headers/linux/psp-sev.h | 7 + > linux-headers/linux/userfaultfd.h | 17 ++- > linux-headers/linux/vfio.h| 27 > linux-headers/linux/vhost.h | 31 > 32 files changed, 423 insertions(+), 154 deletions(-) Acked-by: Cornelia Huck

[virtio-dev] Re: [PATCH v12 0/3] admin: Access legacy registers using admin commands

2023-07-07 Thread Cornelia Huck
On Fri, Jul 07 2023, Parav Pandit wrote: > This short series introduces legacy registers access commands for the owner > group member access the legacy registers of the member VFs. > This short series introduces legacy region access commands by the group owner > device for its member devices. >

[virtio-dev] Re: [PATCH v11 0/3] admin: Access legacy registers using admin commands

2023-07-07 Thread Cornelia Huck
On Thu, Jul 06 2023, "Michael S. Tsirkin" wrote: > On Fri, Jul 07, 2023 at 12:27:19AM +0300, Parav Pandit wrote: >> This short series introduces legacy registers access commands for the owner >> group member access the legacy registers of the member VFs. >> This short series introduces legacy

[virtio-dev] Re: [virtio-comment] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-07 Thread Cornelia Huck
On Thu, Jul 06 2023, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Thursday, July 6, 2023 4:42 PM > > [..] >> > Can we please avoid this over engineering? >> > Interface has the doors open for driver to make wise decision depending on >> its environment. >> >> what if driver can

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Cornelia Huck
On Thu, Jul 06 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Thursday, July 6, 2023 12:28 PM >> >> On Thu, Jul 06 2023, Parav Pandit wrote: >> >> > diff --git a/transport-pci-legacy-regs.tex >> > b/transport-pci-legacy-regs.tex

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Cornelia Huck
On Thu, Jul 06 2023, Parav Pandit wrote: > diff --git a/transport-pci-legacy-regs.tex b/transport-pci-legacy-regs.tex > new file mode 100644 > index 000..ceea28c > --- /dev/null > +++ b/transport-pci-legacy-regs.tex > @@ -0,0 +1,42 @@ > +\subsection{Legacy Interface: Group member device

[virtio-dev] Re: [PATCH v10 3/4] admin: Add group member legacy register access commands

2023-07-06 Thread Cornelia Huck
On Thu, Jul 06 2023, Parav Pandit wrote: > diff --git a/admin-cmds-legacy-interface.tex b/admin-cmds-legacy-interface.tex > new file mode 100644 > index 000..dd01c0a > --- /dev/null > +++ b/admin-cmds-legacy-interface.tex > @@ -0,0 +1,261 @@ > +\subsubsection{Legacy

[virtio-dev] Re: [PATCH v10 2/4] admin: Fix section numbering

2023-07-06 Thread Cornelia Huck
ion > v4->v5: > - new patch > --- > admin.tex | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional

[virtio-dev] RE: [virtio-comment] [PATCH v9 0/4] admin: Access legacy registers using admin commands

2023-07-05 Thread Cornelia Huck
On Wed, Jul 05 2023, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Wednesday, July 5, 2023 7:09 AM >> >> OK I sent a bunch of comments. Pls try to address, unfortunately I didn't go >> in >> depth over the last patch, but I feel it should be squashed into the generic >> legacy

[virtio-dev] Re: [PATCH v9 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-05 Thread Cornelia Huck
On Wed, Jul 05 2023, Parav Pandit wrote: > diff --git a/admin-cmds-legacy-interface.tex b/admin-cmds-legacy-interface.tex > index 09001d5..571b256 100644 > --- a/admin-cmds-legacy-interface.tex > +++ b/admin-cmds-legacy-interface.tex > @@ -150,7 +150,7 @@ \subsubsection{Legacy

[virtio-dev] Re: [PATCH v9 3/4] admin: Add group member legacy register access commands

2023-07-05 Thread Cornelia Huck
On Wed, Jul 05 2023, Parav Pandit wrote: > diff --git a/admin-cmds-legacy-interface.tex b/admin-cmds-legacy-interface.tex > new file mode 100644 > index 000..09001d5 > --- /dev/null > +++ b/admin-cmds-legacy-interface.tex > @@ -0,0 +1,205 @@ > +\subsubsection{Legacy

[virtio-dev] Re: [PATCH v9 2/4] admin: Fix section numbering

2023-07-05 Thread Cornelia Huck
On Wed, Jul 05 2023, Parav Pandit wrote: > Requirements are put one additional level down. Fix it. > > Signed-off-by: Parav Pandit > --- > changelog: > v4->v5: > - new patch > --- > admin.tex | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Same thing applies to the normative

[virtio-dev] Re: [PATCH v9 1/4] admin: Split opcode table rows with a line

2023-07-05 Thread Cornelia Huck
changed, 2 insertions(+) > Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

Re: [PATCH v1 4/5] arm/kvm: add skeleton implementation for userspace SMCCC call handling

2023-07-04 Thread Cornelia Huck
On Mon, Jun 26 2023, Shaoqin Huang wrote: > The SMCCC call filtering provide the ability to forward the SMCCC call > to userspace, so we provide a new option `user-smccc` to enable handling > SMCCC call in userspace, the default value is off. > > And add the skeleton implementation for userspace

Re: [PATCH v1 2/5] linux-headers: Import arm-smccc.h from Linux v6.4-rc7

2023-07-04 Thread Cornelia Huck
On Mon, Jun 26 2023, Shaoqin Huang wrote: > Copy in the SMCCC definitions from the kernel, which will be used to > implement SMCCC handling in userspace. > > Signed-off-by: Shaoqin Huang > --- > linux-headers/linux/arm-smccc.h | 240 > 1 file changed, 240

[virtio-dev] Re: [PATCH v21] virtio-net: support inner header hash

2023-07-04 Thread Cornelia Huck
On Mon, Jul 03 2023, "Michael S. Tsirkin" wrote: > On Mon, Jul 03, 2023 at 11:27:11PM +0800, Heng Qi wrote: >> 1. Currently, a received encapsulated packet has an outer and an inner >> header, but >> the virtio device is unable to calculate the hash for the inner header. The >> same >> flow

[virtio-dev] [virtio 1.3] Feature freeze has started

2023-07-03 Thread Cornelia Huck
As outlined in https://lists.oasis-open.org/archives/virtio/202304/msg00036.html ff., as part of the release process for the 1.3 version of the virtio spec, we have now entered feature freeze. This means: *** By July 1st[3rd], all not yet integrated features that are targeting 1.3 need to have at

Re: [PATCH v4 1/6] update-linux-headers: sync-up header with Linux for KVM AIA support placeholder

2023-06-30 Thread Cornelia Huck
On Fri, Jun 30 2023, Daniel Henrique Barboza wrote: > On 6/21/23 11:54, Yong-Xuan Wang wrote: >> Sync-up Linux header to get latest KVM RISC-V headers having AIA support. >> >> Note: This is a placeholder commit and could be replaced when all referenced >> Linux patchsets are mainlined. >> >>

[virtio-dev] Re: [virtio-comment] [RFC] virtio 1.3 schedule

2023-06-30 Thread Cornelia Huck
On Thu, Jun 29 2023, "Michael S. Tsirkin" wrote: > On Thu, Jun 29, 2023 at 05:41:34PM +, Parav Pandit wrote: >> Hi Cornelia, Michael, >> >> > From: virtio-comm...@lists.oasis-open.org > > open.org> On Behalf Of Cornelia Huck >> > Sent: W

[virtio-dev] [virtio 1.3] Reminder: Feature freeze coming up on July 1st

2023-06-05 Thread Cornelia Huck
As outlined in https://lists.oasis-open.org/archives/virtio/202304/msg00036.html ff., we'll soon start the process of getting version 1.3 of the virtio spec released. As a first step, we'll enter feature freeze on July 1st. This means: *** By July 1st, all not yet integrated features that are

Re: [PATCH 1/2] linux-headers: Update with vfio_ap IRQ index mapping

2023-05-31 Thread Cornelia Huck
On Wed, May 31 2023, Anthony Krowiak wrote: > On 5/30/23 8:56 PM, Matthew Rosato wrote: >> On 5/30/23 6:55 PM, Tony Krowiak wrote: >>> Signed-off-by: Tony Krowiak >>> --- >>> linux-headers/linux/vfio.h | 9 + >>> 1 file changed, 9 insertions(+) >> >> Worth nothing here that

Re: [PTACH v2 1/6] update-linux-headers: sync-up header with Linux for KVM AIA support

2023-05-23 Thread Cornelia Huck
On Tue, May 23 2023, Yong-Xuan Wang wrote: > On Mon, May 8, 2023 at 3:39 PM Cornelia Huck wrote: >> >> On Fri, May 05 2023, Alex Williamson wrote: >> >> > On Fri, 5 May 2023 11:39:36 + >> > Yong-Xuan Wang wrote: >> > >> >> U

Re: [PATCH v7 0/1] arm: enable MTE for QEMU + kvm

2023-05-22 Thread Cornelia Huck
On Fri, Apr 28 2023, Cornelia Huck wrote: > Another open problem is mte vs mte3: tcg emulates mte3, kvm gives the guest > whatever the host supports. Without migration support, this is not too much > of a problem yet, but for compatibility handling, we'll need a way to keep > QEMU

Re: [PATCH 0/4] Introduce ARM MTE feature

2023-05-22 Thread Cornelia Huck
On Wed, May 17 2023, Andrea Bolognani wrote: > On Wed, May 17, 2023 at 11:19:17AM +0200, Cornelia Huck wrote: >> This has been through some iterations... we (as in people working on >> this in QEMU) need to decide on where to go with cpu features, cpu >> models, etc. on A

Re: [libvirt PATCH 0/4] Revert MTE support

2023-05-22 Thread Cornelia Huck
data/aarch64-gic-v3.args| 2 +- > tests/qemuxml2argvdata/aarch64-gic-v3.xml | 1 - > .../aarch64-gic-v3.aarch64-latest.xml | 1 - > 16 files changed, 10 insertions(+), 53 deletions(-) FWIW, Reviewed-by: Cornelia Huck

Re: [PULL 04/29] arm/kvm: add support for MTE

2023-05-22 Thread Cornelia Huck
On Fri, May 19 2023, Peter Maydell wrote: > On Fri, 19 May 2023 at 14:31, Peter Maydell wrote: >> >> On Fri, 19 May 2023 at 13:55, Alex Bennée wrote: >> > >> > >> > Peter Maydell writes: >> > >> > > From: Cornelia Huck >> &

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-05-17 Thread Cornelia Huck
>>> I also hope to be able to update virtio-video at a faster pace. Please >>> let me try. >> >> Please hold on a bit - there are two things here. >> >> 1) I'd like to settle the virtio-v4l2/virtio-video argument first to >> make sure we don't get two things clashing head-on. As far as codecs >>

Re: [PATCH 0/4] Introduce ARM MTE feature

2023-05-17 Thread Cornelia Huck
On Wed, May 17 2023, Michal Prívozník wrote: > On 5/16/23 18:32, Andrea Bolognani wrote: >> On Tue, May 16, 2023 at 12:54:12PM +0200, Michal Privoznik wrote: >>> Michal Prívozník (4): >>> conf: Introduce MTE domain feature >>> qemu:: Introduce QEMU_CAPS_MACHINE_VIRT_MTE capability >>>

[virtio-dev] Re: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Cornelia Huck
On Tue, May 16 2023, "Michael S. Tsirkin" wrote: > On Tue, May 16, 2023 at 10:24:12AM +0200, Cornelia Huck wrote: >> On Tue, May 16 2023, "Michael S. Tsirkin" wrote: >> >> > On Tue, May 16, 2023 at 06:01:39AM +0300, Parav Pandit wrote: >> >

[virtio-dev] Re: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Cornelia Huck
On Tue, May 16 2023, "Michael S. Tsirkin" wrote: > On Tue, May 16, 2023 at 06:01:39AM +0300, Parav Pandit wrote: >> diff --git a/content.tex b/content.tex >> index 9df81b8..417d476 100644 >> --- a/content.tex >> +++ b/content.tex >> @@ -26,10 +26,10 @@ \section{\field{Device Status}

[virtio-dev] Re: [PATCH v17 03/11] content: Rename confusing queue_notify_data and vqn names

2023-05-15 Thread Cornelia Huck
On Fri, May 05 2023, Parav Pandit wrote: > diff --git a/content.tex b/content.tex > index 9cf938c..327926f 100644 > --- a/content.tex > +++ b/content.tex > @@ -405,8 +405,12 @@ \section{Driver Notifications} \label{sec:Basic > Facilities of a Virtio Device / > notification to the device. > >

Re: [PATCH 1/4] virtio-dmabuf: introduce virtio-dmabuf

2023-05-08 Thread Cornelia Huck
On Wed, May 03 2023, Albert Esteve wrote: > This API manages objects (in this iteration, > dmabuf fds) that can be shared along different > virtio devices. > > The API allows the different devices to add, > remove and/or retrieve the objects by simply > invoking the public functions that reside

[virtio-dev] Re: [virtio-comment] [PATCH] admin: Fix reference and table formation

2023-05-08 Thread Cornelia Huck
dhat.com/T/#t > > Signed-off-by: Parav Pandit > --- > admin.tex | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Cornelia Huck Let's push this as an editorial change once the main series is merged. -

Re: css_clear_io_interrupt() error handling

2023-05-08 Thread Cornelia Huck
On Mon, May 08 2023, Markus Armbruster wrote: > css_clear_io_interrupt() aborts on unexpected ioctl() errors, and I > wonder whether that's appropriate. Let's have a closer look: > > static void css_clear_io_interrupt(uint16_t subchannel_id, >uint16_t

Re: [PTACH v2 1/6] update-linux-headers: sync-up header with Linux for KVM AIA support

2023-05-08 Thread Cornelia Huck
On Fri, May 05 2023, Alex Williamson wrote: > On Fri, 5 May 2023 11:39:36 + > Yong-Xuan Wang wrote: > >> Update the linux headers to get the latest KVM RISC-V headers with AIA >> support >> by the scripts/update-linux-headers.sh. >> The linux headers is comes from the riscv_aia_v1 branch

Re: [PATCH v7 1/1] arm/kvm: add support for MTE

2023-05-04 Thread Cornelia Huck
On Tue, May 02 2023, Richard Henderson wrote: > On 5/2/23 10:03, Cornelia Huck wrote: >> Has anyone been able to access a real system with MTE? (All the systems >> where I had hoped that MTE would be available didn't have MTE in the end >> so far, so I'd be interested to

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-05-03 Thread Cornelia Huck
On Wed, May 03 2023, Alex Bennée wrote: > Cornelia Huck writes: > >> On Fri, Apr 28 2023, Alexander Gordeev >> wrote: >> >>> On 27.04.23 15:16, Alexandre Courbot wrote: >>>> But in any case, that's irrelevant to the guest-host interface, and I &g

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-05-03 Thread Cornelia Huck
On Fri, Apr 28 2023, Alexander Gordeev wrote: > On 27.04.23 15:16, Alexandre Courbot wrote: >> But in any case, that's irrelevant to the guest-host interface, and I >> think a big part of the disagreement stems from the misconception that >> V4L2 absolutely needs to be used on either the guest

Re: [PATCH v7 1/1] arm/kvm: add support for MTE

2023-05-02 Thread Cornelia Huck
On Mon, May 01 2023, Richard Henderson wrote: > On 4/28/23 18:50, Juan Quintela wrote: >> Pardon my ignorance here, but to try to help with migration. How is >> this mte tag stored? >> - 1 array of 8bits per page of memory >> - 1 array of 64bits per page of memory >> - whatever >> >> Lets

[PATCH v7 1/1] arm/kvm: add support for MTE

2023-04-28 Thread Cornelia Huck
unless requested explicitly. Signed-off-by: Cornelia Huck --- hw/arm/virt.c| 69 +--- target/arm/cpu.c | 9 +++--- target/arm/cpu.h | 4 +++ target/arm/kvm.c | 35 ++ target/arm/kvm64.c | 5 target/arm/kvm_arm.h

[PATCH v7 0/1] arm: enable MTE for QEMU + kvm

2023-04-28 Thread Cornelia Huck
in general.) In any case, I think we'll need a way to inform kvm of it. Tested with kvm selftests on FVP (as I still don't have any hardware with MTE...) and some make check(-tcg) incantations. Hopefully, I haven't (re)- introduced too many issues. Cornelia Huck (1): arm/kvm: add support for MTE hw/

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-04-25 Thread Cornelia Huck
[I'm replying here, as that seems to be the last message in the thread, and my reply hopefully catches everyone interested here.] To do a very high level summary, we have (at least) two use cases for virtio-video, that unfortunately have quite different requirements. Both want to encode/decode

Re: [PATCH 1/6] update-linux-headers: sync-up header with Linux for KVM AIA support

2023-04-24 Thread Cornelia Huck
On Mon, Apr 24 2023, Thomas Huth wrote: > On 24/04/2023 11.07, Yong-Xuan Wang wrote: >> Sync-up Linux header to get latest KVM RISC-V headers having AIA support. >> >> Signed-off-by: Yong-Xuan Wang >> Reviewed-by: Jim Shu >> --- >> linux-headers/linux/kvm.h | 2 ++ >>

Re: [PATCH] kvm: Merge kvm_check_extension() and kvm_vm_check_extension()

2023-04-24 Thread Cornelia Huck
s the returned value, and ensures that SVM is actually > supported. Since QEMU follows the check with kvm_vm_enable_cap(), this > patch should only provide better error reporting. > > [1] > https://www.kernel.org/doc/html/latest/virt/kvm/api.html#kvm-check-extension > [2] https://l

[virtio-dev] Re: [PATCH v1] device-types/multiple: replace queues with enqueues

2023-04-21 Thread Cornelia Huck
On Thu, Apr 20 2023, Parav Pandit wrote: > Queue is a verb and noun both. Replacing it with enqueue avoids > ambiguity around plural queues noun vs verb; similar to virtio fs device > description. > > Acked-by: Michael S. Tsirkin > Signed-off-by: Parav Pandit > --- > changelog: > v0->v1: > -

Re: [PATCH RFC v1 01/10] linux-headers: Add KVM headers for loongarch

2023-04-20 Thread Cornelia Huck
On Thu, Apr 20 2023, Tianrui Zhao wrote: > Add asm-loongarch/kvm.h for loongarch KVM, and update > the linux/kvm.h about loongarch part. The structures in > the header are used as kvm_ioctl arguments. Just a procedural note: It's probably best to explicitly mark this as a placeholder patch

[virtio-dev] Re: [PATCH] device-types/multiple: replace queues with enqueues

2023-04-19 Thread Cornelia Huck
On Tue, Apr 11 2023, Parav Pandit wrote: > Queue is a verb and noun both. Replacing it with enqueue avoids > ambiguity around plural queues noun vs verb; similar to virtio fs device > description. Personally, I don't think this patch adds much, but I don't really mind it, either. > >

Re: [virtio-dev] [PATCH v13 03/11] content: Rename confusing queue_notify_data and vqn names

2023-04-18 Thread Cornelia Huck
On Tue, Apr 18 2023, Halil Pasic wrote: > On Mon, 17 Apr 2023 20:53:32 + > Parav Pandit wrote: > >> > From: Halil Pasic >> > Sent: Sunday, April 16, 2023 11:42 PM > [..] >> > >> > > @@ -1053,9 +1059,9 @@ \subsubsection{Available Buffer >> > > Notifications}\label{sec:Virtio Transport

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] [PATCH v13 03/11] content: Rename confusing queue_notify_data and vqn names

2023-04-18 Thread Cornelia Huck
On Tue, Apr 18 2023, Parav Pandit wrote: >> From: Halil Pasic >> Sent: Tuesday, April 18, 2023 7:40 AM >> >> IMHO VIRTIO_F_NOTIFY_CONFIG_DATA should remain aligned with >> VIRTIO_F_NOTIFICATION_DATA in one way or another. Thus way out would be >> to do something like: >>

Re: [virtio-dev][PATCH 2/2] virtio-spi: add the device specification

2023-04-18 Thread Cornelia Huck
On Mon, Apr 17 2023, Haixu Cui wrote: Meta comment: I think you want to send to virtio-comment (feel free to keep virtio-dev on cc:). > virtio-spi is a virtual SPI master and it allows a guset to operate and > use the physical SPI master controlled by the host. > --- >

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-04-17 Thread Cornelia Huck
On Mon, Apr 17 2023, Alexander Gordeev wrote: > Hi Alexandre, > > Thanks for you letter! Sorry, it took me some time to write an answer. > > First of all I'd like to describe my perspective a little bit because it > seems, that in many cases we (and other people writing their feedbacks) >

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-04-17 Thread Cornelia Huck
On Mon, Apr 17 2023, Alexander Gordeev wrote: > Hello Cornelia, > > On 17.04.23 14:56, Cornelia Huck wrote: >> On Sat, Apr 15 2023, Alexandre Courbot wrote: >> >>> If nobody strongly objects, I think this can be pushed a bit more >>> officially. Cornel

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-04-17 Thread Cornelia Huck
On Sat, Apr 15 2023, Alexandre Courbot wrote: > If nobody strongly objects, I think this can be pushed a bit more > officially. Cornelia, would you consider it for inclusion if I > switched the next version of the specification to use V4L2 as the > host/guest protocol? This may take some more

[virtio-dev] Participation (was: Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names)

2023-04-17 Thread Cornelia Huck
On Mon, Apr 17 2023, "Michael S. Tsirkin" wrote: > I am not saying don't give feedback but I'm saying please help us > all be more organized, feedback time really should be within a > day or two, in rare cases up to a week. Given that there are things like weekends, public holidays, etc. one

[Kernel-packages] [Bug 1838151] Re: Poor quality audio with modern Bluetooth headsets in HSP/HFP. Missing wide band speech support (Bluetooth A2DP codecs).

2023-04-13 Thread Christian Huck
Thank you for your response Konrad. I followed the docs for replacing pulseaudio with pipewire which worked well. Now the bluetooth app offers more codecs to use. I figured out "mSBC" offers the best quality. Compared to A2DP it still sucks and sounds horrible. You dont want to accept this if you

[Touch-packages] [Bug 1838151] Re: Poor quality audio with modern Bluetooth headsets in HSP/HFP. Missing wide band speech support (Bluetooth A2DP codecs).

2023-04-13 Thread Christian Huck
Thank you for your response Konrad. I followed the docs for replacing pulseaudio with pipewire which worked well. Now the bluetooth app offers more codecs to use. I figured out "mSBC" offers the best quality. Compared to A2DP it still sucks and sounds horrible. You dont want to accept this if you

[Desktop-packages] [Bug 1838151] Re: Poor quality audio with modern Bluetooth headsets in HSP/HFP. Missing wide band speech support (Bluetooth A2DP codecs).

2023-04-13 Thread Christian Huck
Thank you for your response Konrad. I followed the docs for replacing pulseaudio with pipewire which worked well. Now the bluetooth app offers more codecs to use. I figured out "mSBC" offers the best quality. Compared to A2DP it still sucks and sounds horrible. You dont want to accept this if you

[Touch-packages] [Bug 1838151] Re: Poor quality audio with modern Bluetooth headsets in HSP/HFP. Missing wide band speech support (Bluetooth A2DP codecs).

2023-04-13 Thread Christian Huck
Hi, now it's 2023 and I still have this problem. Using Mint 21.1 and Teams for Linux. When I switch to A2DP I cannot use the headset mic. When I switch to HFP the sound in conversations is horrible. Would appreciate a fix here. -- You received this bug notification because you are a member of

[Kernel-packages] [Bug 1838151] Re: Poor quality audio with modern Bluetooth headsets in HSP/HFP. Missing wide band speech support (Bluetooth A2DP codecs).

2023-04-13 Thread Christian Huck
Hi, now it's 2023 and I still have this problem. Using Mint 21.1 and Teams for Linux. When I switch to A2DP I cannot use the headset mic. When I switch to HFP the sound in conversations is horrible. Would appreciate a fix here. -- You received this bug notification because you are a member of

[Desktop-packages] [Bug 1838151] Re: Poor quality audio with modern Bluetooth headsets in HSP/HFP. Missing wide band speech support (Bluetooth A2DP codecs).

2023-04-13 Thread Christian Huck
Hi, now it's 2023 and I still have this problem. Using Mint 21.1 and Teams for Linux. When I switch to A2DP I cannot use the headset mic. When I switch to HFP the sound in conversations is horrible. Would appreciate a fix here. -- You received this bug notification because you are a member of

[virtio-dev] Re: [virtio-comment] [RFC] virtio 1.3 schedule

2023-04-12 Thread Cornelia Huck
On Fri, Apr 07 2023, "Michael S. Tsirkin" wrote: > On Wed, Apr 05, 2023 at 03:57:09PM +0200, Cornelia Huck wrote: >> That said, let me propose the following timeline: >> >> - July 1st 2023: enter feature freeze; all proposed changes must at >> least

[virtio-dev] Re: [virtio-comment] [PATCH] introduction: Add missing helping verb

2023-04-12 Thread Cornelia Huck
On Tue, Apr 11 2023, Parav Pandit wrote: > The terminology of Transitional device and driver is missing the helping > verb 'is' similar to other terminologies. > > Hence, add them to complete the sentence. > > Signed-off-by: Parav Pandit > --- > introduction.tex | 4 ++-- > 1 file changed, 2

Re: [virtio-dev] [PATCH v14] virtio-net: support the virtqueue coalescing moderation

2023-04-11 Thread Cornelia Huck
On Tue, Apr 11 2023, "Michael S. Tsirkin" wrote: > On Tue, Apr 11, 2023 at 10:05:11AM +0200, Cornelia Huck wrote: >> On Thu, Mar 23 2023, Heng Qi wrote: >> >> > Hi all! If after reviewing it you feel it meets the necessary >> > requirements, I ki

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names

2023-04-11 Thread Cornelia Huck
On Fri, Apr 07 2023, "Michael S. Tsirkin" wrote: > On Wed, Apr 05, 2023 at 03:58:55PM +, Parav Pandit wrote: >> For sure "cookie" is better than "config_data" and I don't have objection to >> "cookie". >> >> But I disagree to the claim that "identifier" is less good than "cookie". >> >>

[virtio-dev] Re: [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Cornelia Huck
On Mon, Apr 10 2023, "Michael S. Tsirkin" wrote: > On Mon, Apr 10, 2023 at 07:57:08PM +, Parav Pandit wrote: >> >> > From: Michael S. Tsirkin >> > Sent: Monday, April 10, 2023 3:49 PM >> >> > Attribution is nice but Signed-off-by is not that. >> >> Then what is Signed-off-by for virtio

Re: [virtio-dev] [PATCH v14] virtio-net: support the virtqueue coalescing moderation

2023-04-11 Thread Cornelia Huck
On Thu, Mar 23 2023, Heng Qi wrote: > Hi all! If after reviewing it you feel it meets the necessary > requirements, I kindly request a vote. > > Thanks a lot! > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/166 So this has been voted upon and accepted, but we have further discussion

Re: [PATCH 2/2] Add missing Linux kernel headers.

2023-04-05 Thread Cornelia Huck
On Wed, Apr 05 2023, David Turner wrote: > On Wed, Apr 5, 2023 at 3:06 PM Cornelia Huck wrote: > >> On Wed, Apr 05 2023, "David 'Digit' Turner" wrote: >> > The script has then been run against the official >> > 6.2.8 kernel source tree (current stable re

[virtio-dev] [RFC] virtio 1.3 schedule

2023-04-05 Thread Cornelia Huck
The virtio 1.2 spec has been released on July 1st, 2022, so I think we should come up with a plan for the 1.3 release. Given that it took us several months last time, we need to think about declaring freeze during (northern hemisphere) summer if we want to have a release ready before the

Re: [PATCH 2/2] Add missing Linux kernel headers.

2023-04-05 Thread Cornelia Huck
On Wed, Apr 05 2023, "David 'Digit' Turner" wrote: > Add , used by hw/display/virtio-gpu-udmabuf.c > Add , used by qga/commands-posix.c > Add used by kvm-all.c, which requires > the _BITUL() macro definition to be available. > > Without these, QEMU will not compile on Debian 10 systems. Hm, I

[virtio-dev] Re: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names

2023-04-05 Thread Cornelia Huck
On Wed, Apr 05 2023, "Michael S. Tsirkin" wrote: > On Wed, Apr 05, 2023 at 04:06:50AM +0300, Parav Pandit wrote: >> diff --git a/content.tex b/content.tex >> index cd93db2..d5f8026 100644 >> --- a/content.tex >> +++ b/content.tex >> @@ -405,8 +405,18 @@ \section{Driver Notifications}

[virtio-dev] Re: [PATCH v12 02/10] content.tex Replace virtqueue number with index

2023-04-05 Thread Cornelia Huck
ew patch > --- > content.tex | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number

2023-04-04 Thread Cornelia Huck
On Tue, Apr 04 2023, Halil Pasic wrote: > On Tue, 4 Apr 2023 03:07:26 -0400 > "Michael S. Tsirkin" wrote: > >> > 3. Once interrupt moderation series is merged, rename vqn to vq_index. >> > (really vqn reads better even though history say vq index). >> > Because votes is completed and voting

[virtio-dev] Re: [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-04 Thread Cornelia Huck
On Tue, Apr 04 2023, "Michael S. Tsirkin" wrote: > On Tue, Apr 04, 2023 at 09:54:55AM +0200, Cornelia Huck wrote: >> On Tue, Apr 04 2023, "Michael S. Tsirkin" wrote: >> >> > On Fri, Mar 31, 2023 at 01:58:31AM +0300, Parav Pandit wrote: >>

[virtio-dev] RE: [virtio-comment] [PATCH 0/3] transport-pci: msix summary update

2023-04-04 Thread Cornelia Huck
On Mon, Apr 03 2023, Parav Pandit wrote: > Hi Cornelia, > >> From: Xuan Zhuo >> Sent: Monday, March 27, 2023 2:09 AM >> Series: >> >> Reviewed-by: Xuan Zhuo >> > > It is editorial change rewording the text. > Can you please take this short series forward? Patch 1 (which Michael has already

[virtio-dev] Re: [virtio-comment] RE: [PATCH v10 8/8] virtio-net: Describe RSS using rss rq id

2023-04-04 Thread Cornelia Huck
On Mon, Apr 03 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Thursday, March 30, 2023 5:17 AM >> > +Field \field{indirection_table} is an array of receive virtqueues. >> >> "an array of receive virtqueues identified via their rss_rq_i

[virtio-dev] Re: [PATCH v11 00/10] Introduce device group and device management

2023-04-04 Thread Cornelia Huck
On Mon, Apr 03 2023, "Michael S. Tsirkin" wrote: > On Mon, Apr 03, 2023 at 06:39:12PM +0200, Cornelia Huck wrote: >> On Mon, Apr 03 2023, "Michael S. Tsirkin" wrote: >> >> > Change log: >> > >> > since v10: >> >addresse

[virtio-dev] Re: [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-04 Thread Cornelia Huck
On Tue, Apr 04 2023, "Michael S. Tsirkin" wrote: > On Fri, Mar 31, 2023 at 01:58:31AM +0300, Parav Pandit wrote: >> PCI device configuration space for capabilities is limited to only 192 >> bytes shared by many PCI capabilities of generic PCI device and virtio >> specific. >> >> Hence,

Re: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number

2023-03-31 Thread Cornelia Huck
On Thu, Mar 30 2023, Halil Pasic wrote: > On Thu, 30 Mar 2023 00:23:33 +0300 > Parav Pandit wrote: > >> 1. Currently, virtqueue is identified between driver and device >> interchangeably using either number or index terminology. >> >> 2. Between PCI and MMIO transport the queue size (depth) is

[virtio-dev] Re: [PATCH v10 8/8] virtio-net: Describe RSS using rss rq id

2023-03-30 Thread Cornelia Huck
On Thu, Mar 30 2023, Parav Pandit wrote: > The content of indirection table and unclassified_queue which are > based on math calculation historically. To better describe this, to > avoid intermixing array index with virtqueue index and to use virtqueue > number > > introduce a field rq_handle

[virtio-dev] Re: [PATCH v10 7/8] virtio-net: Avoid duplicate receive queue example

2023-03-30 Thread Cornelia Huck
"the 0-based number"? > \item If the destination receive queue is being reset (See \ref{sec:Basic > Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}), the device > MUST drop the packet. > \end{itemize} > Otherwise, Reviewed-by: Cornelia Huck

[virtio-dev] Re: [PATCH v10 6/8] transport-ccw: Refer to the vq by its number

2023-03-30 Thread Cornelia Huck
mment > v2->v3: > - added comment note for queue_select similar to max_queue_size > v0->v1: > - new patch > --- > transport-ccw.tex | 14 ++++-- > 1 file changed, 8 insertions(+), 6 deletions(-) Reviewed-by: Cornelia Huck ---

[virtio-dev] Re: [PATCH v10 1/8] content: Add vq number text

2023-03-30 Thread Cornelia Huck
moved description close to introduction, it was in middle of > queue data transfer description > v2->v3: > - new patch > --- > content.tex | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Cornelia Huck ---

[virtio-dev] RE: [PATCH v9 6/8] transport-ccw: Refer to the vq by its number

2023-03-29 Thread Cornelia Huck
On Wed, Mar 29 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Wednesday, March 29, 2023 5:30 AM >> >> Same comment regarding s/Previously/previously/ as for the last patch. >> > Will change. > >> Also, I'm not that happy with the name &q

[virtio-dev] RE: [PATCH v9 3/8] transport-mmio: Rename QueueNum register

2023-03-29 Thread Cornelia Huck
On Wed, Mar 29 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Wednesday, March 29, 2023 5:16 AM >> >> I'm not sure it is worthwile keeping the lines short so aggressively (after >> all, it >> does not affect the generated html/pdf), espec

[virtio-dev] Re: [PATCH v9 6/8] transport-ccw: Refer to the vq by its number

2023-03-29 Thread Cornelia Huck
On Tue, Mar 28 2023, Parav Pandit wrote: > Currently specification uses virtqueue index and > number interchangeably to refer to the virtqueue. > > Instead refer to it by its number. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 > Signed-off-by: Parav Pandit > > --- >

[virtio-dev] Re: [PATCH v9 5/8] transport-ccw: Rename queue depth/size to other transports

2023-03-29 Thread Cornelia Huck
ct vq_config_block { > be16 index; > -be16 max_num; > +be16 max_queue_size; /* Previously known as max_num */ Nit: the comment should probably start with a lower-case 'p', as it is not a complete sentence (further instances of this below). Otherwise, Reviewed-by: Cornelia Hu

[virtio-dev] Re: [PATCH v9 4/8] transport-mmio: Refer to the vq by its number

2023-03-29 Thread Cornelia Huck
-- > transport-mmio.tex | 23 +-- > 1 file changed, 9 insertions(+), 14 deletions(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [PATCH v9 3/8] transport-mmio: Rename QueueNum register

2023-03-29 Thread Cornelia Huck
}, \field{QueueNum}, > \field{QueueReady}, > +following operations on \field{QueueSizeMax}, > +\field{QueueSize}, \field{QueueReady}, I'm not sure it is worthwile keeping the lines short so aggressively (after all, it does not affect the generated html/pdf), e

[virtio-dev] Re: [PATCH v9 2/8] transport-pci: Refer to the vq by its number

2023-03-29 Thread Cornelia Huck
virtqueue number in the Note > - refer to vqn field instead of virtqueue number > --- > transport-pci.tex | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Cornelia Huck - To

[virtio-dev] Re: [PATCH v9 1/8] content: Add vq number text

2023-03-29 Thread Cornelia Huck
On Tue, Mar 28 2023, Parav Pandit wrote: > Introduce vq number and its range so that subsequent patches can refer > to it. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 > Signed-off-by: Parav Pandit > --- > changelog: > v8->v9: > - added inclusive when describing the vq number

Re: [PATCH v2] virtio: refresh vring region cache after updating a virtqueue size

2023-03-27 Thread Cornelia Huck
tio/virtio-pci.c | 1 + > hw/virtio/virtio.c | 2 +- > include/hw/virtio/virtio.h | 1 + > 5 files changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Cornelia Huck We can always do any ccw reshuffling on top.

[virtio-dev] Re: [PATCH] virtio-spi: add the device specification

2023-03-27 Thread Cornelia Huck
On Fri, Mar 24 2023, Haixu Cui wrote: > virtio-spi is a virtual SPI master and it allows a guset to operate and > use the physical SPI master controlled by the host. Please spell out what SPI is the first time you use it. Also, please remember to post the separate patch that reserves the ID

<    1   2   3   4   5   6   7   8   9   10   >