Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21389
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21389
cc @gengliangwang Please take another look
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21590
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r198314687
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -109,6 +134,20 @@ class JDBCOptions
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r198313914
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -86,7 +86,8 @@ class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21641
Based on my understanding, the issue should be fixed by
https://github.com/antlr/antlr4/pull/873 , which is released in
https://github.com/antlr/antlr4/releases/tag/4.5.1
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21553#discussion_r198301742
--- Diff: python/pyspark/sql/conf.py ---
@@ -64,6 +64,96 @@ def _checkType(self, obj, identifier):
(identifier, obj
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21553#discussion_r198300614
--- Diff: docs/configuration.md ---
@@ -456,33 +456,6 @@ Apart from these, the following properties are also
available, and may be useful
from
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21598
LGTM and WFT
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21598
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21570
ping @JoshRosen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21594
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21594
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21631
Both?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21631
@maropu Could you confirm whether these two bugs are regressions in the
master branch?
---
-
To unsubscribe, e-mail: reviews
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21594
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21379
The build passed. The tests have passed in the previous run. The current
tests will be killed at the midnight.
LGTM
Thanks! Merged to master
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21603#discussion_r197686539
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -378,6 +378,17 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21379
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21603#discussion_r197681414
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -378,6 +378,17 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21596
Can we target this to Spark 3.0, which should be the next release after
Spark 2.4 release?
---
-
To unsubscribe, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21618#discussion_r197657738
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -724,4 +726,35 @@ object DataSource extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21598
All the behavior changes need very careful reviews and discussions.
Whenever we decide to make a behavior change, we should document it in the
migration guide and provide a conf to revert it
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21594
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r197646687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala
---
@@ -99,27 +100,28 @@ trait
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r197629698
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -301,7 +301,6 @@ case class FileSourceScanExec
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21288
Sure
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20345
cc @maryannxue Please take a look at this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r197626306
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r197626232
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,222 @@ class FileBasedDataSourceSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r197626154
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r197626122
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21288
LGTM
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20949
cc @MaxGekk @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21247
LGTM
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r197620329
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -65,13 +65,38 @@ class JDBCOptions
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r197620436
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -65,13 +65,38 @@ class JDBCOptions
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r197620455
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -109,6 +134,20 @@ class JDBCOptions
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r197620140
--- Diff: docs/sql-programming-guide.md ---
@@ -1302,9 +1302,20 @@ the following case-insensitive options:
dbtable
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r197620099
--- Diff: docs/sql-programming-guide.md ---
@@ -1302,9 +1302,20 @@ the following case-insensitive options:
dbtable
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r197620021
--- Diff: docs/sql-programming-guide.md ---
@@ -1302,9 +1302,20 @@ the following case-insensitive options:
dbtable
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r197620115
--- Diff: docs/sql-programming-guide.md ---
@@ -1302,9 +1302,20 @@ the following case-insensitive options:
dbtable
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r197620496
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -58,6 +58,10 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r197620483
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -109,6 +134,20 @@ class JDBCOptions
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r197620091
--- Diff: docs/sql-programming-guide.md ---
@@ -1302,9 +1302,20 @@ the following case-insensitive options:
dbtable
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r197620340
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -65,13 +65,38 @@ class JDBCOptions
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r197620384
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -65,13 +65,38 @@ class JDBCOptions
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21598#discussion_r197618603
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -75,28 +75,47 @@ trait
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21598#discussion_r197618318
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -75,28 +75,47 @@ trait
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21598
I created a JIRA https://issues.apache.org/jira/browse/SPARK-24640. We
should change the behavior in 3.0. Before 3.0 release, we introduce a conf and
make it configurable. The default is to keep
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21623
cc @rdblue
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21594
Thanks for fixing the current behavior! This is a very important fix.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21594
document the behavior changes in the `# Migration Guide` of
`/docs/sql-programming-guide.md`
---
-
To unsubscribe, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21594#discussion_r197591957
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ---
@@ -490,7 +494,7 @@ class CatalogImpl(sparkSession: SparkSession
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21594#discussion_r197591943
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ---
@@ -438,7 +440,9 @@ class CatalogImpl(sparkSession: SparkSession
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21594#discussion_r197591886
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -204,9 +205,10 @@ case class DropTableCommand
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21594#discussion_r197591842
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -189,8 +189,9 @@ case class DropTableCommand
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21594#discussion_r197591661
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2971,7 +2971,7 @@ class Dataset[T] private[sql](
* @since 1.6.0
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21594#discussion_r197586914
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -493,7 +493,7 @@ case class TruncateTableCommand
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21594#discussion_r197586970
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -105,24 +105,58 @@ class CacheManager extends Logging
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21594#discussion_r197586499
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -105,24 +105,58 @@ class CacheManager extends Logging
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21594#discussion_r197289750
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -105,24 +105,58 @@ class CacheManager extends Logging
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21603#discussion_r197523544
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -378,6 +378,17 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21610#discussion_r197348104
--- Diff: NOTICE ---
@@ -1,667 +1,11 @@
Apache Spark
-Copyright 2014 and onwards The Apache Software Foundation.
+Copyright 2014 - 20018 The
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21610#discussion_r197347713
--- Diff: NOTICE ---
@@ -1,667 +1,11 @@
Apache Spark
-Copyright 2014 and onwards The Apache Software Foundation.
+Copyright 2014 - 20018 The
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21610
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21587
LGTM
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21602
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21603#discussion_r197191390
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -270,6 +270,11 @@ private[parquet
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21602
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21578
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21593
cc @zsxwing @JoshRosen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21585
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21578
@MaxGekk Could you resolve the conflict and then I will merge it?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21531
LGTM
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21587#discussion_r196301308
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
---
@@ -99,16 +99,19 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21550#discussion_r196242923
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -354,8 +354,8 @@ class JsonFunctionsSuite extends QueryTest with
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21585
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21546
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21529
Adding new queries to `SQLQueryTestSuite` is the best way to do it in the
current infrastructure. Do your best to cover all the join algorithms for
different input data and join types
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21529
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21288
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21379
LGTM except one minor comment.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21379#discussion_r195479735
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -309,7 +309,8 @@ class DataFrameReader private[sql](sparkSession
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21389
@maropu Just want to double check whether all the data types are not
supported before this PR? Have you ran these test cases without the code
changes? After this PR, the error messages are more
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r195472992
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21553
Could you address the comments in the original PR?
- https://github.com/apache/spark/pull/21370#discussion_r194276735
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21370#discussion_r195316251
--- Diff: docs/configuration.md ---
@@ -456,6 +456,33 @@ Apart from these, the following properties are also
available, and may be useful
from
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21379
@maropu The fix looks good to me. Thanks for changing the solution. Could
you update the PR title and description?
---
-
To
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21379#discussion_r195314034
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -78,7 +84,17 @@ private[sql] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21379#discussion_r195313861
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -99,10 +115,21 @@ private[sql] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21379#discussion_r195313934
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -51,7 +53,11 @@ private[sql] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21379#discussion_r195313083
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -1206,4 +1211,47 @@ class JDBCSuite extends SparkFunSuite
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21288
@maropu Could you fix the style?
BTW, based on the latest result, Parquet is generally faster than ORC. cc
@dongjoon-hyun @rdblue
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21529
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21553#discussion_r195254446
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1314,6 +1314,31 @@ object SQLConf {
"Other c
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21553#discussion_r195254239
--- Diff: docs/configuration.md ---
@@ -472,15 +472,17 @@ Apart from these, the following properties are also
available, and may be useful
20
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21549
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21499
Thank you for fixing this! In Spark 3.0, we might introduce a mode for
strict ANSI compliance. We can handle the cases in
https://github.com/apache/spark/pull/20350
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21549#discussion_r195153892
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/xml/UDFXPathUtilSuite.scala
---
@@ -77,6 +77,23 @@ class
1201 - 1300 of 14069 matches
Mail list logo
