[edk2-devel] Does anyone know the history of LzmaF86Compress.bat?

2020-06-18 Thread Andrew Fish via groups.io
calls x86_Convert_Init() and x86_Convert() to post process the buffer. Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61503): https://edk2.groups.io/g/devel/message/61503 Mute This Topic: https://groups.io/mt

Re: [edk2-devel] ci problems again

2020-06-12 Thread Andrew Fish via groups.io
Mike, Thanks so different encase. Thanks, Andrew Fish > On Jun 12, 2020, at 12:25 PM, Kinney, Michael D > wrote: > > Hi Andrew, > > Not related to patch vs patch set. All commits in a pr are being evaluated. > > After further evaluation, it appears it may b

Re: [edk2-devel] ci problems again

2020-06-12 Thread Andrew Fish via groups.io
Mike, Is this an issue of assuming a patch vs. a patch set? Are there other places we could run into this? Thanks, Andrew Fish > On Jun 12, 2020, at 11:19 AM, Michael D Kinney > wrote: > > Hi Ard, > > I think this is related to a patch series that deletes > some file

Re: [edk2-devel] Device and driver

2020-06-09 Thread Andrew Fish via groups.io
machine, PC, or Mac. BDS and DXE are actually defined in the PI Specs (still owned by the UEFI Forum). PI is about building the modular BIOS, and UEFI is about how to write Option ROMs and OS loaders. Thanks, Andrew Fish > On Jun 9, 2020, at 2:56 AM, Tomas Pilar (tpilar) wrote: >

Re: [edk2-devel] Does anyone know the definition of EFI_SYSTEM_CONTEXT_X64.Gdtr[2] and EFI_SYSTEM_CONTEXT_X64.Idtr[2]

2020-06-03 Thread Andrew Fish via groups.io
o well. I can think of at least 3 ways ti could be mapped? Match the instruction, Base 1st, Limit 1st. Thanks, Andrew Fish > Mike > >> -Original Message- >> From: Andrew Fish >> Sent: Wednesday, June 3, 2020 5:57 PM >> To: edk2-devel-groups-io ; Kinney,

Re: [edk2-devel] Does anyone know the definition of EFI_SYSTEM_CONTEXT_X64.Gdtr[2] and EFI_SYSTEM_CONTEXT_X64.Idtr[2]

2020-06-03 Thread Andrew Fish via groups.io
f data that is not UINTN aligned. These register point to a limit then base address. If you execute the instruction you get 2 bytes of limit and 4 or 8 bytes of data. But Idtr[0] is base and Intro[1] is limit, so reversed from the instruction order. What defines index 0 vs. index 1 data content

[edk2-devel] Does anyone know the definition of EFI_SYSTEM_CONTEXT_X64.Gdtr[2] and EFI_SYSTEM_CONTEXT_X64.Idtr[2]

2020-06-03 Thread Andrew Fish via groups.io
The x86 instructions do limit then base, but the code is storing base, then limit. Does anyone remember if this is properly defined some place? Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60699): https://edk2

Re: [edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

2020-06-03 Thread Andrew Fish via groups.io
> On Jun 2, 2020, at 11:32 PM, Ard Biesheuvel wrote: > > On 6/3/20 12:28 AM, Andrew Fish wrote: >>> On Jun 2, 2020, at 6:38 AM, Ard Biesheuvel >>> wrote: >>> >>> From: Ard Biesheuvel >>> >>> The ChaosKey driver implements

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-02 Thread Andrew Fish via groups.io
> On Jun 2, 2020, at 8:33 PM, Andrew Fish via groups.io > wrote: > > > >> On May 29, 2020, at 7:02 AM, Leif Lindholm wrote: >> >> The description of [Packages] sections stated that >> "Packages must be listed in the order that may be requir

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-02 Thread Andrew Fish via groups.io
mand line, we should approach this programmatically. > I think the intent of this was to deal with duplicates include file names, and it was not really about build performance. Thanks, Andrew Fish > 3_edk_ii_inf_file_format/37_[packages]_sections.md | 7 ++- > 1 file changed, 2 inser

Re: [edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

2020-06-02 Thread Andrew Fish via groups.io
ick look at the DXE Core and the gBS->ConnectController() is not doing any book keeping, other than managing the precedence rules, but it seems like it would be legal to add something in the future. + Mike in case I’m off on this one. Also It would like be a good idea to have a PCD to

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable202005

2020-05-28 Thread Andrew Fish via groups.io
Liming, Sounds good. There is a Stewards meeting next Tuesday so please let us know if there is any other feedback we could give that would be helpful. Thanks, Andrew Fish > On May 28, 2020, at 8:00 PM, Liming Gao wrote: > > Stewards and all: > Leif requests two patc

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-27 Thread Andrew Fish via groups.io
with git sendmail. It might be worth while to have folks reach out inside their companies to see if there are existing known good recipes? Thanks, Andrew Fish > On May 27, 2020, at 3:07 PM, Rebecca Cran wrote: > > On 5/27/2020 6:12 AM, Laszlo Ersek wrote: > >> So, it could be a

Re: [edk2-devel] [PATCH 3/3] OvmfwPkg: Don't exclude XCODE Modules

2020-05-27 Thread Andrew Fish via groups.io
> On May 26, 2020, at 4:45 AM, Laszlo Ersek wrote: > > On 05/26/20 06:10, Andrew Fish wrote: >> >> >>> On May 25, 2020, at 12:31 PM, Laszlo Ersek wrote: >>> >>> Hi Andrew, >>> >>> On 05/24/20 23:20, Andrew Fish via group

Re: [edk2-devel] [PATCH 3/3] OvmfwPkg: Don't exclude XCODE Modules

2020-05-25 Thread Andrew Fish via groups.io
> On May 25, 2020, at 12:31 PM, Laszlo Ersek wrote: > > Hi Andrew, > > On 05/24/20 23:20, Andrew Fish via groups.io <http://groups.io/> wrote: >> With this BZ getting fixed we no longer need to special case XCODE. >> >> Cc: Ard Biesheuvel >>

Re: [edk2-devel] OVMF gdb seems to require "stone knives and bearskins" to debug code?

2020-05-25 Thread Andrew Fish via groups.io
> On May 25, 2020, at 7:19 PM, Rebecca Cran wrote: > > On 5/24/20 9:30 PM, Andrew Fish via groups.io wrote: > >> I could open source an lldb symbolication Python script and I'm happy to >> explain the common logic to some one to make it easier to port this lld

Re: [edk2-devel] Updating to latest EDK2 and now get NMAKE: fatal error U1073: Don't know how to make.. on some items?

2020-05-25 Thread Andrew Fish via groups.io
ls/Conf/*.template files that are checked in. Thanks, Andrew Fish > I also recommend you use VS2015, 2017, or VS2019 and let us know what issues > you see after these 2 changes. > > Mike > > From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > mailto:devel@ed

Re: [edk2-devel] OVMF gdb seems to require "stone knives and bearskins" to debug code?

2020-05-25 Thread Andrew Fish via groups.io
> On May 25, 2020, at 12:15 PM, Laszlo Ersek wrote: > > (+Rebecca, +Andrei) > > On 05/25/20 05:30, Andrew Fish via groups.io wrote: >> The full Star Trek quote from Spock is: " I am endeavoring, ma'am, to >> construct a mnemonic memory circuit using stone k

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-25 Thread Andrew Fish via groups.io
> On May 25, 2020, at 11:10 AM, Laszlo Ersek wrote: > > Hi Andrew, > > On 05/25/20 06:09, Andrew Fish wrote: > >> I also found I had to Bing/Google to find the detailed instructions I >> needed as a developer, as the Wiki seems to assume you just know the

[edk2-devel] OVMF gdb seems to require "stone knives and bearskins" to debug code?

2020-05-24 Thread Andrew Fish via groups.io
filenames not paths -h, --helpShow help for the command Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60203): https://edk2.groups.io/g/devel/message/60203 Mute This Topic: https://groups.io/mt/744

[edk2-devel] [PATCH 0/1] BaseTools: Turn on LTO for XCOODE

2020-05-24 Thread Andrew Fish via groups.io
SEC/PEI/DXE/FVMAIN_COMPACT size savings in % 31/42/21/10 To turn off for good source level debugging add this to your INF. [BuildOptions] XCODE:*_*_*_CC_FLAGS = -O0 -fno-lto Andrew Fish (1): BaseTools: Turn on Link Time Optimization (LTO) for XCOODE BaseTools/Conf/tools_def.template | 16

[edk2-devel] [PATCH 1/1] BaseTools: Turn on Link Time Optimization (LTO) for XCOODE

2020-05-24 Thread Andrew Fish via groups.io
FVMAIN_COMPACT [33%Full] 3440640 total, 1165352 used, 2275288 free Signed-off-by: Andrew Fish Cc: Liming Gao Cc: Zhiguang Liu --- BaseTools/Conf/tools_def.template | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools

[edk2-devel] [PATCH 1/3] BaseTools/GenFv: Add PE/COFF resource sections injection to GenFw

2020-05-24 Thread Andrew Fish via groups.io
an existing empty section, or add a new section header. If there is not space to add a new section header append to the last section. The resource entry if found via a directory entry so the PE/COFF loading code does not depend on the section type. Signed-off-by: Andrew Fish Cc: Bob Feng Cc

[edk2-devel] [PATCH 3/3] OvmfwPkg: Don't exclude XCODE Modules

2020-05-24 Thread Andrew Fish via groups.io
With this BZ getting fixed we no longer need to special case XCODE. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Philippe Mathieu-Daudé Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=557 Signed-off-by: Andrew Fish Signed-off-by: Andrew Fish --- OvmfPkg/OvmfPkgIa32.dsc

[edk2-devel] [PATCH 2/3] BaseTools: Add PE/COFF resource sections support for XCODE

2020-05-24 Thread Andrew Fish via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=557 Build a nul lib in [Hii-Binary-Package.UEFI_HII] so the makefile dependencies are satisfied. Add --rc to Genfw in [Dynamic-Library-File] to inject the *hii.rc data if it exists. Signed-off-by: Andrew Fish Cc: Bob Feng Cc: Liming Gao

[edk2-devel] [PATCH 0/3] Add PE/COFF resource sections support for XCODE

2020-05-24 Thread Andrew Fish via groups.io
. Andrew Fish (3): BaseTools/GenFv: Add PE/COFF resource sections injection to GenFw BaseTools: Add PE/COFF resource sections support for XCODE OvmfwPkg: Don't exclude XCODE Modules BaseTools/Conf/build_rule.template | 15 +- BaseTools/Source/C/GenFw/GenFw.c | 370

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-21 Thread Andrew Fish via groups.io
> reciprocal of that ratio. > I'd also point out that the processes you chose kind of defines your quanta of work. It is likely you would be willing to tackle a really big change as a large patch set, that you would likely break up into multiple PRs in a squash on commit world. In a squash o

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-21 Thread Andrew Fish via groups.io
d see a list of the commits/patch set and see only the diffs for those. I'm not sure how github does it. In our world we don't require the squash. We also have a set of command line tools that help automate common operations. Thanks, Andrew Fish > 2. With GitHub branch protections requ

[edk2-devel] Broken link on: https://github.com/tianocore/tianocore.github.io/wiki/Code-Contributions

2020-05-18 Thread Andrew Fish via groups.io
https://github.com/tianocore/tianocore.github.io/wiki/Code-Contributions link to https://github.com/tianocore/edk2/blob/master/Readme.md is broken. Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59764): https

[edk2-devel] Hii PE/COFF resource section.

2020-05-16 Thread Andrew Fish via groups.io
is always the .debug section. [1] https://github.com/tianocore/edk2/blob/master/MdePkg/Library/BasePeCoffLib/BasePeCoff.c#L1521 Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59715): https://edk2.groups.io/g/devel/me

Re: [edk2-devel] BDS Phase Output Menu

2020-05-12 Thread Andrew Fish via groups.io
you get the menu if you exit the UEFI Shell. On other platform it works like the old BIOS Setup so you have to hold some vendor specific snag key on boot? Thanks, Andrew Fish > Thanks. > > -- > Jim Slaughter > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages

Re: [edk2-devel] Help with Logo Display Problems

2020-05-11 Thread Andrew Fish via groups.io
ootManagerLib|UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf Thanks, Andrew Fish PS If we broke out BaseTools parser for edk2 build config files we could build a smart git grep. Something like: $ edk2-git-grep -p OvmfPkg/OvmfPkgX64.dsc Then you only see files that are

Re: [edk2-devel] Where to put the bhyve code in the edk2 repo: BhyvePkg, or under OvmfPkg?

2020-05-11 Thread Andrew Fish via groups.io
Crazy question. Should we add a VirtualizationPkg and move everything under that? I'm not sure the disruption to OVMF is worth, but figured I'd ask. Thanks, Andrew Fish > On May 11, 2020, at 9:36 AM, Kinney, Michael D > wrote: > > I agree that ArmVirtPkg contents should be adde

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-09 Thread Andrew Fish via groups.io
u need a library to link in to the CpuExceptionHandlerLib that allows you to override the handler. If CpuInterruptHandlerOverride() returns NULL you do the current behavior if not NULL then you call the returned handler. EFI_CPU_INTERRUPT_HANDLER EFIAPI OverrideCpuInterruptHandler ( IN EFI_EXC

Re: [EXTERNAL] [edk2-devel] APRIORI in RISC-V or Where did OVMF APRIORIs come from?

2020-05-07 Thread Andrew Fish via groups.io
Bret, How does that test work? Does it make a custom FDF file? Thanks, Andrew Fish > On May 7, 2020, at 9:45 AM, Bret Barkelew via groups.io > wrote: > > I know I’ve also seen tests that randomize the driver dispatch order to try > to catch these “implementation-speci

Re: [edk2-devel] APRIORI in RISC-V or Where did OVMF APRIORIs come from?

2020-05-07 Thread Andrew Fish via groups.io
re there in the first place, and I suspect it is a different issue. > It is good to get the history. In general the APRIORI files are used to force a dispatch order for debugging, like getting status codes or serial output quicker. >From an architectural point of view the dispatch order is

Re: [edk2-devel] Trying to get Logo to display in uEFI boot

2020-05-04 Thread Andrew Fish via groups.io
Oh and ImageHandle and *SystemTable are passed into every EFI Driver and App when it is loaded and this is how the Driver gets access to EFI services, and can figured the location it was loaded from. Thanks, Andrew Fish > On May 4, 2020, at 9:16 PM, Andrew Fish via groups.io >

Re: [edk2-devel] Trying to get Logo to display in uEFI boot

2020-05-04 Thread Andrew Fish via groups.io
MdeModulePkg/Logo/LogoDxe.inf Thanks, Andrew Fish > On May 4, 2020, at 9:05 PM, jim slaughter > wrote: > > Hello, > > I am trying to display a logo during the uEFI boot. > Found logo.c file. New to this code base. > I assume I must call: > Initial

Re: [edk2-devel] EDK2 environment setup

2020-05-04 Thread Andrew Fish via groups.io
that means you started running code from the FD. So maybe the App is faulting in some way and if you ran it under a debugger you would find out why? [1] $ git grep "SEC Has Started" EmulatorPkg/Sec/Sec.c:83: DEBUG ((EFI_D_ERROR, "SEC Has Started\n")); Thanks, Andrew Fish

Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

2020-04-19 Thread Andrew Fish via groups.io
t is our preference for a process. Maybe it would be useful to summarize the issue and state the pro and cons? Thanks, Andrew Fish > How many points do folks thing we need for a merge? I'd say +2. > > A > From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > mailto:devel@

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Register SnpNotifyExitBootServices at TPL_CALLBACK

2020-04-16 Thread Andrew Fish via groups.io
the EFI spec. PXE was a PC BIOS specification for network booting, UNDI (Universal Network Device Interface) was a standardized abstraction for NIC hardware that goes back to PC BIOS The cross link for specs referenced in the UEFI Spec is here: https://uefi.org/uefi. The idea is to keep th

Re: [edk2-devel] Debug UEFI Event

2020-04-03 Thread Andrew Fish via groups.io
ePkg/Core/Dxe/Event/Tpl.c#L95 Thanks, Andrew Fish > On Apr 3, 2020, at 5:48 PM, Stanley Gan wrote: > > I have an event callback function not called. So, I want to track event > execution in UEFI. There is a "DEBUG_EVENT" debug level in EDKII. But no > module in EDKII

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-29 Thread Andrew Fish via Groups.Io
to map a local file system so that i can setup a > startup.nsh? > I think you can mount a dir as a FAT32 disk by passing this to QEMU `-drive file=fat:rw:c:\Exchange,format=raw,media=disk` Thanks, Andrew Fish > Thanks > Sean > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You r

Re: [edk2-devel] [EXTERNAL] [edk2-devel] Information about the VMs used to do EDK2 CI?

2020-03-28 Thread Andrew Fish via Groups.Io
This works on my MacBook Pro $ getconf _NPROCESSORS_ONLN 8 The macOS centric way is this: $ sysctl -n hw.logicalcpu 8 Thanks, Andrew FIsh > On Mar 23, 2020, at 5:38 AM, Laszlo Ersek wrote: > > On 03/22/20 00:03, Rebecca Cran wrote: >> Thank you. I think we probably do

Re: [edk2-devel] Initial PXE boot over IPv6

2020-03-27 Thread Andrew Fish via Groups.Io
define (DEClare) the legal PCD types and the default value. Adding the info to the OVMF DSC file lets the platform build control the PCD type and the default value. Feel free to file a bugzilla and ask for a command line build option to control this feature. Thanks, Andrew Fish > On Mar

Re: [edk2-devel] CLANGPDB binary debugging

2020-03-21 Thread Andrew Fish via Groups.Io
odule(self, *args) method of lldb.SBTarget instance >> AddModule(SBTarget self, SBModule module) -> bool >> AddModule(SBTarget self, char const * path, char const * triple, char >> const * uuid) -> SBModule >> AddModule(SBTarget self, char const * path, char con

Re: [edk2-devel] CLANGPDB binary debugging

2020-03-21 Thread Andrew Fish via Groups.Io
st * triple, char const * uuid) -> SBModule AddModule(SBTarget self, char const * path, char const * triple, char const * uuid_cstr, char const * symfile) -> SBModule AddModule(SBTarget self, SBModuleSpec module_spec) -> SBModule The minimum you need to symbolicate a frame is uu

Re: [edk2-devel] CLANGPDB binary debugging

2020-03-20 Thread Andrew Fish via Groups.Io
ANGPDB path, but if you want to connect lldb to QEMU you need to set plugin.process.gdb-remote.target-definition-file [1] to [2]. [1] lldb -o "settings set plugin.process.gdb-remote.target-definition-file x86_64_target_definition.py" -o "gdb-remote 9000" [2] https://github.com/llvm-

Re: [edk2-devel] Disabling safe string constraint assertions

2020-03-18 Thread Andrew Fish via Groups.Io
gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 } Thanks, Andrew Fish > On Mar 18, 2020, at 2:31 PM, Vitaly Cheptsov wrote: > > Mike, > > That explains the current behaviour, but makes me even more confused. > > I do not really understand how DEC

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

2020-03-12 Thread Andrew Fish via Groups.Io
t; structure assignment. > Laszlo, My brain has flipped too. For x86 I find smaller structure assignments can cause the optimizer to optimize away the memcpy/memset and you only see issue issues on a NOOPT build since DEBUG builds tend to be size optimized. I tend to hit this

Re: [edk2-devel] Disabling safe string constraint assertions

2020-03-04 Thread Andrew Fish via Groups.Io
> On Mar 4, 2020, at 10:18 AM, Laszlo Ersek wrote: > > On 03/04/20 18:53, Andrew Fish wrote: >> >> >>> On Mar 4, 2020, at 5:33 AM, Laszlo Ersek wrote: >>> >>> On 03/03/20 22:12, Vitaly Cheptsov wrote: >>>> Hello, >>>>

Re: [edk2-devel] Disabling safe string constraint assertions

2020-03-04 Thread Andrew Fish via Groups.Io
ime Drivers, code running on the AP, and other places that the ASSERTs could have side effects. > - I'm unfriendly towards callbacks. They make the behavior of code > implicit rather than explicit, and implicit is more difficult to reason > about. IMO callbacks should be considered a last r

Re: [edk2-devel] Disabling safe string constraint assertions

2020-03-03 Thread Andrew Fish via Groups.Io
ter a driver is loaded it is generally always called indirectly via its protocol APIs. It is common for applications to not run at elevated TPL at all. Thanks, Andrew Fish > — My own approach makes sense, as it reduces the amount of code in every > DebugLib and actually simplifies the de

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-03-03 Thread Andrew Fish via Groups.Io
line. > > Best regards, > Marvin > > Am 20.02.2020 um 00:55 schrieb Andrew Fish: >> >> >>> On Feb 17, 2020, at 12:26 AM, Marvin Häuser >> <mailto:mhaeu...@outlook.de>> wrote: >>> >>> Good day Andrew, >>> >>> Fir

Re: [edk2-devel] [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.

2020-03-01 Thread Andrew Fish via Groups.Io
f the day a pointer is also a flexible array in C so that is the other option. Thanks, Andrew Fish > > Mike > >> -Original Message- >> From: af...@apple.com <mailto:af...@apple.com> > <mailto:af...@apple.com>> >> Sent: Thursday, Feb

Re: [edk2-devel] A problem with live migration of UEFI virtual machines

2020-02-27 Thread Andrew Fish via
> On Feb 26, 2020, at 1:42 AM, Laszlo Ersek wrote: > > Hi Andrew, > > On 02/25/20 22:35, Andrew Fish wrote: > >> Laszlo, >> >> The FLASH offsets changing breaking things makes sense. >> >> I now realize this is like updating the EFI ROM witho

Re: [edk2-devel] A problem with live migration of UEFI virtual machines

2020-02-27 Thread Andrew Fish via Groups.Io
> On Feb 26, 2020, at 1:42 AM, Laszlo Ersek wrote: > > Hi Andrew, > > On 02/25/20 22:35, Andrew Fish wrote: > >> Laszlo, >> >> The FLASH offsets changing breaking things makes sense. >> >> I now realize this is like updating the EFI ROM witho

Re: [edk2-devel] [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.

2020-02-27 Thread Andrew Fish via Groups.Io
Mike, Flexible array members must be the last element of a struct but they can not be the only element. This is non standard behavior from the compilers that are not throwing the error. Why not just use a pointer? > On Feb 26, 2020, at 10:03 PM, Michael D Kinney > wrote: > > Liming, > >

Re: [edk2-devel] A problem with live migration of UEFI virtual machines

2020-02-25 Thread Andrew Fish via
> On Feb 25, 2020, at 12:40 PM, Laszlo Ersek wrote: > > Hi Andrew, > > On 02/25/20 19:56, Andrew Fish wrote: >> Laszlo, >> >> If I understand this correctly is it not more complicated than just size. It >> also assumes the memory layout is the sam

Re: [edk2-devel] A problem with live migration of UEFI virtual machines

2020-02-25 Thread Andrew Fish via Groups.Io
> On Feb 25, 2020, at 12:40 PM, Laszlo Ersek wrote: > > Hi Andrew, > > On 02/25/20 19:56, Andrew Fish wrote: >> Laszlo, >> >> If I understand this correctly is it not more complicated than just size. It >> also assumes the memory layout is the sam

Re: [edk2-devel] A problem with live migration of UEFI virtual machines

2020-02-25 Thread Andrew Fish via
and S4 layouts consistent between boots, I'm not aware of any mechanism to keep the memory map address the same between versions of the firmware? Thanks, Andrew Fish > On Feb 25, 2020, at 9:53 AM, Laszlo Ersek wrote: > > On 02/24/20 16:28, Daniel P. Berrangé wrote: >> On Tu

Re: [edk2-devel] A problem with live migration of UEFI virtual machines

2020-02-25 Thread Andrew Fish via Groups.Io
and S4 layouts consistent between boots, I'm not aware of any mechanism to keep the memory map address the same between versions of the firmware? Thanks, Andrew Fish > On Feb 25, 2020, at 9:53 AM, Laszlo Ersek wrote: > > On 02/24/20 16:28, Daniel P. Berrangé wrote: >> On Tu

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-02-16 Thread Andrew Fish via Groups.Io
Dst =%s (%r)\n", Dst, Status); SetConstraintHandler (AssertConstraintHandler); StrCpyS (Dst, sizeof (Dst), L"Too Long"); Thanks, Andrew Fish PS Since I'm on a crazy idea roll another idea would be to add a MdePkgCompatability.dsc.inc file that could be used to future proof adding

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-02-14 Thread Andrew Fish via Groups.Io
to do in a global sense even if there is a PCD. It almost seems like we should have wrappers for the Safe string functions that implement the behavior you want as a caller. I'm not sure about that, but it seems like it is worth talking about? Thanks, Andrew Fish > On Feb 14, 2020, at 7:31

Re: [edk2-devel] Shell feature?

2020-02-14 Thread Andrew Fish via Groups.Io
Python and wrap it in a lib so it can optionally get built into the UEFI Shell binary. Thanks, Andrew Fish > On Feb 11, 2020, at 1:54 PM, Andrew Fish wrote: > > > >> On Feb 11, 2020, at 1:30 PM, Jim Dailey wrote: >> >> Andrew, >> >> Granted such

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-02-14 Thread Andrew Fish via Groups.Io
ng the _QUIET to debug. I'd thought I throw out the other forms for folks to think about. I'm probably biased as I used to looking at code and seeing things like require_action_string(Arg1 != NULL, ErrorExit, Status = EFI_INVALID_PARAMETER, "1st Arg1 check"); Thanks, Andrew Fish PS

[edk2-devel] OVMF and MEMFD_BASE_ADDRESS values.

2020-02-13 Thread Andrew Fish via Groups.Io
OVMF config that seems to be PcdOvmfLockBoxStorageBase and PcdOvmfPeiMemFvBase. It is easy enough to move MEMFD_BASE_ADDRESS to a much higher address, but I'm not sure if there are any restrictions to the addresses I can use? Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You

Re: [edk2-devel] PCD Migration issue

2020-02-11 Thread Andrew Fish via Groups.Io
have a platform in a common core base, and update the EDK2 code to pick up security fixes it seems the PCD data base implies you have to freeze Dynamic PCD usage in your common core? Thanks, Andrew Fish > On Feb 11, 2020, at 7:54 PM, Liming Gao wrote: > > Andrew: > Current im

Re: [edk2-devel] Shell feature?

2020-02-11 Thread Andrew Fish via Groups.Io
ilar to shell >> variables) so that the change could be installed and survive a reboot. I also >> think there can be a simple shell command that manages extensions (so that >> they can be installed by a script) >> >> Tim >> >> -Original Message- &

[edk2-devel] Shell feature?

2020-02-10 Thread Andrew Fish via Groups.Io
n3.efi"); Seems like this could just plug into the Shell via a ShellExecute(). So for example you could make Python a UEFI Shell command via a library and that library constructor could also teach the shell that a .py file could be an executable? Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=

[edk2-devel] PCD Migration issue

2020-02-10 Thread Andrew Fish via Groups.Io
adding a Dynamic PCD could potentially change the token layout and thus break compatibility? Is there any scheme to keep a previous token layout? Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54154): https://edk2

Re: [edk2-devel] PCD EX interface.

2020-01-23 Thread Andrew Fish via Groups.Io
for GetNextToken() in PCD_PROTOCOL [1] vs EFI_PCD_PROTOCOL [2]. Also EFI_PCD_PROTOCOL does not have the *Ex functions, so you need PCD_PROTOCOL anyway to have access to the *Ex versions of the API. [1] https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Protocol/Pcd.h [2] https://github.co

Re: [edk2-devel] [RFC PATCH 2/2] MdeModulePkg/BdsDxe: allow consoles on drivers loaded via Driver####

2020-01-14 Thread Andrew Fish via Groups.Io
> On Jan 14, 2020, at 8:46 AM, Ard Biesheuvel wrote: > > On Mon, 13 Jan 2020 at 18:57, Andrew Fish via Groups.Io > wrote: >> >> Ard, >> >> Is the problem GFX console? Would it be possible to have a PCD to assume >> graphics console, and if n

Re: [edk2-devel] [RFC PATCH 2/2] MdeModulePkg/BdsDxe: allow consoles on drivers loaded via Driver####

2020-01-13 Thread Andrew Fish via Groups.Io
was written to make the ConSpliter see it? Thanks, Andrew Fish > On Jan 13, 2020, at 9:28 AM, Ard Biesheuvel wrote: > > On Fri, 10 Jan 2020 at 17:23, Laszlo Ersek <mailto:ler...@redhat.com>> wrote: >> >> On 01/10/20 15:37, Ni, Ray wrote: >>> Ard, >>&

Re: [edk2-devel] EDK2 Host-Based Unit Test RFC (Now with docs!)

2019-12-04 Thread Andrew Fish via Groups.Io
te complex and let us not get bogged down in all that to get something working. [1] *Pkg/Test/UnitTest/[Library|Protocol|Ppi|Guid] Thanks, Andrew Fish > On Dec 2, 2019, at 3:12 PM, Michael D Kinney > wrote: > > Hi Bret, > > Thanks for posting this content. Host based uni

Re: [edk2-devel] build error

2019-12-02 Thread Andrew Fish via Groups.Io
The most common cause of something like this is a syntax error in the INF file. Thanks, Andrew Fish > > - Failed - > Build end time: 04:22:15, Dec.03 2019 > Build total time: 00:00:22 > > [cmd=build -u --genfds-multi-thread -D DOCUMENT_BUILD=None -D > XMLCLI_COMPILE=TRUE -D

[edk2-devel] [staging/master]:master on edk2-staging is out of date.

2019-11-26 Thread Andrew Fish via Groups.Io
I was looking at creating a staging branch to work on Bz2387. The README [1] for edk2-staging (about branch) mentions that edk2-staging/master tracks edk2/master, but I see it was last synced in June? I'm not clear on the process for updating the edk2-staging/master? It is not setup to

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-11 Thread Andrew Fish via Groups.Io
generates PE/COFF image. >>> And, PE/COFF image debug symbol is PDB. So, PE also means PDB. >>> >>> Last, I just review the changes. Tool chain name update is not big. If you >>> accept CLANGPE as tool chain name, >>> I will send the patch so

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-11 Thread Andrew Fish via Groups.Io
generates PE/COFF image. >>> And, PE/COFF image debug symbol is PDB. So, PE also means PDB. >>> >>> Last, I just review the changes. Tool chain name update is not big. If you >>> accept CLANGPE as tool chain name, >>> I will send the patch so

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-07 Thread Andrew Fish via Groups.Io
_ is muscle memory. I like adding the PDB part as the clang debugger does not support PDB for 1st class debugging. Thanks, Andrew Fish > Regards, > > Leif > > On Thu, Nov 07, 2019 at 11:54:04AM -0600, Andrew Fish wrote: >> Leif, >> >> I think I proposed CLAN

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-07 Thread Andrew Fish via Groups.Io
Leif, I think I proposed CLANG_PDB or CLANG_PECOFF. I seem to like CLANG_PDB as assuming the PDE debugging experience is awesome/exists on Linux and macOS is not a given. Thanks, Andrew Fish > On Nov 7, 2019, at 11:19 AM, Leif Lindholm wrote: > > Oops, sorry, missed this

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-06 Thread Andrew Fish via Groups.Io
Ray, Is there an obvious hook point we could point Jeff and Ashish at? Long term it would be a good idea to have a Wiki page to give some guidance on how to customize the BDS. Thanks, Andrew Fish > On Nov 5, 2019, at 9:20 PM, Ni, Ray wrote: > > Andrew, > I agree with your opi

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-06 Thread Andrew Fish via Groups.Io
ould. Should we write a BZ for the variable stack not to update a variable if the data is not changing? Thanks, Andrew Fish > > [...] > > Thanks > Laszlo > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply O

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-05 Thread Andrew Fish via Groups.Io
option points to the media supporting LoadFile protocol. Reference: UEFI Spec chapter 3.3 Boot Option Variables Default Boot Behavior The function won't delete the boot option not added by itself. **/ VOID EFIAPI EfiBootManagerRefreshAllBootOption ( VOI

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-05 Thread Andrew Fish via Groups.Io
> On Nov 5, 2019, at 3:54 AM, Laszlo Ersek wrote: > > On 11/05/19 07:15, Andrew Fish via Groups.Io wrote: > >> You could also edit any existing variables that point to your Load File to >> make sure they follow the rules you care about? >> >> It is l

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-04 Thread Andrew Fish via Groups.Io
oint of view for a platform to edit the nvram boot variables based on platform boot policy. Thanks, Andrew Fish > Thanks > Ashish > > From: af...@apple.com > Sent: Monday, November 4, 2019 10:22 PM > To: Ashish Singhal > Cc: devel@edk2.groups.io; Ni, Ray ; La

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-04 Thread Andrew Fish via Groups.Io
all your protocol to get a memory buffer and then just pass that buffer into gBS->LoadImage ()? Thanks, Andrew Fish > On Nov 4, 2019, at 11:06 PM, Ashish Singhal wrote: > > Hello Andrew, > > On my platform, I am installing Load File protocol on a handle which I do not > wa

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-04 Thread Andrew Fish via Groups.Io
the handle based on some platform policy. This is the only way you can filter based on things getting connected at different times during boot. Thanks, Andrew Fish > Thanks > Ashish > > -Original Message- > From: Ni, Ray mailto:ray...@intel.com>> > Sent: Mon

Re: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable

2019-11-04 Thread Andrew Fish via Groups.Io
Liming, Thanks for looking into this. It is always good to try and do things the same way on different tool chains if possible. Thanks, Andrew Fish > On Nov 3, 2019, at 9:40 PM, Liming Gao wrote: > > Andrew: > I did some investigation. Seemly, there is no way to disabl

Re: [edk2-devel] Question regarding MMIO address space exposed from GetMemoryMap

2019-10-31 Thread Andrew Fish via Groups.Io
tation is not required to be constructed out of PI Spec components, but the EDKII UEFI implementation is constructed using the PI Specification. [1] https://acpica.org/downloads/uefi-support [2] Sorry I could not make up a better name at the time. Thanks, Andrew Fish > On Oct 31, 2019, at 1:3

Re: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable

2019-10-30 Thread Andrew Fish via Groups.Io
the same behavior? Thanks, Andrew Fish > On Oct 30, 2019, at 6:46 PM, Liming Gao wrote: > > Yes. This is the expect behavior. Compiler optimization is disabled, then Od > option will be used for VS tool chain. > > From: devel@edk2.groups.io <mailto:devel@edk2.groups.io&g

Re: [edk2-devel] [edk2] [EmulatorPkg] using __debugbreak()

2019-10-30 Thread Andrew Fish via Groups.Io
t we could move to launching via the debugger for all paths? [1] https://github.com/tianocore/edk2/blob/master/EmulatorPkg/build.sh#L221 Thanks, Andrew Fish > On Oct 30, 2019, at 9:16 AM, Michael D Kinney > wrote: > > Liming, > > This may be something that is better wit

Re: [edk2-devel] [Patch 0/1] BaseTools: Using compiler to generate source code dependency files.

2019-10-28 Thread Andrew Fish via Groups.Io
used with -M or -MM, specifies a file to write the dependencies to. If > no -MF switch is given the preprocessor sends the rules to the same place it > would send preprocessed output. > When used with the driver options -MD or -MMD, -MF overrides the default > dependency output file. >

Re: [edk2-devel] [Patch 0/1] BaseTools: Using compiler to generate source code dependency files.

2019-10-28 Thread Andrew Fish via Groups.Io
s -MD or -MMD, -MF overrides the default dependency output file. If file is -, then the dependencies are written to stdout. Thanks, Andrew Fish > On Oct 28, 2019, at 8:03 AM, Yao, Jiewen wrote: > > I think we need avoid confusing for future. > I don’t believe .d is good choice

Re: [edk2-devel] EDK2 UEFI Specification and Revision

2019-10-21 Thread Andrew Fish via Groups.Io
2_70_SYSTEM_TABLE_REVISION ((2 << 16) | (70)) MdePkg/Include/Uefi/UefiSpec.h:1780:#define EFI_SYSTEM_TABLE_REVISION EFI_2_70_SYSTEM_TABLE_REVISION Thanks, Andrew Fish > On Oct 21, 2019, at 1:15 AM, serges...@yandex.ru wrote: > > When runs "ver" command in

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-10-17 Thread Andrew Fish via Groups.Io
. Thanks, Andrew Fish > On Oct 17, 2019, at 12:27 AM, Ni, Ray wrote: > > Liming, > Emulator is using a generic SEC module. The host specific module is called > "Host". > So I prefer to change the macro to "WIN_HOST_BUILD", with this change, > Reviewe

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-14 Thread Andrew Fish via Groups.Io
> On Oct 14, 2019, at 6:11 AM, Laszlo Ersek wrote: > > On 10/12/19 08:42, Andrew Fish wrote: >> Laszlo, >> >> For 2) this is very unfortunate. I think the root cause is for those >> of us who work on x86 hardware day to day we get programed that

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-12 Thread Andrew Fish via Groups.Io
.globl _gRelocation## @gRelocation .p2align3 _gRelocation: .quad _main .subsections_via_symbols If you have questions about a specific chunk of code to convert let me know. Thanks, Andrew Fish > On Oct 12, 2019, at 12:46 AM, Liming Gao wrote: > > A

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-12 Thread Andrew Fish via Groups.Io
section relocations for XCODE, and map them to .text for the other toolchain? Thanks, Andrew Fish > On Oct 11, 2019, at 1:56 AM, Laszlo Ersek wrote: > > On 10/11/19 01:17, Lendacky, Thomas wrote: >> On 10/3/19 10:12 AM, Tom Lendacky wrote: >>> >>> >>&

Re: [edk2-devel] question about qemu+kvm+ovmf+winxp

2019-10-12 Thread Andrew Fish via Groups.Io
Junhao FYI there is a regression in master for OVFM right now: https://bugzilla.tianocore.org/show_bug.cgi?id=2266 so you might be hitting that. Thanks, Andrew Fish > On Oct 11, 2019, at 11:13 PM, Junhao Gao wrote: > > > >> -Original Message- >> From: D

<    1   2   3   4   5   6   7   8   9   10   >