Ori.livneh has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/390645 )
Change subject: xenon: pass --mindwidth to flamegraph.pl
..
xenon: pass --mindwidth to flamegraph.pl
The flame graphs are
Hello Aaron Schulz, Krinkle,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/390645
to review the following change.
Change subject: xenon: pass --mindwidth to flamegraph.pl
..
xenon: pass
Hello Aaron Schulz, Krinkle,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/390073
to review the following change.
Change subject: xenon: encode the request method as a virtual stack frame
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387301 )
Change subject: Update my (ori) keys
..
Update my (ori) keys
One of my YKs got damaged, and the other is unrecoverable due to my
having
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386384 )
Change subject: Set $wgAutoloadAttemptLowercase to false
..
Set $wgAutoloadAttemptLowercase to false
No autoloader.log entries since
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385978 )
Change subject: labs: Set $wgAutoloadAttemptLowercase to false
..
labs: Set $wgAutoloadAttemptLowercase to false
In preparation for
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385405 )
Change subject: Add $wgAutoloadAttemptLowercase = false to dev settings
..
Add $wgAutoloadAttemptLowercase = false to dev settings
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385311 )
Change subject: Fix class name letter-case
..
Fix class name letter-case
Change-Id: Ifbbe537e8cac8b022793e4398c30dfdd148b4bfe
---
M
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385310 )
Change subject: Fix class name letter-case
..
Fix class name letter-case
Change-Id: I1bccc8a72e0fe33939c7db4a60a80bc12b8fb6ff
---
M
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385276 )
Change subject: Fix class name letter-case
..
Fix class name letter-case
Change-Id: I1bccc8a72e0fe33939c7db4a60a80bc12b8fb6ff
---
M
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385274 )
Change subject: Fix class name letter-case
..
Fix class name letter-case
Change-Id: Ifbbe537e8cac8b022793e4398c30dfdd148b4bfe
---
M
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384654 )
Change subject: Set $wgAutoloadAttemptLowercase to false
..
Set $wgAutoloadAttemptLowercase to false
As a prelude to Wikimedia turning
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384310 )
Change subject: Fix letter-case of class name
..
Fix letter-case of class name
Bug: T166759
Change-Id:
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384309 )
Change subject: Fix letter-case of class name
..
Fix letter-case of class name
Bug: T166759
Change-Id:
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384308 )
Change subject: Fix class name letter-case
..
Fix class name letter-case
Bug: T166759
Change-Id:
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384303 )
Change subject: Fix letter-case of XML
..
Fix letter-case of XML
Bug: T166759
Change-Id: Ief6834016add694d2ce11974b5ae21562fd9bd33
---
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384301 )
Change subject: Fix letter-case of several namespace and class names
..
Fix letter-case of several namespace and class names
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384288 )
Change subject: Add lowercase variants to the autoloader for legacy history
blob classes
..
Add lowercase variants to the autoloader
Ori.livneh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/357329 )
Change subject: Minor language tweak
..
Minor language tweak
Change-Id: If5f584c7c976492e8ab94c9d5ee690d3cea59c74
---
M
Hello Aaron Schulz, Krinkle,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/356841
to review the following change.
Change subject: Capture messages on 'autoloader' debug log channel
..
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322708
Change subject: Add X-Wikimedia-Debug config
..
Add X-Wikimedia-Debug config
Add ./debug.json, which holds configuration data for the
Ori.livneh has submitted this change and it was merged.
Change subject: Changes to coal-web.py should refresh the coal webapp
..
Changes to coal-web.py should refresh the coal webapp
Bug: T131820
Change-Id:
Hello Krinkle, MaxSem, Mkoch,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/322295
to review the following change.
Change subject: Revert "Remove obsolete hiphop code"
..
Revert "Remove
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322289
Change subject: Revert "Don't use AbuseFilterCachingParser on bgwiki"
..
Revert "Don't use AbuseFilterCachingParser on bgwiki"
This
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322095
Change subject: Don't report stats when page visibility changes during page load
..
Don't report stats when page visibility changes during
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322096
Change subject: Don't report stats when page visibility changes during page load
..
Don't report stats when page visibility changes during
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/321890
Change subject: Don't use AbuseFilterCachingParser on bgwiki
..
Don't use AbuseFilterCachingParser on bgwiki
Bug: T148660
Change-Id:
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/321728
Change subject: Re-enable AbuseFilterCachingParser everywhere
..
Re-enable AbuseFilterCachingParser everywhere
With T148673 fixed, I
Ori.livneh has submitted this change and it was merged.
Change subject: Use systemd's process watchdog to trigger restarts
..
Use systemd's process watchdog to trigger restarts
I3ad8bb49ce was supposed to take care of the
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/321231
Change subject: statsv: use systemd's process watchdog
..
statsv: use systemd's process watchdog
This is the companion change to
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/321230
Change subject: Use systemd's process watchdog to trigger restarts
..
Use systemd's process watchdog to trigger restarts
I3ad8bb49ce was
Ori.livneh has submitted this change and it was merged.
Change subject: Add an Icinga check for Graphite metric freshness
..
Add an Icinga check for Graphite metric freshness
Checks a Graphite metric and generates WARNING or
Ori.livneh has submitted this change and it was merged.
Change subject: Fix-up for Ia07b03f12b
..
Fix-up for Ia07b03f12b
Get the right field name.
Change-Id: Ib2329d08579ca938584035f290a17bacdcd893d8
---
M
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319916
Change subject: Fix-up for Ia07b03f12b
..
Fix-up for Ia07b03f12b
Get the right field name.
Change-Id:
Ori.livneh has submitted this change and it was merged.
Change subject: Report save timing by MediaWiki version
..
Report save timing by MediaWiki version
Add a 'mw.performance.save_by_version' key namespace which includes a
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319902
Change subject: Don't report stats when page visibility changes during page load
..
Don't report stats when page visibility changes during
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319389
Change subject: Module storage: count modules which fail to execute, too
..
Module storage: count modules which fail to execute, too
Ori.livneh has submitted this change and it was merged.
Change subject: Fix-up for Iff996299
..
Fix-up for Iff996299
Change-Id: I4c6e3859917c7b34d76c23eb0628402a188f60a2
---
M modules/coal/files/coal
1 file changed, 1
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317856
Change subject: Fix-up for Iff996299
..
Fix-up for Iff996299
Change-Id: I4c6e3859917c7b34d76c23eb0628402a188f60a2
---
M
Ori.livneh has submitted this change and it was merged.
Change subject: Die if no metrics received in one minute
..
Die if no metrics received in one minute
If no message is received in TIMEOUT_SECONDS (hard-coded to 60), die
Ori.livneh has submitted this change and it was merged.
Change subject: Use ^ and $ while spliting metric value and type
..
Use ^ and $ while spliting metric value and type
If stats are sent to the enpoint using jsonp then
a
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317847
Change subject: Die if no metrics received in one minute
..
Die if no metrics received in one minute
Change-Id:
Ori.livneh has submitted this change and it was merged.
Change subject: coal: using stdlib's logging
..
coal: using stdlib's logging
Using syslog.syslog() is fine, except exception info doesn't end up
there. We could use
Ori.livneh has submitted this change and it was merged.
Change subject: coal: die if no events in N seconds
..
coal: die if no events in N seconds
Sometimes coal will keep running even when the publisher has stopped
sending it
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317838
Change subject: Use correct IP for Vanderbilt 2016-10-25 edit-a-thon throttle
exception
..
Use correct IP for Vanderbilt 2016-10-25
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317832
Change subject: coal: using stdlib's logging
..
coal: using stdlib's logging
Using syslog.syslog() is fine, except exception info doesn't
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317831
Change subject: coal: die if no events in N seconds
..
coal: die if no events in N seconds
Sometimes coal will keep running even when the
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317823
Change subject: Drop support for the legacy configuration format
..
Drop support for the legacy configuration format
Per Mark, in
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317743
Change subject: mw.loader: Fix off-by-one error in splitModuleKey()
..
mw.loader: Fix off-by-one error in splitModuleKey()
Follows-up
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316825
Change subject: Disable AbuseFilterCachingParser on bgwiki
..
Disable AbuseFilterCachingParser on bgwiki
After enabling
Ori.livneh has submitted this change and it was merged.
Change subject: Remove ~ori/.hushlogin
..
Remove ~ori/.hushlogin
Hiding the MOTD banners isn't optimal when they are used to signal
things like the active deployment
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316364
Change subject: Enable AbuseFilterCachingParser by default
..
Enable AbuseFilterCachingParser by default
Set AbuseFilterParserClass to
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316361
Change subject: Fix-up for Ia3d767e86
..
Fix-up for Ia3d767e86
Add 'use ContentHandler' statement to avoid having references to
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316360
Change subject: Fix-up for Ia3d767e86
..
Fix-up for Ia3d767e86
Add 'use ContentHandler' statement to avoid having references to
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316354
Change subject: Enable AbuseFilterCachingParser on metawiki and commonswiki
..
Enable AbuseFilterCachingParser on metawiki and commonswiki
Ori.livneh has submitted this change and it was merged.
Change subject: ori: update personal dot files
..
ori: update personal dot files
- iron isn't the ops/root bastion anymore, we all use bast*
- palladium isn't the
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315729
Change subject: Enable AbuseFilterCachingParser on testwiki and mediawikiwiki
..
Enable AbuseFilterCachingParser on testwiki and
Ori.livneh has submitted this change and it was merged.
Change subject: Module and role for Recommendation API
..
Module and role for Recommendation API
The Wikimedia Recommendation API is a JSON API that provides personalized
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314291
Change subject: CachingSiteStore: store site list using global key
..
CachingSiteStore: store site list using global key
As best as I can
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313547
Change subject: Keep counts of login errors by type
..
Keep counts of login errors by type
For obvious reasons: to catch bugs and
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312045
Change subject: [WIP] Module for Recommendation API
..
[WIP] Module for Recommendation API
Change-Id:
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311468
Change subject: Add .gitreview
..
Add .gitreview
Change-Id: Ifcd49ca5a1a9301c0fc23b8240b4bbcd63291a0d
---
A .gitreview
1 file changed, 6
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311199
Change subject: Memoize isWideScreen()
..
Memoize isWideScreen()
It is called multiple times, and each call triggers a reflow.
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306804
Change subject: Handle string input in humanSize()
..
Handle string input in humanSize()
The $.isNumeric( bytes ) in humanSize() is not
Ori.livneh has submitted this change and it was merged.
Change subject: graphite: Set xFilesFactor to 0 for sum/count.
..
graphite: Set xFilesFactor to 0 for sum/count.
Carbon uses xFilesFactor to decide whether to aggregate
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/300587
Change subject: Support reading/writing data to/from a static PHP array
..
Support reading/writing data to/from a static PHP array
If
Ori.livneh has submitted this change and it was merged.
Change subject: Add alerting for MediaWiki exceptions and fatals
..
Add alerting for MediaWiki exceptions and fatals
Watch the rate per minute of MediaWiki exceptions and
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/300327
Change subject: Add alerting for MediaWiki exceptions and fatals
..
Add alerting for MediaWiki exceptions and fatals
Watch the rate per
Ori.livneh has submitted this change and it was merged.
Change subject: Fix-up for I39d2d7db576: move log_format directive to top level
..
Fix-up for I39d2d7db576: move log_format directive to top level
Change-Id:
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/299898
Change subject: Fix-up for I39d2d7db576: move log_format directive to top level
..
Fix-up for I39d2d7db576: move log_format directive to
Ori.livneh has submitted this change and it was merged.
Change subject: rcstream: log X-Forwarded-Proto
..
rcstream: log X-Forwarded-Proto
Right now the Nginx logs on rcs hosts are useless for determining which
clients are
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/299892
Change subject: rcstream: log X-Forwarded-Proto
..
rcstream: log X-Forwarded-Proto
Right now the Nginx logs on rcs hosts are useless
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/299203
Change subject: Add Http::sendBeacon()
..
Add Http::sendBeacon()
Add a PHP implementation of `navigator.sendBeacon`, part of the
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/298895
Change subject: Update expected length of module version hash
..
Update expected length of module version hash
It's 7, not 8, as of
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/298892
Change subject: Update expected length of module version hash
..
Update expected length of module version hash
It's 7, not 8, as of
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/298414
Change subject: All wikis back to 1.28.0-wmf8
..
All wikis back to 1.28.0-wmf8
Due to T115198:
$ zgrep -c 'local user data'
Ori.livneh has submitted this change and it was merged.
Change subject: PCC: Fix success/failure detection
..
PCC: Fix success/failure detection
Puppet always sets a nonzero exit code, so resort to cruder means of testing
for
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/298252
Change subject: PCC: Fix success/failure detection
..
PCC: Fix success/failure detection
Puppet always sets a nonzero exit code, so
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296963
Change subject: Bump $wgResourceLoaderMaxQueryLength to 4,000
..
Bump $wgResourceLoaderMaxQueryLength to 4,000
See if this eliminates the
Hello Nuria,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/296959
to review the following change.
Change subject: explicitly specify identity for EL legacy zmq forwarder
..
explicitly
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296862
Change subject: Bump $wgResourceLoaderStorageEnabled to 3,000
..
Bump $wgResourceLoaderStorageEnabled to 3,000
The strictest URL length
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296799
Change subject: Drop check for mbstring in copyFileBackend maintenance script
..
Drop check for mbstring in copyFileBackend maintenance
Hello Tim Starling, Krinkle, Brion VIBBER, MaxSem,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/296699
to review the following change.
Change subject: For discussion: add installer option to share env data with WMF
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296275
Change subject: Don't show the banner on action=edit
..
Don't show the banner on action=edit
* It's a nice gesture to contributors.
*
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296184
Change subject: Remove ResourceLoaderModule methods that were deprecated in 1.26
..
Remove ResourceLoaderModule methods that were
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296179
Change subject: Use hashes instead of names in module strings
..
Use hashes instead of names in module strings
The code that enforces
Hello Krinkle,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/296176
to review the following change.
Change subject: Replace SHA1 with 32-bit FNV-1 as ResourceLoader's hash function
..
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/295564
Change subject: [NOT FOR MERGING] hack maintain-replicas.pl for adywiki/jamwiki
..
[NOT FOR MERGING] hack maintain-replicas.pl for
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/295374
Change subject: Optimize mobile static images
..
Optimize mobile static images
Each file was converted to PNG8+alpha with ImageAlpha
Ori.livneh has submitted this change and it was merged.
Change subject: Provision a "staging" microsite for the transparency report
..
Provision a "staging" microsite for the transparency report
Provision a private microsite
Ori.livneh has submitted this change and it was merged.
Change subject: Add passwords::misc::private_static_site
..
Add passwords::misc::private_static_site
Change-Id: Ifb52d0c19ce1181150a96c243c0cf841ca1c77db
---
M
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/295193
Change subject: Add passwords::misc::private_static_site
..
Add passwords::misc::private_static_site
Change-Id:
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/295192
Change subject: Provision a "staging" microsite for the transparency report
..
Provision a "staging" microsite for the transparency report
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/295184
Change subject: Better cache headers for 'Powered by MediaWiki' badge
..
Better cache headers for 'Powered by MediaWiki' badge
Serve
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/295108
Change subject: mediawiki.js: remove type-checks
..
mediawiki.js: remove type-checks
I searched Google and could not find any indication
Hello Krinkle,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/295100
to review the following change.
Change subject: Simplify dynamic CSS loading by removing IE8-specific hacks
..
Simplify
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294437
Change subject: Make edit preview detection less expensive
..
Make edit preview detection less expensive
Checking if
Ori.livneh has submitted this change and it was merged.
Change subject: Improve client-side edit stash change detection
..
Improve client-side edit stash change detection
The keypress event does not fire for backspace or
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294418
Change subject: Improve client-side edit stash change detection
..
Improve client-side edit stash change detection
The keypress event
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294402
Change subject: Revert "Make sure AntiSpoof mappings are mapping in the correct
direction."
..
Revert "Make sure AntiSpoof mappings are
1 - 100 of 8520 matches
Mail list logo