[PATCH v3] Don't require libcap-ng for virtfs support

2023-05-03 Thread Peter Foley
It's only required for the proxy helper. Add a new option for the proxy helper rather than enabling it implicitly. Change-Id: I95b73fca625529e99d16b0a64e01c65c0c1d43f2 Signed-off-by: Peter Foley --- meson.build | 12 +--- meson_options.txt | 2 ++ scripts

[PATCH v2] Don't require libcap-ng for virtfs support

2023-04-28 Thread Peter Foley
It's only required for the proxy helper. Add a new option for the proxy helper rather than enabling it implicitly. Change-Id: I95b73fca625529e99d16b0a64e01c65c0c1d43f2 Signed-off-by: Peter Foley --- meson.build | 11 --- meson_options.txt | 2 ++ scripts

[PATCH] Don't require libcap-ng for virtfs support

2023-04-21 Thread Peter Foley
It's only required for the proxy helper. Signed-off-by: Peter Foley --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index c44d05a13f..1d4888b1c0 100644 --- a/meson.build +++ b/meson.build @@ -1759,12 +1759,12 @@ have_virtfs

[PATCH] ada: Respect GNATMAKE

2023-01-16 Thread Peter Foley
Use the GNATMAKE variables consistently. Avoids failures when bootstraping with a custom GNATMAKE value. gcc/ada/ChangeLog: * Make-generated.in: Use GNATMAKE. * gcc-interface/Makefile.in: Ditto. Signed-off-by: Peter Foley --- gcc/ada/Make-generated.in | 6 +++--- gcc

[PATCH v2] configure: Only create serdep.tmp if needed

2023-01-16 Thread Peter Foley
There's no reason to create this file if none of the serial configure options are passed. v2: Use test instead of [ to avoid running afoul of autoconf quoting. ChangeLog: * configure: Regenerate. * configure.ac: Only create serdep.tmp if needed Signed-off-by: Peter Foley

[PATCH] configure: Only create serdep.tmp if needed

2023-01-14 Thread Peter Foley
There's no reason to create this file if none of the serial configure options are passed. ChangeLog: * configure: Regenerate. * configure.ac: Only create serdep.tmp if needed Signed-off-by: Peter Foley --- configure| 2 ++ configure.ac | 2 ++ 2 files changed, 4 insertions

[PATCH] um: Support LTO

2023-01-13 Thread Peter Foley
Only a handful of changes are necessary to get it to work. Signed-off-by: Peter Foley --- arch/um/Kconfig | 2 ++ arch/um/Makefile | 2 +- arch/x86/um/vdso/Makefile | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/um/Kconfig b/arch/um/Kconfig index

[PATCH] um: put power options in a menu

2023-01-13 Thread Peter Foley
Because having them all dumped at top-level is a bit messy. Signed-off-by: Peter Foley --- arch/um/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch/um/Kconfig b/arch/um/Kconfig index ad4ff3b0e91e..65bc4c5f2e64 100644 --- a/arch/um/Kconfig +++ b/arch/um/Kconfig @@ -242,4

[PATCH] amdgpu: Avoid building on UML

2023-01-13 Thread Peter Foley
/../amdkfd/kfd_topology.c:2157:48: error: ‘struct cpuinfo_um’ has no member named ‘apicid’ Signed-off-by: Peter Foley --- drivers/gpu/drm/amd/amdgpu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig index

[PATCH] amdgpu: Avoid building on UML

2023-01-13 Thread Peter Foley
/../amdkfd/kfd_topology.c:2157:48: error: ‘struct cpuinfo_um’ has no member named ‘apicid’ Signed-off-by: Peter Foley --- drivers/gpu/drm/amd/amdgpu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig index

[PATCH 1/4] um: Make the definition of cpu_data more compatible

2023-01-12 Thread Peter Foley
/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:2157:16: note: in expansion of macro ‘cpu_data’ 2157 | return cpu_data(first_cpu_of_numa_node).apicid; Signed-off-by: Peter Foley --- arch/um/include/asm/processor-generic.h | 2 +- arch/um/kernel/um_arch.c| 2 +- 2 files changed

[PATCH 3/4] um: Prevent building modules incompatible with MODVERSIONS

2023-01-12 Thread Peter Foley
The manual ld invocation in arch/um/drivers doesn't play nicely with genksyms. Given the problematic modules are deprecated anyway, just prevent building them when using MODVERSIONS. e.g. MODPOST Module.symvers arch/um/drivers/.pcap.o.cmd: No such file or directory --- arch/um/drivers/Kconfig |

[PATCH 4/4] um: Use CFLAGS_vmlinux

2023-01-12 Thread Peter Foley
link-vmlinux.sh doesn't use LDFLAGS_vmlinux when linking the kernel for UML. Move the LDFLAGS_EXESTACK options into CFLAGS_vmlinux so they're actually respected. e.g. /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: warning: .tmp_vmlinux.kallsyms3.o: missing

[PATCH 0/4] um: Various build fixes for allyesconfig

2023-01-12 Thread Peter Foley
Fix some build failures I ran across when trying to build an allyesconfig kernel for ARCH=um. To: Richard Weinberger To: Anton Ivanov To: Johannes Berg Cc: linux-um@lists.infradead.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Peter Foley --- Peter Foley (4): um: Make

[PATCH 2/4] um: Avoid pcap multiple definition errors

2023-01-12 Thread Peter Foley
Change the function name in pcap_kern to avoid conflicting with libpcap.a. e.g. ld: /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../lib64/libpcap.a(pcap.o): in function `pcap_init': (.text+0x7f0): multiple definition of `pcap_init'; arch/um/drivers/pcap_kern.o:pcap_kern.c:(.text.unlikely+0x0):

Re: misaligned-pointer-use libslirp/src/tcp_input.c

2022-06-21 Thread Peter Foley
The upstream fixes in https://gitlab.freedesktop.org/slirp/libslirp/-/commit/6489ebbc691f5d97221ad154d570a231e30fb369 and https://gitlab.freedesktop.org/slirp/libslirp/-/commit/cc20d9ac578aec5502dcb26557765d3e9433cb26 resolved the failure we were seeing in our internal test-case. Thanks! On Tue,

Re: [PATCH] net: Fix uninitialized data usage

2022-01-06 Thread Peter Foley
Yeah, but this same pattern is used elsewhere in the file, so I went with being consistent. On Thu, Jan 6, 2022, 2:44 PM Philippe Mathieu-Daudé wrote: > On 6/1/22 19:28, Patrick Venture wrote: > > From: Peter Foley > > > > e.g. > > 1109 15:16:20.151506 Uninitialize

[DynInst_API:] [dyninst/dyninst] 87f7ac: fix memory leaks

2017-02-15 Thread Peter Foley
Branch: refs/heads/leaks-for-9.3 Home: https://github.com/dyninst/dyninst Commit: 87f7acf88cc316325e1154620f562ae804c74958 https://github.com/dyninst/dyninst/commit/87f7acf88cc316325e1154620f562ae804c74958 Author: Peter Foley <pefol...@pefoley.com> Date: 2017-02-15 (W

[DynInst_API:] [dyninst/dyninst] cdb1a0: Fix warnings

2017-01-29 Thread Peter Foley
Branch: refs/heads/master Home: https://github.com/dyninst/dyninst Commit: cdb1a0c0ec01b4af4a19ca2cd04a6987ed7daedb https://github.com/dyninst/dyninst/commit/cdb1a0c0ec01b4af4a19ca2cd04a6987ed7daedb Author: Peter Foley <pefol...@pefoley.com> Date: 2017-01-29 (Sun, 29 Ja

[DynInst_API:] [dyninst/dyninst] ee6955: make Address portable

2017-01-29 Thread Peter Foley
Branch: refs/heads/master Home: https://github.com/dyninst/dyninst Commit: ee69558fbaab677d27fa8428788e3ae119020522 https://github.com/dyninst/dyninst/commit/ee69558fbaab677d27fa8428788e3ae119020522 Author: Peter Foley <pefol...@pefoley.com> Date: 2016-11-11 (Fri, 11 No

[tip:perf/core] tools build: Fix objtool build with clang

2016-12-06 Thread tip-bot for Peter Foley
Commit-ID: baa1973ebcf6a7bd15522a5b6a35a8fefd6cb232 Gitweb: http://git.kernel.org/tip/baa1973ebcf6a7bd15522a5b6a35a8fefd6cb232 Author: Peter Foley <pefol...@pefoley.com> AuthorDate: Sun, 27 Nov 2016 21:43:46 -0500 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Commit

[tip:perf/core] tools build: Fix objtool build with clang

2016-12-06 Thread tip-bot for Peter Foley
Commit-ID: baa1973ebcf6a7bd15522a5b6a35a8fefd6cb232 Gitweb: http://git.kernel.org/tip/baa1973ebcf6a7bd15522a5b6a35a8fefd6cb232 Author: Peter Foley AuthorDate: Sun, 27 Nov 2016 21:43:46 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 5 Dec 2016 15:51:42 -0300 tools build

Re: [PATCH v4] Fixes for compiling with clang

2016-12-01 Thread Peter Foley
On Tue, Nov 29, 2016 at 6:22 AM, Michal Marek <mma...@suse.com> wrote: > Dne 28.11.2016 v 07:44 Peter Foley napsal(a): > This adds new -Wno-* options also for the gcc case, is there a reason > for this? Also, the -Wno-missing-field-initializers option is not > available in so

Re: [PATCH v4] Fixes for compiling with clang

2016-12-01 Thread Peter Foley
On Tue, Nov 29, 2016 at 6:22 AM, Michal Marek wrote: > Dne 28.11.2016 v 07:44 Peter Foley napsal(a): > This adds new -Wno-* options also for the gcc case, is there a reason > for this? Also, the -Wno-missing-field-initializers option is not > available in some old gccs, so we would n

Re: [PATCHv3] tools build: Make fixdep parsing wait for last target

2016-12-01 Thread Peter Foley
t; is_first_dep = 1; > - } else { > + has_target = 1; > + } else if (has_target) { > /* Save this token/filename */ > memcpy(s, m, p-m); > s[p - m] = 0; > -- > 2.7.4 > Acked-by: Peter Foley <pefol...@pefoley.com>

Re: [PATCHv3] tools build: Make fixdep parsing wait for last target

2016-12-01 Thread Peter Foley
- } else { > + has_target = 1; > + } else if (has_target) { > /* Save this token/filename */ > memcpy(s, m, p-m); > s[p - m] = 0; > -- > 2.7.4 > Acked-by: Peter Foley

Re: [PATCH v2] Fix objtool with clang

2016-11-28 Thread Peter Foley
On Mon, Nov 28, 2016 at 7:00 AM, Arnaldo Carvalho de Melo wrote: > After I applied this I started getting this: > > CC /tmp/build/perf/tests/sw-clock.o > /tmp/build/perf/.plugin_jbd2.o.cmd:3: *** empty variable name. Stop. > Makefile:192: recipe for target

Re: [PATCH v2] Fix objtool with clang

2016-11-28 Thread Peter Foley
On Mon, Nov 28, 2016 at 7:00 AM, Arnaldo Carvalho de Melo wrote: > After I applied this I started getting this: > > CC /tmp/build/perf/tests/sw-clock.o > /tmp/build/perf/.plugin_jbd2.o.cmd:3: *** empty variable name. Stop. > Makefile:192: recipe for target

[tip:x86/urgent] x86/build: Annotate die() with noreturn to fix build warning on clang

2016-11-27 Thread tip-bot for Peter Foley
Commit-ID: adee8705d2517f0e163ffc45e8d7f9e97a58f1f6 Gitweb: http://git.kernel.org/tip/adee8705d2517f0e163ffc45e8d7f9e97a58f1f6 Author: Peter Foley <pefol...@pefoley.com> AuthorDate: Sat, 26 Nov 2016 17:22:29 -0500 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Mon, 28

[tip:x86/urgent] x86/build: Annotate die() with noreturn to fix build warning on clang

2016-11-27 Thread tip-bot for Peter Foley
Commit-ID: adee8705d2517f0e163ffc45e8d7f9e97a58f1f6 Gitweb: http://git.kernel.org/tip/adee8705d2517f0e163ffc45e8d7f9e97a58f1f6 Author: Peter Foley AuthorDate: Sat, 26 Nov 2016 17:22:29 -0500 Committer: Ingo Molnar CommitDate: Mon, 28 Nov 2016 07:47:22 +0100 x86/build: Annotate die

[PATCH v4] Fixes for compiling with clang

2016-11-27 Thread Peter Foley
asm constructs. Changes from v1: * Move the $(cc-name) conditional below the definition of $(CC) Changes from v2: * Actually commit the changes in v2. Changes from v3: * HOSTCC is not guaranteed to be the same as CC, adjust accordingly. Signed-off-by: Peter Foley <pefol...@pefoley.

[PATCH v4] Fixes for compiling with clang

2016-11-27 Thread Peter Foley
asm constructs. Changes from v1: * Move the $(cc-name) conditional below the definition of $(CC) Changes from v2: * Actually commit the changes in v2. Changes from v3: * HOSTCC is not guaranteed to be the same as CC, adjust accordingly. Signed-off-by: Peter Foley --- Makefile | 12

[PATCH v2] Avoid nested function definition

2016-11-27 Thread Peter Foley
' sort(p, n, sizeof(uint16_t), cmp, NULL); ^ 2 errors generated. v2: rename function to __bch_cache_cmp Signed-off-by: Peter Foley <pefol...@pefoley.com> --- drivers/md/bcache/sysfs.c | 10 ++ 1 file changed, 6 insertions(+), 4 del

[PATCH v2] Avoid nested function definition

2016-11-27 Thread Peter Foley
' sort(p, n, sizeof(uint16_t), cmp, NULL); ^ 2 errors generated. v2: rename function to __bch_cache_cmp Signed-off-by: Peter Foley --- drivers/md/bcache/sysfs.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/md

[PATCH v2] Fix objtool with clang

2016-11-27 Thread Peter Foley
Clang doesn't support multiple arguments being passed to -Wp, so split them. Fixes this error: HOSTCC tools/objtool/fixdep.o cat: tools/objtool/.fixdep.o.d: No such file or directory v2: rebased onto perf/core branch. Signed-off-by: Peter Foley <pefol...@pefoley.com> --- tools

[PATCH v2] Fix objtool with clang

2016-11-27 Thread Peter Foley
Clang doesn't support multiple arguments being passed to -Wp, so split them. Fixes this error: HOSTCC tools/objtool/fixdep.o cat: tools/objtool/.fixdep.o.d: No such file or directory v2: rebased onto perf/core branch. Signed-off-by: Peter Foley --- tools/build/Build.include | 6 +++--- 1

[PATCH] drivers/extcon: Fix incompatible pointer type warning

2016-11-27 Thread Peter Foley
nt *cable); ^ 1 error generated. Signed-off-by: Peter Foley <pefol...@pefoley.com> --- include/linux/extcon/extcon-adc-jack.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/extcon/extcon-adc-jack.h b/include/linux/extcon/extcon-a

[PATCH] drivers/extcon: Fix incompatible pointer type warning

2016-11-27 Thread Peter Foley
nt *cable); ^ 1 error generated. Signed-off-by: Peter Foley --- include/linux/extcon/extcon-adc-jack.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/extcon/extcon-adc-jack.h b/include/linux/extcon/extcon-adc-jack.h index a0e03b13b449..2aa

[PATCH] Fix multiple definition error under lto

2016-11-26 Thread Peter Foley
drivers/thermal/built-in.o: In function `type_show.lto_priv.33': (.text+0x3d80): multiple definition of `type_show.lto_priv.33' drivers/base/built-in.o:(.text+0x2a40): first defined here Signed-off-by: Peter Foley <pefol...@pefoley.com> --- drivers/thermal/thermal_core.c | 4 ++-- 1 file c

[PATCH] Fix multiple definition error under lto

2016-11-26 Thread Peter Foley
drivers/thermal/built-in.o: In function `type_show.lto_priv.33': (.text+0x3d80): multiple definition of `type_show.lto_priv.33' drivers/base/built-in.o:(.text+0x2a40): first defined here Signed-off-by: Peter Foley --- drivers/thermal/thermal_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] Avoid nested function definition

2016-11-26 Thread Peter Foley
' sort(p, n, sizeof(uint16_t), cmp, NULL); ^ 2 errors generated. Signed-off-by: Peter Foley <pefol...@pefoley.com> --- drivers/md/bcache/sysfs.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/md/bcache/sys

[PATCH] Avoid nested function definition

2016-11-26 Thread Peter Foley
' sort(p, n, sizeof(uint16_t), cmp, NULL); ^ 2 errors generated. Signed-off-by: Peter Foley --- drivers/md/bcache/sysfs.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c

[PATCH] Annotate die() with noreturn

2016-11-26 Thread Peter Foley
' to silence this warning const char *symname); ^ = NULL Signed-off-by: Peter Foley <pefol...@pefoley.com> --- arch/x86/tools/relocs.h | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH] Annotate die() with noreturn

2016-11-26 Thread Peter Foley
' to silence this warning const char *symname); ^ = NULL Signed-off-by: Peter Foley --- arch/x86/tools/relocs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86

[PATCH] Fix objtool with clang

2016-11-26 Thread Peter Foley
Clang doesn't support multiple arguments being passed to -Wp, so split them. Fixes this error: HOSTCC tools/objtool/fixdep.o cat: tools/objtool/.fixdep.o.d: No such file or directory Signed-off-by: Peter Foley <pefol...@pefoley.com> --- tools/build/Build.include | 6 +++--- 1 file chan

[PATCH] Fix objtool with clang

2016-11-26 Thread Peter Foley
Clang doesn't support multiple arguments being passed to -Wp, so split them. Fixes this error: HOSTCC tools/objtool/fixdep.o cat: tools/objtool/.fixdep.o.d: No such file or directory Signed-off-by: Peter Foley --- tools/build/Build.include | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v3] Fixes for compiling with clang

2016-11-26 Thread Peter Foley
: * Actually commit the changes in v2. Signed-off-by: Peter Foley <pefol...@pefoley.com> --- Makefile | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index 0ede48ba5aaf..94402cef6622 100644 --- a/Makefile +++ b/Makefile @@ -299,16

[PATCH v3] Fixes for compiling with clang

2016-11-26 Thread Peter Foley
: * Actually commit the changes in v2. Signed-off-by: Peter Foley --- Makefile | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index 0ede48ba5aaf..94402cef6622 100644 --- a/Makefile +++ b/Makefile @@ -299,16 +299,6 @@ CONFIG_SHELL

[PATCH v2] Fixes for compiling with clang

2016-11-26 Thread Peter Foley
-by: Peter Foley <pefol...@pefoley.com> --- Makefile | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index 0ede48ba5aaf..b69ad7e4a6d2 100644 --- a/Makefile +++ b/Makefile @@ -299,16 +299,6 @@ CONFIG_SHELL := $(shell if [ -x &

[PATCH v2] Fixes for compiling with clang

2016-11-26 Thread Peter Foley
-by: Peter Foley --- Makefile | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index 0ede48ba5aaf..b69ad7e4a6d2 100644 --- a/Makefile +++ b/Makefile @@ -299,16 +299,6 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then ec

[PATCH] Fixes for compiling with clang

2016-11-25 Thread Peter Foley
Move definition of HOSTCC to allow use of cc-name. Suppress warnings about unsupported optimization options. Disable clang's integrated assembler which is incompatible with kernel asm constructs. Signed-off-by: Peter Foley <pefol...@pefoley.com> --- Makefile | 23 +--

[PATCH] Fixes for compiling with clang

2016-11-25 Thread Peter Foley
Move definition of HOSTCC to allow use of cc-name. Suppress warnings about unsupported optimization options. Disable clang's integrated assembler which is incompatible with kernel asm constructs. Signed-off-by: Peter Foley --- Makefile | 23 +-- 1 file changed, 13 insertions

[DynInst_API:] [dyninst/dyninst] 377419: more leaks

2016-11-25 Thread Peter Foley
Branch: refs/heads/leaks Home: https://github.com/dyninst/dyninst Commit: 377419bb304d12a64e66c652dedefdf68ddefcdb https://github.com/dyninst/dyninst/commit/377419bb304d12a64e66c652dedefdf68ddefcdb Author: Peter Foley <pefol...@pefoley.com> Date: 2016-11-25 (Fri, 25 No

[DynInst_API:] [dyninst/dyninst] 3f6c94: fix memory leaks

2016-11-24 Thread Peter Foley
Branch: refs/heads/leaks Home: https://github.com/dyninst/dyninst Commit: 3f6c94321102e4488f748ba374604235600a4c06 https://github.com/dyninst/dyninst/commit/3f6c94321102e4488f748ba374604235600a4c06 Author: Peter Foley <pefol...@pefoley.com> Date: 2016-11-24 (Thu, 24 No

[DynInst_API:] [dyninst/dyninst] ff0fce: remove trailing whitespace

2016-11-21 Thread Peter Foley
Branch: refs/heads/master Home: https://github.com/dyninst/dyninst Commit: ff0fcebbea1635f046b8ceae0eeef66139c4eef8 https://github.com/dyninst/dyninst/commit/ff0fcebbea1635f046b8ceae0eeef66139c4eef8 Author: Peter Foley <pefol...@pefoley.com> Date: 2016-11-21 (Mon, 21 No

[DynInst_API:] [dyninst/dyninst] 3c72d5: fix cmake warning

2016-11-20 Thread Peter Foley
Branch: refs/heads/master Home: https://github.com/dyninst/dyninst Commit: 3c72d5bbdf7bb947370deb31349018ca1fa0cb0c https://github.com/dyninst/dyninst/commit/3c72d5bbdf7bb947370deb31349018ca1fa0cb0c Author: Peter Foley <pefol...@pefoley.com> Date: 2016-11-21 (Mon, 21 No

[DynInst_API:] [dyninst/dyninst] 502364: dynC for Windows

2016-11-10 Thread Peter Foley
Branch: refs/heads/dync_windows Home: https://github.com/dyninst/dyninst Commit: 502364ef6ad3cd4153753b75b854ff1d74056ffb https://github.com/dyninst/dyninst/commit/502364ef6ad3cd4153753b75b854ff1d74056ffb Author: Peter Foley <pefol...@pefoley.com> Date: 2016-11-11 (Fri,

[DynInst_API:] [dyninst/dyninst] ef3065: Consistantly style the codebase with clang-format

2016-11-06 Thread Peter Foley
Branch: refs/heads/format Home: https://github.com/dyninst/dyninst Commit: ef3065dedc7c3fb920ebfa916aeee3b8c1a7a087 https://github.com/dyninst/dyninst/commit/ef3065dedc7c3fb920ebfa916aeee3b8c1a7a087 Author: Peter Foley <pefol...@pefoley.com> Date: 2016-11-06 (Sun, 06 No

[DynInst_API:] [dyninst/dyninst] a79ba0: fix AddressRange forward declarations

2016-11-06 Thread Peter Foley
Branch: refs/heads/master Home: https://github.com/dyninst/dyninst Commit: a79ba00b9cd3f9b690bd73100c196ad201971a7f https://github.com/dyninst/dyninst/commit/a79ba00b9cd3f9b690bd73100c196ad201971a7f Author: Peter Foley <pefol...@pefoley.com> Date: 2016-11-06 (Sun, 06 No

[DynInst_API:] [dyninst/dyninst] 65936d: Consistantly style the codebase with clang-format

2016-11-06 Thread Peter Foley
Branch: refs/heads/format Home: https://github.com/dyninst/dyninst Commit: 65936d36cca409b6fad1e566fde8ba232616d266 https://github.com/dyninst/dyninst/commit/65936d36cca409b6fad1e566fde8ba232616d266 Author: Peter Foley <pefol...@pefoley.com> Date: 2016-11-06 (Sun, 06 No

[DynInst_API:] [dyninst/dyninst] c5fb5f: Fix warnings

2016-11-05 Thread Peter Foley
Branch: refs/heads/master Home: https://github.com/dyninst/dyninst Commit: c5fb5f8c75fef57faa846922561358b0cfd40f94 https://github.com/dyninst/dyninst/commit/c5fb5f8c75fef57faa846922561358b0cfd40f94 Author: Peter Foley <pefol...@pefoley.com> Date: 2016-11-06 (Sun, 06 No

[DynInst_API:] [dyninst/dyninst] 75bc5a: fix icc warning flags

2016-11-05 Thread Peter Foley
Branch: refs/heads/icc_flags Home: https://github.com/dyninst/dyninst Commit: 75bc5ac9f1a1c804b38e183aa09f33097370c8e4 https://github.com/dyninst/dyninst/commit/75bc5ac9f1a1c804b38e183aa09f33097370c8e4 Author: Peter Foley <pefol...@pefoley.com> Date: 2016-11-05 (Sat,

[DynInst_API:] [dyninst/dyninst] 25b148: fix icc warning flags

2016-10-30 Thread Peter Foley
Branch: refs/heads/icc_flags Home: https://github.com/dyninst/dyninst Commit: 25b1481b3cf639ded93add3189d83824c4f34802 https://github.com/dyninst/dyninst/commit/25b1481b3cf639ded93add3189d83824c4f34802 Author: Peter Foley <pefol...@pefoley.com> Date: 2016-10-30 (Sun,

[DynInst_API:] [dyninst/dyninst] 859cb7: Properly handle SL_UNIQUE in switch statements

2016-10-30 Thread Peter Foley
Branch: refs/heads/master Home: https://github.com/dyninst/dyninst Commit: 859cb778e20b619443c943c96dd1851da763142b https://github.com/dyninst/dyninst/commit/859cb778e20b619443c943c96dd1851da763142b Author: Peter Foley <pefol...@pefoley.com> Date: 2016-10-30 (Sun, 30 Oc

[DynInst_API:] [dyninst/dyninst] 8ad13d: Fix typo in Boost_FOUND conditional

2016-10-30 Thread Peter Foley
Branch: refs/heads/master Home: https://github.com/dyninst/dyninst Commit: 8ad13d3f102c71007ef49c9b11ef96bbca8dfc0e https://github.com/dyninst/dyninst/commit/8ad13d3f102c71007ef49c9b11ef96bbca8dfc0e Author: Peter Foley <pefol...@pefoley.com> Date: 2016-10-30 (Sun, 30 Oc

[DynInst_API:] [dyninst/dyninst] c39b90: dynC for Windows

2016-10-19 Thread Peter Foley
Branch: refs/heads/dync_windows Home: https://github.com/dyninst/dyninst Commit: c39b9009e0a086e8684c14ff2549198b964d7db5 https://github.com/dyninst/dyninst/commit/c39b9009e0a086e8684c14ff2549198b964d7db5 Author: Peter Foley <pefol...@pefoley.com> Date: 2016-10-20 (Thu,

[DynInst_API:] [dyninst/dyninst] ecf77e: Fixes for boost on linux

2016-10-17 Thread Peter Foley
Branch: refs/heads/pefoley2-boost_win Home: https://github.com/dyninst/dyninst Commit: ecf77e4f90714c8068e8a2a0f6e3bec297fde0dc https://github.com/dyninst/dyninst/commit/ecf77e4f90714c8068e8a2a0f6e3bec297fde0dc Author: Peter Foley <pefol...@pefoley.com> Date: 2016-10-1

[DynInst_API:] [dyninst/dyninst] 8f35b1: dynC for Windows

2016-10-16 Thread Peter Foley
Branch: refs/heads/dync_windows Home: https://github.com/dyninst/dyninst Commit: 8f35b100c0bebec5427113103aa808289f836f1f https://github.com/dyninst/dyninst/commit/8f35b100c0bebec5427113103aa808289f836f1f Author: Peter Foley <pefol...@pefoley.com> Date: 2016-10-16 (Sun,

[DynInst_API:] [dyninst/dyninst] d389b2: cmake cleanup

2016-09-27 Thread Peter Foley
Branch: refs/heads/master Home: https://github.com/dyninst/dyninst Commit: d389b2f16af8c0a7646c4f8549756a1e765ccf6c https://github.com/dyninst/dyninst/commit/d389b2f16af8c0a7646c4f8549756a1e765ccf6c Author: Peter Foley <pefol...@pefoley.com> Date: 2016-09-27 (Tue, 27 Se

Re: [DynInst_API:] Windows 64-bit Binary Analysis Support

2016-09-06 Thread Peter Foley
er we bump to > 10.0, as I fully expect there will be API-breakers all over the place. That's > a separate question from when it will be good enough for analysis-only > purposes, though, and we should be able to fast-track that portion of the > changes. > > ___

Re: [DynInst_API:] Windows 64-bit Binary Analysis Support

2016-09-06 Thread Peter Foley
There's also more (untested and probably broken) work on this at https://github.com/pefoley2/dyninst/tree/vs_x64 On Tue, Sep 6, 2016, 9:43 AM Bill Williams wrote: > https://github.com/dyninst/dyninst/pull/168 has initial WIP on this > problem. > >

Re: [DynInst_API:] Building issue in Windows environment.

2016-07-25 Thread Peter Foley
On Mon, Jul 25, 2016 at 11:50 AM Florent Saudel wrote: > I'm running a box on Windows 8.1 64 bits. > I tried to build dyninst 9.2 with different versions of MSVC (2014 and > 2012) for the two different bitness > (32 and 64) but none of them worked. > What is the

Re: [PATCH libmnl] Move declaration of visibility attributes before definition.

2016-07-01 Thread Peter Foley
On Fri, Jul 1, 2016 at 9:54 AM, Pablo Neira Ayuso wrote: > I don't like that we have to change coding style for this, but given > many of you have follow up on this, I'm willing to help so I'm > applying this. Great, thanks! -- To unsubscribe from this list: send the line

[DynInst_API:] [dyninst/dyninst] 3a60d9: temporarily disable broken clang build (#85)

2016-06-10 Thread Peter Foley
Branch: refs/heads/master Home: https://github.com/dyninst/dyninst Commit: 3a60d9468f9bb93f2009c35be1e2713544d1fbb0 https://github.com/dyninst/dyninst/commit/3a60d9468f9bb93f2009c35be1e2713544d1fbb0 Author: Peter Foley <pefol...@pefoley.com> Date: 2016-06-10 (Fri, 10 Ju

[DynInst_API:] [PATCH] Avoid producing excess output while running aarch64 tests

2016-05-01 Thread Peter Foley
Signed-off-by: Peter Foley <pefol...@pefoley.com> --- src/instruction/aarch64_decode.C | 2 +- src/instruction/aarch64_decode_ldst.C | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/instruction/aarch64_decode.C b/src/instruction/aarch64_decode.C index b

[DynInst_API:] [PATCH 2/2] testsuite: Put test_names.txt in builddir

2016-05-01 Thread Peter Foley
Signed-off-by: Peter Foley <pefol...@pefoley.com> --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 3457f36..a13bb24 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -246,7 +246,7 @@ install (TARGETS i

[DynInst_API:] [PATCH 1/2] testsuite: fix warnings

2016-05-01 Thread Peter Foley
Signed-off-by: Peter Foley <pefol...@pefoley.com> --- CMakeLists.txt | 2 ++ src/ResumeLog.C| 2 +- src/dyninst/amd64_7_arg_call.C | 2 +- src/dyninst/dyninst_comp.C | 16 src/dyninst/lib

[DynInst_API:] [PATCH] Teach emitElf about PT_PAX_FLAGS

2016-05-01 Thread Peter Foley
the UNKNOWN assert to trigger on PT_PAX_FLAGS. Add the correct constant to the switch statement to allow these binaries to be rewritten. The correct constant was retrieved from https://pax.grsecurity.net/binutils-2.19-pt-pax-flags-200811041810.patch Signed-off-by: Peter Foley <pefol...@pefoley.

[DynInst_API:] Dyninst build failure with gcc 5.3

2016-05-01 Thread Peter Foley
t::shared_ptr; -extern template class boost::shared_ptr; +//extern template class boost::shared_ptr; +//extern template class boost::shared_ptr; Dyninst::SymtabAPI::SymtabReaderFactory *PCProcess::symReaderFactory_; Suggestions on the right way to fix this would be appreciated. Thanks, Pete

[DynInst_API:] [PATCH v2] Cleanup warnings

2016-04-30 Thread Peter Foley
dyninstAPI/src/linux.C:223:37: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result [-Wunused-result] fgets(buffer, 512, ldconfig); // ignore first line ^ Signed-off-by: Peter Foley <pefol...@pef

Re: [DynInst_API:] [RFC PATCH] Cleanup warnings

2016-04-30 Thread Peter Foley
On Fri, Apr 29, 2016 at 5:24 PM, Bill Williams wrote: > InstructionDecoder-aarch64.C: we'd better be null-checking and failing the > entire decode if we hit the failure cases in this patch. Since most of the functions that call this code path return void, it wasn't at all clear

Re: [DynInst_API:] [RFC PATCH] Cleanup warnings

2016-04-29 Thread Peter Foley
On Fri, Apr 29, 2016 at 5:24 PM, Bill Williams wrote: > And a general note for developers: we should prefer using scoped_ptr and a > custom destructor for file descriptors and other such things where we're > going to error-check, clean up, and bail multiple times in a function.

Re: [DynInst_API:] [RFC PATCH] Cleanup warnings

2016-04-29 Thread Peter Foley
On Fri, Apr 29, 2016 at 5:24 PM, Bill Williams wrote: > Taking things in patch order: > > codegen-x86.C: fine to remove rather than commenting dead code there > dyninstAPI/src/linux.C: by symmetry, use pclose if reading the first line > fails. > InstructionDecoder-aarch64.C:

Re: [DynInst_API:] Dyninst aarch64 ISA xml files

2016-04-28 Thread Peter Foley
On Thu, Apr 28, 2016 at 3:45 PM, Barton Miller wrote: > These files are not our property, so we cannot release them. They have been > generously provided to us, which is a huge resource, and we can create > parsers from them, but not the files themselves. > > --bart I realize

Re: [DynInst_API:] Dyninst aarch64 ISA xml files

2016-04-28 Thread Peter Foley
On Thu, Apr 28, 2016 at 3:48 PM, Josh Stone <jist...@redhat.com> wrote: > On 04/28/2016 12:35 PM, Peter Foley wrote: > FWIW, VTA only has an affect on the debuginfo quality for these > functions. The actual code generation should be unchanged. Sure, but that file takes a *re

Re: [DynInst_API:] Dyninst aarch64 ISA xml files

2016-04-28 Thread Peter Foley
On Thu, Apr 28, 2016 at 1:19 PM, Sunny Shah wrote: > Peter, > > The XML files are not publicly available - they're accessible to a very > small group of people at UW. > > Thanks, > Sunny Ok. Maybe you should add a comment to the script to that effect? I was planning on

[DynInst_API:] Dyninst aarch64 ISA xml files

2016-04-28 Thread Peter Foley
Hi, I've been poking at the ISA generation script at http://git.dyninst.org/?p=dyninst.git;a=blob;f=instructionAPI/aarch64_manual_pareser.py However, I haven't been able to figure out where the input xml files came from. Are they publicly available somewhere? Thanks, Peter Foley

[DynInst_API:] [PATCH] Reduce namespace pollution

2016-04-27 Thread Peter Foley
Remove 'using namespace std' from public header files. Add it where necessary to internal files. Signed-off-by: Peter Foley <pefol...@pefoley.com> --- common/h/IBSTree-fast.h | 14 +- common/h/IBSTree.h

Re: [DynInst_API:] [PATCH 1/2] Reduce namespace pollution

2016-04-26 Thread Peter Foley
On Tue, Apr 26, 2016 at 4:55 PM, Bill Williams wrote: > I'd back out any changes you're making in private headers and any changes in > source files that are only required by those; at that point it's ready for > testing I think. Alright, will do.

Re: [DynInst_API:] [PATCH 1/2] Reduce namespace pollution

2016-04-26 Thread Peter Foley
On Tue, Apr 26, 2016 at 1:03 PM, Josh Stone wrote: > On 04/25/2016 10:58 AM, Bill Williams wrote: >> I think what we want to maintain, at least for 9.x, is the following >> guidelines: >> >> * No "using namespace" in public headers (foo/h/*.h); "using foo::bar" >> may be used

Re: [DynInst_API:] [PATCH 1/2] Reduce namespace pollution

2016-04-25 Thread Peter Foley
On Mon, Apr 25, 2016 at 1:05 PM, Josh Stone <jist...@redhat.com> wrote: > On 04/23/2016 12:57 PM, Peter Foley wrote: >> Don't unconditionally include all of namespace std > > I agree it's good practice avoid "using namespace std;" in API headers, > so you don't

[DynInst_API:] [PATCH 1/2] Reduce namespace pollution

2016-04-23 Thread Peter Foley
Don't unconditionally include all of namespace std Signed-off-by: Peter Foley <pefol...@pefoley.com> --- common/h/IBSTree.h| 6 +++--- dataflowAPI/src/SymEval.C | 16 +--- dataflowAPI/src/debug_dataflow.h | 10 +- dataflowA

Re: [PATCH v3] Refactor to avoid nonnull checks on "this" pointer.

2016-04-05 Thread Peter Foley
On Tue, Apr 5, 2016 at 4:32 AM, Corinna Vinschen wrote: > And reverted. This patch is the culprit for the problem reported in > https://cygwin.com/ml/cygwin/2016-04/msg00085.html > > Can you please take another look, Peter? Huh, that's odd... I'll take a look when I

[PATCH v3] Refactor to avoid nonnull checks on "this" pointer.

2016-04-02 Thread Peter Foley
ed from pipe.cc (fhandler_pipe::open) after a null check. Signed-off-by: Peter Foley <pefol...@pefoley.com> --- winsup/cygwin/external.cc | 2 +- winsup/cygwin/fhandler_dsp.cc | 55 --- winsup/cygwin/fhandler_process.cc | 11 +--- winsup/c

[PATCH v2] Rename without-mingw-progs to with-cross-bootstrap

2016-04-02 Thread Peter Foley
AC_WINDOWS_LIBS when using with-cross-bootstrap configure: regenerate Signed-off-by: Peter Foley <pefol...@pefoley.com> --- winsup/configure | 19 +++ winsup/configure.ac | 8 +--- winsup/cygserver/configure| 2 ++ winsup/cygserver/configure.a

[RFC PATCH v3] Refactor to avoid nonnull checks on "this" pointer.

2016-04-01 Thread Peter Foley
G++ 6.0 asserts that the "this" pointer is non-null for member functions. Refactor methods that check if this is non-null to resolve this. Signed-off-by: Peter Foley <pefol...@pefoley.com> --- Just wanted to make sure that this approach looked good before I fix all the p

Re: [PATCH v2] Refactor to avoid nonnull checks on "this" pointer.

2016-04-01 Thread Peter Foley
On Fri, Apr 1, 2016 at 11:10 AM, Corinna Vinschen wrote: > As I mentioned in my first reply, I'd prefer if the callers check the > pointer explicitly. Changing the methods to static methods seems ... > wrong. Ugly, if you don't mind me saying so. Fair enough, I'll

Re: [PATCH v2] Refactor to avoid nonnull checks on "this" pointer.

2016-04-01 Thread Peter Foley
On Fri, Apr 1, 2016 at 9:12 AM, Yaakov Selkowitz wrote: > See https://gcc.gnu.org/gcc-6/porting_to.html, section named "Optimizations > remove null pointer checks for this". If there's an better way to do this, I'm all ears. However, it seems to come down to either making

Re: [PATCH] Add without-library-checks

2016-04-01 Thread Peter Foley
On Fri, Apr 1, 2016 at 8:16 AM, Corinna Vinschen wrote: > Can we please fold the --without-mingw-progs and --without-library-checks > into a single option? Given the task is basically the same, the option > name should reflect something along the lines of

[PATCH 4/4] Update autoconf for doc/lsaauth/utils

2016-03-31 Thread Peter Foley
Signed-off-by: Peter Foley <pefol...@pefoley.com> --- winsup/doc/aclocal.m4 | 875 winsup/doc/configure| 95 - winsup/doc/configure.ac | 5 +- winsup/lsaauth/aclocal.m4 | 875

  1   2   3   4   5   6   7   8   9   10   >