Re: amflush run while amdump underway tries to flush .tmp files

2017-11-20 Thread Nathan Stratton Treadway
On Mon, Nov 20, 2017 at 19:03:52 -0500, Nathan Stratton Treadway wrote: > On Mon, Nov 20, 2017 at 14:42:01 -0500, Jean-Louis Martineau wrote: > > + if (open(my $pidh, $pidfn)) { > > + my $pid = <$pidh>; > > + if (kill($pid, 0) == 0) { > > + # pid is alive,

Re: amflush run while amdump underway tries to flush .tmp files

2017-11-20 Thread Nathan Stratton Treadway
On Mon, Nov 20, 2017 at 14:42:01 -0500, Jean-Louis Martineau wrote: > + if (open(my $pidh, $pidfn)) { > + my $pid = <$pidh>; > + if (kill($pid, 0) == 0) { > + # pid is alive, skip this directory > + next; > + } looks

Re: amflush run while amdump underway tries to flush .tmp files

2017-11-20 Thread Jean-Louis Martineau
On 20/11/17 02:56 PM, Nathan Stratton Treadway wrote: > On Mon, Nov 20, 2017 at 14:42:01 -0500, Jean-Louis Martineau wrote: > > Each process should take a lock on the holding directory (a pid file), > > Okay, makes sense. > > > > + my $pidfn = File::Spec->catfile($dirfn, "pid"); > > + if (open(my

Re: amflush run while amdump underway tries to flush .tmp files

2017-11-20 Thread Nathan Stratton Treadway
On Mon, Nov 20, 2017 at 14:42:01 -0500, Jean-Louis Martineau wrote: > Each process should take a lock on the holding directory (a pid file), Okay, makes sense. > + my $pidfn = File::Spec->catfile($dirfn, "pid"); > + if (open(my $pidh, $pidfn)) { > + my $pid =

Re: amflush run while amdump underway tries to flush .tmp files

2017-11-20 Thread Jean-Louis Martineau
Each process should take a lock on the holding directory (a pid file), The attached path fix it. Please try it. On 17/11/17 12:38 AM, Nathan Stratton Treadway wrote: > (Amanda v3.5) > > I noticed that Amanda 3.5 no longer aborts amflush if amdump is > currently running (as older versions of

Re: "vaulting run" amdump email report issues -- driver.c "nodump" option

2017-11-20 Thread Jean-Louis Martineau
Nathan, I was too fast to write the first patch, and you are completely right. I committed the attached patch,now amflush use the --no-dump argument and driver merge both 'nodump' and '--no-dump'. Jean-Louis On 18/11/17 01:11 AM, Nathan Stratton Treadway wrote: > On Thu, Nov 16, 2017 at

Re: amvault and label problem as of 3.4.5

2017-11-20 Thread Jean-Louis Martineau
On 20/11/17 10:54 AM, Winston Sorfleet wrote: Thanks Nathan... I have tried the command line without any -o options: |/usr/sbin/amvault --latest-fulls --dest-storage "HP G2 Robot" vtl | Now the response is "FATAL amvault no 'tape-device' property specified" which doesn't make sense

Re: amvault and label problem as of 3.4.5

2017-11-20 Thread Winston Sorfleet
Thanks Nathan... I have tried the command line without any -o options: |/usr/sbin/amvault  --latest-fulls --dest-storage "HP G2 Robot" vtl | Now the response is "FATAL amvault no 'tape-device' property specified" which doesn't make sense to me, since the storage definition includes a