Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review14599 --- One minor comment: Please don't remove copyright headers when

Build failed in Jenkins: amarok_master #140

See http://build.kde.org/job/amarok_master/140/changes Changes: [sam] Fix inconsistent scrobbling with GStreamer backend [matej] Trivial change in proxy collection EditCapability -- Started by an SCM change [EnvInject] - Loading node environment

Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105221/#review14622 --- Ship it! Testing done: mounted an external HDD via Plasma's

Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105221/#review14624 --- From the code: 297 if ((*it)-mountType() == nfs ||

Build failed in Jenkins: amarok_master #141

See http://build.kde.org/job/amarok_master/141/changes Changes: [vonreth] added missing translations and updated some [kde] Fix insert options in AddTrack in the MPRIS1 interface -- Started by an SCM change [EnvInject] - Loading node environment

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/ --- (Updated June 11, 2012, 1:26 p.m.) Review request for Amarok.

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

On June 11, 2012, 8:52 a.m., Leo Franchi wrote: One minor comment: Please don't remove copyright headers when copying files from another project--this is important for both legal and authorship (e.g. who do I ask when this code doesn't work) reasons. The ScriptResolver.* files

Build failed in Jenkins: amarok_master #143

See http://build.kde.org/job/amarok_master/143/changes Changes: [kde] Update the changelog -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace http://build.kde.org/job/amarok_master/ws/

Build failed in Jenkins: amarok_master #142

See http://build.kde.org/job/amarok_master/142/changes Changes: [kde] Make the playlist code a little clearer [kde] Play the correct track when inserting tracks into a sorted playlist -- Started by an SCM change [EnvInject] - Loading node environment

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

On June 11, 2012, 8:41 a.m., Bart Cerneels wrote: I'm assuming this is mostly code copied and edited (but not completely) from the playdar work done by Andy for GSoC 2010. As far as I understand it the protocol used by the Tomahawk resolver is still the same (playdar API), so that

Build failed in Jenkins: amarok_master #145

See http://build.kde.org/job/amarok_master/145/changes Changes: [kde] Add more debugging info for mpris:artUrl in the MPRIS2 interface -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace

Build failed in Jenkins: amarok_master #144

See http://build.kde.org/job/amarok_master/144/changes Changes: [kde] Construct the MPRIS1 arturl the same way as the MPRIS2 mpris:artUrl -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace

Build failed in Jenkins: amarok_master #146

See http://build.kde.org/job/amarok_master/146/changes Changes: [kde] MPRIS: Actually use the cached we created -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace http://build.kde.org/job/amarok_master/ws/