Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-04-15 Thread Harsh Gupta
on my PC. File Attachments Equalizer snapshot http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png Thanks, Harsh Gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-04-15 Thread Harsh Gupta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review31016 --- On April 15, 2013, 9:25 p.m., Harsh Gupta wrote

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-04-15 Thread Harsh Gupta
On March 29, 2013, 12:03 a.m., Harsh Gupta wrote: src/EngineController.cpp, line 793 http://git.reviewboard.kde.org/r/108995/diff/2/?file=119751#file119751line793 How am I suppose to stage changes in a line ( line 791 ) in which a variable is first renamed and then get deleted

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-04-15 Thread Harsh Gupta
On April 14, 2013, 7:08 p.m., Matěj Laitl wrote: src/dialogs/EqualizerDialog.cpp, lines 100-102 http://git.reviewboard.kde.org/r/108995/diff/4/?file=138625#file138625line100 code style: no space between if and ( Harsh Gupta wrote: ooppss !!! Matěj Laitl wrote: I'll

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-04-13 Thread Harsh Gupta
crashing on my PC. File Attachments Equalizer snapshot http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png Thanks, Harsh Gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-03-28 Thread Harsh Gupta
On March 29, 2013, 12:03 a.m., Harsh Gupta wrote: src/EngineController.cpp, line 793 http://git.reviewboard.kde.org/r/108995/diff/2/?file=119751#file119751line793 How am I suppose to stage changes in a line ( line 791 ) in which a variable is first renamed and then get deleted

Re: Review Request 109585: FIX UI doesn't say I have to run Moodbar generator manually. (BR 289483)

2013-03-28 Thread Harsh Gupta
/dialogs/GeneralConfig.ui 4e33f64 Diff: http://git.reviewboard.kde.org/r/109585/diff/ Testing --- All test case passed. File Attachments Screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/moodbar.png Thanks, Harsh Gupta

Re: Review Request 109585: FIX UI doesn't say I have to run Moodbar generator manually. (BR 289483)

2013-03-19 Thread Harsh Gupta
://git.reviewboard.kde.org/r/109585/diff/ Testing --- All test case passed. File Attachments (updated) Screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/moodbar.png Thanks, Harsh Gupta ___ Amarok

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-03-14 Thread Harsh Gupta
/02/17/equalizer.png Thanks, Harsh Gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-02-17 Thread Harsh Gupta
. Note : I have tested it with gstreamer only. Xine phonon keep crashing on my PC. File Attachments Equalizer snapshot http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png Thanks, Harsh Gupta ___ Amarok-devel

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-02-17 Thread Harsh Gupta
snapshot http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png Thanks, Harsh Gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-10 Thread Harsh Gupta
://bugs.kde.org/show_bug.cgi?id=208061 Diffs (updated) - src/MainWindow.h 4b23679 src/MainWindow.cpp 8587784 Diff: http://git.reviewboard.kde.org/r/108716/diff/ Testing --- All tests passed. Thanks, Harsh Gupta ___ Amarok-devel

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-10 Thread Harsh Gupta
(updated) - ChangeLog 139ffa5 src/MainWindow.h 4b23679 src/MainWindow.cpp 8587784 Diff: http://git.reviewboard.kde.org/r/108716/diff/ Testing --- All tests passed. Thanks, Harsh Gupta ___ Amarok-devel mailing list Amarok-devel

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-10 Thread Harsh Gupta
/108716/#review27117 --- On Feb. 10, 2013, 7:16 p.m., Harsh Gupta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-09 Thread Harsh Gupta
--- All tests passed. Thanks, Harsh Gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-09 Thread Harsh Gupta
--- On Feb. 10, 2013, 2:21 a.m., Harsh Gupta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-03 Thread Harsh Gupta
/ Testing (updated) --- All tests passed. File Attachments http://git.reviewboard.kde.org/media/uploaded/files/2013/02/02/0001-Randomize-playlist-with-Ctrl-H.patch Thanks, Harsh Gupta ___ Amarok-devel mailing list Amarok

Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-02 Thread Harsh Gupta
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/02/0001-Randomize-playlist-with-Ctrl-H.patch Thanks, Harsh Gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel