Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

> On Aug. 17, 2012, 12:22 p.m., Ralf Engels wrote: > > I can only see the changed copyright header. > > Is this request still valid? Can we reject it? Ryan should probably close this one, rebase his gsoc branch and upload a new, full diff to a new review board. Want feedback from more people si

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review17592 --- I can only see the changed copyright header. Is this request st

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review17591 --- I can only see the changed copyright header. Is this request st

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

> On Aug. 14, 2012, 8:30 a.m., Bart Cerneels wrote: > > src/core-impl/collections/spotifycollection/SpotifySettings.cpp, line 217 > > > > > > You probably should do readAll() here. The data will be fully available

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

> On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote: > > src/core-impl/collections/spotifycollection/support/Controller.cpp, line 424 > > > > > > I think there should be a restart delay here. Imagine that t

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105285/ --- (Updated Aug. 15, 2012, 6:47 a.m.) Review request for Amarok. Changes --

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

> On Aug. 14, 2012, 8:14 a.m., Bart Cerneels wrote: > > src/core-impl/collections/spotifycollection/SpotifyCollection.cpp, line 149 > > > > > > QAction is a QObject so could be parented to SpotifyCollection to be >

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

> On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote: > > Actually these are from PlaydarCollection, I will reformat all signal & slot names later. > On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote: > > src/core-impl/collections/spotifycollection/support/Controller.cpp, lin

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105285/#review17359 --- src/core-impl/collections/spotifycollection/SpotifySettings.cp

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

> On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote: > > src/core-impl/collections/spotifycollection/SpotifyCollection.cpp, line 57 > > > > > > I'd rather you checked here, if m_controller is 0. Yup, can be

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105285/#review17355 --- The resolver failed to download for me. Got an QNetworkReply::

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105285/ --- (Updated Aug. 13, 2012, 11:24 a.m.) Review request for Amarok. Changes -

Re: GSoC Report: Integrate Spotify into Amarok

On Tue, Jul 31, 2012 at 11:28 PM, Ryan Feng wrote: > Hi all, > >Last week I've been working on the configuration plug-in for > Spotify collection, and it's still working in progress. I have also > spent some time looking back at the SpotifyCollection and > SpotifyQueryMaker implementation, and

GSoC Report: Integrate Spotify into Amarok

Hi all, Last week I've been working on the configuration plug-in for Spotify collection, and it's still working in progress. I have also spent some time looking back at the SpotifyCollection and SpotifyQueryMaker implementation, and tried to improve the stability of querying. Current implementa

Re: GSoC Report: Integrate Spotify into Amarok

On Sat, Jul 14, 2012 at 4:46 PM, Ryan Feng wrote: > Hi, > >The last report already showed that the Spotify plugin has been loaded > correctly and the collection is working, but sometimes the search results > are inserted into the collection but fail showing up in the collection, now > my next

GSoC Report: Integrate Spotify into Amarok

Hi, The last report already showed that the Spotify plugin has been loaded correctly and the collection is working, but sometimes the search results are inserted into the collection but fail showing up in the collection, now my next move is to fix that problem. Here's a list of already known i

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105285/ --- (Updated July 13, 2012, 6:04 p.m.) Review request for Amarok. Changes --

Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105285/ --- Review request for Amarok. Description --- Things I've done this week

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

> On June 11, 2012, 8:41 a.m., Bart Cerneels wrote: > > I'm assuming this is mostly code copied and edited (but not completely) > > from the playdar work done by Andy for GSoC 2010. > > As far as I understand it the protocol used by the Tomahawk resolver is > > still the same (playdar API), so

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

> On June 11, 2012, 8:52 a.m., Leo Franchi wrote: > > One minor comment: > > > > Please don't remove copyright headers when copying files from another > > project--this is important for both legal and authorship (e.g. "who do I > > ask when this code doesn't work") reasons. The ScriptResolver

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/ --- (Updated June 11, 2012, 1:26 p.m.) Review request for Amarok. Descriptio

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review14599 --- One minor comment: Please don't remove copyright headers when

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review14597 --- I'm assuming this is mostly code copied and edited (but not com

Review Request: GSoC report: Integrate Spotify into Amarok (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/ --- Review request for Amarok. Description --- Add Spotify collection cod

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

--- Rename the title Summary (updated) - GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top) Description --- Add Spotify collection code Currently implemented SpotifyCollection, SpotifyQueryMaker and SpotifyMeta. The ScriptResolver is the