---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105201/#review17591
---
I can only see the changed copyright header.
Is this request
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105201/#review17592
---
I can only see the changed copyright header.
Is this request
On Aug. 17, 2012, 12:22 p.m., Ralf Engels wrote:
I can only see the changed copyright header.
Is this request still valid? Can we reject it?
Ryan should probably close this one, rebase his gsoc branch and upload a new,
full diff to a new review board. Want feedback from more people since
On Aug. 14, 2012, 8:14 a.m., Bart Cerneels wrote:
src/core-impl/collections/spotifycollection/SpotifyCollection.cpp, line 149
http://git.reviewboard.kde.org/r/105285/diff/3/?file=77309#file77309line149
QAction is a QObject so could be parented to SpotifyCollection to be
On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote:
Actually these are from PlaydarCollection, I will reformat all signal slot
names later.
On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote:
src/core-impl/collections/spotifycollection/support/Controller.cpp, line 266
On Aug. 14, 2012, 8:30 a.m., Bart Cerneels wrote:
src/core-impl/collections/spotifycollection/SpotifySettings.cpp, line 217
http://git.reviewboard.kde.org/r/105285/diff/3/?file=77322#file77322line217
You probably should do readAll() here. The data will be fully available
after
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105285/
---
(Updated Aug. 15, 2012, 6:47 a.m.)
Review request for Amarok.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105285/#review17355
---
The resolver failed to download for me. Got an
On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote:
src/core-impl/collections/spotifycollection/SpotifyCollection.cpp, line 57
http://git.reviewboard.kde.org/r/105285/diff/3/?file=77309#file77309line57
I'd rather you checked here, if m_controller is 0.
Yup, can be a cause
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105285/#review17359
---
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105285/
---
(Updated Aug. 13, 2012, 11:24 a.m.)
Review request for Amarok.
Changes
Hi everyone,
I finally managed to make Tomahawk's playlists available in Amarok. Now,
It's time to give the ability, for Tomahawk, to do the same with Amarok's
playlists.
In spite of that, lets clarify some details first. When a new peer
connects, Amarok simply shows the playlist along with the
On Tue, Jul 31, 2012 at 11:28 PM, Ryan Feng odayf...@gmail.com wrote:
Hi all,
Last week I've been working on the configuration plug-in for
Spotify collection, and it's still working in progress. I have also
spent some time looking back at the SpotifyCollection and
SpotifyQueryMaker
Hi all,
Last week I've been working on the configuration plug-in for
Spotify collection, and it's still working in progress. I have also
spent some time looking back at the SpotifyCollection and
SpotifyQueryMaker implementation, and tried to improve the stability
of querying. Current
On Thu, Jul 26, 2012 at 5:39 AM, Lucas Lira Gomes x8luca...@gmail.com wrote:
Hi everyone,
the loading times for big collections has hugely improved.
Bart's idea to get rid of MemoryMeta in favour of a custom QueryMaker really
solved our problems.
I also removed the need to use the Tomahawk's
Hi everyone,
the loading times for big collections has hugely improved.
Bart's idea to get rid of MemoryMeta in favour of a custom QueryMaker
really solved our problems.
I also removed the need to use the Tomahawk's ViewManager in Amarok. The
less indirection the better ^^.
From now on, I'll be
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105285/
---
(Updated July 13, 2012, 6:04 p.m.)
Review request for Amarok.
Changes
Hi,
The last report already showed that the Spotify plugin has been loaded
correctly and the collection is working, but sometimes the search results
are inserted into the collection but fail showing up in the collection, now
my next move is to fix that problem.
Here's a list of already known
This command is mandatory for all amarok developers:
git config branch.master.rebase true
the result of this is that all git pull commands will do a rebase
rather then a merge. Your local commits will be rewritten (parented to
origin/master). The prevents the git log to become unreadable because
Hi all,
On Tue, Jul 10, 2012 at 3:01 PM, Matěj Laitl ma...@laitl.cz wrote:
On 10. 7. 2012 Edward Toroshchin wrote:
G'day,
On Tue, Jul 10, 2012 at 01:25:59PM +0200, Matěj Laitl wrote:
I've checked above repo and the master branch there is polluted with many
Merge branch 'master' of
On Mon, Jul 9, 2012 at 11:15 PM, Lucas Lira Gomes x8luca...@gmail.com wrote:
Hi everyone,
i've been fixing bugs and improving overall performance of the tomahawk
service. It's a bit lazy to load big collections(50k tracks) and I haven't
figured yet how I can make its loading faster. And yes,
On Mon, Jul 9, 2012 at 11:15 PM, Lucas Lira Gomes x8luca...@gmail.com wrote:
Hi everyone,
i've been fixing bugs and improving overall performance of the tomahawk
service. It's a bit lazy to load big collections(50k tracks) and I haven't
figured yet how I can make its loading faster. And yes,
On 9. 7. 2012 Lucas Lira Gomes wrote:
Hi everyone,
Hi Lucas,
My amarok repo:
http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-ama
rok.gita=summary (tomahawk
branch)
I've checked above repo and the master branch there is polluted with many
Merge branch 'master' of
G'day,
On Tue, Jul 10, 2012 at 01:25:59PM +0200, Matěj Laitl wrote:
I've checked above repo and the master branch there is polluted with many
Merge branch 'master' of git://anongit.kde.org/amarok commits. Shouldn't all
these be fast-forwards?
Merge and fast-forward are not antonyms. What
On 10. 7. 2012 Edward Toroshchin wrote:
G'day,
On Tue, Jul 10, 2012 at 01:25:59PM +0200, Matěj Laitl wrote:
I've checked above repo and the master branch there is polluted with many
Merge branch 'master' of git://anongit.kde.org/amarok commits. Shouldn't
all these be fast-forwards?
On Tue, Jul 10, 2012 at 03:01:06PM +0200, Matěj Laitl wrote:
Lucas' repo looks like it has no his own commits in master. Therefore I
wanted
to say: Shouldn't all his `git pull git://anongit.kde.org/amarok master`
commands performed in his master branch have resulted in fast-forwards? (that
On 10. 7. 2012 Edward Toroshchin wrote:
On Tue, Jul 10, 2012 at 03:01:06PM +0200, Matěj Laitl wrote:
E.g. `git push` without --rebase in master may still be correct if you
don't have own commits so that it results in fast-forward, that's what I
wanted to say.
I see. There is actually
Agreed. And hey, I didn't know about merge.conflictstyle, that'll make my
life
much easier, thanks!
Anytime! Try also kdiff3 as mergetool.
--
Edward Hades Toroshchin
dr_lepper on irc.freenode.org
___
Amarok-devel mailing list
Amarok-devel@kde.org
Hi everyone,
i've been fixing bugs and improving overall performance of the tomahawk
service. It's a bit lazy to load big collections(50k tracks) and I haven't
figured yet how I can make its loading faster. And yes, I'm running track
loading and removal in the background using Threadweaver jobs.
Hi everyone,
Last two weeks weren’t the most productive of all, since some tests and a
project consumed a lot of my time.
In spite of that, I finally managed to play tomahawk streams in Amarok. To
query others collections is working too.
For those curious, tomahawk service is using capabilities,
On Wed, Jun 27, 2012 at 4:09 AM, Lucas Lira Gomes x8luca...@gmail.com wrote:
Hi everyone,
Last two weeks weren’t the most productive of all, since some tests and a
project consumed a lot of my time.
In spite of that, I finally managed to play tomahawk streams in Amarok. To
query others
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105285/
---
Review request for Amarok.
Description
---
Things I've done this
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105201/#review14599
---
One minor comment:
Please don't remove copyright headers when
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105201/
---
(Updated June 11, 2012, 1:26 p.m.)
Review request for Amarok.
On June 11, 2012, 8:52 a.m., Leo Franchi wrote:
One minor comment:
Please don't remove copyright headers when copying files from another
project--this is important for both legal and authorship (e.g. who do I
ask when this code doesn't work) reasons. The ScriptResolver.* files
On June 11, 2012, 8:41 a.m., Bart Cerneels wrote:
I'm assuming this is mostly code copied and edited (but not completely)
from the playdar work done by Andy for GSoC 2010.
As far as I understand it the protocol used by the Tomahawk resolver is
still the same (playdar API), so that
---
Rename the title
Summary (updated)
-
GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)
Description
---
Add Spotify collection code
Currently implemented SpotifyCollection, SpotifyQueryMaker and
SpotifyMeta. The ScriptResolver
Hi,
just a quick note to follow up the weekly schedule: this week i've been busy
with upcoming exams, and so I haven't done a real lot. I will start committing
to Amarok (in a branch) soonish.
Bye,
-Riccardo
___
Amarok-devel mailing list
On 3. 6. 2012 Riccardo Iaconelli wrote:
Hi,
just a quick note to follow up the weekly schedule: this week i've been
busy with upcoming exams, and so I haven't done a real lot. I will start
committing to Amarok (in a branch) soonish.
Hi Riccardo,
in a branch in my personal repository clone
On May 27, 2012, at 10:13 PM, Ryan Feng wrote:
Hi,
The Spotify service plugin has two parts, a standalone Spotify resolver and
a Amarok side Script Resolver, it's mainly from Tomahawk. I've rewrote the
Amarok side resolver, it can work without Tomahawk base classes and headers
now.
Hi,
The Spotify service plugin has two parts, a standalone Spotify resolver and
a Amarok side Script Resolver, it's mainly from Tomahawk. I've rewrote the
Amarok side resolver, it can work without Tomahawk base classes and headers
now. Here[1] is the code.
In the following week, I will continue
On Sun, May 27, 2012 at 11:13 PM, Ryan Feng odayf...@gmail.com wrote:
Hi,
The Spotify service plugin has two parts, a standalone Spotify resolver and
a Amarok side Script Resolver, it's mainly from Tomahawk. I've rewrote the
Amarok side resolver, it can work without Tomahawk base classes and
Hi,
time for the weekly report!
Unfortunately, I've not achieved too much this week since there has been a
pretty big midterm exam (which will happen tomorrow by the way), so I've only
continued working on the UI mockups. I will propose a semi-final version for
feedback as soon as it is ready,
Hi,
I would like to introduce myself to this list, I'm Riccardo Iaconelli, a KDE
developer who this year happens to be a GSoC student who will work on Amarok.
As you might or might not know, know, I will work on the context view and on
sexying up Amarok's UI. I've started my GSoC coding
44 matches
Mail list logo
