Re: Review Request 110920: Fight warnings.

2013-08-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110920/ --- (Updated Aug. 16, 2013, 6:57 a.m.) Status -- This change has been

Re: Review Request 110920: Fight warnings.

2013-08-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110920/#review37918 --- This review has been submitted with commit

Re: Review Request 110920: Fight warnings.

2013-08-15 Thread Albert Astals Cid
On July 2, 2013, 10:53 a.m., Matěj Laitl wrote: If it compiles with the const, it cannot hurt, ship it! Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting? - Albert

Re: Review Request 110920: Fight warnings.

2013-08-15 Thread Matěj Laitl
On July 2, 2013, 12:53 p.m., Matěj Laitl wrote: If it compiles with the const, it cannot hurt, ship it! Albert Astals Cid wrote: Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting? I forgot to commit it, but it

Re: Review Request 110920: Fight warnings.

2013-07-02 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110920/#review35438 --- Ship it! If it compiles with the const, it cannot hurt, ship