Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-05-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/#review57426 --- This review has been submitted with commit 01d512aa1168c8dffd

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-05-06 Thread Abhay Sombanshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/ --- (Updated May 6, 2014, 4:02 p.m.) Status -- This change has been mark

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-05-06 Thread Myriam Schweingruber
> On May 6, 2014, 12:58 a.m., Albert Astals Cid wrote: > > Has this been commited? Yuri can you commit it? Want me to commit it? > > Yuri Chornoivan wrote: > I just wanted that it to be committed by the team leader (Mat?j). Please > commit the patch if you find this appropriate. ;) > > Alb

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-05-06 Thread Albert Astals Cid
> On May 5, 2014, 10:58 p.m., Albert Astals Cid wrote: > > Has this been commited? Yuri can you commit it? Want me to commit it? > > Yuri Chornoivan wrote: > I just wanted that it to be committed by the team leader (Mat?j). Please > commit the patch if you find this appropriate. ;) No no n

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-05-05 Thread Yuri Chornoivan
> On May 5, 2014, 10:58 p.m., Albert Astals Cid wrote: > > Has this been commited? Yuri can you commit it? Want me to commit it? I just wanted that it to be committed by the team leader (Matěj). Please commit the patch if you find this appropriate. ;) - Yuri

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-05-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/#review57368 --- Has this been commited? Yuri can you commit it? Want me to com

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-11 Thread Yuri Chornoivan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/#review47218 --- Ship it! Ship It! - Yuri Chornoivan On Jan. 5, 2014, 2:17

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-05 Thread Abhay Sombanshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/ --- (Updated Jan. 5, 2014, 7:47 p.m.) Review request for Amarok and Yuri Chor

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-05 Thread Yuri Chornoivan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/#review46845 --- Ship it! Ship It! - Yuri Chornoivan On Jan. 5, 2014, 10:25

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-05 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/#review46844 --- I see, this patch is almost ready, please wait for Yuri to ans

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-05 Thread Abhay Sombanshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/ --- (Updated Jan. 5, 2014, 11:25 a.m.) Review request for Amarok and Yuri Cho

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-04 Thread Abhay Sombanshi
> On Jan. 4, 2014, 9:28 p.m., Matěj Laitl wrote: > > src/widgets/MetaQueryWidget.cpp, line 850 > > > > > > I see no point in allowing only 23:59:59, just make it 24:00:00 please, > > unless there is a usability

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-04 Thread Abhay Sombanshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/ --- (Updated Jan. 5, 2014, 12:10 a.m.) Review request for Amarok. Changes -

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-04 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/#review46778 --- Looks better, please see another round of suggestions below an

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-03 Thread Abhay Sombanshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/ --- (Updated Jan. 3, 2014, 5:33 p.m.) Review request for Amarok. Changes --

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-03 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/#review46685 --- Thanks for the patch, it looks good. When at it, I have some i