Re: Review Request 114765: Bug 322016 - Apply button is always enabled in Playlist Layout Editor dialog

2014-01-04 Thread Nilesh Suthar
On Jan. 3, 2014, 12:23 p.m., Matěj Laitl wrote: Hi, thanks for the patch. I think there could be a better approach in solving the bug - the one I've outlined in my review of a similar request: https://git.reviewboard.kde.org/r/113057/ It may turn out not possible/worth it, but it

Re: Review Request 114765: Bug 322016 - Apply button is always enabled in Playlist Layout Editor dialog

2014-01-04 Thread Nilesh Suthar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114765/ --- (Updated Jan. 4, 2014, 8:53 a.m.) Review request for Amarok. Changes

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-04 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/#review46778 --- Looks better, please see another round of suggestions below

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-04 Thread Abhay Sombanshi
On Jan. 4, 2014, 9:28 p.m., Matěj Laitl wrote: src/widgets/MetaQueryWidget.cpp, line 850 https://git.reviewboard.kde.org/r/114752/diff/2/?file=229709#file229709line850 I see no point in allowing only 23:59:59, just make it 24:00:00 please, unless there is a usability problem with