D13438: Removed obsolete PackagePath role from AppletModel

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. Restricted Application removed a project: Amarok. Restricted Application added a subscriber: amarok-devel. malteveerman requested review of this revision. REVISION SUMMARY This

D13438: Removed obsolete PackagePath role from AppletModel

malteveerman updated this revision to Diff 36046. malteveerman added a comment. Fixed some issues with newer kf5 and qt versions. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13438?vs=35861=36046 BRANCH master REVISION DETAIL

D10526: Port core application away from kdelibs4

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This patch ports the core app away from kdelibs4 to pure qt5/kf5. Kdelibs4 classes that don't have an equivalent in

D10526: Port core application away from kdelibs4

malteveerman edited the summary of this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10526 To: malteveerman, #amarok Cc: asturmlechner, stikonas, kpiwowarski, markey, spettini, #amarok, yaohanchen, malteveerman, progwolff, cochise, tbettler, Smar,

D10708: New context area

malteveerman added a comment. Analyzer should work as well. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10708 To: malteveerman, #amarok Cc: heikobecker, #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner,

D10708: New context area

malteveerman added a comment. I have no idea why the vlc backend doesn't work. But I think it's a bug in the backend, not the analyzer. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10708 To: malteveerman, #amarok Cc: heikobecker, #amarok, paul, yaohanchen,

D10708: New context area

malteveerman updated this revision to Diff 27699. malteveerman added a comment. Added resizing of applets in config mode REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10708?vs=27670=27699 BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D10708

D10708: New context area

malteveerman edited the summary of this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10708 To: malteveerman, #amarok Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber

D10708: New context area

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This patch adds a new context area and some of the most important applets for it. The context and applets are

D10831: Ported some services to Qt5/KF5

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This patch ports the ampache, magnatune and opmldirectory services. I've laid some groundwork for the other services

D10831: Ported some services to Qt5/KF5

malteveerman added a comment. I've created this revision against the wrong branch. How do I fix that? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10831 To: malteveerman, #amarok Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar,

D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory.

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY Simple patch. Fixes Amarok using wrong local data dirs. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL

D11150: Use Kirigami's spacing and icon sizes and remove own implementation

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This patch removes some redundant functionality from ContextView and makes the QML parts instead rely on

D11170: Use new kpackage_install_bundled_package macro

malteveerman added a comment. In D11170#222062 , @heikobecker wrote: > While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is

D11192: Ported playdar collection away from qjson

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This ports the playdar collection from qjson to QJsonDocument and QJsonObject. Also removes the unneeded dependency

D10900: Ported importers to Qt5/KF5

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This patch ports the importers. I haven't tested anything but the next patch will port the autotests and they run

D11299: Fixed a crash in magnatune service

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This fixes a crash in the magnatune service introduced by revision REPOSITORY

D11171: Port NetworkAccessManager to new signal/slot syntax

malteveerman updated this revision to Diff 29438. malteveerman added a comment. Previous diff relied on a function of QMetaObject added in Qt 5.10. This now works with older versions of Qt, too. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE

D11192: Ported playdar collection away from qjson

malteveerman updated this revision to Diff 29167. malteveerman added a comment. Fixed hang on shutdown REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11192?vs=29115=29167 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11192 AFFECTED FILES

D11169: Another QUrl fix

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY Just another small QUrl fix that slipped through the cracks last time. REPOSITORY R181 Amarok BRANCH master

D11170: Use new kpackage_install_bundled_package macro

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY Using the new macro gets rid of some deprecation warnings and reduces the used disk space. Needs KPackage >= 5.41.

D11171: Port NetworkAccessManager to new signal/slot syntax

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This adds some template code to enable using NetworkAccessManager with member function pointers. REPOSITORY R181

D11170: Use new kpackage_install_bundled_package macro

malteveerman updated this revision to Diff 31425. malteveerman added a comment. Just a rebase. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11170?vs=29062=31425 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11170 AFFECTED FILES

D11862: Get rid of scripting

malteveerman added a comment. In D11862#239984 , @markey wrote: > See, the problem with removing features like this is, there will be a huge outcry from users. That's guaranteed, even without knowing for sure how much the scripting feature is

D11968: More interface stuttering work

malteveerman updated this revision to Diff 31909. malteveerman added a comment. Added a few random improvements and compilation warning fixes. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11968?vs=31413=31909 BRANCH master REVISION DETAIL

D11968: More interface stuttering work

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This includes the C++ implementation of the lyrics functionality, which is now async. Also includes a fix for

D12316: Some analyzer applet tweaks

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY Increased the data buffer slightly, fixed a small threading problem and made the applet draw empty bars when

D12315: Fixed crash at shutdown

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This fixes a crash at shutdown, when Threadweaver threads try to access already deleted objects like the sql

D12315: Fixed crash at shutdown

malteveerman updated this revision to Diff 32506. malteveerman added a comment. Removed unnecessary volatile REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12315?vs=32485=32506 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12315 AFFECTED

D12223: Improvements to CurrentTrack applet

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY Some improvements to the CurrentTrack applet. Fixed some scaling and performance issues. REPOSITORY R181 Amarok

D12492: Fixed fadebars

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This fixes the missing fadebars since my last analyzer work. REPOSITORY R181 Amarok BRANCH master REVISION

D12492: Fixed fadebars

malteveerman updated this revision to Diff 32968. malteveerman added a comment. Added some performance optimizations to the analyzer applet. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12492?vs=32963=32968 BRANCH master REVISION DETAIL

D12492: Fixed fadebars

malteveerman updated this revision to Diff 32970. malteveerman added a comment. Cleaned up some includes. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12492?vs=32968=32970 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12492 AFFECTED

D11710: Workaround for clang bug 23029

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This isn't quite as pretty as the previous version, but it works with clang now. REPOSITORY R181 Amarok BRANCH

D11862: Get rid of scripting

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY Since Qt5Script is deprecated and virtually useless without bindings support I got rid of it. I moved the lyrics

D11867: Logger overhaul

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This moves ProxyLoggers functionality to the Logger base class and makes all important public functions static.

D11787: Small MySQL libraries fix for tests.

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This just fixes a small MySQL issue in the tests. Now all tests pass again. REPOSITORY R181 Amarok BRANCH

D11788: Fixed wrong slot signatures in BrowserMessageArea

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This is the reason I like the new signal/slot syntax so much better than the old one. REPOSITORY R181 Amarok

D11534: Some small changes and fixes

malteveerman added a comment. There seems to be a bug in clang. But it doesn't seem to get fixed anytime soon. I'll write a workaround. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11534 To: malteveerman, #amarok,

D11349: Reactivate wikipedia applet

malteveerman updated this revision to Diff 29856. malteveerman added a comment. Changed fileUrl() to filePath(). Builds now with older KPackage. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11349?vs=29578=29856 BRANCH master REVISION DETAIL

D11349: Reactivate wikipedia applet

malteveerman updated this revision to Diff 29972. malteveerman added a comment. Fixed issue with missing optional dependency Qt5WebEngine. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11349?vs=29856=29972 BRANCH master REVISION DETAIL

D11349: Reactivate wikipedia applet

malteveerman added a comment. I managed to fix the issue with missing QtWebEngine but I'm not sure what I can do about the missing qml module. Isn't it part of the WebEngine package? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11349 To: malteveerman, #amarok,

D11534: Some small changes and fixes

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY Just a bunch of small fixes and some minor changes. Biggest change is porting of Logger to new signal/slot syntax.

D11033: Fix some deprecation warnings

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This patch fixes some deprecation warnings in various areas. No major changes, though. REPOSITORY R181 Amarok

D10978: Port tests to Qt5/KF5

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This patch ports the tests and fixes some issues they had. All tests pass now. REPOSITORY R181 Amarok BRANCH

D10831: Ported some services to Qt5/KF5

malteveerman added a comment. In D10831#213608 , @asturmlechner wrote: > > gpodder service using mygpo-qt, which is still in a qt4 world > > Even though it may not be available on every distro out there yet (for lack of consumers),

D10831: Ported some services to Qt5/KF5

malteveerman edited the summary of this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10831 To: malteveerman, #amarok Cc: asturmlechner, #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, schweingruber

D10831: Ported some services to Qt5/KF5

malteveerman updated this revision to Diff 28020. malteveerman edited the summary of this revision. malteveerman added a comment. Fixed branch and commit author REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10831?vs=28016=28020 BRANCH kf5 REVISION

D10831: Ported some services to Qt5/KF5

malteveerman updated this revision to Diff 28043. malteveerman added a comment. - cleaned up CMakeLists.txt a bit - Reactivated gpodder service. Build support depends on this pr, though: https://github.com/gpodder/libmygpo-qt/pull/12 REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE

D10831: Ported some services to Qt5/KF5

malteveerman updated this revision to Diff 28042. malteveerman added a comment. - cleaned up CMakeLists.txt a bit - Reactivated gpodder service. Build support depends on this pr, though: https://github.com/gpodder/libmygpo-qt/pull/12 REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE

D10971: Fixed a crash in analyzer applet when sample rate reported by engine controller is zero

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY Just a simple fix. This crash happened with some podcasts for me. REPOSITORY R181 Amarok BRANCH kf5 REVISION

D13438: Removed obsolete PackagePath role from AppletModel

malteveerman updated this revision to Diff 68430. malteveerman added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Made SvgHandler handle QRC resource files. - Removed "PackagePath" data role from AppletModel. - Moved applet view from

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

malteveerman added inline comments. INLINE COMMENTS > FindMySQLe.cmake:45 > +# below. > +set(MYSQLE_LIBRARIES ${MYSQL_LIBRARIES}) > +else() This breaks embedded for me. The embedded storage plugin silently links against libmysqlclient and then fails when initializing. It's

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

malteveerman added inline comments. INLINE COMMENTS > wbauer wrote in FindMySQLe.cmake:45 > > Although, I just noticed that it actually does that below (in line#73ff) if > > (NOT MYSQLE_LIBRARIES), so maybe it would just be enough to remove the > > set(MYSQLE_LIBRARIES ${MYSQL_LIBRARIES}) here