formats may need a similar
option, don't they?
- Matěj Laitl
On Dec. 20, 2013, 11:06 a.m., Martin Brodbeck wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114563
On July 2, 2013, 12:50 p.m., Mark Kretschmann wrote:
Any news on this? Could you please upload the patch again?
There has been no feedback for 6 months and I believe this could have been
superseded by Scripting GSoC 2013 project - should this be discarded?
- Matěj
too invasive
complication for little gain - it should be discarded unless anybody plans to
simplify this.
- Matěj Laitl
On March 12, 2013, 7:27 p.m., Anmol Ahuja wrote:
---
This is an automatically generated e-mail. To reply, visit
may fix that in a separate
review request (not in this one as we want style fixes separate from other
fixes)
- Matěj Laitl
On Dec. 31, 2013, 6:04 p.m., Nilesh Suthar wrote:
---
This is an automatically generated e-mail. To reply, visit
to top of the cpp file and than use it at appropriate places. This
improves maintainability.
src/widgets/MetaQueryWidget.cpp
https://git.reviewboard.kde.org/r/114752/#comment33328
I suggest to create local variable for the display format for better
maintainability.
- Matěj Laitl
On Dec
around arguments.
- Matěj Laitl
On Dec. 30, 2013, 7:20 a.m., Nilesh Suthar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114736
places to
match)
- Matěj Laitl
On Jan. 3, 2014, 6:33 p.m., Abhay Sombanshi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114752
for the string - use i18nc() call with context like
time format for specifying track length - hours, minutes, seconds
2. respect Amarok coding style - spaces around arguments
- Matěj Laitl
On Jan. 5, 2014, 11:25 a.m., Abhay Sombanshi wrote
On Thu, May 8, 2014 at 8:41 PM, Dan Meltzer
parallelgrapefr...@gmail.com wrote:
Hi Everyone,
Hi Dan,
first, thanks for all your recent work on Amarok, especially for
taking care of review requests and other similar long-overdue taks!
I was talking With Mark this morning, and I think it would
have commit access?)
- Matěj Laitl
On July 22, 2014, 2:32 p.m., Raphael Kubo da Costa wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119405
was apparently introduced by
accident), so thanks for it and ship it! (I haven't tested it, the the diff
looks completely fine)
- Matěj Laitl
On July 22, 2014, 8:20 p.m., Raphael Kubo da Costa wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119429/#review62969
---
Ship it!
Looks good to me, ship it and thanks. :)
- Matěj
On July 23, 2014, 5:12 p.m., Matěj Laitl wrote:
Looks good to me, ship it and thanks. :)
Please don't forget to add relevant tags to commit:
REVIEW: ...
BUG: ...
FIXED-IN: ...
- Matěj
---
This is an automatically generated e-mail
the HACKING folder)
src/core/collections/CollectionLocation.cpp
https://git.reviewboard.kde.org/r/118864/#comment43803
excess whitespace, please remove
- Matěj Laitl
On July 24, 2014, 4:19 p.m., Robert Marshall wrote
situation), but perhaps
we can do what you envisioned on the bug, i.e. pause instantenously when pause
is pressed within pausin fadeout?
- Matěj Laitl
On Sept. 28, 2014, 2:39 a.m., Martin Lyth wrote:
---
This is an automatically generated e
access please push this. (please
don't forget BUG, REVIEW, FIXED-IN tags)
- Matěj Laitl
On Oct. 31, 2014, 11:49 p.m., Duilio Felix wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
On 13. 12. 2014 Konrad Zemek wrote:
gmock sources are still not packaged by distributions, and compiling
Amarok with tests on is still troublesome (I still use a cmake-gui
based approach where I manually set paths to my pre-compiled gmock
lib, as I outlined in an email some months ago).
I
On 14. 12. 2014 Myriam Schweingruber wrote:
Can we please make a release soon, Matěj?
That's what I wanted to do for ages, but having a full-time job and furnishing
a flat takes more time than I've ever expected. :-|
I still plan want to do it, but if someone is faster than me (Ralf?
On 14. 12. 2014 Konrad Zemek wrote:
Git submodule approach looks promising, however I have some concerns:
a) this makes test depend on 'your' github repositories; we cannot
guarantee they won't go away etc.
b) this makes testing Amarok require internet connection, at least
initially;
On 14. 12. 2014 Konrad Zemek wrote:
Matěj Laitl wrote:
How big is tarballed gtest + gmock? Can we just embed them in our release
tarballs? Else we can create something like
amarok-testlibs-$version.tar.bz2, but that would be more work and effort.
tarred and bzipped, the repos take 588KB
good to me, let's merge this
and let wider user base test it.
- Matěj Laitl
On Čer. 19, 2016, 3:01 dop., Stefano Pettini wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboa
parate patch. Applies also to the change few lines below.
- Matěj Laitl
On Čer. 19, 2016, 11:44 dop., Olivier Churlaud wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128246/#review97291
---
Ship it!
Ship It!
- Matěj Laitl
On Čec. 10, 2016, 11
thinking about value/risk of this change. Pro: according to
standards. Con: existing .desktop links may stop working. Has anyone tested
this for example with Amarok shortcut in panel, desktop in various DEs? Others,
what do you think?
- Matěj Laitl
On Říj. 16, 2016, 4:12 odp., Luigi Toscano
> On Říj. 16, 2016, 12:06 odp., Matěj Laitl wrote:
> > Looks good, but see one question below.
> >
> > Also, I wonder what the consequences would be? People loosing custom-set
> > file associations? What about shortcuts in panels etc.?
I also think MediaPl
commit access. Since kf5 is a
development branch and there are few people to review, feel free to push to it
directly unless you explicitly want a review (perhaps for something
controversial).
- Matěj Laitl
On Zář. 27, 2016, 10:13 odp., Alexandr Akulich wrote
least for consistency.
- Matěj Laitl
On Říj. 15, 2016, 9:44 odp., Luigi Toscano wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
Hi Stefano,
I totally agree, 2.9 should be released to push the work done to users.
I unfortunately won't find time to do it myself, but: try to start making
the release yourself! ;) It should be documented quite well.
If you get stuck or need help with particular tasks, speak up on ML (and CC
501 - 528 of 528 matches
Mail list logo
