---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/
---
(Updated April 15, 2013, 9:25 p.m.)
Review request for Amarok.
Changes
On April 14, 2013, 7:08 p.m., Matěj Laitl wrote:
src/dialogs/EqualizerDialog.cpp, lines 100-102
http://git.reviewboard.kde.org/r/108995/diff/4/?file=138625#file138625line100
code style: no space between if and (
ooppss !!!
- Harsh
On March 29, 2013, 12:03 a.m., Harsh Gupta wrote:
src/EngineController.cpp, line 793
http://git.reviewboard.kde.org/r/108995/diff/2/?file=119751#file119751line793
How am I suppose to stage changes in a line ( line 791 ) in which a
variable is first renamed and then get deleted ?
On April 14, 2013, 1:38 p.m., Matěj Laitl wrote:
src/dialogs/EqualizerDialog.cpp, lines 100-102
http://git.reviewboard.kde.org/r/108995/diff/4/?file=138625#file138625line100
code style: no space between if and (
Harsh Gupta wrote:
ooppss !!!
I'll fix it while committin, no
On April 14, 2013, 7:08 p.m., Matěj Laitl wrote:
src/dialogs/EqualizerDialog.cpp, lines 100-102
http://git.reviewboard.kde.org/r/108995/diff/4/?file=138625#file138625line100
code style: no space between if and (
Harsh Gupta wrote:
ooppss !!!
Matěj Laitl wrote:
I'll
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/#review31119
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/#review31016
---
src/EngineController.cpp
On March 28, 2013, 6:33 p.m., Harsh Gupta wrote:
src/EngineController.cpp, line 793
http://git.reviewboard.kde.org/r/108995/diff/2/?file=119751#file119751line793
How am I suppose to stage changes in a line ( line 791 ) in which a
variable is first renamed and then get deleted ?
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/
---
(Updated April 13, 2013, 9:44 p.m.)
Review request for Amarok.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/#review30951
---
Ping.. While it may seem confusing, remarks for the latest
On March 29, 2013, 12:03 a.m., Harsh Gupta wrote:
src/EngineController.cpp, line 793
http://git.reviewboard.kde.org/r/108995/diff/2/?file=119751#file119751line793
How am I suppose to stage changes in a line ( line 791 ) in which a
variable is first renamed and then get deleted ?
On March 28, 2013, 6:33 p.m., Harsh Gupta wrote:
src/EngineController.cpp, line 793
http://git.reviewboard.kde.org/r/108995/diff/2/?file=119751#file119751line793
How am I suppose to stage changes in a line ( line 791 ) in which a
variable is first renamed and then get deleted ?
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/#review29959
---
Looks good, thanks! Just a remark or 2 below. Thanks also for
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/
---
(Updated March 14, 2013, 11 p.m.)
Review request for Amarok.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/#review28114
---
Could a developer please look at this?
- Myriam Schweingruber
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/#review28117
---
Hi, thanks for the patch and sorry for delays while reviewing
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/
---
Review request for Amarok.
Description
---
1. Disabled Pre-amplifier
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/
---
(Updated Feb. 18, 2013, 11:38 a.m.)
Review request for Amarok.
18 matches
Mail list logo