Re: [PATCH 1/2] drm: Implement vm_operations_struct.access

2017-07-14 Thread Michel Dänzer
On 15/07/17 04:47 AM, Felix Kuehling wrote: > On 17-07-13 11:26 PM, Michel Dänzer wrote: >> On 14/07/17 06:08 AM, Felix Kuehling wrote: >>> Allows gdb to access contents of user mode mapped BOs. VRAM access >>> requires the driver to implement a new callback in ttm_bo_driver. >> Thanks for doing th

Re: [PATCH 1/2] drm: Implement vm_operations_struct.access

2017-07-14 Thread Felix Kuehling
On 17-07-13 11:26 PM, Michel Dänzer wrote: > On 14/07/17 06:08 AM, Felix Kuehling wrote: >> Allows gdb to access contents of user mode mapped BOs. VRAM access >> requires the driver to implement a new callback in ttm_bo_driver. > Thanks for doing this. Looks mostly good, but I still have some comme

Re: [PATCH 1/2] drm: Implement vm_operations_struct.access

2017-07-14 Thread Felix Kuehling
On 17-07-14 06:06 AM, Christian König wrote: > Am 13.07.2017 um 23:08 schrieb Felix Kuehling: >> Allows gdb to access contents of user mode mapped BOs. VRAM access >> requires the driver to implement a new callback in ttm_bo_driver. > > One more comment additionally to what Michel already wrote bel

Re: [PATCH 2/2] drm/amdgpu: Implement ttm_bo_driver.access_vram callback

2017-07-14 Thread Felix Kuehling
On 17-07-14 06:08 AM, Christian König wrote: > Am 13.07.2017 um 23:08 schrieb Felix Kuehling: >> Allows gdb to access contents of user mode mapped VRAM BOs. >> >> Signed-off-by: Felix Kuehling >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 59 >> + >> driver

Re: [PATCH v3 1/4] drm/amdgpu: Fix KFD oversubscription by tracking queues correctly

2017-07-14 Thread Alex Deucher
On Thu, Jul 13, 2017 at 9:21 PM, Jay Cornwall wrote: > The number of compute queues available to the KFD was erroneously > calculated as 64. Only the first MEC can execute compute queues and > it has 32 queue slots. > > This caused the oversubscription limit to be calculated incorrectly, > leading

RE: [PATCH] drm/amdgpu/gfx9: simplify and fix GRBM index selection

2017-07-14 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Nicolai Hähnle > Sent: Friday, July 14, 2017 7:42 AM > To: amd-gfx@lists.freedesktop.org > Cc: Haehnle, Nicolai > Subject: [PATCH] drm/amdgpu/gfx9: simplify and fix GRBM index selection > > F

RE: [PATCH 4/4] drm/amdgpu: add ring_destroy for psp v10

2017-07-14 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Junwei Zhang > Sent: Friday, July 14, 2017 6:42 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Jerry > Subject: [PATCH 4/4] drm/amdgpu: add ring_destroy for psp v10 > > Signed-off-by: Ju

RE: [PATCH 3/4] drm/amdgpu: add ring_create function for psp v10

2017-07-14 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Junwei Zhang > Sent: Friday, July 14, 2017 6:42 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Jerry > Subject: [PATCH 3/4] drm/amdgpu: add ring_create function for psp v10 > > Signed-of

RE: [PATCH 2/4] drm/amdgpu: add init microcode function for psp v10

2017-07-14 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Junwei Zhang > Sent: Friday, July 14, 2017 6:42 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Jerry > Subject: [PATCH 2/4] drm/amdgpu: add init microcode function for psp v10 > > Signed

RE: [PATCH 1/4] drm/amdgpu: remove unncessary code in psp v10 ring init func

2017-07-14 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Junwei Zhang > Sent: Friday, July 14, 2017 6:42 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Jerry > Subject: [PATCH 1/4] drm/amdgpu: remove unncessary code in psp v10 ring > init func

RE: [PATCH] drm/amdgpu: read reg in each iterate of psp_wait_for loop

2017-07-14 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Junwei Zhang > Sent: Friday, July 14, 2017 6:20 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Jerry; Huang, Ray > Subject: [PATCH] drm/amdgpu: read reg in each iterate of psp_wait_for lo

[PATCH umr] Remove duplicate comparison in PM4 ring detection.

2017-07-14 Thread Tom St Denis
Signed-off-by: Tom St Denis --- src/app/ring_read.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/app/ring_read.c b/src/app/ring_read.c index 714a54e4f5ea..401a1ac87b8d 100644 --- a/src/app/ring_read.c +++ b/src/app/ring_read.c @@ -54,7 +54,6 @@ void umr_read_ring(struct umr_asic *asic,

Re: [PATCH] drm/amdgpu/gmc8: SRIOV need to program fb location

2017-07-14 Thread Alex Deucher
On Fri, Jul 14, 2017 at 5:40 AM, Emily Deng wrote: > SRIOV won't do vbios post in guest OS, and the mmMC_VM_FB_LOCATION > is pf and vf copy, so still need to program fb location for SRIOV. > > BUG: SWDEV-126629 > > Signed-off-by: Emily Deng You may want to update gmc_v8_0_vram_gtt_location() as

Re: [PATCH v5 12/14] drm: radeon: remove dead code and pointless local lut storage

2017-07-14 Thread Alex Deucher
On Thu, Jul 13, 2017 at 12:25 PM, Peter Rosin wrote: > The redundant fb helpers .load_lut, .gamma_set and .gamma_get are > no longer used. Remove the dead code and hook up the crtc .gamma_set > to use the crtc gamma_store directly instead of duplicating that > info locally. > > Acked-by: Daniel Ve

Re: [PATCH v5 04/14] drm: amd: remove dead code and pointless local lut storage

2017-07-14 Thread Alex Deucher
On Thu, Jul 13, 2017 at 12:25 PM, Peter Rosin wrote: > The redundant fb helpers .load_lut, .gamma_set and .gamma_get are > no longer used. Remove the dead code and hook up the crtc .gamma_set > to use the crtc gamma_store directly instead of duplicating that > info locally. > > Acked-by: Daniel Ve

[PATCH] drm/amdgpu/gmc8: SRIOV need to program fb location

2017-07-14 Thread Emily Deng
SRIOV won't do vbios post in guest OS, and the mmMC_VM_FB_LOCATION is pf and vf copy, so still need to program fb location for SRIOV. BUG: SWDEV-126629 Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 17 + 1 file changed, 17 insertions(+) diff --git a/driv

[PATCH] drm/amdgpu/gfx9: simplify and fix GRBM index selection

2017-07-14 Thread Nicolai Hähnle
From: Nicolai Hähnle Copy the approach taken by gfx8, which simplifies the code, and set the instance index properly. The latter is required for debugging, e.g. for reading wave status by UMR. Signed-off-by: Nicolai Hähnle --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 24 +---

[PATCH 1/4] drm/amdgpu: remove unncessary code in psp v10 ring init func

2017-07-14 Thread Junwei Zhang
Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c index 8e0a24f..328c6f5 100644 --- a/drivers/gpu/drm/amd/amdgpu/psp_v10_0

[PATCH 4/4] drm/amdgpu: add ring_destroy for psp v10

2017-07-14 Thread Junwei Zhang
Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 27 +++ drivers/gpu/drm/amd/amdgpu/psp_v10_0.h | 2 ++ 3 files changed, 30 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/dri

[PATCH 3/4] drm/amdgpu: add ring_create function for psp v10

2017-07-14 Thread Junwei Zhang
Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 31 +++ drivers/gpu/drm/amd/amdgpu/psp_v10_0.h | 2 ++ 3 files changed, 34 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b

[PATCH 2/4] drm/amdgpu: add init microcode function for psp v10

2017-07-14 Thread Junwei Zhang
Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 46 + drivers/gpu/drm/amd/amdgpu/psp_v10_0.h | 1 + 3 files changed, 48 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

[PATCH 0/4] *** Prepare to support PSP v10 for Raven ***

2017-07-14 Thread Junwei Zhang
Junwei Zhang (4): drm/amdgpu: remove unncessary code in psp v10 ring init func drm/amdgpu: add init microcode function for psp v10 drm/amdgpu: add ring_create function for psp v10 drm/amdgpu: add ring_destroy for psp v10 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++ drivers/gpu/drm/amd

[PATCH] drm/amdgpu: read reg in each iterate of psp_wait_for loop

2017-07-14 Thread Junwei Zhang
Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index ba743d4..71ce3ee 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ps

Re: [PATCH 2/2] drm/amdgpu: Implement ttm_bo_driver.access_vram callback

2017-07-14 Thread Christian König
Am 13.07.2017 um 23:08 schrieb Felix Kuehling: Allows gdb to access contents of user mode mapped VRAM BOs. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 59 + drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 2 ++ 2 files changed, 61 i

Re: [PATCH 1/2] drm: Implement vm_operations_struct.access

2017-07-14 Thread Christian König
Am 13.07.2017 um 23:08 schrieb Felix Kuehling: Allows gdb to access contents of user mode mapped BOs. VRAM access requires the driver to implement a new callback in ttm_bo_driver. One more comment additionally to what Michel already wrote below, apart from that it looks good to me. Signed-