Re: KFD co-maintainership and branch model

2018-08-24 Thread Felix Kuehling
On 2018-08-23 08:38 AM, Deucher, Alexander wrote: >> -Original Message- >> From: Christian König >> Sent: Thursday, August 23, 2018 3:01 AM >> To: Oded Gabbay ; Dave Airlie >> >> Cc: Deucher, Alexander ; Kuehling, Felix >> ; amd-gfx list >> Subject: Re: KFD co-maintainership and branch

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-24 Thread Felix Kuehling
On 2018-08-24 03:09 PM, Christian König wrote: > Am 24.08.2018 um 20:59 schrieb Felix Kuehling: >> On 2018-08-24 03:32 AM, Christian König wrote: >>> The roundup to a power of two here is not 100% correct, but I don't >>> think it will hurt us much. >>> >>> For now the patch is Reviewed-by:

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-24 Thread Christian König
Am 24.08.2018 um 20:59 schrieb Felix Kuehling: On 2018-08-24 03:32 AM, Christian König wrote: The roundup to a power of two here is not 100% correct, but I don't think it will hurt us much. For now the patch is Reviewed-by: Christian König . Thanks. Do you mind elaborating on what's not 100%

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-24 Thread Felix Kuehling
On 2018-08-24 03:32 AM, Christian König wrote: > The roundup to a power of two here is not 100% correct, but I don't > think it will hurt us much. > > For now the patch is Reviewed-by: Christian König > . Thanks. Do you mind elaborating on what's not 100% correct here? Maybe do the min(...,

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Jerome Glisse
On Fri, Aug 24, 2018 at 06:40:03PM +0200, Michal Hocko wrote: > On Fri 24-08-18 11:12:40, Jerome Glisse wrote: > [...] > > I am fine with Michal patch, i already said so couple month ago first time > > this discussion did pop up, Michal you can add: > > > > Reviewed-by: Jérôme Glisse > > So I

RE: [PATCH] drm/amdgpu: Set pasid for compute vm

2018-08-24 Thread Zeng, Oak
Yes I will add more description. Plus some fixes to Felix's comment, I will work out a v2. Thanks, Oak -Original Message- From: Alex Deucher Sent: Wednesday, August 22, 2018 5:47 PM To: ozeng Cc: amd-gfx list ; Zeng, Oak Subject: Re: [PATCH] drm/amdgpu: Set pasid for compute vm On

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 11:12:40, Jerome Glisse wrote: [...] > I am fine with Michal patch, i already said so couple month ago first time > this discussion did pop up, Michal you can add: > > Reviewed-by: Jérôme Glisse So I guess the below is the patch you were talking about? From

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 23:52:25, Tetsuo Handa wrote: > On 2018/08/24 22:32, Michal Hocko wrote: > > On Fri 24-08-18 22:02:23, Tetsuo Handa wrote: > >> I worry that (currently > >> out-of-tree) users of this API are involving work / recursion. > > > > I do not give a slightest about out-of-tree modules.

RE: [PATCH] drm/amd/powerplay: expose vega20 OD features

2018-08-24 Thread Zhu, Rex
> -Original Message- > From: Alex Deucher > Sent: Friday, August 24, 2018 11:48 PM > To: Quan, Evan > Cc: amd-gfx list ; Xu, Feifei > ; Kuehling, Felix ; Deucher, > Alexander ; Zhu, Rex ; > Zhang, Hawking > Subject: Re: [PATCH] drm/amd/powerplay: expose vega20 OD features > > On Fri,

Re: [PATCH 3/5] drm/amdgpu: add GMC9 support for PDs/PTs in system memory

2018-08-24 Thread Alex Deucher
On Fri, Aug 24, 2018 at 10:21 AM Christian König wrote: > > Add the necessary handling. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 2/5] drm/amdgpu: add helper for VM PD/PT allocation parameters v2

2018-08-24 Thread Alex Deucher
On Fri, Aug 24, 2018 at 10:21 AM Christian König wrote: > > Add a helper function to figure them out only once. > > v2: fix typo with memset > > Signed-off-by: Christian König > Reviewed-by: Junwei Zhang Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61

Re: [PATCH 1/5] drm/amdgpu: remove extra root PD alignment

2018-08-24 Thread Alex Deucher
On Fri, Aug 24, 2018 at 10:20 AM Christian König wrote: > > Just another leftover from radeon. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 +--- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 3 --- > 2 files changed, 1

Re: [PATCH 4/5] drm/amdgpu: add amdgpu_gmc_get_pde_for_bo helper

2018-08-24 Thread Alex Deucher
On Fri, Aug 24, 2018 at 10:20 AM Christian König wrote: > > Helper to get the PDE for a PD/PT. > > Signed-off-by: Christian König A few comments below. With those fixed: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 37 +++-- >

Re: [PATCH 5/5] drm/amdgpu: enable GTT PD/PT for raven v2

2018-08-24 Thread Alex Deucher
On Fri, Aug 24, 2018 at 10:21 AM Christian König wrote: > > Should work on Vega10 as well, but with an obvious performance hit. > > Older APUs can be enabled as well, but will probably be more work. > > v2: fix error checking > > Signed-off-by: Christian König > --- >

Re: [PATCH] drm/amd/powerplay: expose vega20 OD features

2018-08-24 Thread Alex Deucher
On Fri, Aug 24, 2018 at 3:45 AM Evan Quan wrote: > > Vega20 simplifies the OD logics and it can not fit old > OD interfaces. Thus we design new OD interfaces for > vega20. Please split this into two patches, one to add the internal od8_settings API, and one to wire it up to sysfs. A few more

Re: [PATCH 3/3] drm/amdgpu: Power on uvd block when hw_fini

2018-08-24 Thread Alex Deucher
On Fri, Aug 24, 2018 at 5:39 AM Zhu, Rex wrote: > > > > > -Original Message- > > From: Michel Dänzer > > Sent: Friday, August 24, 2018 5:31 PM > > To: Zhu, Rex > > Cc: amd-gfx@lists.freedesktop.org > > Subject: Re: [PATCH 3/3] drm/amdgpu: Power on uvd block when hw_fini > > > > On

Re: [PATCH xf86-video-amdgpu 2/2] Use AC_CONFIG_MACRO_DIR instead of AC_CONFIG_MACRO_DIRS

2018-08-24 Thread Alex Deucher
On Fri, Aug 24, 2018 at 11:21 AM Michel Dänzer wrote: > > From: Michel Dänzer > > Older versions of autoconf only supported the former. > > (Cherry picked from radeon commit cba8fe4d64819aaa8ba516aa68dbe6d2aa153046) > > Signed-off-by: Michel Dänzer Series is: Acked-by: Alex Deucher > --- >

[PATCH xf86-video-amdgpu 1/2] Add m4 directory

2018-08-24 Thread Michel Dänzer
From: Michel Dänzer Although normally it only warns about it, under some circumstances, aclocal can error out if this directory doesn't exist. Reported-by: John Lumby (Cherry picked from radeon commit 7b01c10137aba24c8f61dd9b2a19ea257ad24371) Signed-off-by: Michel Dänzer --- .gitignore|

[PATCH xf86-video-amdgpu 2/2] Use AC_CONFIG_MACRO_DIR instead of AC_CONFIG_MACRO_DIRS

2018-08-24 Thread Michel Dänzer
From: Michel Dänzer Older versions of autoconf only supported the former. (Cherry picked from radeon commit cba8fe4d64819aaa8ba516aa68dbe6d2aa153046) Signed-off-by: Michel Dänzer --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Jerome Glisse
On Fri, Aug 24, 2018 at 11:52:25PM +0900, Tetsuo Handa wrote: > On 2018/08/24 22:32, Michal Hocko wrote: > > On Fri 24-08-18 22:02:23, Tetsuo Handa wrote: > >> I worry that (currently > >> out-of-tree) users of this API are involving work / recursion. > > > > I do not give a slightest about

[PATCH v2] drm/amdgpu: Move KFD parameters to amdgpu

2018-08-24 Thread Amber Lin
After merging KFD into amdgpu, move module parameters defined in KFD to amdgpu_drv.c, where other module parameters are declared. v2: add kernel-doc comments Change-Id: I2de8d6c96bb49554c028bbc84bdb194f974c9278 Signed-off-by: Amber Lin --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 87

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Jerome Glisse
On Fri, Aug 24, 2018 at 02:33:41PM +0200, Michal Hocko wrote: > On Fri 24-08-18 14:18:44, Christian König wrote: > > Am 24.08.2018 um 14:03 schrieb Michal Hocko: > > > On Fri 24-08-18 13:57:52, Christian König wrote: > > > > Am 24.08.2018 um 13:52 schrieb Michal Hocko: > > > > > On Fri 24-08-18

Re: [PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-24 Thread Alex Deucher
On Fri, Aug 24, 2018 at 3:20 AM Hans Verkuil wrote: > > On 08/23/2018 08:38 PM, Harry Wentland wrote: > > On 2018-08-17 10:11 AM, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. > >> > >> Signed-off-by: Hans Verkuil > >> Acked-by:

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Tetsuo Handa
On 2018/08/24 22:32, Michal Hocko wrote: > On Fri 24-08-18 22:02:23, Tetsuo Handa wrote: >> I worry that (currently >> out-of-tree) users of this API are involving work / recursion. > > I do not give a slightest about out-of-tree modules. They will have to > accomodate to the new API. I have no

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Tetsuo Handa
Two more worries for this patch. > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > @@ -178,12 +178,18 @@ void amdgpu_mn_unlock(struct amdgpu_mn *mn) > * > * @amn: our notifier > */ > -static void amdgpu_mn_read_lock(struct amdgpu_mn *amn) >

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Tetsuo Handa
On 2018/08/24 20:36, Michal Hocko wrote: >> That is, this API seems to be currently used by only out-of-tree users. Since >> we can't check that nobody has memory allocation dependency, I think that >> hmm_invalidate_range_start() should return -EAGAIN if blockable == false for >> now. > > The

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Jerome Glisse
On Fri, Aug 24, 2018 at 07:54:19PM +0900, Tetsuo Handa wrote: > Two more worries for this patch. [...] > > > --- a/mm/hmm.c > > +++ b/mm/hmm.c > > @@ -177,16 +177,19 @@ static void hmm_release(struct mmu_notifier *mn, > > struct mm_struct *mm) > > up_write(>mirrors_sem); > > } > > >

Re: [PATCH xf86-video-ati 2/2] Use AC_CONFIG_MACRO_DIR instead of AC_CONFIG_MACRO_DIRS

2018-08-24 Thread Alex Deucher
On Thu, Aug 23, 2018 at 1:01 PM Michel Dänzer wrote: > > From: Michel Dänzer > > Older versions of autoconf only supported the former. > > Signed-off-by: Michel Dänzer Series is: Acked-by: Alex Deucher > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[PATCH v2] drm/amdgpu: Merge amdkfd into amdgpu

2018-08-24 Thread Amber Lin
Since KFD is only supported by single GPU driver, it makes sense to merge amdgpu and amdkfd into one module. This patch is the initial step: merge Kconfig and Makefile. v2: also remove kfd from drm Kconfig Change-Id: I21c996ba29d393c1bf8064bdb2f5d89541159649 Signed-off-by: Amber Lin ---

[PATCH 1/5] drm/amdgpu: remove extra root PD alignment

2018-08-24 Thread Christian König
Just another leftover from radeon. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 3 --- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 3/5] drm/amdgpu: add GMC9 support for PDs/PTs in system memory

2018-08-24 Thread Christian König
Add the necessary handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index a82b3eb429e8..453bd7ea50e7 100644 ---

[PATCH 5/5] drm/amdgpu: enable GTT PD/PT for raven v2

2018-08-24 Thread Christian König
Should work on Vega10 as well, but with an obvious performance hit. Older APUs can be enabled as well, but will probably be more work. v2: fix error checking Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 13 - 1 file changed, 12 insertions(+), 1

[PATCH 2/5] drm/amdgpu: add helper for VM PD/PT allocation parameters v2

2018-08-24 Thread Christian König
Add a helper function to figure them out only once. v2: fix typo with memset Signed-off-by: Christian König Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 -- 1 file changed, 28 insertions(+), 33 deletions(-) diff --git

[PATCH 4/5] drm/amdgpu: add amdgpu_gmc_get_pde_for_bo helper

2018-08-24 Thread Christian König
Helper to get the PDE for a PD/PT. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 37 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 21 -- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h |

Re: [PATCH] drm/amdgpu: Enable/disable gfx PG feature in rlc safe mode

2018-08-24 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Rex Zhu Sent: Friday, August 24, 2018 5:32:22 AM To: Zhou, Hang; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH] drm/amdgpu: Enable/disable gfx PG feature in rlc safe mode This is required by

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 15:44:03, Christian König wrote: > Am 24.08.2018 um 15:40 schrieb Michal Hocko: > > On Fri 24-08-18 15:28:33, Christian König wrote: > > > Am 24.08.2018 um 15:24 schrieb Michal Hocko: > > > > On Fri 24-08-18 15:10:08, Christian König wrote: > > > > > Am 24.08.2018 um 15:01 schrieb

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 15:40 schrieb Michal Hocko: On Fri 24-08-18 15:28:33, Christian König wrote: Am 24.08.2018 um 15:24 schrieb Michal Hocko: On Fri 24-08-18 15:10:08, Christian König wrote: Am 24.08.2018 um 15:01 schrieb Michal Hocko: On Fri 24-08-18 14:52:26, Christian König wrote: Am

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 15:28:33, Christian König wrote: > Am 24.08.2018 um 15:24 schrieb Michal Hocko: > > On Fri 24-08-18 15:10:08, Christian König wrote: > > > Am 24.08.2018 um 15:01 schrieb Michal Hocko: > > > > On Fri 24-08-18 14:52:26, Christian König wrote: > > > > > Am 24.08.2018 um 14:33 schrieb

Re: [PATCH 2/2] drm/amdgpu: fix holding mn_lock while allocating memory

2018-08-24 Thread Chunming Zhou
在 2018/8/24 20:50, Christian König 写道: We can't hold the mn_lock while allocating memory. if you could add some comments from what you discussed with Michal to explain why, it would be better. With that fixed, Acked-by: Chunming Zhou David Signed-off-by: Christian König ---

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 22:02:23, Tetsuo Handa wrote: > On 2018/08/24 20:36, Michal Hocko wrote: > >> That is, this API seems to be currently used by only out-of-tree users. > >> Since > >> we can't check that nobody has memory allocation dependency, I think that > >> hmm_invalidate_range_start() should

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 15:24 schrieb Michal Hocko: On Fri 24-08-18 15:10:08, Christian König wrote: Am 24.08.2018 um 15:01 schrieb Michal Hocko: On Fri 24-08-18 14:52:26, Christian König wrote: Am 24.08.2018 um 14:33 schrieb Michal Hocko: [...] Thiking about it some more, I can imagine that a

Re: [PATCH 1/2] drm/amdgpu: amdgpu_ctx_add_fence can't fail

2018-08-24 Thread Chunming Zhou
在 2018/8/24 20:50, Christian König 写道: No more waiting for a fence done here. Signed-off-by: Christian König Reviewed-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 8 +++-

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 15:01 schrieb Michal Hocko: On Fri 24-08-18 14:52:26, Christian König wrote: Am 24.08.2018 um 14:33 schrieb Michal Hocko: [...] Thiking about it some more, I can imagine that a notifier callback which performs an allocation might trigger a memory reclaim and that in turn

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 14:52:26, Christian König wrote: > Am 24.08.2018 um 14:33 schrieb Michal Hocko: [...] > > Thiking about it some more, I can imagine that a notifier callback which > > performs an allocation might trigger a memory reclaim and that in turn > > might trigger a notifier to be invoked

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 14:33 schrieb Michal Hocko: On Fri 24-08-18 14:18:44, Christian König wrote: Am 24.08.2018 um 14:03 schrieb Michal Hocko: On Fri 24-08-18 13:57:52, Christian König wrote: Am 24.08.2018 um 13:52 schrieb Michal Hocko: On Fri 24-08-18 13:43:16, Christian König wrote: [...]

[PATCH 1/2] drm/amdgpu: amdgpu_ctx_add_fence can't fail

2018-08-24 Thread Christian König
No more waiting for a fence done here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 8 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h | 6 +++--- 3 files changed, 7 insertions(+), 17 deletions(-) diff

[PATCH 2/2] drm/amdgpu: fix holding mn_lock while allocating memory

2018-08-24 Thread Christian König
We can't hold the mn_lock while allocating memory. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 30 +++--- 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 14:18:44, Christian König wrote: > Am 24.08.2018 um 14:03 schrieb Michal Hocko: > > On Fri 24-08-18 13:57:52, Christian König wrote: > > > Am 24.08.2018 um 13:52 schrieb Michal Hocko: > > > > On Fri 24-08-18 13:43:16, Christian König wrote: > > [...] > > > > > That won't work like

Re: [PATCH 1/8] drm: fix syncobj null_fence_enable_signaling

2018-08-24 Thread Christian König
Patches #1-#4 are Reviewed-by: Christian König I would squash patches #5-#8 into one and make sure that the patch is a clean replacement of the existing functionality with the new one. For example patch #5 still has some code move for the stub fence which now seems unnecessary. Regards,

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 14:03 schrieb Michal Hocko: On Fri 24-08-18 13:57:52, Christian König wrote: Am 24.08.2018 um 13:52 schrieb Michal Hocko: On Fri 24-08-18 13:43:16, Christian König wrote: [...] That won't work like this there might be multiple invalidate_range_start()/invalidate_range_end()

[PATCH 8/8] drm: clean up syncobj->fence and cb

2018-08-24 Thread Chunming Zhou
syncobj fence and cb aren't need any more. wait pt already contains sumission wait. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_syncobj.c | 69 --- include/drm/drm_syncobj.h | 56 +--- 2 files changed, 1 insertion(+), 124

[PATCH 6/8] drm: merge normal syncobj to timeline syncobj

2018-08-24 Thread Chunming Zhou
normal syncobj can be unified to timeline syncobj. The thingking is: a. singal op always append to sinal list tail. b. wait op always wait on last sinal point. the driver indeed be simplified more. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_syncobj.c | 113

[PATCH 7/8] drm: export syncobj search fence to replace fence_get

2018-08-24 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_syncobj.c | 5 +++-- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 4 +++- include/drm/drm_syncobj.h | 2 ++ 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c

[PATCH 5/8] [RFC]drm: add syncobj timeline support v2

2018-08-24 Thread Chunming Zhou
VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations: * CPU query - A host operation that allows querying the payload of the timeline semaphore.

[PATCH 4/8] drm: expand replace_fence to support timeline point v2

2018-08-24 Thread Chunming Zhou
we can place a fence to a timeline point after expanded. v2: change func parameter order Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 14 -- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +-

[PATCH 3/8] drm: expand drm_syncobj_find_fence to support timeline point v2

2018-08-24 Thread Chunming Zhou
we can fetch timeline point fence after expanded. v2: The parameter fence is the result of the function and should come last. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 5 +++-- drivers/gpu/drm/v3d/v3d_gem.c

[PATCH 2/8] drm: rename null fence to stub fence in syncobj

2018-08-24 Thread Chunming Zhou
stub fence will be used by timeline syncobj as well. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand --- drivers/gpu/drm/drm_syncobj.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index

[PATCH 1/8] drm: fix syncobj null_fence_enable_signaling

2018-08-24 Thread Chunming Zhou
That is certainly totally nonsense. dma_fence_enable_sw_signaling() is the function who is calling this callback. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand Reviewed-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_syncobj.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-24 Thread Daniel Vetter
On Fri, Aug 24, 2018 at 8:52 AM, Jani Nikula wrote: > On Wed, 22 Aug 2018, Rodrigo Vivi wrote: >> On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: >>> On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: >>> >>> > - Sticking to fdo bugzilla and disabling gitlab issues for at least

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 13:52 schrieb Michal Hocko: On Fri 24-08-18 13:43:16, Christian König wrote: Am 24.08.2018 um 13:32 schrieb Michal Hocko: On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: Two more worries for this patch. --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c +++

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 13:43:16, Christian König wrote: > Am 24.08.2018 um 13:32 schrieb Michal Hocko: > > On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: > > > Two more worries for this patch. > > > > > > > > > > > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > > > > +++

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 13:32 schrieb Michal Hocko: On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: Two more worries for this patch. --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c @@ -178,12 +178,18 @@ void amdgpu_mn_unlock(struct amdgpu_mn *mn) * *

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: [...] > > --- a/mm/hmm.c > > +++ b/mm/hmm.c > > @@ -177,16 +177,19 @@ static void hmm_release(struct mmu_notifier *mn, > > struct mm_struct *mm) > > up_write(>mirrors_sem); > > } > > > > -static void hmm_invalidate_range_start(struct

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: > Two more worries for this patch. > > > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > > @@ -178,12 +178,18 @@ void amdgpu_mn_unlock(struct amdgpu_mn *mn) > > * > > * @amn: our notifier > >

RE: [PATCH 3/3] drm/amdgpu: Power on uvd block when hw_fini

2018-08-24 Thread Zhu, Rex
> -Original Message- > From: Michel Dänzer > Sent: Friday, August 24, 2018 5:31 PM > To: Zhu, Rex > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 3/3] drm/amdgpu: Power on uvd block when hw_fini > > On 2018-08-24 10:50 a.m., Rex Zhu wrote: > > when hw_fini/suspend, smu only

[PATCH] drm/amdgpu: Enable/disable gfx PG feature in rlc safe mode

2018-08-24 Thread Rex Zhu
This is required by gfx hw and can fix the rlc hang when do s3 stree test on Cz/St. Signed-off-by: Hang Zhou Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c

Re: [PATCH 3/3] drm/amdgpu: Power on uvd block when hw_fini

2018-08-24 Thread Michel Dänzer
On 2018-08-24 10:50 a.m., Rex Zhu wrote: > when hw_fini/suspend, smu only need to power on uvd block > if uvd pg is supported, don't need to call uvd to do hw_init. > > v2: fix typo in patch descriptions. > > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 4 ++-- > 1 file

[PATCH xf86-video-ati 2/4] Handle ihandle == -1 in radeon_set_shared_pixmap_backing

2018-08-24 Thread Michel Dänzer
From: Michel Dänzer It means to stop using the shared pixmap backing. Fixes crash when changing PRIME slave output configuration. Signed-off-by: Michel Dänzer --- src/radeon_bo_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/radeon_bo_helper.c b/src/radeon_bo_helper.c

[PATCH xf86-video-ati 4/4] glamor: Handle ihandle == -1 in radeon_glamor_set_shared_pixmap_backing

2018-08-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/radeon_glamor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/radeon_glamor.c b/src/radeon_glamor.c index c733d192d..bffc89ec6 100644 --- a/src/radeon_glamor.c +++ b/src/radeon_glamor.c @@ -402,11 +402,13 @@

[PATCH xf86-video-ati 1/4] EXA: Handle NULL BO pointer in radeon_set_pixmap_bo

2018-08-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/radeon.h | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/radeon.h b/src/radeon.h index 1a1edb1ba..b1d5f5af4 100644 --- a/src/radeon.h +++ b/src/radeon.h @@ -772,11 +772,15 @@ static inline Bool

[PATCH xf86-video-ati 3/4] EXA: Handle ihandle == -1 in RADEONEXASharePixmapBacking

2018-08-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/radeon_exa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/radeon_exa.c b/src/radeon_exa.c index 93c2f056c..268155ed7 100644 --- a/src/radeon_exa.c +++ b/src/radeon_exa.c @@ -296,11 +296,12 @@ Bool

[PATCH 3/3] drm/amdgpu: Power on uvd block when hw_fini

2018-08-24 Thread Rex Zhu
when hw_fini/suspend, smu only need to power on uvd block if uvd pg is supported, don't need to call uvd to do hw_init. v2: fix typo in patch descriptions. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 2/3] drm/amdgpu: Update power state at the end of smu hw_init.

2018-08-24 Thread Rex Zhu
For SI/Kv, the power state is managed by function amdgpu_pm_compute_clocks. when dpm enabled, we should call amdgpu_pm_compute_clocks to update current power state instand of set boot state. this change can fix the oops when kfd driver was enabled on Kv. Signed-off-by: Rex Zhu ---

[PATCH 1/3] drm/amdgpu: Fix vce initialize failed on Kaveri/Mullins

2018-08-24 Thread Rex Zhu
Forgot to add vce pg support via smu for Kaveri/Mullins. Fixes: 561a5c83eadd ("drm/amd/pp: Unify powergate_uvd/vce/mmhub to set_powergating_by_smu") v2: refine patch descriptions suggested by Michel Tested-by: Michel Dänzer Signed-off-by: Rex Zhu ---

[PATCH] drm/amd/powerplay: expose vega20 OD features

2018-08-24 Thread Evan Quan
Vega20 simplifies the OD logics and it can not fit old OD interfaces. Thus we design new OD interfaces for vega20. Change-Id: I888faec46a81287ae24f452ce16b42c1f6d06d7d Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 8 + drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

Re: [PATCH 1/3] drm/amdgpu: Merge amdkfd into amdgpu

2018-08-24 Thread Christian König
Looks like a step into the right direction to me. With Felix comment addressed patch #1 and #2 are Acked-by: Christian König . For patch #3 I agree with Alex that we need more kerneldoc, when that is done we can probably add rb to that as well. Regards, Christian. Am 24.08.2018 um 00:21

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-24 Thread Christian König
Am 24.08.2018 um 00:37 schrieb Felix Kuehling: Set the VM size based on system memory size between the ASIC-specific limits given by min_vm_size and max_bits. GFXv9 GPUs will keep their default VM size of 256TB (48 bit). Only older GPUs will adjust VM size depending on system memory size. This

Re: [PATCH 2/5] drm/amdgpu: add ring soft recovery v2

2018-08-24 Thread Christian König
Am 23.08.2018 um 22:21 schrieb Marek Olšák: On Thu, Aug 23, 2018 at 2:51 AM Christian König wrote: Am 22.08.2018 um 21:32 schrieb Marek Olšák: On Wed, Aug 22, 2018 at 12:56 PM Alex Deucher wrote: On Wed, Aug 22, 2018 at 6:05 AM Christian König wrote: Instead of hammering hard on the GPU

Re: [PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-24 Thread Hans Verkuil
On 08/23/2018 08:38 PM, Harry Wentland wrote: > On 2018-08-17 10:11 AM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. >> >> Signed-off-by: Hans Verkuil >> Acked-by: Alex Deucher >> --- >>

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-24 Thread Jani Nikula
On Wed, 22 Aug 2018, Rodrigo Vivi wrote: > On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: >> On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: >> >> > - Sticking to fdo bugzilla and disabling gitlab issues for at least >> > drm-intel for the time being. Doing that migration

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-24 Thread Huang Rui
On Thu, Aug 23, 2018 at 06:37:10PM -0400, Felix Kuehling wrote: > Set the VM size based on system memory size between the ASIC-specific > limits given by min_vm_size and max_bits. GFXv9 GPUs will keep their > default VM size of 256TB (48 bit). Only older GPUs will adjust VM size > depending on