[PATCH 30/43] drm/radeon/si_dma: Move 'si_gpu_check_soft_reset()'s prototype to shared header

2020-11-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/si.c:3768:5: warning: no previous prototype for ‘si_gpu_check_soft_reset’ [-Wmissing-prototypes] 3768 | u32 si_gpu_check_soft_reset(struct radeon_device *rdev) | ^~~ Cc: Alex Deucher Cc: "Christian

[PATCH 38/43] drm/radeon/cik: Move 'Move 'cik_sdma_*()'s prototypes to shared header

2020-11-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/cik_sdma.c:331:6: warning: no previous prototype for ‘cik_sdma_enable’ [-Wmissing-prototypes] 331 | void cik_sdma_enable(struct radeon_device *rdev, bool enable) | ^~~ drivers/gpu/drm/radeon/cik_sdma.c:528:5:

[RESEND 00/43] Rid W=1 warnings from GPU

2020-11-16 Thread Lee Jones
This set contains fixes for some "wouldn't it be nice if" issues, however most of the patches seen here have been on the MLs, but were left unreviewed. Lee Jones (43): drm/radeon/atombios_encoders: Move 'radeon_atom_get_tv_timings()'s prototype into shared location drm/radeon/radeon: Move

[PATCH 06/43] drm/radeon/radeon_legacy_encoders: Move 'radeon_add_legacy_encoder' prototype to shared header

2020-11-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_legacy_encoders.c:1745:1: warning: no previous prototype for ‘radeon_add_legacy_encoder’ [-Wmissing-prototypes] 1745 | radeon_add_legacy_encoder(struct drm_device *dev, uint32_t encoder_enum, uint32_t

[PATCH 13/43] drm/radeon/radeon_drv: Move 'radeon_mmap()'s prototype to shared header

2020-11-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_ttm.c:931:5: warning: no previous prototype for ‘radeon_mmap’ [-Wmissing-prototypes] 931 | int radeon_mmap(struct file *filp, struct vm_area_struct *vma) | ^~~ Cc: Alex Deucher Cc: "Christian König" Cc:

[PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level'

2020-11-16 Thread Lee Jones
Also removing the call to amdgpu_atombios_encoder_get_backlight_level_from_reg() since, according to Alex Deucher, "We call it again below indirectly". Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/atombios_encoders.c: In function

[PATCH 10/43] drm/radeon/radeon_pm: Move 'radeon_pm_acpi_event_handler' prototype into shared header

2020-11-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_pm.c:74:6: warning: no previous prototype for ‘radeon_pm_acpi_event_handler’ [-Wmissing-prototypes] 74 | void radeon_pm_acpi_event_handler(struct radeon_device *rdev) | ^~~~ Cc: Alex

[PATCH 12/43] drm/radeon/evergreen: Move 'evergreen_*' and 'sumo_*' prototypes out to shared location

2020-11-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/evergreen.c:1281:6: warning: no previous prototype for ‘evergreen_fix_pci_max_read_req_size’ [-Wmissing-prototypes] 1281 | void evergreen_fix_pci_max_read_req_size(struct radeon_device *rdev) |

[PATCH 01/43] drm/radeon/atombios_encoders: Move 'radeon_atom_get_tv_timings()'s prototype into shared location

2020-11-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototypes] 1791 | bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, | ^~

[PATCH 10/43] drm/radeon/radeon_pm: Move 'radeon_pm_acpi_event_handler' prototype into shared header

2020-11-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_pm.c:74:6: warning: no previous prototype for ‘radeon_pm_acpi_event_handler’ [-Wmissing-prototypes] 74 | void radeon_pm_acpi_event_handler(struct radeon_device *rdev) | ^~~~ Cc: Alex

[PATCH 11/43] drm/radeon/radeon_audio: Move 'dce3_2_*' prototypes to shared location

2020-11-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/dce3_1_afmt.c:30:6: warning: no previous prototype for ‘dce3_2_afmt_hdmi_write_speaker_allocation’ [-Wmissing-prototypes] 30 | void dce3_2_afmt_hdmi_write_speaker_allocation(struct drm_encoder *encoder, |

[PATCH 28/43] drm/radeon/ci_dpm: Move 'ci_*()'s prototypes to shared header

2020-11-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/cik.c:1868:5: warning: no previous prototype for ‘ci_mc_load_microcode’ [-Wmissing-prototypes] 1868 | int ci_mc_load_microcode(struct radeon_device *rdev) | ^~~~ drivers/gpu/drm/radeon/cik.c:5847:6:

Re: [PATCH v2 1/8] drm: Add dummy page per device or GEM object

2020-11-16 Thread Andrey Grodzovsky
On 11/16/20 4:48 AM, Christian König wrote: Am 15.11.20 um 07:34 schrieb Andrey Grodzovsky: On 11/14/20 4:51 AM, Daniel Vetter wrote: On Sat, Nov 14, 2020 at 9:41 AM Christian König wrote: Am 13.11.20 um 21:52 schrieb Andrey Grodzovsky: On 6/22/20 1:50 PM, Daniel Vetter wrote: On Mon,

Re: [PATCH v2] drm/amdgpu: fix SI UVD firmware validate resume fail

2020-11-16 Thread Leo Liu
Reviewed-by: Leo Liu On 2020-11-13 5:33 p.m., Jiang, Sonny wrote: [AMD Official Use Only - Internal Distribution Only] [AMD Official Use Only - Internal Distribution Only] Ping. *From:* Jiang, Sonny *Sent:* Monday,

Re: [PATCH] drm/fourcc: fix AMD modifiers PACKERS field doc

2020-11-16 Thread Alex Deucher
Applied and updated based on the corrected layout. Thanks! Alex On Sun, Nov 15, 2020 at 10:48 AM Bas Nieuwenhuizen wrote: > > Reviewed-by: Bas Nieuwenhuizen > > On Sun, Nov 15, 2020 at 10:39 AM Simon Ser wrote: > > > > This field doesn't alias with BANK_XOR_BITS: PACKERS is bits 26:28 while

Re: [PATCH] drm/amdgpu: make gfxhub_v1_0 callback functions to be static

2020-11-16 Thread Alex Deucher
On Mon, Nov 16, 2020 at 9:51 AM Hawking Zhang wrote: > > Those functions should be invoked through gfxhub.funcs > pointer. > > Signed-off-by: Hawking Zhang Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 17 + >

RE: [PATCH] drm/amdgpu: remove experimental flag from arcturus

2020-11-16 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Monday, November 16, 2020 23:12 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: remove experimental flag from arcturus

[PATCH] drm/amdgpu: remove experimental flag from arcturus

2020-11-16 Thread Alex Deucher
This has been stable for a while. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index

[PATCH] drm/amdgpu: make gfxhub_v1_0 callback functions to be static

2020-11-16 Thread Hawking Zhang
Those functions should be invoked through gfxhub.funcs pointer. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 17 + drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.h | 10 +- 2 files changed, 10 insertions(+), 17 deletions(-) diff --git

RE: [PATCH] drm/amdgpu/sriov: reopen sienna_child smu ip block under sriov

2020-11-16 Thread Liu, Monk
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Monk Liu _ Monk Liu|GPU Virtualization Team |AMD -Original Message- From: amd-gfx On Behalf Of Jane Jian Sent: Friday, October 16, 2020 4:05 PM To: amd-gfx@lists.freedesktop.org Cc:

Re: [PATCH v2 1/8] drm: Add dummy page per device or GEM object

2020-11-16 Thread Christian König
Am 15.11.20 um 07:34 schrieb Andrey Grodzovsky: On 11/14/20 4:51 AM, Daniel Vetter wrote: On Sat, Nov 14, 2020 at 9:41 AM Christian König wrote: Am 13.11.20 um 21:52 schrieb Andrey Grodzovsky: On 6/22/20 1:50 PM, Daniel Vetter wrote: On Mon, Jun 22, 2020 at 7:45 PM Christian König wrote:

Re: [PATCH v2 1/8] drm: Add dummy page per device or GEM object

2020-11-16 Thread Michel Dänzer
On 2020-11-14 10:57 a.m., Daniel Vetter wrote: On Sat, Nov 14, 2020 at 10:51 AM Daniel Vetter wrote: On Sat, Nov 14, 2020 at 9:41 AM Christian König wrote: Am 13.11.20 um 21:52 schrieb Andrey Grodzovsky: On 6/22/20 1:50 PM, Daniel Vetter wrote: On Mon, Jun 22, 2020 at 7:45 PM Christian

Recall: [PATCH] drm/amd/pm: change the baco parameter

2020-11-16 Thread Gao, Likun
Gao, Likun would like to recall the message, "[PATCH] drm/amd/pm: change the baco parameter". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: update golden setting for sienna_cichlid

2020-11-16 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Gao, Likun Sent: Monday, November 16, 2020 15:10 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Gao, Likun Subject: [PATCH] drm/amdgpu: update golden setting for sienna_cichlid From: Likun

RE: [PATCH] drm/amd/pm: change the baco parameter

2020-11-16 Thread Gao, Likun
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Likun Gao Regards, Likun -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: Monday, November 16, 2020 4:20 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amd/pm: change the

RE: [PATCH] drm/amd/pm: update driver if file for sienna cichlid

2020-11-16 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Gao, Likun Sent: Monday, November 16, 2020 15:35 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Feng, Kenneth ; Gao, Likun Subject: [PATCH] drm/amd/pm: update driver if file for sienna

Re: [PATCH 01/40] drm/amd/include/vega10_ip_offset: Mark _BASE structs as __maybe_unused

2020-11-16 Thread Joe Perches
On Fri, 2020-11-13 at 13:48 +, Lee Jones wrote: > This patch fixes nearly 400 warnings! > > These structures are too widely used in too many varying > configurations to be split-up into different headers or moved into > source files. > > Instead, we'll mark them as __maybe_unused which tells

[PATCH] drm/amd/pm: change the baco parameter

2020-11-16 Thread Kenneth Feng
For some products, baco parameter 1 is dummy and this doesn't trigger the baco entry/exit. Parameter 0 is valid and these products don't depend on ras for baco sequence. Signed-off-by: Kenneth Feng --- .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c| 24 +-- 1 file changed, 17

RE: [PATCH] drm/amd/pm: update driver if file for sienna cichlid

2020-11-16 Thread Feng, Kenneth
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kenneth Feng Best Regards Kenneth -Original Message- From: Gao, Likun Sent: Monday, November 16, 2020 3:35 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Feng, Kenneth ; Gao, Likun Subject: [PATCH]

<    1   2