Re: [PATCH] drm/amdgpu: add missed write lock for pci detected state pci_channel_io_normal

On 2021-09-30 10:00 p.m., Guchun Chen wrote: When a PCI error state pci_channel_io_normal is detectd, it will report PCI_ERS_RESULT_CAN_RECOVER status to PCI driver, and PCI driver will continue the execution of PCI resume callback report_resume by pci_walk_bridge, and the callback will go into

[PATCH] drm/amdgpu: add missed write lock for pci detected state pci_channel_io_normal

When a PCI error state pci_channel_io_normal is detectd, it will report PCI_ERS_RESULT_CAN_RECOVER status to PCI driver, and PCI driver will continue the execution of PCI resume callback report_resume by pci_walk_bridge, and the callback will go into amdgpu_pci_resume finally, where write lock is

Re: [PATCH v3] drm/dp: Add Additional DP2 Headers

Applied to drm-misc-next. Thanks On 09/28, Harry Wentland wrote: > On 2021-09-27 15:23, Fangzhi Zuo wrote: > > Include FEC, DSC, Link Training related headers. > > > > Change since v2 > > - Align with the spec for DP_DSC_SUPPORT_AND_DSC_DECODER_COUNT > > > > Signed-off-by: Fangzhi Zuo > >

Re: [PATCH 1/2] drm/amdkfd: remove redundant iommu cleanup code

[AMD Official Use Only] Reviewed-by: James Zhu for the series James Zhu From: amd-gfx on behalf of Yifan Zhang Sent: Tuesday, September 28, 2021 4:28 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Zhang, Yifan Subject: [PATCH 1/2]

Re: [PATCH] drm/amdkfd: match the signatures of the real and stub kgd2kfd_probe()

On Thu, Sep 30, 2021 at 4:35 PM wrote: > > From: Tom Rix > > When CONFIG_HSA_AMD=n this there is this error > amdgpu_amdkfd.c:75:56: error: incompatible type for > argument 2 of ‘kgd2kfd_probe’ >75 | adev->kfd.dev = kgd2kfd_probe((struct kgd_dev *)adev, vf); > > amdgpu_amdkfd.h:349:17:

[PATCH] drm/amdkfd: match the signatures of the real and stub kgd2kfd_probe()

From: Tom Rix When CONFIG_HSA_AMD=n this there is this error amdgpu_amdkfd.c:75:56: error: incompatible type for argument 2 of ‘kgd2kfd_probe’ 75 | adev->kfd.dev = kgd2kfd_probe((struct kgd_dev *)adev, vf); amdgpu_amdkfd.h:349:17: note: declared here 349 | struct kfd_dev

Re: [PATCH] amd/amdkfd: remove svms declaration to avoid werror

On Thu, Sep 30, 2021 at 11:53 AM Alex Sierra wrote: > > svm_range_list svms declaration removed to avoid werror when > CONFIG_HSA_AMD_SVM is not enabled. > > Signed-off-by: Alex Sierra Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 11 +-- > 1 file

Re: [PATCH] drm/amd: Guard IS_OLD_GCC assignment with CONFIG_CC_IS_GCC

On Thu, Sep 30, 2021 at 12:02 PM Nathan Chancellor wrote: > > cc-ifversion only works for GCC, as clang pretends to be GCC 4.2.1 for > glibc compatibility, which means IS_OLD_GCC will get set and unsupported > flags will be passed to clang when building certain code within the DCN > files: > >

Re: [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer()

On Thu, Sep 30, 2021 at 1:23 PM Nick Desaulniers wrote: > > On Thu, Sep 30, 2021 at 10:10 AM Alex Deucher wrote: > > > > Applied. Thanks! > > > > Alex > > > > On Thu, Sep 30, 2021 at 12:23 PM Nathan Chancellor > > wrote: > > > > > > Clang warns: > > Any chance AMDGPU folks can look into

Re: [PATCH] drm/amd/display: fix DCC settings for DCN3

Thanks for the info! - Joshie ✨ On 9/30/21 18:33, Marek Olšák wrote: The name is kind of correct. It means "64B with no 128B cache line straddling", which really means just 64B independent blocks with a small modification to support DCC image stores.  They are not true 128B independent

Re: [PATCH] drm/amd/display: fix DCC settings for DCN3

The name is kind of correct. It means "64B with no 128B cache line straddling", which really means just 64B independent blocks with a small modification to support DCC image stores. They are not true 128B independent blocks. Marek On Thu, Sep 30, 2021 at 12:35 PM Joshua Ashton wrote: > Can we

Re: [PATCH] drm/amd: Initialize remove_mpcc in dcn201_update_mpcc()

Applied. Thanks! Alex On Thu, Sep 30, 2021 at 12:16 PM Nathan Chancellor wrote: > > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_hwseq.c:505:6: error: > variable 'remove_mpcc' is used uninitialized whenever 'if' condition is false >

Re: [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer()

Applied. Thanks! Alex On Thu, Sep 30, 2021 at 12:23 PM Nathan Chancellor wrote: > > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_resource.c:1017:10: > error: expression which evaluates to zero treated as a null pointer constant > of type 'struct pipe_ctx *'

Re: [PATCH] drm/amd/display: fix DCC settings for DCN3

Can we please add documentation for this enum? This was not necessarily a typo, but me misunderstanding and stuff it working in my testing. I guess I don't understand why hubp_ind_block_64b_no_128bcl is for 64b && 128b when it specifically says "no_128" in the name. Is there something

Re: [PATCH] drm/amdkfd: avoid conflicting address mappings

On 9/29/2021 9:15 PM, Felix Kuehling wrote: On 2021-09-29 7:35 p.m., Mike Lothian wrote: Hi This patch is causing a compile failure for me drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_chardev.c:1254:25: error: unused variable 'svms' [-Werror,-Wunused-variable]     struct svm_range_list

[PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer()

Clang warns: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_resource.c:1017:10: error: expression which evaluates to zero treated as a null pointer constant of type 'struct pipe_ctx *' [-Werror,-Wnon-literal-null-conversion] return false; ^ 1

[PATCH] drm/amd: Initialize remove_mpcc in dcn201_update_mpcc()

Clang warns: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_hwseq.c:505:6: error: variable 'remove_mpcc' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (mpc->funcs->get_mpcc_for_dpp_from_secondary)

Re: [PATCH] drm/amd/display: fix DCC settings for DCN3

I've also amended the version bump that I forgot to do: -#define KMS_DRIVER_MINOR 43 +#define KMS_DRIVER_MINOR 44 Marek On Thu, Sep 30, 2021 at 12:06 PM Alex Deucher wrote: > Acked-by: Alex Deucher > > On Thu, Sep 30, 2021 at 11:50 AM Marek Olšák wrote: > > > > Hi, > > > > Just

Re: [PATCH] drm/amd/display: fix DCC settings for DCN3

Acked-by: Alex Deucher On Thu, Sep 30, 2021 at 11:50 AM Marek Olšák wrote: > > Hi, > > Just discovered this typo. Please review. > > Thanks, > Marek

[PATCH] drm/amd: Guard IS_OLD_GCC assignment with CONFIG_CC_IS_GCC

cc-ifversion only works for GCC, as clang pretends to be GCC 4.2.1 for glibc compatibility, which means IS_OLD_GCC will get set and unsupported flags will be passed to clang when building certain code within the DCN files: clang-14: error: unknown argument: '-mpreferred-stack-boundary=4' make[5]:

[PATCH] amd/amdkfd: remove svms declaration to avoid werror

svm_range_list svms declaration removed to avoid werror when CONFIG_HSA_AMD_SVM is not enabled. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

[PATCH] drm/amd/display: fix DCC settings for DCN3

Hi, Just discovered this typo. Please review. Thanks, Marek From 3abee824223e214d8a74c3f1b47a24e5ea9a9a34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Ol=C5=A1=C3=A1k?= Date: Thu, 30 Sep 2021 11:13:59 -0400 Subject: [PATCH] drm/amd/display: fix DCC settings for DCN3 MIME-Version: 1.0

Re: [PATCH] drm/amdgpu: use generic fb helpers instead of setting up AMD own's.

@Christian Koenig Have you had a chance to look at this yet? Alex On Mon, Sep 20, 2021 at 4:44 AM Thomas Zimmermann wrote: > > Hi > > Am 20.09.21 um 10:41 schrieb Thomas Zimmermann: > > (cc'ing dri-devel) > > > > Hi > > > > Am 13.09.21 um 16:36 schrieb Alex Deucher: > >> On Thu, Sep 9, 2021 at

Re: [PATCH] drm/amdkfd: Fix dummy kgd2kfd_probe parameters

On Thu, Sep 30, 2021 at 9:18 AM Anson Jacob wrote: > > Commit 4d706ed6825f ("drm/amdkfd: clean up parameters in kgd2kfd_probe") > updated paremeters for kgd2kfd_probe. Update the dummy function as well > when CONFIG_HSA_AMD is not enabled. > > Fixes: 4d706ed6825f ("drm/amdkfd: clean up parameters

Re: [PATCH] drm/amdgpu: print warning and taint kernel if lockup timeout is disabled

[AMD Official Use Only] Acked-by: Alex Deucher From: Christian König Sent: Thursday, September 30, 2021 6:00 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: print warning and taint kernel if lockup timeout is disabled

Re: [PATCH 02/02 v2] drm/amd/display: add cyan_skillfish display support

On 2021-09-30 10:12, Alex Deucher wrote: > On Thu, Sep 30, 2021 at 10:10 AM Alex Deucher wrote: >> >> On Wed, Sep 29, 2021 at 10:00 PM Alex Deucher wrote: >>> >>> On Wed, Sep 29, 2021 at 7:23 PM Mike Lothian wrote: Hi This patch is causing a failure for me when building

Re: [PATCH 02/02 v2] drm/amd/display: add cyan_skillfish display support

On Thu, Sep 30, 2021 at 10:10 AM Alex Deucher wrote: > > On Wed, Sep 29, 2021 at 10:00 PM Alex Deucher wrote: > > > > On Wed, Sep 29, 2021 at 7:23 PM Mike Lothian wrote: > > > > > > Hi > > > > > > This patch is causing a failure for me when building with clang: > > > > > > > > > Enable DCN201

Re: [PATCH] drm/amd/display: Don't use mpreferred-stack-boundary for clang on DCN201

On Thu, Sep 30, 2021 at 10:02 AM Harry Wentland wrote: > > We were erroneously setting IS_OLD_GCC for clang since we didn't > check first whether we're doing a GCC build. > > See dcn30/Makefile for reference. > > Fixes: 4ac93fa0ec12 ("drm/amd/display: add cyan_skillfish display support") >

Re: [PATCH 02/02 v2] drm/amd/display: add cyan_skillfish display support

On Wed, Sep 29, 2021 at 10:00 PM Alex Deucher wrote: > > On Wed, Sep 29, 2021 at 7:23 PM Mike Lothian wrote: > > > > Hi > > > > This patch is causing a failure for me when building with clang: > > > > > > Enable DCN201 support in DC (DRM_AMD_DC_DCN201) [Y/n/?] (NEW) y > > Enable HDCP support in

[PATCH] drm/amd/display: Don't use mpreferred-stack-boundary for clang on DCN201

We were erroneously setting IS_OLD_GCC for clang since we didn't check first whether we're doing a GCC build. See dcn30/Makefile for reference. Fixes: 4ac93fa0ec12 ("drm/amd/display: add cyan_skillfish display support") Signed-off-by: Harry Wentland ---

Re: [PATCH 1/2] drm/amdgpu/jpeg2: move jpeg2 shared macro to header file

The series are: Reviewed-by: Leo Liu On 2021-09-29 3:57 p.m., James Zhu wrote: Move jpeg2 shared macro to header file Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 20 drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.h | 20 2 files

[PATCH] drm/amdkfd: Fix dummy kgd2kfd_probe parameters

Commit 4d706ed6825f ("drm/amdkfd: clean up parameters in kgd2kfd_probe") updated paremeters for kgd2kfd_probe. Update the dummy function as well when CONFIG_HSA_AMD is not enabled. Fixes: 4d706ed6825f ("drm/amdkfd: clean up parameters in kgd2kfd_probe") Signed-off-by: Anson Jacob ---

RE: [PATCH] drm/amdgpu: fix some repeated includings

Actually the duplicates take place in line 46, 47 and 62, 63. diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index 291a47f7992a..94fca56583a0 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +++

[PATCH] drm/amdgpu: fix some repeated includings

Remove two repeated includings in line 62 and 63. Signed-off-by: Guo Zhengkui --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index

Repository for additional color and HDR related documentation (Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC)

On Thu, 23 Sep 2021 10:43:54 +0300 Pekka Paalanen wrote: > On Wed, 22 Sep 2021 11:28:37 -0400 > Harry Wentland wrote: > > > On 2021-09-22 04:31, Pekka Paalanen wrote: > > > On Tue, 21 Sep 2021 14:05:05 -0400 > > > Harry Wentland wrote: > > > > > >> On 2021-09-21 09:31, Pekka Paalanen

Re: [PATCH v6 2/2] habanalabs: add support for dma-buf exporter

On Wed, Sep 29, 2021 at 12:17 AM Oded Gabbay wrote: > > On Tue, Sep 28, 2021 at 8:36 PM Jason Gunthorpe wrote: > > > > On Sun, Sep 12, 2021 at 07:53:09PM +0300, Oded Gabbay wrote: > > > From: Tomer Tayar > > > > > > Implement the calls to the dma-buf kernel api to create a dma-buf > > > object

Re: [PATCH] drm/amdgpu: fix some repeated includings

Ah, that makes more sense. Then please remove the duplicates in lines 46 and 47 instead since the other ones are more correctly grouped together with their blocks. Christian. Am 30.09.21 um 13:54 schrieb 郭正奎: Actually the duplicates take place in line 46, 47 and 62, 63. diff --git

AW: [PATCH] drm/amdgpu: fix some repeated includings

Seconded, there is one include for each hardware version. At least of hand I don't see a duplicate. Von: Simon Ser Gesendet: Donnerstag, 30. September 2021 12:17 An: Guo Zhengkui Cc: Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; David Airlie ; Daniel

Re: [PATCH] drm/amdgpu: fix some repeated includings

One include is v2, the other is v3, or am I missing something?

[PATCH] drm/amdgpu: print warning and taint kernel if lockup timeout is disabled

Make sure that we notice this in error reports. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index

Re: [PATCH] drm/amdgpu: revert "Add autodump debugfs node for gpu reset v8"

Acked-by: Nirmoy Das On 9/30/2021 11:26 AM, Christian König wrote: This reverts commit 728e7e0cd61899208e924472b9e641dbeb0775c4. Further discussion reveals that this feature is severely broken and needs to be reverted ASAP. GPU reset can never be delayed by userspace even for debugging or

[PATCH] drm/amdgpu: revert "Add autodump debugfs node for gpu reset v8"

This reverts commit 728e7e0cd61899208e924472b9e641dbeb0775c4. Further discussion reveals that this feature is severely broken and needs to be reverted ASAP. GPU reset can never be delayed by userspace even for debugging or otherwise we can run into in kernel deadlocks. Signed-off-by: Christian

Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

On Tue, Sep 28, 2021 at 10:04:29AM +0300, Oded Gabbay wrote: > On Thu, Sep 23, 2021 at 12:22 PM Oded Gabbay wrote: > > > > On Sat, Sep 18, 2021 at 11:38 AM Oded Gabbay wrote: > > > > > > On Fri, Sep 17, 2021 at 3:30 PM Daniel Vetter wrote: > > > > > > > > On Thu, Sep 16, 2021 at 10:10:14AM

Re: amdgpu driver halted on suspend of shutdown

Well you could remove it locally if it solves your problem at hand. But keep in mind that a lot of ARM boards are simply not compliant to the PCIe specification and the hardware won't work correctly on those in general. I'm pretty sure you have one of those cases here. Christian. Am

Re: [PATCH] Documentation/gpu: remove spurious "+" in amdgpu.rst

Am 29.09.21 um 19:45 schrieb Alex Deucher: Not sure why that was there. Remove it. Signed-off-by: Alex Deucher Reviewed-by: Christian König --- Documentation/gpu/amdgpu.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/amdgpu.rst

Re: [PATCH] drm/amdgpu: consolidate case statements

Am 29.09.21 um 19:45 schrieb Alex Deucher: IP_VERSION(11, 0, 13) does the exact same thing as IP_VERSION(11, 0, 12) so squash them together. Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 7 --- 1 file changed, 7 deletions(-)